Re: [bug report] scsi: arcmsr: Add a function to set date and time to firmware

2017-12-10 Thread
Dan, Yeah, secs is never be negative. This checking is redundant and have to be removed. Thanks Colin Ian King has done this patch for me on [next]. Thanks, Ching 2017-12-09 20:47 GMT+08:00 Dan Carpenter : > Hello Ching Huang, > > The patch b416c099472a: "scsi: arcmsr: Add a function to set date

Re: [PATCH][next] scsi: arcmsr: remove redundant check for secs < 0

2017-12-10 Thread
Colin, You are right. That's checking is redundant. secs is never be negative. Thanks for your correction and patch. Regards, Ching 2017-12-09 8:34 GMT+08:00 Colin King : > From: Colin Ian King > > The check for secs being less than zero is redundant for two reasons. > Firstly, secs is unsigned

Re: [PATCH 0/3] scsi: arcmsr: add driver module parameter - msi_enable, msix_enable

2017-11-26 Thread
Dan, There is our user feedback said that they have some system have MSI interrupt issue.(but some system are working) Those have MSI issue system all are old system, even if MSI interrupt enable and request are successful, there is not any hardware interrupt for scsi command. Cause each scsi comm

Re: [PATCH 1.1 1/1] arcmsr: Notify has sense data report

2014-11-28 Thread
There is no this case. We always have auto request sense to device in case of CHECK_CONDITION status. 2014-11-28 18:14 GMT+08:00 Hannes Reinecke : > On 11/28/2014 11:07 AM, Ching Huang wrote: >> From: Ching Huang >> >> Setting command status with 'DRIVER_SENSE' except 'CHECK_CONDITION' if we >>

Re: AW: ARCMSR - Notify sense data report - Lost patch?

2014-11-27 Thread
Of course. I shall submit this patch latter. Thanks, Ching 2014-11-28 0:05 GMT+08:00 Markus Stockhausen : >> Von: 黃清隆 [ching2...@areca.com.tw] >> Gesendet: Donnerstag, 27. November 2014 12:43 >> An: Markus Stockhausen >> Cc: Tomas Henzl; Christoph Hellwig; linux-scsi@vg

Re: [PATCH v1.1 2/16] arcmsr: Adding code to support MSI-X interrupt

2014-05-05 Thread
Hi Dan, Thanks for correcting this bug. Regards, Ching 2014-05-05 18:28 GMT+08:00 Dan Carpenter : > On Mon, May 05, 2014 at 04:47:11PM +0800, ching wrote: >> +static int >> +arcmsr_request_irq(struct pci_dev *pdev, struct AdapterControlBlock *acb) >> +{ >> + int i, j, r; >> + struct

Re: [PATCH v1.0 12/16] arcmsr: revise alloction of second dma_coherent_handle for type B adapter

2014-05-04 Thread
Hi Dan, This patch is not a bugfix. It is a simplification and consistency of coding for both adapter type B and D. Regards, Ching 2014-05-02 16:57 GMT+08:00 Dan Carpenter : > On Wed, Apr 30, 2014 at 07:30:29PM +0800, ching wrote: >> From: Ching >> >> Revise allocation of second dma_coherent_han

Re: [PATCH v1.0 14/16] arcmsr: fix sparse checking error

2014-05-04 Thread
Hi Dan, In this patch, there are several replace of call readl() or writel() by direct access to memory. Because in main memory, we allocated a block of memory for post_qbuffer and done_qbuffer. These memory are access by both of CPU and IOP, they are not hardware registers. This change will not i

Re: [PATCH v1.0 1/11] arcmsr: Revise interrupt service routine relate function

2014-05-02 Thread
Hi James, Indeed, it makes you confusion that I mistake typing the subject. It should be [PATCH v1.0 1/16] , but not [PATCH v1.0 1/11]. Why I use v1.0 other than v1.4? Changing from 11 patches to 16 patches. Because I spend a long time to simplify each patch, so patch number is increase. It is eas

[PATCH v1.3 11/11] arcmsr: Adding support Areca ARC1214/1224/1264/1284 SATA 6Gb raid controllers

2014-02-20 Thread
From: Ching Adding support Areca ARC1214/1224/1264/1284 SATA 6Gb raid controllers. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-20 20:14:42.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h

[PATCH v1.3 9/11] arcmsr: Fixed sparse warning or errors

2014-02-20 Thread
From: Ching Fixed sparse warning or errors. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-02-18 01:30:16.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-02-20 23:23:30.0 +0800

[PATCH v1.3 8/11] arcmsr: Modify ioctl relate functions to fix update firmware error

2014-02-20 Thread
From: Ching Modify ioctl relate functions to fix update firmware error. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-01-10 20:28:48.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_attr.

[PATCH v1.3 7/11] arcmsr: Notify sense data report

2014-02-20 Thread
From: Ching Notify sense data report Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:03:28.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:04:10.0 +0800

[PATCH v1.3 6/11] arcmsr: Rewrite arcmsr_message_isr_bh_fn function

2014-02-20 Thread
From: Ching Rewrite arcmsr_message_isr_bh_fn function Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:02:34.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:03:

[PATCH v1.3 5/11] arcmsr: Rename function name and variables for readability

2014-02-20 Thread
From: Ching Rename function name and variables for readability. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-13 23:21:56.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-01-14 23:27

[PATCH v1.3 4/11] arcmsr: Revise xxx_get_config functions

2014-02-20 Thread
From: Ching Revise xxx_get_config functions. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 03:14:14.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-01-13 23:21:56.0 +0800

[PATCH v1.3 3/11] arcmsr: Support hibernation

2014-02-20 Thread
From: Ching Supporting hibernation. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_hba.c b/drivers/scsi/arcmsr/arcmsr_hba.c --- a/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 01:59:56.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr_hba.c 2014-02-21 02:00:16.0 +0800

[PATCH v1.3 2/11] arcmsr: Support MSI and MSI-X interrupt service

2014-02-20 Thread
From: Ching Supporting MSI and MSI-X interrupt service. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr.h b/drivers/scsi/arcmsr/arcmsr.h --- a/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 02:53:22.0 +0800 +++ b/drivers/scsi/arcmsr/arcmsr.h 2014-01-11 03:14:14.

[PATCH v1.3 1/11] arcmsr: Revise interrupt service routine to fix command timeout

2014-02-20 Thread
From: Ching Rewrite interrupt service routine to fix command timeout on controller too heavy loading. Singed-off-by: Ching --- diff -uprN a/drivers/scsi/arcmsr/arcmsr_attr.c b/drivers/scsi/arcmsr/arcmsr_attr.c --- a/drivers/scsi/arcmsr/arcmsr_attr.c 2014-02-07 01:47:24.0 +0800 +++ b/dr

[PATCH 3/3] arcmsr: Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface

2013-08-25 Thread
From: Ching Fix bug of updating adapter firmware through ioctl(ARCHTTP) interface. Signed-off-by: Ching --- patch3 Description: Binary data

[PATCH 2/3] arcmsr: Fix command throttling for ARC188x series

2013-08-25 Thread
From: Ching Fix command throttling for ARC188x series adapter. Signed-off-by: Ching --- patch2 Description: Binary data

[PATCH 1/3] arcmsr: Support Areca new SATA Raid Adapter ARC1214/1224/1264/1284

2013-08-25 Thread
From: Ching Support Areca new SATA Raid adapter ARC1214/1224/1264/1284. Modify maximum outstanding command number, notify command complete with auto request sense Signed-off-by: Ching -- To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the body of a message to major

[PATCH 3/3] arcmsr: Fix bug of updating ARECA Raid adapter firmware through ioctl(ARCHTTP) interface

2013-07-16 Thread
From: chingching2...@areca.com.tw Fix bug of updating ARECA Raid adapter firmware through ioctl(ARCHTTP) interface Signed-off-by: chingching2...@areca.com.tw --- patch3 Description: Binary data

[PATCH 2/3] arcmsr: Fix command throttling for ARC188x series adapters

2013-07-16 Thread
From: chingching2...@areca.com.tw Fix command throttling for ARC188x series adapters. Signed-off-by: chingching2...@areca.com.tw --- patch2 Description: Binary data

[PATCH 1/3] arcmsr: Modify maxium outstanding command

2013-07-16 Thread
From: Ching Modify maximum outstanding command number, notify command complete with auto request sense, reassign ARC12x4 series to SATA type adapter Signed-off-by: chingching2...@areca.com.tw --- patch1 Description: Binary data