Re: [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr

2019-10-20 Thread Johannes Thumshirn
On 18/10/2019 15:43, Martin K. Petersen wrote: [...] > Johannes: Whatever happened to your efforts at cleaning all this up? Do > you have a patch series or a working tree we could use as starting > point? I'll have to look. I think it's still floating around in some git tree. Let me search for it

Proposal

2019-10-20 Thread Mr. Maheed
I have a special discussion to discuss with you please get back to me. Sincerely, Mr. Maheed Asad Alcaldia La Magdalena Contreras Coordinacion

Re: [PATCH] scsi: sd: fix uninit access of sshdr

2019-10-20 Thread Bart Van Assche
On 2019-10-18 03:01, zhengbin wrote: > @@ -1648,16 +1651,20 @@ static int sd_sync_cache(struct scsi_disk *sdkp, > struct scsi_sense_hdr *sshdr) > if (res) { > sd_print_result(sdkp, "Synchronize Cache(10) failed", res); > > - if (driver_byte(res) == DRIVER_SENSE) >

Re: [PATCH v5 00/13] scsi: core: fix uninit-value access of variable sshdr

2019-10-20 Thread zhengbin (A)
On 2019/10/18 21:43, Martin K. Petersen wrote: > Hannes, > >> The one thing which I patently don't like is the ambivalence between >> DRIVER_SENSE and scsi_sense_valid(). What shall we do if only _one_ >> of them is set? IE what would be the correct way of action if >> DRIVER_SENSE is not set,