Re: [PATCH] ch: Make it again possible to open a ch device two or more times

2019-10-09 Thread Martin K. Petersen
Bart, > Clearing ch->device in ch_release() is wrong because that pointer must > remain valid until ch_remove() is called. This patch fixes the > following crash the second time a ch device is opened: Applied to 5.4/scsi-fixes, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] megaraid_sas: unique names for MSIx vectors

2019-10-09 Thread Martin K. Petersen
Chandrakanth, > Currently, MSIx vectors name appears in /proc/interrupts is "megasas" > which is same for all the vectors. This patch provides the unique > name to all megaraid_sas controllers and its associated MSIx interrupts. > > Suggested-by: Konstantin Shalygin > Signed-off-by: Sumit Saxen

Re: [PATCH 00/10] smartpqi updates

2019-10-09 Thread Martin K. Petersen
Don, > These patches are based on Linus's tree Applied to 5.5/scsi-queue. There was some fuzz but I think I figured it out. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi_dh_alua: handle RTPG sense code correctly during state transitions

2019-10-09 Thread Martin K. Petersen
Hannes, > Some arrays are not capable of returning RTPG data during state > transitioning, but rather return an 'LUN not accessible, asymmetric > access state transition' sense code. In these cases we can set the > state to 'transitioning' directly and don't need to evaluate the RTPG > data (whi

Re: [PATCH] scsi: mpt3sas: Clean up some indenting

2019-10-09 Thread Martin K. Petersen
Dan, > This line is indented too far so it's a bit confusing. Applied to 5.5/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: Make function lpfc_defer_pt2pt_acc static

2019-10-09 Thread Martin K. Petersen
zhengbin, > drivers/scsi/lpfc/lpfc_nportdisc.c:290:1: warning: symbol > 'lpfc_defer_pt2pt_acc' was not declared. Should it be static? Applied to 5.5/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 08/14] qla2xxx: Dual FCP-NVMe target port support

2019-10-09 Thread Martin K. Petersen
Himanshu, > Some storage arrays advertise FCP LUNs and NVMe namespaces behind the > same WWN. The driver now offer's a user option by way of NVRAM > parameter to allow users to choose, on a per port basis, the kind of > FC-4 type they would like to prioritize for login. Applied patches 8-14 to

Re: [RFC PATCH V4 2/2] scsi: core: don't limit per-LUN queue depth for SSD

2019-10-09 Thread Ming Lei
On Wed, Oct 09, 2019 at 09:05:26AM -0700, Bart Van Assche wrote: > On 10/9/19 2:32 AM, Ming Lei wrote: > > @@ -354,7 +354,8 @@ void scsi_device_unbusy(struct scsi_device *sdev, > > struct scsi_cmnd *cmd) > > if (starget->can_queue > 0) > > atomic_dec(&starget->target_busy); > > -

[PATCH] ch: Make it again possible to open a ch device two or more times

2019-10-09 Thread Bart Van Assche
Clearing ch->device in ch_release() is wrong because that pointer must remain valid until ch_remove() is called. This patch fixes the following crash the second time a ch device is opened: BUG: kernel NULL pointer dereference, address: 0790 RIP: 0010:scsi_device_get+0x5/0x60 Call Trace

Re: [PATCH] scsi_dh_alua: handle RTPG sense code correctly during state transitions

2019-10-09 Thread Bart Van Assche
On 10/7/19 6:57 AM, Hannes Reinecke wrote: Some arrays are not capable of returning RTPG data during state transitioning, but rather return an 'LUN not accessible, asymmetric access state transition' sense code. In these cases we can set the state to 'transitioning' directly and don't need to eva

Re: [PATCH V4 1/2] scsi: core: avoid host-wide host_busy counter for scsi_mq

2019-10-09 Thread Bart Van Assche
On 10/9/19 2:32 AM, Ming Lei wrote: Cc: Bart Van Assche As one can see in the .mailmap file in the kernel tree I use my @acm.org email address for kernel contributions. The above email address is no longer valid since I left WDC more than a year ago. Otherwise this patch looks fine to me.

Re: [RFC PATCH V4 2/2] scsi: core: don't limit per-LUN queue depth for SSD

2019-10-09 Thread Bart Van Assche
On 10/9/19 2:32 AM, Ming Lei wrote: @@ -354,7 +354,8 @@ void scsi_device_unbusy(struct scsi_device *sdev, struct scsi_cmnd *cmd) if (starget->can_queue > 0) atomic_dec(&starget->target_busy); - atomic_dec(&sdev->device_busy); + if (!blk_queue_nonrot(sdev->reques

[RFC PATCH V4 2/2] scsi: core: don't limit per-LUN queue depth for SSD

2019-10-09 Thread Ming Lei
SCSI core uses the atomic variable of sdev->device_busy to track in-flight IO requests dispatched to this scsi device. IO request may be submitted from any CPU, so the cost for maintaining the shared atomic counter can be very big on big NUMA machine with lots of CPU cores. sdev->queue_depth is us

[PATCH V4 1/2] scsi: core: avoid host-wide host_busy counter for scsi_mq

2019-10-09 Thread Ming Lei
It isn't necessary to check the host depth in scsi_queue_rq() any more since it has been respected by blk-mq before calling scsi_queue_rq() via getting driver tag. Lots of LUNs may attach to same host and per-host IOPS may reach millions, so we should avoid expensive atomic operations on the host-

[PATCH V4 0/2] scsi: avoid atomic operations in IO path

2019-10-09 Thread Ming Lei
Hi, The 1st patch kills the atomic host-wide counter of host_busy. The 2nd patch bypass the atomic LUN-wide connter of device_busy for fast SSD device. V4: - fix one build waring, just a line change in scsi_dev_queue_ready() V3: - use non-atomic set/clear bit operations as sugge

[PATCH] scsi: megaraid: remove set but not used variables 'debugBlk','fusion'

2019-10-09 Thread zhengbin
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/megaraid/megaraid_sas_fp.c: In function MR_GetSpanBlock: drivers/scsi/megaraid/megaraid_sas_fp.c:400:16: warning: variable debugBlk set but not used [-Wunused-but-set-variable] drivers/scsi/megaraid/megaraid_sas_fp.c: In function mr_span