Re: [PATCH v3] scsi_debug: randomize command duration option

2019-10-02 Thread Bart Van Assche
On 10/1/19 8:27 PM, Douglas Gilbert wrote: - kt = ns_to_ktime((u64)delta_jiff * (NSEC_PER_SEC / HZ)); - } else - kt = ndelay; + u64 ns = jiffies_to_nsecs(delta_jiff); + + if (sdebug_random && ns

Re: [PATCH V3] scsi: save/restore command resid for error handling

2019-10-02 Thread Bart Van Assche
On 10/1/19 12:48 AM, Damien Le Moal wrote: When a non-passthrough command is terminated with CHECK CONDITION, request sense is executed by hijacking the command descriptor. Since scsi_eh_prep_cmnd() and scsi_eh_restore_cmnd() do not save/restore the original command resid, the value returned on f

[PATCH v2] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Martin Wilck
From: Martin Wilck Hello Martin, this patch fixes two issues in patch 02/14 in Himanshu's latest qla2xxx series ("qla2xxx: Bug fixes for the driver") from Sept. 12th, which you applied onto 5.4/scsi-fixes already. See https://marc.info/?l=linux-scsi&m=156951704106671&w=2 I'm assuming that Himan

Re: [PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Bart Van Assche
On 10/2/19 8:25 AM, Martin Wilck wrote: > On Wed, 2019-10-02 at 08:17 -0700, Bart Van Assche wrote: >> >> Both loops check the loop termination condition twice. Has it been >> considered to write these loops such that the loop termination >> condition >> is only tested once, e.g. using the followin

Re: [PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Martin Wilck
On Wed, 2019-10-02 at 08:17 -0700, Bart Van Assche wrote: > > Both loops check the loop termination condition twice. Has it been > considered to write these loops such that the loop termination > condition > is only tested once, e.g. using the following pattern? > > for (i = 0; i < 10; i++) >

Re: [PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Bart Van Assche
On 10/2/19 7:35 AM, Martin Wilck wrote: > From: Martin Wilck > > Hello Martin, > > this patch fixes two issues in patch 02/14 in Himanshu's latest > qla2xxx series ("qla2xxx: Bug fixes for the driver") from > Sept. 12th, which you applied onto 5.4/scsi-fixes already. > See https://marc.info/?l=l

[PATCH] fixup "qla2xxx: Optimize NPIV tear down process"

2019-10-02 Thread Martin Wilck
From: Martin Wilck Hello Martin, this patch fixes two issues in patch 02/14 in Himanshu's latest qla2xxx series ("qla2xxx: Bug fixes for the driver") from Sept. 12th, which you applied onto 5.4/scsi-fixes already. See https://marc.info/?l=linux-scsi&m=156951704106671&w=2 I'm assuming that Himan

Re: [PATCH v2] zfcp: fix reaction on bit error theshold notification with adapter close

2019-10-02 Thread Steffen Maier
On 10/1/19 8:26 PM, Martin K. Petersen wrote: Ok, then why make this a module option that you will have to support for the next 20+ years anyway if you feel this fix is the correct way that it should be done instead? I agree. Why not just shut FCP down unconditionally on excessive bit errors?