Re: [PATCH v2] scsi_debug: randomize command duration option + %p

2019-09-30 Thread Martin K. Petersen
Doug, >> Since sdebug_random is either 0 or 1, is the "? 1 : 0" part necessary? > > No. > Why didn't you complain when MKP wrote that? That is where I cut and > pasted that code from (sdebug_removable). [...] > Again, copy and paste from MKP's code (which no doubt was a copy + > paste from my

Re: [PATCH] zfcp: fix reaction on bit error theshold notification with adapter close

2019-09-30 Thread Martin K. Petersen
Steffen, > Kernel message explanation: > > * Description: > * The FCP channel reported that its bit error threshold has been exceeded. > * These errors might result from a problem with the physical components > * of the local fibre link into the FCP channel. > * The problem might be damage

Re: [PATCH] megaraid_sas: unique names for MSIx vectors

2019-09-30 Thread Martin K. Petersen
Chandrakanth, > +#define MEGASAS_MSIX_NAME_LEN16 [...] > + snprintf(instance->irq_context[i].name, MEGASAS_MSIX_NAME_LEN, > "%s%d-msix%d", > + "megasas", instance->host->host_no, i); Seems like MEGASAS_MSIX_NAME_LEN is too small given t

Re: [PATCH] scsi: ignore a failure to synchronize cache due to lack of authorization

2019-09-30 Thread Martin K. Petersen
Oliver, > I've got a report about a UAS drive enclosure reporting back Sense: > Logical unit access not authorized if the drive it holds is password > protected. While the drive is obviously unusable in that state as a > mass storage device, it still exists as a sd device and when the > system i

Re: [PATCH v2] scsi: Add sysfs attributes for VPD pages 0h and 89h

2019-09-30 Thread Martin K. Petersen
Ryan, > Add sysfs attributes for the ATA information page and Supported VPD > Pages page. Applied to 5.5/scsi-queue, thank you. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 0/3] scsi: core: allow auto suspend override by low-level driver

2019-09-30 Thread Martin K. Petersen
Stanley, > Until now the scsi mid-layer forbids runtime suspend till userspace > enables it. This is mainly to quarantine some disks with broken > runtime power management or have high latencies executing suspend > resume callbacks. If the userspace doesn't enable the runtime suspend > the under

Re: [PATCH v2] scsi_debug: randomize command duration option + %p

2019-09-30 Thread Douglas Gilbert
On 2019-09-30 11:46 a.m., Bart Van Assche wrote: On 9/27/19 7:04 AM, Douglas Gilbert wrote: Add an option to use the given command delay (in nanoseconds) as the upper limit for command durations. A pseudo random number generator chooses each duration from the range:    [0..delay_in_ns) Main

Re: [PATCH 00/13] Enhancements w.r.t to diag buffer and few bug fixes

2019-09-30 Thread Martin K. Petersen
Sreekanth, > This patch series contains enhancements w.r.t to diag buffer support > and few bug fix patches. Applied to 5.5/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH V2] scsi: save/restore command resid for error handling

2019-09-30 Thread Damien Le Moal
On 2019/09/30 17:42, Finn Thain wrote: > On Sat, 28 Sep 2019, Damien Le Moal wrote: > >> When a non-passthrough command is terminated with CHECK CONDITION, >> request sense is executed by hijacking the command descriptor. Since >> scsi_eh_prep_cmnd() and scsi_eh_restore_cmnd() do not save/restore

Re: [PATCH 00/20] lpfc: Update lpfc to revision 12.4.0.1

2019-09-30 Thread Martin K. Petersen
James, > Update lpfc to revision 12.4.0.1 Applied to 5.5/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [RFC,v2] scsi: scan: map PQ=1, PDT=other values to SCSI_SCAN_TARGET_PRESENT

2019-09-30 Thread Martin K. Petersen
Hannes, > 1) all underlying devices are exported to the OS; of course they have > to be properly masked etc to avoid udev to latch on those devices. I > also was under the impression that the 'no_uld_attach' should be > sufficient here, but then that only avoids the 'sd' driver to become > attac

Re: [PATCH V2] scsi: save/restore command resid for error handling

2019-09-30 Thread Finn Thain
On Sat, 28 Sep 2019, Damien Le Moal wrote: > When a non-passthrough command is terminated with CHECK CONDITION, > request sense is executed by hijacking the command descriptor. Since > scsi_eh_prep_cmnd() and scsi_eh_restore_cmnd() do not save/restore the > original command resid, the value return

Re: [PATCH v2 02/14] qla2xxx: Fix unbound sleep in fcport delete path.

2019-09-30 Thread Bart Van Assche
On 9/12/19 11:09 AM, Himanshu Madhani wrote: From: Quinn Tran There are instances, though rare, where a LOGO request cannot be sent out and the thread in free session done can wait indefinitely. Fix this by putting an upper bound to sleep. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Mad

Re: [PATCH v2] scsi_debug: randomize command duration option + %p

2019-09-30 Thread Bart Van Assche
On 9/27/19 7:04 AM, Douglas Gilbert wrote: Add an option to use the given command delay (in nanoseconds) as the upper limit for command durations. A pseudo random number generator chooses each duration from the range: [0..delay_in_ns) Main benefit: allows testing with out-of-order respons