Re: [PATCH v4 4/5] block: introduce LED block device activity trigger

2019年8月20日(火) 3:38 Jacek Anaszewski : > > On 8/19/19 8:22 PM, Jacek Anaszewski wrote: > > On 8/19/19 4:38 PM, Pavel Machek wrote: > >> On Sat 2019-08-17 22:07:43, Jacek Anaszewski wrote: > >>> On 8/17/19 4:55 PM, Pavel Machek wrote: > On Fri 2019-08-16 01:59:58, Akinobu Mita wrote: > > Thi

[PATCH] scsi: fnic: print port speed only at driver init or speed change

Port speed printing was added by commit d948e6383ec3 ("scsi: fnic: Add port speed stat to fnic debug stats"). As currently configured, this will cause the port speed to be printed to syslog every 2 seconds. To prevent log spamming, only print the vnic port speed at driver initialization and if the

[PATCH] scsi: ufs: remove set but not used variable 'val'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/ufs/ufs-qcom.c: In function ufs_qcom_pwr_change_notify: drivers/scsi/ufs/ufs-qcom.c:808:6: warning: variable val set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/scsi/ufs/ufs-qc

[PATCH 0/2] scsi: csiostor: remove some set but not used variables

zhengbin (2): scsi: csiostor: remove set but not used variables 'mc_bist_status_rdata_reg','edc_bist_status_rdata_reg' scsi: csiostor: remove set but not used variable 'rln' drivers/scsi/csiostor/csio_hw_t5.c | 6 ++ drivers/scsi/csiostor/csio_lnode.c | 3 +-- 2 files changed, 3 inser

[PATCH 1/2] scsi: csiostor: remove set but not used variables 'mc_bist_status_rdata_reg','edc_bist_status_rdata_reg'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/csiostor/csio_hw_t5.c: In function csio_t5_mc_read: drivers/scsi/csiostor/csio_hw_t5.c:151:11: warning: variable mc_bist_status_rdata_reg set but not used [-Wunused-but-set-variable] drivers/scsi/csiostor/csio_hw_t5.c: In function csio_t

[PATCH 2/2] scsi: csiostor: remove set but not used variable 'rln'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/csiostor/csio_lnode.c: In function csio_ln_init: drivers/scsi/csiostor/csio_lnode.c:1992:21: warning: variable rln set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/scsi/csiostor

Re: [PATCH RFC 00/24] scsi: enable reserved commands for LLDDs

On 29/05/2019 14:28, Hannes Reinecke wrote: Hi all, quite some drivers use internal commands for various purposes, most commonly sending TMFs or querying the HBA status. While these commands use the same submission mechanism than normal I/O commands, they will not be counted as outstanding comma

[PATCH 2/3] scsi: bnx2fc: remove set but not used variables 'lport','host'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/bnx2fc/bnx2fc_io.c: In function bnx2fc_initiate_seq_cleanup: drivers/scsi/bnx2fc/bnx2fc_io.c:932:19: warning: variable lport set but not used [-Wunused-but-set-variable] drivers/scsi/bnx2fc/bnx2fc_io.c: In function bnx2fc_initiate_cleanu

[PATCH 1/3] scsi: bnx2fc: remove set but not used variable 'fh'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function bnx2fc_rcv: drivers/scsi/bnx2fc/bnx2fc_fcoe.c:431:26: warning: variable fh set but not used [-Wunused-but-set-variable] Reported-by: Hulk Robot Signed-off-by: zhengbin --- drivers/scsi/bnx2fc/bnx2fc_

[PATCH 3/3] scsi: bnx2fc: remove set but not used variables 'task','port','orig_task'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/bnx2fc/bnx2fc_hwi.c: In function bnx2fc_process_unsol_compl: drivers/scsi/bnx2fc/bnx2fc_hwi.c:636:30: warning: variable task set but not used [-Wunused-but-set-variable] drivers/scsi/bnx2fc/bnx2fc_hwi.c: In function bnx2fc_process_ofld_c

[PATCH 0/3] scsi: bnx2fc: remove some set but not used variables

zhengbin (3): scsi: bnx2fc: remove set but not used variable 'fh' scsi: bnx2fc: remove set but not used variables 'lport','host' scsi: bnx2fc: remove set but not used variables 'task','port','orig_task' drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 2 -- drivers/scsi/bnx2fc/bnx2fc_hwi.c | 16 --

Re: Slow I/O on USB media after commit f664a3cc17b7d0a2bc3b3ab96181e1029b0ec0e6

Il giorno mar, 20/08/2019 alle 13.13 -0400, Alan Stern ha scritto: > On Mon, 19 Aug 2019, Andrea Vai wrote: > > > Hi Alan, > > I attach the two traces, collected as follows: > > > > - start the trace; > > - wait 10 seconds; > > - plug the drive; > > - wait 5 seconds; > > - mount the drive; > >

[Bug 204119] scsi_mod: Could not allocate 4104 bytes percpu data

https://bugzilla.kernel.org/show_bug.cgi?id=204119 --- Comment #11 from Yill Din (justinc...@yopmail.com) --- Thx for answer. I tried to patch my distribution-kernel with your bugfix. It works brilliant. I can use all my usb-devices again. -- You are receiving this mail because: You are the a

[PATCH 13/14] qedf: Fix race betwen fipvlan request and response path.

There is a race b/w fipvlan request and response path. = qedf_fcoe_process_vlan_resp:113]:2: VLAN response, vid=0xffd. qedf_initiate_fipvlan_req:165]:2: vlan = 0x6ffd already set. qedf_set_vlan_id:139]:2: Setting vlan_id=0ffd prio=3. == The request thread sees that vlan is already set and

[PATCH 07/14] qedf: Add support for 20 Gbps speed.

- The current code doeesn't support 20Gbps speed for current and supported speed, add support for the same. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index

[PATCH 09/14] qedf: Initiator fails to re-login to switch after link down.

Problem Statement: Driver has fc_id of 0xcc0200 Driver gets link down (due to test) and calls fcoe_ctlr_link_down(). At this point, the fc_id of the initiator port is zeroed out. Driver gets a link up 14 seconds later. Driver performs FIP VLAN request, gets a response from the switch. No change in

[PATCH 05/14] qedf: Add shutdown callback handler.

- Add shutdown callback handler. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 6959f7c..a824bbb 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/driver

[PATCH 06/14] qedf: Interpret supported caps value correctly.

- Driver was wrongly interpreting the supported cap value returned by qed. Solution: Use QED define macros instead of OS defined for interpreting supporting speeds. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 32 +++- 1 file changed, 27 insert

[PATCH 08/14] qedf: Add debug information for unsolicited processing.

- log s_id, d_id, type and command to the log message. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_io.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 7377a53..27989b3 100644 --- a/drivers/scsi/qedf/qedf_io.c +

[PATCH 14/14] qedf: Update the version to 8.42.3.0.

- Update the driver version to 8.42.3.0 Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_version.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index e57533d..b0e37af 100644 --- a/drivers/s

[PATCH 04/14] qedf: Update module description string.

From: Nilesh Javali Update module description. Signed-off-by: Nilesh Javali Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 2d69860..6959f7c

[PATCH 00/14] qedf: Miscellaneous fixes.

Hi Martin, This series have bug fixes and improve the log messages for better debugging. Kindly apply this series to scsi-queue at your earliest convenience. Thanks, ~Saurav Arun Easi (1): qedf: Fix crash during sg_reset. Hannes Reinecke (1): qedf: Use discovery list to traverse rports

[PATCH 11/14] qedf: Decrease the LL2 MTU size to 2500.

- Decrease the LL2 MTU size to 2500. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf.h | 1 + drivers/scsi/qedf/qedf_main.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf.h b/drivers/scsi/qedf/qedf.h index 5a02121..f3f399f 100644 --- a/

[PATCH 03/14] qedf: Fix crash during sg_reset.

From: Arun Easi Driver was attempting to print cdb[0], which is not set for resets coming from SCSI ioctls. Check for cmd_len before accessing cmnd. Crash info: [84790.864747] BUG: unable to handle kernel NULL pointer dereference at (null) [84790.864783] IP: qedf_initiate_tmf+0x7a/0x6e0 [qedf] [

[PATCH 12/14] qedf: Use discovery list to traverse rports

From: Hannes Reinecke The list of rports might become stale, so we should rather traverse the discovery list when trying relogin. Signed-off-by: Hannes Reinecke Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 39 +++ 1 file changed, 7 inse

[PATCH 10/14] qedf: Check for module unloading bit before processing link update AEN.

- Prevent race where we're removing the module and we get link update Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_main.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 50b1fa8..ab9a932 100644 --- a/

[PATCH 01/14] qedf: Print message during bailout conditions.

- Print messages during exiting condition to help debugging. Signed-off-by: Saurav Kashyap --- drivers/scsi/qedf/qedf_debugfs.c | 16 +-- drivers/scsi/qedf/qedf_els.c | 38 -- drivers/scsi/qedf/qedf_fip.c | 5 +++- drivers/scsi/qedf/qedf_io.c | 58

[PATCH 02/14] qedf: Stop sending fipvlan request on unload.

- On some setups fipvlan can be retried for long duration and the connection to switch was not there so it was not getting any reply. - During unload this thread was hanging. Problem Resolution: Check if unload is in progress then quit from fipvlan thread. Signed-off-by: Saurav Kashyap --- driv