On 8/13/19 10:31 PM, Martin Wilck wrote:
> From: Martin Wilck
>
> It seems right to try and calculate the dump size properly
> even in the error case, before allocating the dump buffers.
>
> Cc: Joe Carnuccio
> Cc: Quinn Tran
> Cc: Himanshu Madhani
> Cc: Bart Van Assche
> Signed-off-by: Mart
On 8/13/19 10:31 PM, Martin Wilck wrote:
> From: Martin Wilck
>
> Reset ha->rce, ha->eft and the respective dma fields if
> the buffers aren't mapped for some reason. Also, treat
> both failure cases (allocation and initialization failure)
> equally. The next patch modifies the failure behavior
>
On 8/13/19 10:31 PM, Martin Wilck wrote:
> From: Martin Wilck
>
> In qla2x00_alloc_fw_dump(), an existing EFT buffer (e.g. from
> previous invocation of qla2x00_alloc_offload_mem()) is freed.
> The buffer is then re-allocated, but without setting the eft and
> eft_dma fields to the new values.
>
On 2019-08-12 10:23 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:37PM +0200, Douglas Gilbert wrote:
+ unsigned long fdev_bm[1]; /* see SG_FDEV_* defines above */
No need for the array of one here.
Justification here:
https://www.spinics.net/lists/linux-scsi/msg
On 2019-08-12 10:31 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:41PM +0200, Douglas Gilbert wrote:
Add sg_allow_if_err_recover() to do checks common to several entry
points. Replace retval with either res or ret. Rename
sg_finish_rem_req() to sg_finish_scsi_blk_rq(). Rename
sg_n
On 2019-08-12 10:35 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:43PM +0200, Douglas Gilbert wrote:
Remove the fixed size array of 16 request elements per file
descriptor and replace with two linked lists per file descriptor.
One list is for active commands, the other list is a f
On 2019-08-12 10:23 a.m., Christoph Hellwig wrote:
On Wed, Aug 07, 2019 at 01:42:35PM +0200, Douglas Gilbert wrote:
Replace SCSI_LOG_TIMEOUT macros with SG_LOG macros across the driver.
The definition of SG_LOG calls SCSI_LOG_TIMEOUT if given and derived
pointers are non-zero, calls pr_info othe
From: Martin Wilck
It seems right to try and calculate the dump size properly
even in the error case, before allocating the dump buffers.
Cc: Joe Carnuccio
Cc: Quinn Tran
Cc: Himanshu Madhani
Cc: Bart Van Assche
Signed-off-by: Martin Wilck
---
drivers/scsi/qla2xxx/qla_init.c | 5 +++--
1 f
From: Martin Wilck
Hi Himanshu, hi Martin,
Please consider this series for merging.
The first patch of the series is a fix for a memory corruption we
saw in a test where qla2xxx was loaded/unloaded repeatedly under
memory pressure. The other ones are consistency fixes that occured
to me while w
On 8/13/19 3:25 AM, Christoph Hellwig wrote:
> The hpsim platform supports the HP IA64 simulator which was useful as a
> bring up platform. But it is fairly non-standard vs real IA64 system
> in that it for example doesn't support ACPI. It also comes with a
> whole bunch of simulator specific d
From: Martin Wilck
In qla2x00_alloc_fw_dump(), an existing EFT buffer (e.g. from
previous invocation of qla2x00_alloc_offload_mem()) is freed.
The buffer is then re-allocated, but without setting the eft and
eft_dma fields to the new values.
Fixes: a28d9e4ef997 "scsi: qla2xxx: Add support for mu
From: Martin Wilck
Reset ha->rce, ha->eft and the respective dma fields if
the buffers aren't mapped for some reason. Also, treat
both failure cases (allocation and initialization failure)
equally. The next patch modifies the failure behavior
slightly again.
Fixes: ad0a0b01f088 "scsi: qla2xxx: F
12 matches
Mail list logo
