Re: [PATCH] lpfc: Mitigate high memory pre-allocation by SCSI-MQ

2019-07-30 Thread Ming Lei
On Wed, Jul 31, 2019 at 8:24 AM James Smart wrote: > > When SCSI-MQ is enabled, the SCSI-MQ layers will do pre-allocation of > MQ resources based on shost values set by the driver. In newer cases > of the driver, which attempts to set nr_hw_queues to the cpu count, > the multipliers become excessi

[PATCH] lpfc: Mitigate high memory pre-allocation by SCSI-MQ

2019-07-30 Thread James Smart
When SCSI-MQ is enabled, the SCSI-MQ layers will do pre-allocation of MQ resources based on shost values set by the driver. In newer cases of the driver, which attempts to set nr_hw_queues to the cpu count, the multipliers become excessive, with a single shost having SCSI-MQ pre-allocation reaching

Re: [PATCH 00/15] qla2xxx: Bug fixes for the driver

2019-07-30 Thread Martin K. Petersen
Himanshu, > This series contains bug fixes for the driver. Most of the fixes are > obvious memory leak and/or error handling fixes. > > Please apply this series to 5.4/scsi-queue at your earliest > convenience. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Enginee

Re: [PATCH v2] scsi: mpt3sas: clean up a couple sizeof() uses

2019-07-30 Thread Martin K. Petersen
Dan, > There is a copy and paste bug here. It uses EVENT_TRIGGERS size instead > of SCSI_TRIGGERS size but fortunately both size are 84 bytes so it > doesn't affect runtime. > > These days the prefered style is to just say sizeof(object) instead of > sizeof(type) so I have updated the function

Re: [PATCH v2] scsi: scsi_debugfs: Use for_each_set_bit to simplify code

2019-07-30 Thread Martin K. Petersen
Andy, > We can use for_each_set_bit() to slightly simplify the code. Applied to 5.4/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] mpt3sas: Use 63-bit DMA addressing on SAS35 HBA

2019-07-30 Thread Martin K. Petersen
Suganath, > Although SAS3 & SAS3.5 IT HBA controllers support 64-bit DMA > addressing, as per hardware design, if DMA able range contains all > 64-bits set (0x-) then it results in a firmware fault. Applied to 5.3/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Eng

Re: [PATCH 0/2] hpsa updates

2019-07-30 Thread Martin K. Petersen
Don, > These patches are based on Linus's tree Applied to 5.3/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCHv3 0/3] fcoe: cleanup fc_rport_priv usage

2019-07-30 Thread Martin K. Petersen
Hannes, > the fcoe vn2vn code is using the 'fc_rport_priv' structure as argument > to its internal function, but is really expecting a struct fcoe_rport > to immediately follow this one. This is not only confusing but also an > error for new compilers. So clean up the usage by embedding > fc_rp

Re: [PATCH 0/3] Fix more magic values in the Future Domain drivers

2019-07-30 Thread Martin K. Petersen
Sergei, > Here's a set of 3 patches against the Linus' repo. The recently > resurrected Future Domain SCSI driver got a facelift by Ondrej (thank > you!); however, several magic numbers were overlooked, so I went and > fixed these cases. Applied to 5.4/scsi-queue. Thank you! -- Martin K. Pete

[PATCH v2] mpt3sas: Use 63-bit DMA addressing on SAS35 HBA

2019-07-30 Thread Suganath Prabu
Although SAS3 & SAS3.5 IT HBA controllers support 64-bit DMA addressing, as per hardware design, if DMA able range contains all 64-bits set (0x-) then it results in a firmware fault. e.g. SGE's start address is 0x-000 and data length is 0x1000 bytes. when HBA tries to D