[PATCH v2 1/3] scsi: ufs: clean-up task resource immediately only if task is responded

2019-07-23 Thread Stanley Chu
In __ufshcd_issue_tm_cmd(), if host is unable to clear TM command by setting "clear register", the TM command may be still "outstanding" in the device. In this case, it may be better to do cleanup after reset is done. Therefore let __ufshcd_issue_tm_cmd() clean-up task resource immediately only if

[PATCH v2 2/3] scsi: ufs: introduce ufshcd_tm_cmd_compl() to refactor task cleanup

2019-07-23 Thread Stanley Chu
Introduce ufshcd_tm_cmd_compl() to re-factor taks cleanup jobs to make code more readable and for future wider usage by task error handling. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/ufshcd.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/ufs/u

[PATCH v2 0/3] scsi: ufs: fix broken hba->outstanding_tasks

2019-07-23 Thread Stanley Chu
Currently bits in hba->outstanding_tasks are cleared only after their corresponding task management commands are successfully done by __ufshcd_issue_tm_cmd(). If timeout happens in a task management command, its corresponding bit in hba->outstanding_tasks will not be cleared until next task manage

[PATCH v2 3/3] scsi: ufs: fix broken hba->outstanding_tasks

2019-07-23 Thread Stanley Chu
Currently bits in hba->outstanding_tasks are cleared only after their corresponding task management commands are successfully done by __ufshcd_issue_tm_cmd(). If timeout happens in a task management command, its corresponding bit in hba->outstanding_tasks will not be cleared until next task manage

Re: [PATCH 14/19] sg: tag and more_async

2019-07-23 Thread Douglas Gilbert
On 2019-07-23 2:11 p.m., kbuild test robot wrote: Hi Douglas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v5.3-rc1 next-20190723] [if your patch is applied to the wrong git tree, please drop us a note to help

RE: [PATCH v1 0/2] scsi: ufs: Fix broken hba->outstanding_tasks

2019-07-23 Thread Stanley Chu
Hi Avri, On Mon, 2019-07-22 at 06:10 +, Avri Altman wrote: > > > > > > > > Hi, > > > > > > > > > > > Currently bits in hba->outstanding_tasks are cleared only after their > > > > corresponding task management commands are successfully done by > > > > __ufshcd_issue_tm_cmd(). > > > > > > > > I

Re: [PATCH 0/3] Fix more magic values in the Future Domain drivers

2019-07-23 Thread Martin K. Petersen
Sergei, > Here's a set of 3 patches against the Linus' repo. The recently > resurrected Future Domain SCSI driver got a facelift by Ondrej (thank > you!); however, several magic numbers were overlooked, so I went and > fixed these cases. > > Future Domain's stuff isn't new to me -- I wrote a FD

Re: [PATCH 14/19] sg: tag and more_async

2019-07-23 Thread kbuild test robot
Hi Douglas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v5.3-rc1 next-20190723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com

Re: [PATCH 2/3] fcoe: avoid memset across pointer boundaries

2019-07-23 Thread Christoph Hellwig
On Mon, Jul 22, 2019 at 02:50:50PM -0400, Douglas Gilbert wrote: > Hmmm, "non-empty", is that a GNU extension? Yes, empty initializers are a GNU extension. One that is pretty heavily used in the kernel.

Re: [PATCH 05/19] sg: replace rq array with lists

2019-07-23 Thread kbuild test robot
Hi Douglas, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v5.3-rc1 next-20190723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com