Re: [PATCH v1 0/2] scsi: ufs: Fix broken hba->outstanding_tasks

2019-07-17 Thread Stanley Chu
Hi Avri, Alim and Pedrom, Gentle ping for this fix. On Fri, 2019-07-12 at 12:44 +0800, Stanley Chu wrote: > Currently bits in hba->outstanding_tasks are cleared only after their > corresponding task management commands are successfully done by > __ufshcd_issue_tm_cmd(). > > If timeout happens in

[PATCH 2/2] scsi: implement .cleanup_rq callback

2019-07-17 Thread Ming Lei
Implement .cleanup_rq() callback for freeing driver private part of the request. Then we can avoid to leak this part if the request isn't completed by SCSI, and freed by blk-mq or upper layer(such as dm-rq) finally. Cc: Ewan D. Milne Cc: Bart Van Assche Cc: Hannes Reinecke Cc: Christoph Hellwig

[PATCH 0/2] block/scsi/dm-rq: fix leak of request private data in dm-mpath

2019-07-17 Thread Ming Lei
Hi, When one request is dispatched to LLD via dm-rq, if the result is BLK_STS_*RESOURCE, dm-rq will free the request. However, LLD may allocate private stuff for this request, so this way will cause memory leak. Add .cleanup_rq() callback and implement it in SCSI for fixing the issue. And SCSI is

[PATCH 1/2] blk-mq: add callback of .cleanup_rq

2019-07-17 Thread Ming Lei
dm-rq needs to free request which has been dispatched and not completed by underlying queue. However, the underlying queue may have allocated private stuff for this request in .queue_rq(), so dm-rq will leak the request private part. Add one new callback of .cleanup_rq() to fix the memory leak iss

If interested

2019-07-17 Thread Tk Allen
My name is Mr. Allen, I have a Business Proposal of Four million five hundred thousand united states dollars for you to handle with me from my bank. I will need you to assist me in executing this Business .

答复: [PATCH] scsi_dh_alua: always use a 2 seconds delay before retrying RTPG

2019-07-17 Thread Zhangguanghui
Hi Does Hannes' patch has been lightly tested on my scenario, always use 2 seconds delay before retrying. The patch looks good to me, well running. But I'd wonder whether 'if (!pg->interval) ' is necessary condition for codes style? Thanks very much!  the details: Jul 17 16:21:10 cvknode2058 k