Re: [PATCH V5 10/16] s390: zfcp_fc: use sg helper to operate scatterlist

2019-06-25 Thread Ming Lei
Hi Steffen, On Tue, Jun 25, 2019 at 12:51:04PM +0200, Steffen Maier wrote: > Hi Ming, > > I don't mind doing this change for zfcp. However, I'm having doubts > regarding the rationale in the commit description. If I understood your > patch series correctly from its cover letter (would have been n

scsi_dh_alua: re-initialize pg->interval in alua_rtpg_work

2019-06-25 Thread Zhangguanghui
Hi Thank you very much for you reply, I have tried to contact 3PAR about this issue. Hundreds of them flooding the log for some seconds that is an serious problem. It can be reproduced on the Linux 4.14 kernel version or the lastest version for 3PAR storage Remote Copy Failover platfor

RE: [PATCH] Documentation: scsi: ufs: announce ufs-tool v1.0

2019-06-25 Thread Arthur Simchaev
Hi Alim Yes you can, by writing the configuration descriptor. Regards Arthur > > Hi Arthur, > Does this tools provides a way for ufs device partition provising from > user space as well? > (have not used this tool till now, planning to use soon) >

Re: [PATCH] Documentation: scsi: ufs: announce ufs-tool v1.0

2019-06-25 Thread Alim Akhtar
Hi Arthur, Does this tools provides a way for ufs device partition provising from user space as well? (have not used this tool till now, planning to use soon) On 6/25/19 6:06 PM, Arthur Simchaev wrote: > From: Arthur Simchaev > > The ufs-tool stable release v1.0 is available at > https://github

[PATCH] Documentation: scsi: ufs: announce ufs-tool v1.0

2019-06-25 Thread Arthur Simchaev
From: Arthur Simchaev The ufs-tool stable release v1.0 is available at https://github.com/westerndigitalcorporation/ufs-tool Feedback and bug reports, as always, are welcomed. Signed-off-by: Arthur Simchaev --- Documentation/scsi/ufs.txt | 5 + 1 file changed, 5 insertions(+) diff --git

[PATCH v3 13/18] megaraid_sas: Add support for High IOPs queues

2019-06-25 Thread Chandrakanth Patil
Aero controllers support balanced performance mode through the ability to configure queues with different properties. Reply queues with interrupt coalescing enabled are called "high iops reply queues" and reply queues with interrupt coalescing disabled are called "low latency reply queues". The d

[PATCH v3 16/18] megaraid_sas: Use high IOPs queues based on IO workload

2019-06-25 Thread Chandrakanth Patil
The driver will use round-robin method for IO submission in batches within the high iops queues when the number of in-flight ios on the target device is larger than 8. Otherwise the driver will use low latency reply queues. Signed-off-by: Kashyap Desai Signed-off-by: Chandrakanth Patil --- driv

[PATCH v3 17/18] megaraid_sas: Introduce various Aero performance modes

2019-06-25 Thread Chandrakanth Patil
For Aero adapters, driver provides three different performance modes controlled through module parameter named- 'perf_mode'. Below are those performance modes: 0: Balanced - Additional high IOPs reply queues will be enabled along with low latency queues. Interrupt coalescing will be enabled

[PATCH v3 12/18] megaraid_sas: Add support for MPI toolbox commands

2019-06-25 Thread Chandrakanth Patil
Added driver support to allow passthrough MPI toolbox type MFI commands to firmware based on firmware capability. Signed-off-by: Sumit Saxena Signed-off-by: Chandrakanth Patil --- drivers/scsi/megaraid/megaraid_sas.h| 36 - drivers/scsi/megaraid/megaraid_sas_

[PATCH v3 11/18] megaraid_sas: Offload Aero RAID5/6 division calculations to driver

2019-06-25 Thread Chandrakanth Patil
For RAID5/RAID6 volumes configured behind Aero, driver will be doing 64bit division operations on behalf of firmware as controller's ARM CPU is very slow in this division. Later, driver calculate Q-ARM, P-ARM and Log-ARM and pass those values to firmware by writing these values to RAID_CONTEXT. Si

[PATCH v3 18/18] megaraid_sas: Update driver version to 07.710.06.00-rc1

2019-06-25 Thread Chandrakanth Patil
Signed-off-by: Chandrakanth Patil --- drivers/scsi/megaraid/megaraid_sas.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_sas.h index 0b38691..dc0f71f 100644 --- a/drivers/scsi/megaraid/megaraid_sas.h

[PATCH v3 14/18] megaraid_sas: Enable coalescing for high IOPs queues

2019-06-25 Thread Chandrakanth Patil
Driver should enable interrupt coalescing(during driver load and after Controller Reset) for High IOPs queues by masking appropriate bits in IOC INIT frame. Signed-off-by: Kashyap Desai Signed-off-by: Chandrakanth Patil --- drivers/scsi/megaraid/megaraid_sas.h| 2 +- drivers/scsi/megar

[PATCH v3 15/18] megaraid_sas: Set affinity for high IOPs reply queues

2019-06-25 Thread Chandrakanth Patil
High iops queues are mapped to non-managed IRQs. Set affinity of non-managed irqs to local numa node. Low latency queues are mapped to managed IRQs. Driver reserves some reply queues for high iops queues (through pci_alloc_irq_vectors_affinity and .pre_vectors interface). The rest of queues are f

[PATCH v3 05/18] megaraid_sas: Release Mutex lock before OCR in case of DCMD timeout

2019-06-25 Thread Chandrakanth Patil
Issue: There is possibility of few DCMDs timing out with 'reset_mutex' lock held. As part of DCMD timeout handling, driver calls function megasas_reset_fusion which also tries to acquire same lock 'reset_mutex' and end up with deadlock. Fix: Upon timeout of DCMDs(which are fired with 'reset_mutex'

[PATCH v3 00/18] megaraid_sas: driver updates to 07.710.06.00-rc1

2019-06-25 Thread Chandrakanth Patil
This patchset contains performance improvements in megaraid_sas driver for latest MegaRAID Aero family of adapters along with few driver fixes. V2: - Fixed sparse warnings reported by kbuild test robot in patch 11. - Fixed module parameter description in patch 17. V3: - Fixed smatch

[PATCH v3 04/18] megaraid_sas: Call disable_irq from process IRQ poll

2019-06-25 Thread Chandrakanth Patil
On PowerPC architecture, calling disable_irq_nosync from IRQ context is not providing the required effect. In current megaraid_sas driver, disable_irq_nosync is being called from IRQ context before enabling IRQ poll. But due to the issue seen on PPC, after IRQ poll disable and legacy ISR is enable

[PATCH v3 01/18] megaraid_sas: Add 32 bit atomic descriptor support to AERO adapters

2019-06-25 Thread Chandrakanth Patil
Aero adapters provides Atomic Request Descriptor as an alternative method for posting an entry onto a request queue. The posting of an Atomic Request Descriptor is an atomic operation, providing a safe mechanism for multiple processors on the host to post requests without synchronization. This Atom

[PATCH v3 06/18] megaraid_sas: In probe context, retry IOC INIT once if firmware is in fault

2019-06-25 Thread Chandrakanth Patil
Issue: Under certain conditions, controller goes in FAULT state after IOC INIT fired to firmware. Such Fault can be recovered through controller reset. Fix: In driver probe context, if firmware fault is observed post IOC INIT, driver would do controller reset followed by retry logic for IOC INIT c

[PATCH v3 03/18] megaraid_sas: Remove few debug counters from IO path

2019-06-25 Thread Chandrakanth Patil
Signed-off-by: Kashyap Desai Signed-off-by: Chandrakanth Patil --- drivers/scsi/megaraid/megaraid_sas.h| 5 - drivers/scsi/megaraid/megaraid_sas_fusion.c | 5 - 2 files changed, 10 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas.h b/drivers/scsi/megaraid/megaraid_s

[PATCH v3 07/18] megaraid_sas: Don't send FPIO to RL Bypass queue

2019-06-25 Thread Chandrakanth Patil
Firmware does not expect FastPath IO sent through Region Lock Bypass queue. Though firmware never exposes such settings when fastpath IO can be sent to RL bypass queue but it's safer to remove dead code which directs fastpath IO to RL Bypass queue. Signed-off-by: Sumit Saxena Signed-off-by: Chand

[PATCH v3 02/18] megaraid_sas: Add support for Non-secure Aero PCI IDs

2019-06-25 Thread Chandrakanth Patil
This patch will add support for Non-secure Aero adapters' PCI IDs. Driver will throw an error message when a non-secure type controller is detected. Purpose of this interface is to avoid interacting with any firmware which is not secured/signed by Broadcom. Any tampering on Firmware component will

[PATCH v3 08/18] megaraid_sas: Handle sequence JBOD map failure at driver level

2019-06-25 Thread Chandrakanth Patil
Issue: This issue is applicable to scenario when JBOD sequence map is unavailable (memory allocation for JBOD sequence map failed) to driver but feature is supported by firmware. If the driver sends a JBOD IO by not adding 255(MAX_PHYSICAL_DEVICES - 1) to device ID when underlying firmware supports

[PATCH v3 09/18] megaraid_sas: megaraid_sas: Add check for count returned by HOST_DEVICE_LIST DCMD

2019-06-25 Thread Chandrakanth Patil
Signed-off-by: Shivasharan S Signed-off-by: Chandrakanth Patil --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c index 554ec72..a886de3e3 100644 --- a/drivers

[PATCH v3 10/18] megaraid_sas: RAID1 PCI bandwidth limit algorithm is applicable for only Ventura

2019-06-25 Thread Chandrakanth Patil
RAID1 PCI bandwidth limit algorithm is not applicable to Aero as it's PCIe Gen4 adapter. Signed-off-by: Sumit Saxena Signed-off-by: Chandrakanth Patil --- drivers/scsi/megaraid/megaraid_sas_base.c | 3 +++ drivers/scsi/megaraid/megaraid_sas_fusion.c | 24 +--- drivers/scs

Re: [PATCH V5 10/16] s390: zfcp_fc: use sg helper to operate scatterlist

2019-06-25 Thread Steffen Maier
Hi Ming, I don't mind doing this change for zfcp. However, I'm having doubts regarding the rationale in the commit description. If I understood your patch series correctly from its cover letter (would have been nice to copy the SCSI MQ detail part of its core statement in (one of) the patches

Re: [PATCH 2/3] pm80xx : Event log size through sysfs.

2019-06-25 Thread Jinpu Wang
On Mon, Jun 24, 2019 at 10:22 AM Deepak Ukey wrote: > > Added support to read event log size from MPI configuration table > and export through sysfs. > > Signed-off-by: Deepak Ukey > Signed-off-by: Viswas G Thanks, looks fine. Reviewed-by: Jack Wang

Re: [PATCH 1/3] pm80xx : Fixed kernel panic during error recovery for SATA drive.

2019-06-25 Thread Jinpu Wang
Hi Deepak, Thanks for the patch, comment inline. On Mon, Jun 24, 2019 at 10:22 AM Deepak Ukey wrote: > > Disabling the SATA drive interface cause kernel panic. When the drive > Interface is disabled, device should be deregistered after aborting > all pending IO's. Can you share the call trace for