[PATCH v3 3/3] qla2xxx: Fix NVME cmd and LS cmd timeout race condition

2019-06-21 Thread Himanshu Madhani
From: Quinn Tran This patch uses kref to protect access between fcp_abort path and nvme command and LS command completion path. Stack trace below shows the abort path is accessing stale memory (nvme_private->sp). When command kref reaches 0, nvme_private & srb resource will be disconnected from

[PATCH v3 2/3] qla2xxx: on session delete return nvme cmd

2019-06-21 Thread Himanshu Madhani
From: Quinn Tran - on session delete or chip reset, reject all NVME commands. - on NVME command submission error, free srb resource. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvme.c | 28 +++- 1 file changed, 19 insertions(+

[PATCH v3 1/3] qla2xxx: Fix kernel crash after disconnecting NVMe devices

2019-06-21 Thread Himanshu Madhani
From: Arun Easi BUG: unable to handle kernel NULL pointer dereference at (null) IP: [] qla_nvme_unregister_remote_port+0x6c/0xf0 [qla2xxx] PGD 80084cf41067 PUD 84d288067 PMD 0 Oops: [#1] SMP Call Trace: [] process_one_work+0x17f/0x440 [] worker_thread+0x126/0x3c0 [] ? manage

[PATCH v3 0/3] qla2xxx: Fix crashes with FC-NVMe devices

2019-06-21 Thread Himanshu Madhani
Hi Martin, This series fixes crash during abort handling with FC-NVMe devices. Also, we discovered race condition between nvme command and ls completion with FC-NVMe devices. Please apply this series to 5.3/scsi-queue at your earliest convenience. Thanks, Himanshu Changes from v2 -> v3 o Chang

Re: [PATCH 5/6] qla2xxx: Make the code for freeing SRBs more systematic

2019-06-21 Thread kbuild test robot
Hi Bart, I love your patch! Perhaps something to improve: [auto build test WARNING on scsi/for-next] [also build test WARNING on v5.2-rc5 next-20190620] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

Re: [PATCH] sd_zbc: Fix report zones buffer allocation

2019-06-21 Thread Damien Le Moal
Bart, On 2019/06/21 12:46, Bart Van Assche wrote: > On 6/20/19 5:58 PM, Damien Le Moal wrote: >> The REPORT_ZONES command is executed using scsi_execute_req(). Can we pass a >> vmalloc-ed buffer to that function ? It does look like it since >> scsi_execute_rq >> calls bio_rq_map_kern() which then