Re: [PATCH v2 3/3] scsi: ufs: Use re-factored Auto-Hibernate function

On 5/15/19 3:06 PM, Stanley Chu wrote: > Use re-factored ufshcd_is_auto_hibern8_supported() function > in ufshcd_init() instead to make code more cleaner. > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

RE: [PATCH v1 0/3] scsi: ufs: add error handlings of auto-hibern8

> > On 13/05/2019 16:36, Stanley Chu wrote: > > > Currently auto-hibern8 is activated if host supports > > auto-hibern8 capability. However no error handlings are existed thus > > this feature is kind of risky. > > This last sentence is not very idiomatic. > > I would suggest: > "However, error

Re: [PATCH v2 2/3] scsi: ufs: Add error-handling of Auto-Hibernate

Hi Stanley, On 5/15/19 3:06 PM, Stanley Chu wrote: > Currently auto-hibernate is activated if host supports > auto-hibern8 capability. However error-handling is not implemented, > which makes the feature somewhat risky. > > If either "Hibernate Enter" or "Hibernate Exit" fail during > auto-hibern

RE: [PATCH v2 1/3] scsi: ufs: Do not overwrite Auto-Hibernate timer

Hi Avri, On Mon, 2019-05-20 at 05:47 +, Avri Altman wrote: > > > > Hello Stanley, > > > > On 5/15/19 3:06 PM, Stanley Chu wrote: > > > Some vendor-specific initialization flow may set its own > > > auto-hibernate timer. In this case, do not overwrite timer value > > > as "default value" in u

RE: [PATCH v2 1/3] scsi: ufs: Do not overwrite Auto-Hibernate timer

> > Hello Stanley, > > On 5/15/19 3:06 PM, Stanley Chu wrote: > > Some vendor-specific initialization flow may set its own > > auto-hibernate timer. In this case, do not overwrite timer value > > as "default value" in ufshcd_init(). > > > > Signed-off-by: Stanley Chu > > --- > > drivers/scsi/

Re: [PATCH v2 1/3] scsi: ufs: Do not overwrite Auto-Hibernate timer

Hello Stanley, On 5/15/19 3:06 PM, Stanley Chu wrote: > Some vendor-specific initialization flow may set its own > auto-hibernate timer. In this case, do not overwrite timer value > as "default value" in ufshcd_init(). > > Signed-off-by: Stanley Chu > --- > drivers/scsi/ufs/ufshcd.c | 2 +- >

Re: [PATCH v2 0/3] scsi: ufs: Add error handling of Auto-Hibernate

Hi Avri, Alim, Pedro, Gentle ping for this patch. On Wed, 2019-05-15 at 17:36 +0800, Stanley Chu wrote: > Currently auto-hibernate is activated if host supports > auto-hibern8 capability. However error-handling is not implemented, > which makes the feature somewhat risky. > > If either "Hibernat