[PATCH v3 4/5] scsi: ufs: Change "-max-microamp" to non-mandatory property

2019-03-17 Thread Stanley Chu
In dt-bindings for ufs, "-max-microamp" property indicates current limit and is mandatory if "-fixed-regulator" is not defined on a specified regulator. However, in some platforms, regulators without "-fixed-regulator" deifned may not need to define their current limit. They may only want to defin

[PATCH v3 1/5] scsi: ufs: Remove unused min_uA field in struct ufs_vreg

2019-03-17 Thread Stanley Chu
There are two fields related to regulator current limit in struct ufs_vreg: "min_uA" and "max_uA". "max_uA" is probed by "-max-microamp" property from device tree and used for - regulator_set_load operations, and - icc_level configuration in device. However "min_uA" field is not used anywhere, t

[PATCH v3 2/5] scsi: ufs: Avoid configuring undefined voltage range on a regulator

2019-03-17 Thread Stanley Chu
For regulators used by UFS, vcc, vccq and vccq2 will have voltage range initialized by ufshcd_populate_vreg(), however other regulators may not have voltage range settings if undefined in dt-bindings. In this case, both "min_uV" and "max_uV" fields in ufs_vreg struct will be zero values and used a

[PATCH v3 3/5] scsi: ufs: Fix regulator load and icc-level configuration

2019-03-17 Thread Stanley Chu
Currently if a regulator has "-fixed-regulator" property in device tree, it will skip current limit configuration. This lead to a zero "max_uA" value in struct ufs_vreg. However, "regulator_set_load" operation shall be required on those regulators which specifically configured current limit, other

scsi: ufs: Fix regulator operations and remove "-fixed-regulator" device tree property

2019-03-17 Thread Stanley Chu
Hi, Sorry please help review V3 instead of previous versions. In this version I fix and add more details in commit messages, and add one patch to fix "undefined voltage range" issue as well. This patch series fixes UFS regulator operations, including voltage and current (re-)configuration flow

[PATCH v3 5/5] scsi: ufs: Remove "-fixed-regulator" device tree property

2019-03-17 Thread Stanley Chu
"-fixed-regulator" device tree property can be safely removed because below things are fixed or resolved, 1. "-max-microamp" becomes optional property: Undefined "-max-microamp" will not cause initialization fail if "-fixed-regulator" is not defined. 2. Current switching operation (by regul

[PATCH v3 0/5] scsi: ufs: Fix regulator operations and remove "-fixed-regulator" device tree property

2019-03-17 Thread Stanley Chu
Hi, Sorry please help review V3 instead of previous versions. In this version I fix and add more details in commit messages, and add one patch to fix "undefined voltage range" issue as well. This patch series fixes UFS regulator operations, including voltage and current (re-)configuration flow

Re: [PATCH] Avoid that a kernel warning appears during system resume

2019-03-17 Thread Bart Van Assche
On 3/17/19 7:20 AM, Martin Steigerwald wrote: Bart Van Assche - 16.03.19, 22:28: On 3/16/19 3:43 AM, Martin Steigerwald wrote: Bart Van Assche - 16.03.19, 00:27: Since scsi_device_quiesce() skips SCSI devices that have another state than RUNNING, OFFLINE or TRANSPORT_OFFLINE, scsi_device_resum

Re: [PATCH] Avoid that a kernel warning appears during system resume

2019-03-17 Thread Martin Steigerwald
Hi Bart. Bart Van Assche - 16.03.19, 22:28: > On 3/16/19 3:43 AM, Martin Steigerwald wrote: > > Bart Van Assche - 16.03.19, 00:27: > >> Since scsi_device_quiesce() skips SCSI devices that have another > >> state than RUNNING, OFFLINE or TRANSPORT_OFFLINE, > >> scsi_device_resume() should not compl

Re: [PATCH 04/26] qedf: Simplify s/g list mapping.

2019-03-17 Thread kbuild test robot
Hi Saurav, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on mkp-scsi/for-next] [also build test WARNING on v5.0 next-20190306] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci