On Tue, Feb 26, 2019 at 04:00:39PM +0100, Hannes Reinecke wrote:
> From: Hannes Reinecke
>
> no_scsi2_lun_in_cdb declares a new bitfield, but we should
> rather move it to the existing bitfield for better alignment.
Independent of if this helps the alignment keeping the various bit field
flags t
Hi Joe,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on scsi/for-next]
[also build test WARNING on next-20190306]
[cannot apply to v5.0]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://github.
From: Sagar Biradar
To: Martin K. Petersen
To: James Bottomley
cc: linux-scsi
cc: aacr...@microsemi.com
cc: Dave Carroll
cc: Scott Benesh
cc: sta...@vger.kernel.org
Fix performance issue where the queue depth for SmartIOC logical
volumes is set to 1, and allow the usual logical volume code
From: Joe Carnuccio
This patch does following
- Clean up NVRAM code.
- Optimizes reading of primary/secondary flash image validation.
- Remove 0xff mask and make correct width in FLT structure.
- Use endian macros to assign static fields in fwdump header.
- Correct fdwt checksum calculation.
From: Joe Carnuccio
This patch adds SysFS node for serdes_version
and also cleans up port_speed display.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 43 +--
drivers/scsi/qla2xxx/qla_def.h | 4 ++-
drivers/scsi/qla2xx
From: Joe Carnuccio
This patch made following changes to flash access routines
- updated return type for read_optrom
- use void instead of uint32_t * for buffer parameter in read
and write optrom routines
- Fix flash/nvram addressing.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madha
From: Michael Hernandez
This patch adds support for Secure flash update with ISP28xx
Signed-off-by: Michael Hernandez
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 31 +++-
drivers/scsi/qla2xxx/qla_fw.h | 8 +
drivers/scsi/qla2xxx/qla_gbl.h | 22 ++-
drivers/scs
From: Joe Carnuccio
This patch adds PCI device ID ISP28XX for Gen7 support.
Also signature determination for primary/secondary flash
image for ISP27XX/28XX is aded as part of Gen7 support.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 30
From: Joe Carnuccio
This patch adds multipe firmware dump template and segments
support for ISP27XX/28XX.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_bsg.c | 3 +-
drivers/scsi/qla2xxx/qla_def.h | 9 +-
drivers/scsi/qla2xxx/qla_gbl.h | 2
From: Joe Carnuccio
This patch cleans up and fixes firmware dump template
processing. These changes are added to support newer
features for ISP27XX/ISP28XX.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_tmpl.c | 51 ++
This version Includes support for ISP28XX
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 0690dac24081..0f8cca27c183 10064
From: Joe Carnuccio
Reduce stack space on each fwdt routine by eliminating local
variable reg.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_tmpl.c | 75 -
1 file changed, 29 insertions(+), 46 deletions(-)
di
From: Joe Carnuccio
This patch adds new SysFS node to display firmware attributes
and port number
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/drivers/scsi/q
From: Joe Carnuccio
Includes the following:
- correction to 27xx image status struct;
- factoring of 27xx image status validating routines to make common;
- image status generation compare that works across zero wrap;
- bsg interface to report current active images (as loaded by driver).
Signed-
Hi Martin,
This patch series adds support for our next generation ISP28XX (Gen7) adapter.
Patch 1-3 adds SysFS node and misc cleanup in fw dump routines.
Patch 4-5 adds PCI IDs and serdes support for ISP28XX (Gen7) adapter.
Patch 6-11 cleans up overall firmware dump handling to prepare for new
From: Joe Carnuccio
This patch fixes reported speed for min_link and max_supported
speed. Also rename SysFS nodes link_speed and max_supported to
be consistent with {min|max}_suuported_speed.
Signed-off-by: Joe Carnuccio
Signed-off-by: Mike Hernandez
Signed-off-by: Himanshu Madhani
---
drive
From: Joe Carnuccio
This patch fixes qla27xx_dump_{mpi|ram} api for ISP27XX
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dbg.c | 166 -
1 file changed, 81 insertions(+), 85 deletions(-)
diff --git a/drivers/
From: Joe Carnuccio
This patch removed FW default template as there will
never be case where the default template would be invoked.
Signed-off-by: Joe Carnuccio
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gbl.h | 2 -
drivers/scsi/qla2xxx/qla_init.c | 94 +
Lee,
> If there is an error queueing an iscsi command in
> iscsi_queuecommand(), for example if the transport fails to take the
> command in sessuin->tt->xmit_task(), then the error path can call
> iscsi_complete_task() without first aquiring the back_lock as
> required. This can lead to things
On Thu, Mar 07, 2019 at 05:37:50PM -0800, Lee Duncan wrote:
> On 3/6/19 10:23 AM, Chris Leech wrote:
> > On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote:
> >> From: Lee Duncan
> >>
> >> If there is an error queueing an iscsi command in
> >> iscsi_queuecommand(), for example if the trans
On 3/6/19 10:23 AM, Chris Leech wrote:
> On Mon, Feb 25, 2019 at 09:41:30AM -0800, Lee Duncan wrote:
>> From: Lee Duncan
>>
>> If there is an error queueing an iscsi command in
>> iscsi_queuecommand(), for example if the transport fails
>> to take the command in sessuin->tt->xmit_task(), then
>> t
When building with -Wsometimes-uninitialized, Clang warns:
drivers/scsi/gdth.c:3662:6: warning: variable 'paddr' is used
uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
Don't attempt to call dma_free_coherent when buf is NULL (meaning that
we never called dma_alloc_cohe
When building with -Wsometimes-uninitialized, Clang warns:
drivers/scsi/qla4xxx/ql4_os.c:5915:7: warning: variable 'buf_dma' is
used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
Don't call dma_free_coherent when buf is NULL, meaning that we never
called dma_alloc_coh
Cc: Michael Schmitz
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 01c23d27f290..7fed9bb72784 100644
--- a/drivers/scsi/NCR5380.c
+++ b/drivers/scsi/NCR5380.c
@@ -272
Adjust comments accordingly.
Cc: Gustavo A. R. Silva
Cc: Michael Schmitz
Signed-off-by: Finn Thain
---
drivers/scsi/NCR5380.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/NCR5380.c b/drivers/scsi/NCR5380.c
index 7fed9bb72784..fe0535affc14 100644
---
On 2/12/19 9:21 PM, Bob Liu wrote:
> From: Anoob Soman
>
> When a target sends Check Condition, whilst initiator is busy xmiting
> re-queued data, could lead to race between iscsi_complete_task() and
> iscsi_xmit_task() and eventually crashing with the following kernel
> backtrace.
>
> [3326150.
On Thu, Mar 7, 2019 at 10:41 AM Nathan Chancellor
wrote:
>
> When building with -Wsometimes-uninitialized, Clang warns:
>
> drivers/scsi/qla4xxx/ql4_os.c:5915:7: warning: variable 'buf_dma' is
> used uninitialized whenever 'if' condition is false
> [-Wsometimes-uninitialized]
>
> buf_dma is initia
When building with -Wsometimes-uninitialized, Clang warns:
drivers/scsi/qla4xxx/ql4_os.c:5915:7: warning: variable 'buf_dma' is
used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]
buf_dma is initialized by dma_alloc_coherent, which is only called in
the middle conditio
On 2/27/19 7:09 AM, YueHaibing wrote:
Friendly ping:
Who can review or take this, please?
Thanks
On 2019/1/30 18:11, YueHaibing wrote:
There is a potential NULL pointer dereference in case
fc_rport_create() fails and returns NULL.
Fixes: 2580064b5ec6 ("scsi: libfc: Replace ->rport_create ca
29 matches
Mail list logo
