RE: kernel panic in late shutdown stage (after syncing) in _scsih_set_satl_pending() in mpt3sas

2019-02-21 Thread Sreekanth Reddy
Thanks for conformation. Regards, Sreekanth -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of Michal Soltys Sent: Thursday, February 21, 2019 3:43 PM To: Sreekanth Reddy ; linux-scsi@vger.kernel.org Subject: Re: kernel panic i

Re: WARNING: CPU: 2 PID: 11303 at drivers/scsi/scsi_lib.c:2600 scsi_device_resume+0x4f/0x58

2019-02-21 Thread Bart Van Assche
On 2/20/19 1:17 PM, Przemek Socha wrote: Greetings, recently, after resume from hibernation I'm getting a strange warning in my dmesg output. The whole process (hibernate/resume) triggers WARN_ON_ONCE at line 2600 in scsi_lib.c file. It is a Lenovo g50-45 netbook with sata ssd (micron 1100) an

[PATCH] scsi: qedi: Fix global-out-of-bounds bug in qedi dbg function

2019-02-21 Thread Yue Haibing
From: YueHaibing KASAN report this: BUG: KASAN: global-out-of-bounds in qedi_dbg_err+0xda/0x330 [qedi] Read of size 31 at addr c12b0ae0 by task syz-executor.0/2429 CPU: 0 PID: 2429 Comm: syz-executor.0 Not tainted 5.0.0-rc7+ #45 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIO

[PATCH -next] scsi: megaraid_sas: Remove a bunch of set but not used variables

2019-02-21 Thread Yue Haibing
From: YueHaibing Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/megaraid/megaraid_sas_fusion.c: In function 'wait_and_poll': drivers/scsi/megaraid/megaraid_sas_fusion.c:936:25: warning: variable 'fusion' set but not used [-Wunused-but-set-variable] drivers/scsi/megaraid/megaraid_s

[PATCH] scsi: Remove negative constant left-shifts

2019-02-21 Thread Iustin Pop
Negative constant left-shift is undefined behaviour in the C standard, and as such newer versions of clang (at least) warn against it. GCC supports it for a long time, but it would be better to remove it and rely on defined behaviour. My understanding is "~(-1 << N)" in 2's complement is intended

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-21 Thread Ira Weiny
On Thu, Feb 21, 2019 at 08:48:41AM +0530, Souptick Joarder wrote: > Hi Ira, > > On Wed, Feb 20, 2019 at 11:01 AM wrote: > > > > From: Ira Weiny > > > > To facilitate additional options to get_user_pages_fast() change the > > singular write parameter to be gup_flags. > > > > This patch does not c

Re: [PATCH v2 1/2] scsi: replace GFP_ATOMIC with GFP_KERNEL for allocations in scsi_scan.c

2019-02-21 Thread Bart Van Assche
On Thu, 2019-02-21 at 10:18 +0100, Benjamin Block wrote: > Looking at the code of scsi_alloc_sdev(), and all the calling contexts, > there seems to be no reason to use GFP_ATMOIC here. All the different > call-contexts use a mutex at some point, and nothing in between that > requires no sleeping, a

[PATCH] iscsi: fall back to sendmsg for slab pages

2019-02-21 Thread Vasily Averin
In "XFS over network block device" scenario XFS can create IO requests with slab-based XFS metadata. During processing such requests tcp_sendpage() can merge skb fragments with neighbour slab objects. If receiving side is located on the same host tcp_recvmsg() can trigger BUG_ON in hardening check

[PATCH] scsi: cxgb4i: validate tcp sequence number only if chip version <= T5

2019-02-21 Thread Varun Prakash
T6 adapters generates DDP completion message on receiving all iSCSI pdus in a sequence, because of this driver can not keep track of tcp sequence number for T6 adapters. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) d

[PATCH] scsi: cxgb4i: get pf number from lldi->pf

2019-02-21 Thread Varun Prakash
Instead of using viid to get pf number, directly get pf number from lldi->pf. Signed-off-by: Varun Prakash --- drivers/scsi/cxgbi/cxgb4i/cxgb4i.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c b/drivers/scsi/cxgbi/cxgb4i/cxgb4i.c index d

[PATCH v1] mpt3sas: Use driver scsi lookup to track outstanding IOs

2019-02-21 Thread Sreekanth Reddy
During expander reset handling, the driver invokes kernel function scsi_host_find_tag() to obtain outstanding requests associated with the scsi host managed by the driver. Kernel’s block layer may return stale entry for one or more outstanding requests if blk-mq is enabled. This may lead to Kernel

Re: kernel panic in late shutdown stage (after syncing) in _scsih_set_satl_pending() in mpt3sas

2019-02-21 Thread Michal Soltys
On 2/19/19 1:11 PM, Sreekanth Reddy wrote: Thanks for conformation. Can you please try once with the below patch which I have posted today https://patchwork.kernel.org/patch/10819769/ This seems fine as well - no shutdown panics or other issues observed after applying it (since yesterday).

[PATCH v1 2/2] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-02-21 Thread stanley.chu
From: Stanley Chu This patch adds UFS support for Mediatek SoC chips. Signed-off-by: Stanley Chu --- drivers/scsi/ufs/Kconfig| 12 + drivers/scsi/ufs/Makefile | 1 + drivers/scsi/ufs/ufs-mediatek.c | 526 drivers/scsi/ufs/ufs-mediatek.h | 91 +

[PATCH v1 1/2] dt-bindings: scsi: ufs: Add document for ufs-mediatek

2019-02-21 Thread stanley.chu
From: Stanley Chu Add UFS and UFS PHY node document for Mediatek SoC chips. Signed-off-by: Stanley Chu --- .../devicetree/bindings/ufs/ufs-mediatek.txt | 62 +++ 1 file changed, 62 insertions(+) create mode 100644 Documentation/devicetree/bindings/ufs/ufs-mediatek.txt diff -

[PATCH v1 0/2] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-02-21 Thread stanley.chu
From: Stanley Chu This patch adds UFS support for Mediatek SoC chips. Stanley Chu (2): dt-bindings: scsi: ufs: Add document for ufs-mediatek scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips .../devicetree/bindings/ufs/ufs-mediatek.txt | 62 +++ drivers/scsi/ufs/Kconfig

[PATCH v1] scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips

2019-02-21 Thread stanley.chu
This patch adds UFS support for Mediatek SoC chips. Stanley Chu (2): dt-bindings: scsi: ufs: Add document for ufs-mediatek scsi: ufs-mediatek: Add UFS support for Mediatek SoC chips .../devicetree/bindings/ufs/ufs-mediatek.txt | 62 +++ drivers/scsi/ufs/Kconfig | 12 +

[PATCH v2 1/2] scsi: replace GFP_ATOMIC with GFP_KERNEL for allocations in scsi_scan.c

2019-02-21 Thread Benjamin Block
We had a test-report where, under memory pressure, adding LUNs to the systems would fail (the tests add LUNs strictly in sequence): [ 5525.853432] scsi 0:0:1:1088045124: Direct-Access IBM 2107900 .148 PQ: 0 ANSI: 5 [ 5525.853826] scsi 0:0:1:1088045124: alua: supports implicit TP

[PATCH v2 2/2] scsi: whitespace cleanup in scsi_scan.c

2019-02-21 Thread Benjamin Block
Noticed during editing that vim would remove some trailing spaces. Signed-off-by: Benjamin Block --- drivers/scsi/scsi_scan.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index 53380e07b40e..7e1a6c3dd42c 100644

Re: [RFC PATCH] scsi: fix oops in scsi_uninit_cmd()

2019-02-21 Thread Jason Yan
Hi, Christoph On 2019/2/20 23:18, Christoph Hellwig wrote: [fullquote removed, please follow proper mail etiquette] On Tue, Feb 19, 2019 at 08:56:28AM -0800, Bart Van Assche wrote: regression in the SCSI sd driver due to the switch from the legacy block layer to scsi-mq. The above patch introd

How to disable NCQ with mpt3sas ?

2019-02-21 Thread ca...@uit.com.cn
Hi, I've encountered frequent command timeout while doing heavy pressure of small IO with "LSI Logic / Symbios Logic SAS3008 PCI-Express Fusion-MPT SAS-3" card, using HGST SAS disks. HBA setup dmesg reports it has NCQ capability. By google search, I found many comments that NCQ may delay an I/O