[PATCH v4 3/3] scsi: ufs-bsg: Allow reading descriptors

2019-01-26 Thread Avri Altman
Add this functionality, placing the descriptor being read in the actual data buffer in the bio. That is, for both read and write descriptors query upiu, we are using the job's request_payload. This in turn, is mapped back in user land to the applicable sg_io_v4 xferp: dout_xferp for write descrip

[PATCH v4 1/3] scsi: ufs-bsg: Change the calling convention for write descriptor

2019-01-26 Thread Avri Altman
When we had a write descriptor query upiu, we appended the descriptor right after the bsg request. This was fine as the bsg driver allows to allocate whatever buffer we needed in its job request. Still, the proper way to deliver payload, however small (we only write config descriptors of 144 byte

[PATCH v4 2/3] scsi: ufs: Allow reading descriptor via raw upiu

2019-01-26 Thread Avri Altman
Allow to read descriptors via raw upiu. This in fact was forbidden just as a precaution, as ufs-bsg actually enforces which functionality is supported. Signed-off-by: Avri Altman Reviewed-by: Evan Green --- drivers/scsi/ufs/ufshcd.c | 20 ++-- 1 file changed, 14 insertions(+), 6

[PATCH v4 0/3] scsi: ufs-bsg: Add read descriptor

2019-01-26 Thread Avri Altman
UFS Protocol Information Units (UPIU) are UFS packets that travel between the host and the device on the UniPro bus. Our previous series added the capability to send UPIUs to the ufs driver. It does not cover all the possible UPIU types - we are mainly focused on device management, provisioning, te

Re: [GIT PULL] SCSI fixes for 5.0-rc3

2019-01-26 Thread pr-tracker-bot
The pull request you sent on Fri, 25 Jan 2019 14:15:06 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/7930851ef10c137c1035d1ef2addfdb3c53a1273 Thank you! -- Deet-doot-dot, I am a bot. ht

Re: [PATCH] pcmcia: Remove unnecessary parentheses

2019-01-26 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 04:55:40PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/scsi/pcmcia/nsp_cs.c:1137:27: warning: equality comparison with > extraneous parentheses [-Wparentheses-equality] > if ((tmpSC->SCp.Message == MSG_COMMAND_COMPLETE)) { >

Re: [PATCH] scsi: nsp32: Remove unnecessary self assignment in nsp32_set_sync_entry

2019-01-26 Thread Nathan Chancellor
On Mon, Dec 10, 2018 at 04:51:56PM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/scsi/nsp32.c:2444:14: warning: explicitly assigning value of > variable of type 'unsigned char' to itself [-Wself-assign] > offset = offset; > ~~ ^ > > Signed-off-by: Nathan

Re: fsync hangs after scsi rejected a request

2019-01-26 Thread Florian Stecker
On 1/26/19 2:25 AM, jianchao.wang wrote: On 1/26/19 9:18 AM, jianchao.wang wrote: On 1/26/19 6:10 AM, Florian Stecker wrote: On 1/25/19 10:05 AM, jianchao.wang wrote: On 1/25/19 4:56 PM, Florian Stecker wrote: On 1/25/19 4:49 AM, jianchao.wang wrote: It sounds like not so easy to

Re: [PATCH v2 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2019-01-26 Thread Manivannan Sadhasivam
On Sat, Jan 05, 2019 at 12:58:59PM +0530, Manivannan Sadhasivam wrote: > Add HI3670 SoC UFS driver support by extending the common ufs-hisi > driver. One major difference between HI3660 ad HI3670 SoCs interms of > UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is > used to d

Re: [PATCH v2] SCSI: fcoe: convert to use BUS_ATTR_WO

2019-01-26 Thread Greg Kroah-Hartman
On Sat, Jan 26, 2019 at 11:26:47AM +0100, Hannes Reinecke wrote: > On 1/22/19 3:27 PM, Greg Kroah-Hartman wrote: > > We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe > > driver can be trivially converted to use BUS_ATTR_WO(), so use that > > instead. > > > > Cc: Johannes Th

Re: [PATCH v2] SCSI: fcoe: convert to use BUS_ATTR_WO

2019-01-26 Thread Hannes Reinecke
On 1/26/19 11:39 AM, Greg Kroah-Hartman wrote: On Sat, Jan 26, 2019 at 11:26:47AM +0100, Hannes Reinecke wrote: On 1/22/19 3:27 PM, Greg Kroah-Hartman wrote: We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe driver can be trivially converted to use BUS_ATTR_WO(), so use t

Re: [PATCH v2] SCSI: fcoe: convert to use BUS_ATTR_WO

2019-01-26 Thread Hannes Reinecke
On 1/22/19 3:27 PM, Greg Kroah-Hartman wrote: We are trying to get rid of BUS_ATTR() and the usage of that in the fcoe driver can be trivially converted to use BUS_ATTR_WO(), so use that instead. Cc: Johannes Thumshirn Cc: "James E.J. Bottomley" Cc: "Martin K. Petersen" Signed-off-by: Greg Kr

Re: [PATCH v2 2/4] Revert "ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd"

2019-01-26 Thread Hannes Reinecke
On 1/18/19 11:28 PM, Martin Wilck wrote: This reverts commit 7eec77a1816a7042591a6cbdb4820e9e7ebffe0e. Instead of leaving disk->events completely empty, we now export the supported events again, and tell the block layer not to forward events to user space by not setting DISK_EVENT_FLAG_UEVENT. T

Re: [PATCH 4/4] block: check_events: don't bother with events if unsupported

2019-01-26 Thread Hannes Reinecke
On 1/18/19 10:32 PM, Martin Wilck wrote: Drivers now report to the block layer if they support media change events. If this is not the case, there's no need to allocate the event structure, and all event handling code can effectively be skipped. This simplifies code flow in particular for non-rem

Re: [PATCH 3/4] Revert "block: unexport DISK_EVENT_MEDIA_CHANGE for legacy/fringe drivers"

2019-01-26 Thread Hannes Reinecke
On 1/18/19 10:32 PM, Martin Wilck wrote: This reverts commit 9fd097b14918875bd6f125ed699d7a5893ee. Instead of leaving disk->events completely empty, we now export the supported events again, and tell the block layer not to forward events to user space by not setting DISK_EVENT_FLAG_UEVENT. T

Re: [PATCH 2/4] Revert "ide: unexport DISK_EVENT_MEDIA_CHANGE for ide-gd and ide-cd"

2019-01-26 Thread Hannes Reinecke
On 1/18/19 10:32 PM, Martin Wilck wrote: This reverts commit 7eec77a1816a7042591a6cbdb4820e9e7ebffe0e. Instead of leaving disk->events completely empty, we now export the supported events again, and tell the block layer not to forward events to user space by not setting DISK_EVENT_FLAG_UEVENT. T

Re: [PATCH 1/4] block: disk_events: introduce event flags

2019-01-26 Thread Hannes Reinecke
On 1/18/19 10:32 PM, Martin Wilck wrote: Currently, an empty disk->events field tells the block layer not to forward media change events to user space. This was done in commit 7c88a168da80 ("block: don't propagate unlisted DISK_EVENTs to userland") in order to avoid events from "fringe" drivers t

Re: [PATCH v3 25/26] lpfc: Update 12.2.0.0 file copyrights to 2019

2019-01-26 Thread Hannes Reinecke
On 1/26/19 2:18 AM, James Smart wrote: For files modifed as part of 12.2.0.0 patches, update copyright to 2019 Signed-off-by: Dick Kennedy Signed-off-by: James Smart --- drivers/scsi/lpfc/lpfc.h | 2 +- drivers/scsi/lpfc/lpfc_attr.c | 2 +- drivers/scsi/lpfc/lpfc_crtn.h

Re: [PATCH v3 21/26] lpfc: Rework locking on SCSI io completion

2019-01-26 Thread Hannes Reinecke
On 1/26/19 2:18 AM, James Smart wrote: A scsi host lock is taken on every io completion to check whether the abort handler is waiting on the io completion. This is an expensive lock to take on all completion when rarely in an abort condition. Replace scsi host lock with command-specific lock. Sy

Re: [PATCH v3 17/26] lpfc: Rework EQ/CQ processing to address interrupt coalescing

2019-01-26 Thread Hannes Reinecke
On 1/26/19 2:18 AM, James Smart wrote: When driving high iop counts, auto_imax coalescing kick in and drives the performance to extremely small iops levels. There are two issues: 1) auto_imax is enabled by default. The auto algorithm, when iops gets high divides the iops by the hdwq count an

Re: [PATCH v3 13/26] lpfc: Allow override of hardware queue selection policies

2019-01-26 Thread Hannes Reinecke
On 1/26/19 2:18 AM, James Smart wrote: Default behavior is to use the information from the upper io stacks to select the hardware queue to use for io submission. which typically has good cpu affinity. However, the driver, when used on some variants of the upstream kernel, has found queuing infor

Re: [PATCH v3 12/26] lpfc: Adapt partitioned XRI lists to efficient sharing

2019-01-26 Thread Hannes Reinecke
On 1/26/19 2:18 AM, James Smart wrote: The XRI get/put lists were partitioned per hardware queue. However, the adapter rarely had sufficient resources to give a large number of resources per queue. As such, it became common for a cpu to encounter a lack of XRI resource and request the upper io st

Re: [PATCH v4] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-26 Thread Nick Desaulniers
On Fri, Jan 25, 2019 at 11:53 PM Nathan Chancellor wrote: > > Clang warns several times in the scsi subsystem (trimmed for brevity): > > drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to > switch condition type (2147762695 to 18446744071562347015) [-Wswitch] > case CCI

Re: [PATCH v3 11/26] lpfc: Synchronize hardware queues with SCSI MQ interface

2019-01-26 Thread Hannes Reinecke
On 1/26/19 2:18 AM, James Smart wrote: Now that the lower half has much better per-cpu parallelization using the hardware queues, the SCSI MQ support needs to be tied into it. The involves the following mods: - Use the hardware queue info from the midlayer to help select the hardware queue to