Re: [PATCH 1/8] sd: Rely on the driver core for asynchronous probing

2019-01-13 Thread Hannes Reinecke
On 1/14/19 5:56 AM, Bart Van Assche wrote: On 1/12/19 12:29 AM, Hannes Reinecke wrote: On 1/11/19 5:10 PM, Bart Van Assche wrote: On Fri, 2019-01-11 at 08:31 +0100, Hannes Reinecke wrote: Could you please check if this depends on any changes to the async probing mechanism? Patches one and tw

[PATCH -next] [SCSI] qla4xxx: Remove set but not used variables 'data_size, poll, mask'

2019-01-13 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_84xx_minidump_process_rddfe': drivers/scsi/qla4xxx/ql4_nx.c:2648:23: warning: variable 'data_size' set but not used [-Wunused-but-set-variable] drivers/scsi/qla4xxx/ql4_nx.c: In function 'qla4_84xx_mi

Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-13 Thread Nathan Chancellor
On Sun, Jan 13, 2019 at 08:54:35PM -0800, Bart Van Assche wrote: > On 1/13/19 8:42 PM, Nathan Chancellor wrote: > > @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, > > void __user *arg) > > ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl)); > > if (IS_ERR(

Re: [PATCH 1/8] sd: Rely on the driver core for asynchronous probing

2019-01-13 Thread Bart Van Assche
On 1/12/19 12:29 AM, Hannes Reinecke wrote: On 1/11/19 5:10 PM, Bart Van Assche wrote: On Fri, 2019-01-11 at 08:31 +0100, Hannes Reinecke wrote: Could you please check if this depends on any changes to the async probing mechanism? Patches one and two depend on driver core changes. I was assum

Re: [PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-13 Thread Bart Van Assche
On 1/13/19 8:42 PM, Nathan Chancellor wrote: @@ -1292,7 +1292,7 @@ int esas2r_ioctl_handler(void *hostdata, int cmd, void __user *arg) ioctl = memdup_user(arg, sizeof(struct atto_express_ioctl)); if (IS_ERR(ioctl)) { esas2r_log(ESAS2R_LOG_WARN, -

[PATCH v3] scsi/ata: Use unsigned int for cmd's type in ioctls in scsi_host_template

2019-01-13 Thread Nathan Chancellor
Clang warns several times in the scsi subsystem (trimmed for brevity): drivers/scsi/hpsa.c:6209:7: warning: overflow converting case value to switch condition type (2147762695 to 18446744071562347015) [-Wswitch] case CCISS_GETBUSTYPES: ^ drivers/scsi/hpsa.c:6208:7: warning: ov

Re: ufshcd_queuecommand() triggering after ufshcd_suspend()?

2019-01-13 Thread Zang Leigang
Hey all, I think there are two different issues: 1. clk_gating's state(including state's trace event) and is_suspended is not wrapped by ufshcd_is_clkgating_allowed which Hisilicon's kirin platoform soc does not need but is set and checked in a regular path. 2. I think SCSI is nec