Re: [PATCH] scsi: Fix a harmless double shift bug

2018-12-07 Thread Jens Axboe
On 12/7/18 8:20 PM, Martin K. Petersen wrote: > > Jens, > > This went in through your tree. Can you please pick this fix up? Yep, applied, thanks Dan. -- Jens Axboe

Re: [PATCH 00/15] lpfc updates for 12.0.0.9

2018-12-07 Thread Martin K. Petersen
James, > Update lpfc to revision 12.0.0.9 > > This patch contains lpfc bug fixes Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: bnx2fc: Fix NULL dereference in error handling

2018-12-07 Thread Martin K. Petersen
Dan, > If "interface" is NULL then we can't release it and trying to will > only lead to an Oops. Applied to 4.20/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] Revert "scsi: qla2xxx: Fix NVMe Target discovery"

2018-12-07 Thread Martin K. Petersen
Himanshu, > This reverts commit db186382af21e926e90df19499475f2552192b77. > > This commit introduced regression with FCP discovery so revert it back > to fix discovery for FCP luns Applied to 4.20/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: Fix a harmless double shift bug

2018-12-07 Thread Martin K. Petersen
Jens, This went in through your tree. Can you please pick this fix up? > On Thu, Nov 29, 2018 at 01:37:10PM +0300, Dan Carpenter wrote: >> Smatch generates a warning: >> >> drivers/scsi/scsi_lib.c:1656 scsi_mq_done() warn: test_bit() takes a bit >> number >> >> The problem is that SCMD_S

Re: [PATCH 00/20] smartpqi updates

2018-12-07 Thread Feng Li
Hi Brace, In this patch series, do you have fixed and verified the timeout issue? https://patchwork.kernel.org/patch/10637797/ Thanks, - Alex Don Brace 于2018年12月8日周六 上午6:28写道: > > These patches are based on Linus's tree > > The changes are: > > - smartpqi-add-support-for-PQI-Config-Table-handsh

Re: [PATCH 0/2] zfcp: small bugfix on top of previous v4.21 patches

2018-12-07 Thread Martin K. Petersen
Steffen, > One new recovery fix, which is not urgent, for an old bug. It's > sufficient to apply it on top of the previously sent 23 zfcp updates > for the v4.21 merge window Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: Use of_node_name_eq for node name comparisons

2018-12-07 Thread Martin K. Petersen
Rob, > Convert string compares of DT node names to use of_node_name_eq helper > instead. This removes direct access to the node name pointer. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v7 0/5] target: user configurable T10 Vendor ID

2018-12-07 Thread Martin K. Petersen
David, > This patch-set allows for the modification of the T10 Vendor > Identification string returned in the SCSI INQUIRY response, via the > target/core/$backstore/$name/wwn/vendor_id ConfigFS path. Applied to 4.21/scsi-queue, thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qla2xxx: NULL check before some freeing functions is not needed.

2018-12-07 Thread Martin K. Petersen
Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: qedf: NULL check before some freeing functions is not needed.

2018-12-07 Thread Martin K. Petersen
Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: megaraid_sas: NULL check before some freeing functions is not needed.

2018-12-07 Thread Martin K. Petersen
Thomas, > NULL check before some freeing functions is not needed. Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] qla2xxx: Split the __qla2x00_abort_all_cmds() function

2018-12-07 Thread Martin K. Petersen
Bart, > Nesting in __qla2x00_abort_all_cmds() is way too deep. Reduce the > nesting level by introducing a helper function. This patch does not > change any functionality. Applied to 4.21/scsi-queue. Thank you. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: csiostor: remove flush_scheduled_work()

2018-12-07 Thread Martin K. Petersen
Varun, > flush_scheduled_work() is not required as csio_hw_exit_workers() calls > cancel_work_sync() for hw->evtq_work. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-12-07 Thread Martin K. Petersen
Steffen, > Introduce separate zfcp module parameters to individually select > support for: DIF which should work (zfcp.dif, which used to be > DIF+DIX, disabled) or DIX+DIF which can cause trouble (zfcp.dix, new, > disabled). Applied to 4.21/scsi-queue. -- Martin K. Petersen Oracle Linux

Re: [PATCH 01/41] scsi: BusLogic: mark expected switch fall-through

2018-12-07 Thread Martin K. Petersen
Gustavo A., > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: ufs: Remove redundant sense size definition

2018-12-07 Thread Martin K. Petersen
Avri, > By spec, the ufs sense data is 18 bytes long. Applied to 4.21/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] drivers/scsi/fnic/fnic_trace.c: Use vzalloc

2018-12-07 Thread Martin K. Petersen
Sabyasachi, > Replaced vmalloc + memset with vzalloc Applied to 4.21/scsi-queue, thanks. -- Martin K. Petersen Oracle Linux Engineering

[PATCH 20/20] smartpqi: bump driver version

2018-12-07 Thread Don Brace
Reviewed-by: Gerry Morong Reviewed-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/drivers/scsi/smartpqi/smartpqi_init.c index 8d94028d0a9d..

[PATCH 19/20] smartpqi: add smp_utils support

2018-12-07 Thread Don Brace
Reviewed-by: Scott Benesh Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Dave Carroll Reviewed-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h | 89 + drivers/scsi/smartpqi/smartpqi_init.c | 131

[PATCH 17/20] smartpqi: correct lun reset issues

2018-12-07 Thread Don Brace
From: Kevin Barnett Problem: The Linux kernel takes a logical volume offline after a LUN reset. This is generally accompanied by this message in the dmesg output: Device offlined - not ready after error recovery Root Cause: The root cause is a "quirk" in the timeout handling in the Linux SCSI l

[PATCH 18/20] smartpqi: add module param to disable irq affinity

2018-12-07 Thread Don Brace
The PCI_IRQ_AFFINITY flag prevents customers from changing the smp_affinity and smp_affinity_list entries. Add a module parameter to allow this flag to be turned off. Reviewed-by: Scott Teel Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Kevin

[PATCH 15/20] smartpqi: do not offline disks for transient did no connect conditions

2018-12-07 Thread Don Brace
From: Dave Carroll Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 16/20] smartpqi: correct volume status

2018-12-07 Thread Don Brace
From: Dave Carroll - fix race condition when a unit is deleted after an RLL, and before we have gotten the LV_STATUS page of the unit. - In this case we will get a standard inquiry, rather than the desired page. This will result in a unit presented which no longer exists. - If we a

[PATCH 09/20] smartpqi: fix disk name mount point

2018-12-07 Thread Don Brace
From: Murthy Bhat - fix a formatting issue. Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Dave Carroll Reviewed-by: Kevin Barnett Signed-off-by: Murthy Bhat Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |7 ++- 1 file changed, 6 inserti

[PATCH 13/20] smartpqi: check for null device pointers

2018-12-07 Thread Don Brace
From: Mahesh Rajashekhara - wait on all outstanding I/O to complete before the device is removed. - check for null device pointers in IO entry/completion functions. Reviewed-by: Scott Teel Reviewed-by: Murthy Bhat Reviewed-by: Dave Carroll Reviewed-by: Kevin Barnett Signed-off-by: Mahesh Raj

[PATCH 11/20] smartpqi: enhance numa node detection

2018-12-07 Thread Don Brace
From: Sagar Biradar - set pci_dev->dev to 0 only if the node is NO_NUMA_NODE. If not, do not reset the value but retain it. Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Sagar Biradar

[PATCH 14/20] smartpqi: allow for larger raid maps

2018-12-07 Thread Don Brace
From: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Ajish Koshy Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 59 -

[PATCH 12/20] smartpqi: add support for huawei controllers

2018-12-07 Thread Don Brace
From: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Ajish Koshy Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c | 24 1 file ch

[PATCH 10/20] smartpqi: wake up drives after os resumes from suspend

2018-12-07 Thread Don Brace
From: Dave Carroll - set allow_restart option during scsi_device init. This allows the kernel to send a START/STOP Unit command to the drive if it encounters a 4/2 check condition in sense data. Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Kevin Barnett Signed-

[PATCH 02/20] Add retries for device reset

2018-12-07 Thread Don Brace
From: Mahesh Rajashekhara Reviewed-by: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Justin Lindley Reviewed-by: Scott Benesh Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Mahesh Rajashekhara Signed-off-by: Don Brace --- drivers/scsi/sma

[PATCH 07/20] smartpqi: add sysfs attributes

2018-12-07 Thread Don Brace
From: Dave Carroll - add sysfs device attributes, unique_id, lunid and path_info. Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi.h |3 drivers/scsi/smartpqi/smartpqi_init.c | 232 +++

[PATCH 08/20] smartpqi: add h3c ssid

2018-12-07 Thread Don Brace
From: Murthy Bhat Reviewed-by: Scott Benesh Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Murthy Bhat Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |8 1 file changed, 8 insert

[PATCH 00/20] smartpqi updates

2018-12-07 Thread Don Brace
These patches are based on Linus's tree The changes are: - smartpqi-add-support-for-PQI-Config-Table-handshake . add support for get/set controller features. - smartpqi-add-retries-for-device-resets . re-attempt device reset. - smartpqi-add-no_write_same-for-logical-volumes . turn off WRITE

[PATCH 04/20] smartpqi: correct host serial num for ssa

2018-12-07 Thread Don Brace
From: Mahesh Rajashekhara Reviewed-by: Scott Benesh Reviewed-by: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Dave Carroll Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Mahesh Rajashekhara Signed-off-by: Don Brace --- drivers/scs

[PATCH 01/20] smartpqi: add support for PQI Config Table handshake

2018-12-07 Thread Don Brace
From: Kevin Barnett Add support for new IUs and parsing of the Firmware Features section of the PQI Config Table to implement the "handshake" between the driver and firmware to communicate firmware features supported and enabled by the driver. Reviewed-by: Ajish Koshy Reviewed-by: Mahesh Rajash

[PATCH 05/20] smartpqi: turn off lun data caching for ptraid

2018-12-07 Thread Don Brace
From: Dave Carroll - allow update the luns for PTRAID devices. Reviewed-by: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Justin Lindley Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll Signed-off-by: Don Brace --- drive

[PATCH 03/20] smartpqi: add no_write_same for logical volumes

2018-12-07 Thread Don Brace
From: Dave Carroll During slave_alloc, for logical volumes include no_write_same into the scsi_device structure. This will insure that WRITE_SAME will not be used for LD's. Reviewed-by: Ajish Koshy Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Justin Lindley Reviewed

[PATCH 06/20] smartpqi: refactor sending controller raid requests

2018-12-07 Thread Don Brace
From: Dave Carroll cleanup the common code which creates a raid path request for the controller LUNID and sends it synchronously, into a common routine; Reviewed-by: Murthy Bhat Reviewed-by: Mahesh Rajashekhara Reviewed-by: Scott Teel Reviewed-by: Kevin Barnett Signed-off-by: Dave Carroll S

Re: [PATCH] scsi: qla2xxx: disabling pci error handler early

2018-12-07 Thread Brian King
On 12/07/2018 01:56 PM, Anatoliy Glagolev wrote: > qla2x00_disable_board_on_pci_error and pcie error handlers may run > in parallel. Specifically, I observed qla2xxx_pci_slot_reset running > at around the same moment as qla2x00_disable_board_on_pci_error. > If scsi_qla_host_t or qla_hw_data structs

[PATCH] scsi: qla2xxx: disabling pci error handler early

2018-12-07 Thread Anatoliy Glagolev
qla2x00_disable_board_on_pci_error and pcie error handlers may run in parallel. Specifically, I observed qla2xxx_pci_slot_reset running at around the same moment as qla2x00_disable_board_on_pci_error. If scsi_qla_host_t or qla_hw_data structs are removed before an error handler completes, the handl

Re: BUG in copy_page_to_iter() when iscsi sets ENABLE_CLUSTERING

2018-12-07 Thread Christoph Hellwig
Note that independent of what we do in the Linux iSCSI initiator this is a network DOS, so we'll have to fix it. On Wed, Dec 05, 2018 at 12:09:40PM -0800, Lee Duncan wrote: > I recently found what I believe is a bug, and I'd appreciate feedback > on if that is correct, and if so how to proceed. >

[PATCH 3/3] scsi: ufs: Add HI3670 SoC UFS driver support

2018-12-07 Thread Manivannan Sadhasivam
Add HI3670 SoC UFS driver support by extending the common ufs-hisi driver. One major difference between HI3660 ad HI3670 SoCs interms of UFS is the PHY. HI3670 has a 10nm variant PHY and hence this parameter is used to distinguish the configuration. Signed-off-by: Manivannan Sadhasivam --- drive

[PATCH 2/3] arm64: dts: hisilicon: hi3670: Add UFS controller support

2018-12-07 Thread Manivannan Sadhasivam
Add UFS controller support for HiSilicon HI3670 SoC. Signed-off-by: Manivannan Sadhasivam --- arch/arm64/boot/dts/hisilicon/hi3670.dtsi | 18 ++ 1 file changed, 18 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hi3670.dtsi b/arch/arm64/boot/dts/hisilicon/hi3670.dtsi i

[PATCH 1/3] dt-bindings: ufs: Add HI3670 UFS controller binding

2018-12-07 Thread Manivannan Sadhasivam
Add devicetree binding for HI3670 UFS controller. HI3760 SoC is very similar to HI3660 SoC with almost same IPs. Only major difference interms of UFS is the PHY. HI3670 has 10nm PHY. Signed-off-by: Manivannan Sadhasivam --- Documentation/devicetree/bindings/ufs/ufs-hisi.txt | 4 +++- 1 file chan

[PATCH 0/3] Add UFS controller support for HI3670 SoC

2018-12-07 Thread Manivannan Sadhasivam
Hello, This patchset adds UFS controller support for HiSilicon HI3670 SoC. HI3760 SoC is very similar to HI3660 SoC with almost same IPs, hence the same driver is extended to provide UFS support. Only major difference is the PHY. HI3670 has 10nm PHY, hence that parameter is used to distinguish the

Incorrect warning in fc_rport_destroy

2018-12-07 Thread Ross Lagerwall
Hi Hannes, Commit bbc0f8bd88ab ("scsi: libfc: Add WARN_ON() when deleting rports") added a warning whose intent was to check whether the rport was still linked into the peer list. It doesn't work as intended and I consistently see messages like the following: [ 66.157471] host1: rport fffc

Urgently need money? We can help you!

2018-12-07 Thread Mr. Muller Dieter
Urgently need money? We can help you! Are you by the current situation in trouble or threatens you in trouble? In this way, we give you the ability to take a new development. As a rich person I feel obliged to assist people who are struggling to give them a chance. Everyone deserved a second chanc

Re: [PATCH RFC 00/15] Zero ****s, hugload of hugs <3

2018-12-07 Thread Eric Curtin
Hi Guys, I initially thought these patches were a joke. But I guess they are not. I suppose 2018 is the year everything became offensive. Could we avoid the s/fuck/hug/g though? I have nothing against re-wording this stuff to remove the curse word, but it should at least make sense. What's going

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-07 Thread Johannes Thumshirn
On 07/12/2018 11:07, John Garry wrote: > On 06/12/2018 16:20, Johannes Thumshirn wrote: >> On 06/12/2018 16:37, John Garry wrote: >>> which is important. Let me know if you disagree and I can change it. >> >> Sure, it's your driver. It was just because the patch is even titled >> "Relocate some cod

RE: +AFs-PATCH+AF0- blk-mq: Set request mapping to NULL in blk+AF8-mq+AF8-put+AF8-driver+AF8-tag

2018-12-07 Thread Kashyap Desai
> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Friday, December 7, 2018 3:50 PM > To: Kashyap Desai > Cc: Bart Van Assche; linux-block; Jens Axboe; linux-scsi; Suganath Prabu > Subramani; Sreekanth Reddy; Sathya Prakash Veerichetty > Subject: Re: +AFs-PATCH+AF0-

Re: +AFs-PATCH+AF0- blk-mq: Set request mapping to NULL in blk+AF8-mq+AF8-put+AF8-driver+AF8-tag

2018-12-07 Thread Ming Lei
On Thu, Dec 06, 2018 at 11:15:13AM +0530, Kashyap Desai wrote: > > > > If the 'tag' passed to scsi_host_find_tag() is valid, I think there > > shouldn't have such issue. > > > > If you want to find outstanding IOs, maybe you can try > > blk_mq_queue_tag_busy_iter() > > or blk_mq_tagset_busy_iter(),

Re: [PATCH v4 2/5] scsi: hisi_sas: Relocate some code to reduce complexity

2018-12-07 Thread John Garry
On 06/12/2018 16:20, Johannes Thumshirn wrote: On 06/12/2018 16:37, John Garry wrote: which is important. Let me know if you disagree and I can change it. Sure, it's your driver. It was just because the patch is even titled "Relocate some code to reduce complexity", so I thought of reducing th