On Mon, Dec 3, 2018 at 2:25 AM Thomas Meyer wrote:
>
> NULL check before some freeing functions is not needed.
>
> Signed-off-by: Thomas Meyer
Acked-by: Sumit Saxena
> ---
>
> diff -u -p a/drivers/scsi/megaraid/megaraid_mbox.c
> b/drivers/scsi/megaraid/megaraid_mbox.c
> --- a/drivers/scsi/meg
> -Original Message-
> From: Thomas Meyer
> Sent: Monday, December 3, 2018 2:22 AM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] scsi: qedf
> -Original Message-
> From: Thomas Meyer
> Sent: Monday, December 3, 2018 2:22 AM
> To: Dept-Eng QLogic Storage Upstream upstr...@cavium.com>; j...@linux.vnet.ibm.com;
> martin.peter...@oracle.com; linux-scsi@vger.kernel.org; linux-
> ker...@vger.kernel.org
> Subject: [PATCH] scsi: qla4
Hi Hannes,
Thanks for the feedback...
On Sat, 1 Dec 2018 15:59:25 +0100, Hannes Reinecke wrote:
> On 12/1/18 12:34 AM, David Disseldorp wrote:
...
> > @@ -810,6 +810,23 @@ struct se_device *target_alloc_device(struct se_hba
> > *hba, const char *name)
> > mutex_init(&xcopy_lun->lun_tg_pt_md
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
> On 12/2/18 10:21 PM, Finn Thain wrote:
> > On Sun, 2 Dec 2018, Hannes Reinecke wrote:
> >
> > > Well, that lone 'kmap' is due to a quirk/errata in the datasheet;
> > > essentially
> > > we have to PIO a lone byte out of the FIFO to clear it up.
> > > A
On 12/2/18 10:21 PM, Finn Thain wrote:
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially
we have to PIO a lone byte out of the FIFO to clear it up.
And this byte is technically still part of the SCSI data, so we need to
stuf
On Sun, 2 Dec 2018, Hannes Reinecke wrote:
> Well, that lone 'kmap' is due to a quirk/errata in the datasheet; essentially
> we have to PIO a lone byte out of the FIFO to clear it up.
> And this byte is technically still part of the SCSI data, so we need to
> stuff it onto the end of the actual da
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/aic7xxx/aic79xx_core.c
b/drivers/scsi/aic7xxx/aic79xx_core.c
--- a/drivers/scsi/aic7xxx/aic79xx_core.c
+++ b/drivers/scsi/aic7xxx/aic79xx_core.c
@@ -3673,8 +3673,7 @@ ahd_free_tstat
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/megaraid/megaraid_mbox.c
b/drivers/scsi/megaraid/megaraid_mbox.c
--- a/drivers/scsi/megaraid/megaraid_mbox.c
+++ b/drivers/scsi/megaraid/megaraid_mbox.c
@@ -1243,8 +1243,7 @@ megara
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c
--- a/drivers/scsi/qedf/qedf_main.c
+++ b/drivers/scsi/qedf/qedf_main.c
@@ -2935,8 +2935,7 @@ static void qedf_free_fcoe_pf_param(str
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/mpt3sas/mpt3sas_base.c
b/drivers/scsi/mpt3sas/mpt3sas_base.c
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -4213,8 +4213,7 @@ _base_release_
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
--- a/drivers/scsi/qla4xxx/ql4_os.c
+++ b/drivers/scsi/qla4xxx/ql4_os.c
@@ -4160,20 +4160,17 @@ static void qla4xxx_mem_free(struct s
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -9537,8 +9537,7 @@ static void ipr_free_cmd_blks(struct ipr
}
}
- if (
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/lpfc/lpfc_bsg.c b/drivers/scsi/lpfc/lpfc_bsg.c
--- a/drivers/scsi/lpfc/lpfc_bsg.c
+++ b/drivers/scsi/lpfc/lpfc_bsg.c
@@ -1276,8 +1276,7 @@ lpfc_bsg_hba_set_event(struct bsg_job *j
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/aic94xx/aic94xx_init.c
b/drivers/scsi/aic94xx/aic94xx_init.c
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -584,8 +584,7 @@ static void asd_
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
--- a/drivers/scsi/qla2xxx/qla_os.c
+++ b/drivers/scsi/qla2xxx/qla_os.c
@@ -4191,12 +4191,10 @@ fail_free_nvram:
kfree(ha->nv
NULL check before some freeing functions is not needed.
Signed-off-by: Thomas Meyer
---
diff -u -p a/drivers/scsi/csiostor/csio_init.c
b/drivers/scsi/csiostor/csio_init.c
--- a/drivers/scsi/csiostor/csio_init.c
+++ b/drivers/scsi/csiostor/csio_init.c
@@ -157,8 +157,7 @@ csio_dfs_create(struct c
On 11/26/18 10:46 AM, Finn Thain wrote:
On Mon, 26 Nov 2018, Christoph Hellwig wrote:
On Thu, Nov 22, 2018 at 09:02:13AM +1100, Finn Thain wrote:
you in the To list maintain or wrote SCSI drivers that set the
DISABLE_CLUSTERING flag, which basically disable merges of any
bio segments. We alre
18 matches
Mail list logo
