Re: [PATCH] target: drop unnecessary get_fabric_name() accessor from fabric_ops

2018-11-22 Thread Christoph Hellwig
On Thu, Nov 22, 2018 at 03:16:23PM +0100, David Disseldorp wrote: > All fabrics return a const string. In all cases *except* iSCSI the > get_fabric_name() string matches fabric_ops.name. > > Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing, > with the former being used for PR/A

[PATCH v4] scsi: tcmu: avoid cmd/qfull timers updated whenever a new cmd comes

2018-11-22 Thread xiubli
From: Xiubo Li Currently there has one cmd timeout timer and one qfull timer for each udev, and whenever there has any new coming cmd it will update the cmd timer or qfull timer. And for some corner case the timers are always working only for the ringbuffer's and full queue's newest cmd. That's t

Re: [PATCH AUTOSEL 4.19 09/36] scsi: NCR5380: Return false instead of NULL

2018-11-22 Thread Finn Thain
This patch is not relevant to any -stable branch. Please don't backport. -- On Thu, 22 Nov 2018, Sasha Levin wrote: > From: Finn Thain > > [ Upstream commit 96edebd6bb995f2acb7694bed6e01bf6f5a7b634 ] > > I overlooked this statement when I recently converted the function result > type from

[PATCH AUTOSEL 4.19 08/36] scsi: hisi_sas: Remove set but not used variable 'dq_list'

2018-11-22 Thread Sasha Levin
From: YueHaibing [ Upstream commit e34ff8edcae89922d187425ab0b82e6a039aa371 ] Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/hisi_sas/hisi_sas_v1_hw.c: In function 'start_delivery_v1_hw': drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:907:20: warning: variable 'dq_list' set but not used [

[PATCH AUTOSEL 4.19 09/36] scsi: NCR5380: Return false instead of NULL

2018-11-22 Thread Sasha Levin
From: Finn Thain [ Upstream commit 96edebd6bb995f2acb7694bed6e01bf6f5a7b634 ] I overlooked this statement when I recently converted the function result type from struct scsi_cmnd * to bool. No change to object code. Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sa

[PATCH AUTOSEL 4.19 07/36] scsi: lpfc: fix remoteport access

2018-11-22 Thread Sasha Levin
From: Arnd Bergmann [ Upstream commit f8d294324598ec85bea2779512e48c94cbe4d7c6 ] The addition of a spinlock in lpfc_debugfs_nodelist_data() introduced a bug that lets us not skip NULL pointers correctly, as noticed by gcc-8: drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-22 Thread Guenter Roeck
[-cc] Hi Linus, On 11/22/18 5:49 AM, Linus Walleij wrote: [ ... ] (It's also worth noting that HDD temperature sensors are notoriously unreliable). I am sorry if you think that D-Link does bad engineering, what I am trying to achieve is upstream support for this device, without any out-of-tre

[PATCH AUTOSEL 4.14 02/21] scsi: NCR5380: Return false instead of NULL

2018-11-22 Thread Sasha Levin
From: Finn Thain [ Upstream commit 96edebd6bb995f2acb7694bed6e01bf6f5a7b634 ] I overlooked this statement when I recently converted the function result type from struct scsi_cmnd * to bool. No change to object code. Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sa

[PATCH AUTOSEL 4.9 02/15] scsi: NCR5380: Return false instead of NULL

2018-11-22 Thread Sasha Levin
From: Finn Thain [ Upstream commit 96edebd6bb995f2acb7694bed6e01bf6f5a7b634 ] I overlooked this statement when I recently converted the function result type from struct scsi_cmnd * to bool. No change to object code. Signed-off-by: Finn Thain Signed-off-by: Martin K. Petersen Signed-off-by: Sa

Re: [PATCH net-next] cxgb4: use new fw interface to get the VIN and smt index

2018-11-22 Thread Jason Gunthorpe
On Thu, Nov 22, 2018 at 10:53:49AM -0800, David Miller wrote: > From: Jason Gunthorpe > Date: Wed, 21 Nov 2018 19:46:24 -0700 > > > On Wed, Nov 21, 2018 at 01:40:24PM +0530, Ganesh Goudar wrote: > >> From: Santosh Rastapur > >> > >> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it >

Re: [PATCH net-next] cxgb4: use new fw interface to get the VIN and smt index

2018-11-22 Thread David Miller
From: Jason Gunthorpe Date: Wed, 21 Nov 2018 19:46:24 -0700 > On Wed, Nov 21, 2018 at 01:40:24PM +0530, Ganesh Goudar wrote: >> From: Santosh Rastapur >> >> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it >> in port_info structure else retrieve these from viid and save >> them in p

[PATCH] scsi: ufs: Remove redundant sense size definition

2018-11-22 Thread Avri Altman
By spec, the ufs sense data is 18 bytes long. Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufs.h| 4 ++-- drivers/scsi/ufs/ufshcd.c | 17 +++-- 2 files changed, 9 insertions(+), 12 deletions(-) diff --git a/drivers/scsi/ufs/ufs.h b/drivers/scsi/ufs/ufs.h index 8e4e526..dd65f

Re: [GIT PULL] SCSI fixes for 4.20-rc3

2018-11-22 Thread pr-tracker-bot
The pull request you sent on Wed, 21 Nov 2018 21:34:13 -0800: > git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes has been merged into torvalds/linux.git: https://git.kernel.org/torvalds/c/b84b6345e3827ab616946b52f46e95179657b596 Thank you! -- Deet-doot-dot, I am a bot. ht

[PATCH] target: drop unnecessary get_fabric_name() accessor from fabric_ops

2018-11-22 Thread David Disseldorp
All fabrics return a const string. In all cases *except* iSCSI the get_fabric_name() string matches fabric_ops.name. Both fabric_ops.get_fabric_name() and fabric_ops.name are user facing, with the former being used for PR/ALUA state and the latter for configFS (config/target/$name), so we unfortun

Re: [PATCH v7] scsi: Add hwmon support for SMART temperature sensors

2018-11-22 Thread Linus Walleij
On Wed, Nov 21, 2018 at 6:28 PM Martin K. Petersen wrote: > The problem with all this is that the storage topology is largely > undiscoverable for monitoring purposes. We can use heuristics, but in > many cases there is no reliable way to find out that there is an ATA > device behind member #3 of

[RFC PATCH] target: sanitize ALUA and PR state file paths before use

2018-11-22 Thread David Disseldorp
Block ALUA and PR state storage if any of the dynamic subdirectory components include a path separator. Fixes: c66ac9db8d4a ("[SCSI] target: Add LIO target core v4.0.0-rc6") Signed-off-by: David Disseldorp Signed-off-by: Lee Duncan --- Note: Submitted as an RFC, as I've not properly tested the a

Re: [PATCH 22/23] zfcp: drop default switch case which might paper over missing case

2018-11-22 Thread Steffen Maier
On 11/16/2018 12:22 PM, Hannes Reinecke wrote: On 11/8/18 3:44 PM, Steffen Maier wrote: would now suppress helpful -Wswitch compiler warnings when building with W=1 But then again, only with W=1 we would notice unhandled enum cases. that's the only caveat Without the default cases and a

Re: [PATCH 01/23] zfcp: make DIX experimental, disabled, and independent of DIF

2018-11-22 Thread Steffen Maier
Hi Martin, On 11/21/2018 07:13 PM, Martin K. Petersen wrote: Sorry about the delay. Travel got in the way. No problem. BDI_CAP_STABLE_WRITES should take care of this. What's the configuration that fails? Apologies, if the commit description sounds unfair. I did not mean to blame anyone. It

Re: [PATCH v2] codafs: Fix build using bare-metal toolchain

2018-11-22 Thread Andy Shevchenko
On Wed, Nov 21, 2018 at 8:10 PM Jan Harkes wrote: > > On Wed, Nov 21, 2018 at 06:41:13PM +0200, Andy Shevchenko wrote: > > I'm not sure how you managed to miss people in this list (perhaps by > > default you have suppress all Cc in your Git configuration), but I > > guess we may gently ask Christo