Two small fixes. The qla2xxx is a regression from 4.18 and the ufs one
is a device enablement fix.
The patch is available here:
git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-fixes
The short changelog is:
Bill Kuzeja (1):
scsi: qla2xxx: Timeouts occur on surprise remova
On Wed, Nov 21, 2018 at 05:02:13PM -0500, Theodore Y. Ts'o wrote:
> On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
> > > Thanks applied, this bug was elusive but ever present in recent
> > > testing that we did internally, it's been a huge pain in the butt.
> > > The symptoms were usua
Sabyasachi,
> Replaced dma_alloc_coherent + memset with dma_zalloc_coherent
Applied to 4.21/scsi-queue. Thanks.
--
Martin K. Petersen Oracle Linux Engineering
> Since f44ac12f1dcc, BG enablement is tracked with the
> LPFC_SLI3_BG_ENABLED bit, which is set in lpfc_get_cfgparam before
> lpfc_sli_config_sli_port() is called. The bit shouldn't be cleared
> before checking the feature.
James, please review.
Thanks!
--
Martin K. Petersen Oracle Linu
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl':
> drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning:
> variable 'cid_num' set but not used [-Wunused-but-set-variable]
>
> It never used since commit
> cf4e6363
Christoph/Thomas: Please review. Varun has solicited feedback on this a
few times already.
Thanks!
> If number of interrupt vectors are more than num_online_cpus() then
> pci_alloc_irq_vectors_affinity() assigns cpumask based on
> num_possible_cpus() to the remaining vectors because of this
> i
On 2018/11/22 11:15, Martin K. Petersen wrote:
>
> YueHaibing,
>
>> From: Yue Haibing
>>
>> Fixes gcc '-Wunused-but-set-variable' warning:
>>
>> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
>> drivers/scsi/libfc/fc_rport.c:866:18: warning:
>> variable 'disc' set but not
Christoph,
> aha1542 is one of the last users of the legacy isa_*_to_bus APIs, which
> also isn't portable enough. Convert it to the proper DMA mapping API.
Applied to 4.21/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Shivasharan,
> This patch adds support for MegaRAID Aero controller PCI IDs.
> Throw a message when a Configurable secure type controller is
> encountered.
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Sreekanth,
> Display below warning message only up on detection of
> Configurable secure type controllers.
>
> "HBA is in Configurable Secure mode"
>
Please put a "---" separator before patch change log or any commentary
that shouldn't end up in the commit description. Fixed it up.
> v2 change
YueHaibing,
> From: Yue Haibing
>
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_rport.c: In function 'fc_rport_recv_flogi_req':
> drivers/scsi/libfc/fc_rport.c:866:18: warning:
> variable 'disc' set but not used [-Wunused-but-set-variable]
>
> It no used any more a
David,
> The new emulate_pr backstore attribute allows for Persistent Reservation
> and SCSI2 RESERVE/RELEASE support to be completely disabled. This can be
> useful for scenarios such as:
> - Ensuring ATS (Compare & Write) usage on recent VMware ESXi initiators.
> - Allowing clustered (e.g. tcm
Arnd,
> I fixed a bug by adding a dependency in the network driver, but that
> fix caused a related bug in the SCSI driver:
Applied to 4.21/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Souptick,
> Replaced dma_pool_alloc + memset with dma_pool_zalloc
Applied to 4.21/scsi-queue, thanks.
--
Martin K. Petersen Oracle Linux Engineering
On Wed, Nov 21, 2018 at 07:14:35PM -0700, Jens Axboe wrote:
> On 11/21/18 7:00 PM, Ming Lei wrote:
> > On Wed, Nov 21, 2018 at 06:42:51PM -0700, Jens Axboe wrote:
> >> On 11/21/18 6:00 PM, Ming Lei wrote:
> >>> On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
> On 11/14/18 8:20 AM,
On 2018/11/22 0:37, Mike Christie wrote:
On 11/20/2018 11:37 PM, Xiubo Li wrote:
[...]
-is_running = list_empty(&cmd->cmdr_queue_entry);
+is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, &cmd->flags);
se_cmd = cmd->se_cmd;
if (is_running) {
@@ -1289,7 +1319,6 @@ static int t
On Wed, Nov 21, 2018 at 01:40:24PM +0530, Ganesh Goudar wrote:
> From: Santosh Rastapur
>
> If the fw supports returning VIN/VIVLD in FW_VI_CMD save it
> in port_info structure else retrieve these from viid and save
> them in port_info structure. Do the same for smt_idx from
> FW_VI_MAC_CMD
>
>
On 11/21/18 7:00 PM, Ming Lei wrote:
> On Wed, Nov 21, 2018 at 06:42:51PM -0700, Jens Axboe wrote:
>> On 11/21/18 6:00 PM, Ming Lei wrote:
>>> On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
On 11/14/18 8:20 AM, Jens Axboe wrote:
> On 11/14/18 1:25 AM, Ming Lei wrote:
>> c2
On Wed, Nov 21, 2018 at 06:42:51PM -0700, Jens Axboe wrote:
> On 11/21/18 6:00 PM, Ming Lei wrote:
> > On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
> >> On 11/14/18 8:20 AM, Jens Axboe wrote:
> >>> On 11/14/18 1:25 AM, Ming Lei wrote:
> c2856ae2f315d ("blk-mq: quiesce queue befo
On 11/21/18 6:00 PM, Ming Lei wrote:
> On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
>> On 11/14/18 8:20 AM, Jens Axboe wrote:
>>> On 11/14/18 1:25 AM, Ming Lei wrote:
c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has
already fixed this race, however the impli
On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
> On 11/14/18 8:20 AM, Jens Axboe wrote:
> > On 11/14/18 1:25 AM, Ming Lei wrote:
> >> c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has
> >> already fixed this race, however the implied synchronize_rcu()
> >> in blk_mq_quie
On Wed, Nov 14, 2018 at 10:17:01AM -0800, Sagi Grimberg wrote:
> If for some reason we failed to query the mr status, we need to make sure
> to provide sufficient information for an ambiguous error (guard error on
> sector 0).
>
> Fixes: 0a7a08ad6f5f ("IB/iser: Implement check_protection")
> Cc:
That actually makes a lot of sense.
Jan
On November 21, 2018 2:39:03 PM EST, Sam Protsenko
wrote:
>+ Jan Harkes back to "To:" list, slipped away somehow...
>
>On Wed, Nov 21, 2018 at 9:36 PM Sam Protsenko
> wrote:
>>
>> On Wed, Nov 21, 2018 at 8:10 PM Jan Harkes
>wrote:
>> >
>> > On Wed, Nov 2
On Wed, 21 Nov 2018, Christoph Hellwig wrote:
> Hi all,
>
> you in the To list maintain or wrote SCSI drivers that set the
> DISABLE_CLUSTERING flag, which basically disable merges of any
> bio segments. We already have the actual max_segment size limit
> to say which length a segment should h
On Wed, Nov 21, 2018 at 02:47:35PM -0700, Jens Axboe wrote:
> > Thanks applied, this bug was elusive but ever present in recent
> > testing that we did internally, it's been a huge pain in the butt.
> > The symptoms were usually a crash in blk_mq_get_driver_tag() with
> > hctx->tags == NULL, or a c
On 11/14/18 8:20 AM, Jens Axboe wrote:
> On 11/14/18 1:25 AM, Ming Lei wrote:
>> c2856ae2f315d ("blk-mq: quiesce queue before freeing queue") has
>> already fixed this race, however the implied synchronize_rcu()
>> in blk_mq_quiesce_queue() can slow down LUN probe a lot, so caused
>> performance re
Christoph,
for Atari SCSI, commands can only be merged if the physical addresses
of all buffers are contiguous (limitation of the Falcon DMA engine).
Documentation/scsi/scsi_mid_low_api.tx does not spell out whether that
is the case.
Atari SCSI disables scatter/gather, so if that's sufficient to c
+ Jan Harkes back to "To:" list, slipped away somehow...
On Wed, Nov 21, 2018 at 9:36 PM Sam Protsenko
wrote:
>
> On Wed, Nov 21, 2018 at 8:10 PM Jan Harkes wrote:
> >
> > On Wed, Nov 21, 2018 at 06:41:13PM +0200, Andy Shevchenko wrote:
> > > I'm not sure how you managed to miss people in this l
On Wed, Nov 21, 2018 at 8:10 PM Jan Harkes wrote:
>
> On Wed, Nov 21, 2018 at 06:41:13PM +0200, Andy Shevchenko wrote:
> > I'm not sure how you managed to miss people in this list (perhaps by
> > default you have suppress all Cc in your Git configuration), but I
> > guess we may gently ask Christo
Hi Steffen,
Sorry about the delay. Travel got in the way.
>> BDI_CAP_STABLE_WRITES should take care of this. What's the configuration
>> that fails?
>
> Apologies, if the commit description sounds unfair. I did not mean to
> blame anyone. It's just the collection of issues we saw in distros ove
On Wed, Nov 21, 2018 at 06:41:13PM +0200, Andy Shevchenko wrote:
> I'm not sure how you managed to miss people in this list (perhaps by
> default you have suppress all Cc in your Git configuration), but I
> guess we may gently ask Christoph to apply this in case Jan will not
> appear.
You have got
Hi Linus!
> This driver does not block any simultaneous use of other SMART
> userspace tools, it's a both/and approach, not either/or.
The problem with all this is that the storage topology is largely
undiscoverable for monitoring purposes. We can use heuristics, but in
many cases there is no r
From: Fred Herard
This commit enhances iscsi initiator modules to capture iscsi debug messages
using linux kernel tracepoint facility:
https://www.kernel.org/doc/Documentation/trace/tracepoints.txt
The following tracepoint events have been created under the iscsi tracepoint
event group:
iscsi_
On Wed, Nov 21, 2018 at 06:41:13PM +0200, Andy Shevchenko wrote:
> I'm not sure how you managed to miss people in this list (perhaps by
> default you have suppress all Cc in your Git configuration), but I
> guess we may gently ask Christoph to apply this in case Jan will not
> appear.
I don't real
On Wed, Nov 21, 2018 at 6:31 PM Sam Protsenko
wrote:
>
> On Tue, Oct 30, 2018 at 10:27 PM Sam Protsenko
> wrote:
> >
> > The kernel is self-contained project and can be built with bare-metal
> > toolchain. But bare-metal toolchain doesn't define __linux__. Because of
> > this u_quad_t type is not
On 11/20/2018 11:37 PM, Xiubo Li wrote:
> [...]
>>> -is_running = list_empty(&cmd->cmdr_queue_entry);
>>> +is_running = test_bit(TCMU_CMD_BIT_INFLIGHT, &cmd->flags);
>>> se_cmd = cmd->se_cmd;
>>> if (is_running) {
>>> @@ -1289,7 +1319,6 @@ static int tcmu_check_expired_cmd(int
On Tue, Oct 30, 2018 at 10:27 PM Sam Protsenko
wrote:
>
> The kernel is self-contained project and can be built with bare-metal
> toolchain. But bare-metal toolchain doesn't define __linux__. Because of
> this u_quad_t type is not defined when using bare-metal toolchain and
> codafs build fails. T
From: Xiang Chen
Relocate the codes related to dma_map/unmap in hisi_sas_task_prep()
to reduce complexity, with a view to add DIF/DIX support.
Signed-off-by: Xiang Chen
Signed-off-by: John Garry
---
drivers/scsi/hisi_sas/hisi_sas_main.c | 146 +-
1 file changed
This patchset introduces support to the driver for DIF/DIX (or PI -
protection information).
We will only support PI in v3 hw at the moment, even though previous hw
versions also support it.
The series is broken down as follows:
- Tidy sg table size config
- Some tidy-up to accept PI support
- Ad
From: Xiang Chen
Sht->sg_tablesize is set in the driver, and it will be assigned to
shost->sg_tablesize in SCSI mid-layer. So it is not necessary to
assign shost->sg_table one more time in the driver.
In addition to the change, change each scsi_host_template.sg_tablesize
to HISI_SAS_SGE_PAGE_CNT
From: Xiang Chen
For v3 hw, we support DIF/DIX operation for SAS, but not SATA.
In addition, DIF CRC16 is supported.
This patchset adds the SW support for the described features. The main
components are as follows:
- Allocate memory for PI
- Fill PI fields
- Fill related to DIF/DIX in DQ and pr
Replace dma_alloc_coherent + memset with dma_zalloc_coherent
Signed-off-by: Sabyasachi Gupta
---
drivers/scsi/mvsas/mv_init.c | 12
1 file changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index 3ac3437..495bddb 100644
On Mon, Nov 19, 2018 at 08:19:00AM -0700, Keith Busch wrote:
> On Mon, Nov 19, 2018 at 12:58:15AM -0800, Christoph Hellwig wrote:
> > > index 5d83a162d03b..c1d5e4e36125 100644
> > > --- a/drivers/scsi/scsi_lib.c
> > > +++ b/drivers/scsi/scsi_lib.c
> > > @@ -1635,8 +1635,11 @@ static blk_status_t sc
On 21/11/2018 11:08, Steffen Maier wrote:
On 11/21/2018 12:02 PM, Steffen Maier wrote:
On 11/20/2018 03:59 PM, John Garry wrote:
From: Xiang Chen
Sht->sg_tablesize is set in the driver, and it will be assigned to
shost->sg_tablesize in SCSI mid-layer. So it is not necessary to
assign shost->s
On 11/21/2018 12:02 PM, Steffen Maier wrote:
On 11/20/2018 03:59 PM, John Garry wrote:
From: Xiang Chen
Sht->sg_tablesize is set in the driver, and it will be assigned to
shost->sg_tablesize in SCSI mid-layer. So it is not necessary to
assign shost->sg_table one more time in the driver.
In ad
On 11/20/2018 03:59 PM, John Garry wrote:
From: Xiang Chen
Sht->sg_tablesize is set in the driver, and it will be assigned to
shost->sg_tablesize in SCSI mid-layer. So it is not necessary to
assign shost->sg_table one more time in the driver.
In addition to the change, change each scsi_host_te
Hi all,
you in the To list maintain or wrote SCSI drivers that set the
DISABLE_CLUSTERING flag, which basically disable merges of any
bio segments. We already have the actual max_segment size limit
to say which length a segment should have, independent of merged
or originally created, so this lim
From: Manish Rangankar
The kernel panic was observed after switch side perturbation,
BUG: unable to handle kernel NULL pointer dereference at (null)
IP: [] strcmp+0x20/0x40
PGD 0 Oops: [#1] SMP
CPU: 8 PID: 647 Comm: kworker/8:1 Tainted: GW OE
3.10.0-693.e
Default packet size is 0x400.
For jumbo packets set to 0x2400.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi.h | 1 -
drivers/scsi/qedi/qedi_main.c | 13 +
2 files changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_version.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_version.h b/drivers/scsi/qedi/qedi_version.h
index 8a0e523..41bcbba 100644
--- a/drivers/scsi/qedi/qedi_version.h
+++ b/drivers/scsi/qed
From: Manish Rangankar
1. Removed logic to update HW producer index in interrupt context.
2. Update HW producer index after UIO ring and buffer gets initialized.
Signed-off-by: Manish Rangankar
---
drivers/scsi/qedi/qedi_main.c | 31 +++
1 file changed, 19 insertion
The driver load on some systems failed with error,
[0004:01:00.5]:[qedi_request_msix_irq:2524]:8: request_irq failed.
Allocate the IRQs based on MSIX count obtained from qed module
instead of number of queues.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_main.c | 2 +-
1 file changed
From: Manish Rangankar
Add packet filter to avoid unnecessary packet processing in iscsiuio.
Signed-off-by: Manish Rangankar
---
drivers/scsi/qedi/qedi_main.c | 24
1 file changed, 24 insertions(+)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_ma
Use QEDI_PAGE_SIZE for enablement of module on systems with 64K page size.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi_main.c | 16 +---
1 file changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/scsi/qedi/qedi_main.c b/drivers/scsi/qedi/qedi_main.c
index 0f8eb
Fix trivial spelling mistake within macro definition.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi.h | 4 ++--
drivers/scsi/qedi/qedi_main.c | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
index e966855..6
Remove redundant macro definition.
Signed-off-by: Nilesh Javali
---
drivers/scsi/qedi/qedi.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qedi/qedi.h b/drivers/scsi/qedi/qedi.h
index a6f96b3..e966855 100644
--- a/drivers/scsi/qedi/qedi.h
+++ b/drivers/scsi/qedi/qedi.h
@@ -64
Martin,
Please consider below patch set for next 'scsi-fixes' submission.
Thanks,
Nilesh
Manish Rangankar (3):
qedi: Check for session online before getting iSCSI TLV data.
qedi: Add packet filter in light L2 Rx path.
qedi: Move LL2 producer index processing in BH.
Nilesh Javali (6):
qed
Looks good,
Reviewed-by: Christoph Hellwig
From: Santosh Rastapur
If the fw supports returning VIN/VIVLD in FW_VI_CMD save it
in port_info structure else retrieve these from viid and save
them in port_info structure. Do the same for smt_idx from
FW_VI_MAC_CMD
Signed-off-by: Santosh Rastapur
Signed-off-by: Ganesh Goudar
---
drivers/cr
59 matches
Mail list logo
