Re: [PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'

On 11/12/18, 7:24 AM, "YueHaibing" wrote: >External Email > >Fixes gcc '-Wunused-but-set-variable' warning: > >drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl': >drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning: > variable 'cid_num' set but not used [-Wunused-but-set-variabl

[PATCH -next] scsi: bnx2i: remove set but not used variable 'cid_num'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/bnx2i/bnx2i_hwi.c: In function 'bnx2i_process_ofld_cmpl': drivers/scsi/bnx2i/bnx2i_hwi.c:2430:6: warning: variable 'cid_num' set but not used [-Wunused-but-set-variable] It never used since commit cf4e6363859d ("[SCSI] bnx2i: Add bnx2

Price Inquiry

Hi,friend, This is Daniel Murray and i am from Sinara Group Co.Ltd Group Co.,LTD in Russia. We are glad to know about your company from the web and we are interested in your products. Could you kindly send us your Latest catalog and price list for our trial order. Best Regards, Daniel Murray

Re: remove exofs, the T10 OSD code and block/scsi bidi support V3

On 2018-11-11 2:32 p.m., Christoph Hellwig wrote: The only real user of the T10 OSD protocol, the pNFS object layout driver never went to the point of having shipping products, and we removed it 1.5 years ago. Exofs is just a simple example without real life users. The code has been mostly unma

Re: [PATCH 0/3] SG_IO command filtering via sysfs

On Sun, Nov 11, 2018 at 02:26:45PM +0100, Paolo Bonzini wrote: > > I'm not very eBPF savvy, the question I have is: what kind of > information about the running process is available in an eBPF program? > For example, even considering only the examples you make, would it be > able to access the CDB

Re: [PATCH 0/3] SG_IO command filtering via sysfs

On Sun, Nov 11, 2018 at 05:14:45AM -0800, Christoph Hellwig wrote: > I think this goes in the wrong way. There isn't really any point > in filtering at all if we have access to the whole device by the > file persmissions, and we generally should not allow any access for > partitions. It really de

[PATCH 3/8] scsi: remove bidirectional command support

No real need for bidi support once the OSD code is gone. Signed-off-by: Christoph Hellwig --- drivers/scsi/cxgbi/libcxgbi.c | 13 +++--- drivers/scsi/iscsi_tcp.c | 9 + drivers/scsi/libiscsi.c| 64 +++--- drivers/scsi/libiscsi_tcp.c

[PATCH 5/8] bsg: refactor bsg_ioctl

Move all actual functionality into helpers, just leaving the dispatch in this function. Signed-off-by: Christoph Hellwig --- block/bsg.c | 158 1 file changed, 72 insertions(+), 86 deletions(-) diff --git a/block/bsg.c b/block/bsg.c index 9a4

[PATCH 4/8] scsi: stop setting up request->special

No more need in a blk-mq world where the scsi command and request are allocated together. Signed-off-by: Christoph Hellwig --- drivers/scsi/qedf/qedf_io.c | 6 -- drivers/scsi/qedi/qedi_fw.c | 7 --- drivers/scsi/scsi_lib.c | 3 --- drivers/scsi/sd.c | 1 - drivers/scsi/sr.

[PATCH 2/8] scsi: remove the SCSI OSD library

Now that all the users are gone the SCSI OSD library can be removed as well. Signed-off-by: Christoph Hellwig --- Documentation/scsi/osd.txt | 192 --- drivers/scsi/Kconfig |2 - drivers/scsi/Makefile|1 - drivers/scsi/osd/Kbuild | 20 - drivers/

[PATCH 6/8] bsg-lib: handle bidi requests without block layer help

We can just stash away the second request in struct bsg_job instead of using the block layer req->next_rq field, allowing for the eventual removal of the latter. Signed-off-by: Christoph Hellwig --- block/bsg-lib.c | 44 +++--- block/bsg.c

[PATCH 7/8] block: remove req->special

No users left. Signed-off-by: Christoph Hellwig --- block/blk-mq.c | 1 - include/linux/blkdev.h | 2 -- 2 files changed, 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 411be60d0cb6..c1bb0c0b2ad8 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -322,7 +322,6 @@ sta

remove exofs, the T10 OSD code and block/scsi bidi support V3

The only real user of the T10 OSD protocol, the pNFS object layout driver never went to the point of having shipping products, and we removed it 1.5 years ago. Exofs is just a simple example without real life users. The code has been mostly unmaintained for years and is getting in the way of bloc

[PATCH 8/8] block: remove bidi support

Unused now, and another field in struct request bites the dust. Signed-off-by: Christoph Hellwig --- block/blk-mq-debugfs.c | 1 - block/blk-mq.c | 3 --- include/linux/blkdev.h | 6 -- 3 files changed, 10 deletions(-) diff --git a/block/blk-mq-debugfs.c b/block/blk-mq-debugfs.c ind

Re: [PATCH 0/3] SG_IO command filtering via sysfs

On 10/11/2018 20:05, Theodore Y. Ts'o wrote: > I wonder if a better way of adding SG_IO command filtering is via > eBPF? We are currently carrying a inside Google a patch which allows > a specific of SCSI commands to non-root processes --- if the process > belonged to a particular Unix group id. >

Re: [PATCH 0/3] SG_IO command filtering via sysfs

I think this goes in the wrong way. There isn't really any point in filtering at all if we have access to the whole device by the file persmissions, and we generally should not allow any access for partitions. I think we need to simplify the selection, not add crazy amounts of special case code.