[GIT PULL] final round of SCSI updates for the 4.19+ merge window

2018-11-02 Thread James Bottomley
This is a set of minor small (and safe changes) that didn't make the initial pull request plus some bug fixes. The patch is available here: git://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git scsi-misc The short changelog is: Bart Van Assche (7): scsi: qla2xxx: Remove two argume

Re: [PATCH v7 0/8] mpt3sas: some bug fixes patches

2018-11-02 Thread Andy Shevchenko
On Fri, Nov 2, 2018 at 8:26 PM Bjorn Helgaas wrote: > > Suganath Prabu wrote: > > V7 Change Set: > > Split some patches into multiple small patches > > as suggested by Bjorn Helgaas > > > > v6 Change Set: > > Incorporated changes as suggested by Andy. > > In Patch 1 converted while loop to do whil

RE: [PATCH v7 0/8] mpt3sas: some bug fixes patches

2018-11-02 Thread Bjorn Helgaas
Suganath Prabu wrote: > V7 Change Set: > Split some patches into multiple small patches > as suggested by Bjorn Helgaas > > v6 Change Set: > Incorporated changes as suggested by Andy. > In Patch 1 converted while loop to do while in > function mpt3sas_wait_for_ioc_to_operational(). > And in patch

[PATCH] scsi: myrs: only build on little-endian platforms

2018-11-02 Thread Arnd Bergmann
Reading throught the new driver, I noticed that this cannot work on big-endian CPUs, and the old DAC960 had exactly the same behavior. To document this for the future, add a Kconfig dependency that prevents it from being included in big-endian kernels. Since the hardware is really old and we neve

[PATCH] scsi: myrs: avoid stack overflow warning

2018-11-02 Thread Arnd Bergmann
Putting a 1024 byte data structure on the stack is generally a bad idea. On 32-bit systems, it also triggers a compile-time warning when building with -Og: drivers/scsi/myrs.c: In function 'myrs_get_ctlr_info': drivers/scsi/myrs.c:212:1: error: the frame size of 1028 bytes is larger than 1024 byt

[PATCH] scsi: myrb: fix sprintf buffer overflow warning

2018-11-02 Thread Arnd Bergmann
gcc warns that the 12 byte fw_version field might not be long enough to contain the generated firmware name string: drivers/scsi/myrb.c: In function 'myrb_get_hba_config': drivers/scsi/myrb.c:1052:38: error: '%02d' directive writing between 2 and 3 bytes into a region of size between 2 and 5 [-We

[PATCH] scsi: lpfc: fix remoteport access

2018-11-02 Thread Arnd Bergmann
The addition of a spinlock in lpfc_debugfs_nodelist_data() introduced a bug that lets us not skip NULL pointers correctly, as noticed by gcc-8: drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_data.constprop': drivers/scsi/lpfc/lpfc_debugfs.c:728:13: error: 'nrport' may be use

[PATCH] cxgb4i: fix thermal configuration dependencies

2018-11-02 Thread Arnd Bergmann
I fixed a bug by adding a dependency in the network driver, but that fix caused a related bug in the SCSI driver: WARNING: unmet direct dependencies detected for CHELSIO_T4 Depends on [m]: NETDEVICES [=y] && ETHERNET [=y] && NET_VENDOR_CHELSIO [=y] && PCI [=y] && (IPV6 [=y] || IPV6 [=y]=n) && (

[PATCH 2/3] scsi: megaraid: remove unnecessary condition check in mraid_mm_register_adp()

2018-11-02 Thread Chengguang Xu
dma_pool_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling dma_pool_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/megaraid/megaraid_mm.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/scsi/megaraid/me

[PATCH 1/3] scsi: megaraid: remove unnecessary condition check in megaraid_mbox_teardown_dma_pools()

2018-11-02 Thread Chengguang Xu
dma_pool_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling dma_pool_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/megaraid/megaraid_mbox.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/scsi/mega

[PATCH 3/3] scsi: megaraid: remove unnecessary condition check in megasas_free_cmds_fusion()

2018-11-02 Thread Chengguang Xu
dma_pool_destroy() can handle NULL pointer correctly, so there is no need to check NULL pointer before calling dma_pool_destroy(). Signed-off-by: Chengguang Xu --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 28 - 1 file changed, 10 insertions(+), 18 deletions(-) diff --gi