Re: [PATCH] scsi/aic94xx/aic94xx_hwi.c: Use dma_pool_zalloc

2018-11-01 Thread Souptick Joarder
On Fri, Nov 2, 2018 at 2:25 AM Kees Cook wrote: > > On Wed, Oct 31, 2018 at 9:19 PM, Souptick Joarder > wrote: > > Replaced dma_pool_alloc + memset with dma_pool_zalloc > > > > Signed-off-by: Brajeswar Ghosh > > Signed-off-by: Souptick Joarder > > Reviewed-by: Kees Cook Thanks Kees. > > -Kee

Re: [PATCH 21/30] block: remove dead elevator code

2018-11-01 Thread Jens Axboe
On 11/1/18 3:26 PM, Omar Sandoval wrote: > On Wed, Oct 31, 2018 at 11:59:13AM -0600, Jens Axboe wrote: >> This removes a bunch of core and elevator related code. On the core >> front, we remove anything related to queue running, draining, >> initialization, plugging, and congestions. We also kill a

Re: [PATCH 09/30] scsi: kill off the legacy IO path

2018-11-01 Thread Jens Axboe
On 11/1/18 3:11 PM, Omar Sandoval wrote: >> -if ((ql2x_ini_mode == QLA2XXX_INI_MODE_ENABLED) && >> -shost_use_blk_mq(host)) { >> -mq = true; >> +if (ql2x_ini_mode == QLA2XXX_INI_MODE_ENABLED) >> startit = true; >> -

Re: [PATCH 21/30] block: remove dead elevator code

2018-11-01 Thread Omar Sandoval
On Wed, Oct 31, 2018 at 11:59:13AM -0600, Jens Axboe wrote: > This removes a bunch of core and elevator related code. On the core > front, we remove anything related to queue running, draining, > initialization, plugging, and congestions. We also kill anything > related to request allocation, mergi

Re: [PATCHSET v3 0/30] blk-mq driver conversions and legacy path removal

2018-11-01 Thread Omar Sandoval
On Wed, Oct 31, 2018 at 11:58:52AM -0600, Jens Axboe wrote: > This patch series converts the remaining drivers to blk-mq. SCSI > supports both paths, this removes the legacy IO path from SCSI. At the > end, legacy IO code and schedulers are killed off. > > I'm not aware of any issues with this ser

Re: [PATCH 09/30] scsi: kill off the legacy IO path

2018-11-01 Thread Omar Sandoval
On Wed, Oct 31, 2018 at 11:59:01AM -0600, Jens Axboe wrote: > Cc: linux-scsi@vger.kernel.org > Acked-by: Himanshu Madhani > Reviewed-by: Hannes Reinecke > Signed-off-by: Jens Axboe A bunch of really trivial nitpicks below, only to prove that I read the thing ;) Reviewed-by: Omar Sandoval > -

Re: [PATCH] scsi/aic94xx/aic94xx_hwi.c: Use dma_pool_zalloc

2018-11-01 Thread Kees Cook
On Wed, Oct 31, 2018 at 9:19 PM, Souptick Joarder wrote: > Replaced dma_pool_alloc + memset with dma_pool_zalloc > > Signed-off-by: Brajeswar Ghosh > Signed-off-by: Souptick Joarder Reviewed-by: Kees Cook -Kees > --- > drivers/scsi/aic94xx/aic94xx_hwi.c | 3 +-- > 1 file changed, 1 insertio

Re: [PATCHSET v3 0/30] blk-mq driver conversions and legacy path removal

2018-11-01 Thread Jens Axboe
On 10/31/18 8:35 PM, Ming Lei wrote: > On Wed, Oct 31, 2018 at 11:58:52AM -0600, Jens Axboe wrote: >> This patch series converts the remaining drivers to blk-mq. SCSI >> supports both paths, this removes the legacy IO path from SCSI. At the >> end, legacy IO code and schedulers are killed off. >> >

Re: remove exofs and the T10 OSD code V2

2018-11-01 Thread Douglas Gilbert
On 2018-11-01 1:03 a.m., Boaz Harrosh wrote: On 31/10/18 23:10, Douglas Gilbert wrote: On 2018-10-31 4:57 p.m., Boaz Harrosh wrote: On 30/10/18 09:45, Christoph Hellwig wrote: On Mon, Oct 29, 2018 at 02:42:12PM -0600, Jens Axboe wrote: LGTM, for both: I also have this one on top as requeste

Re: [PATCH 6/9] PCI: consolidate PCI config entry in drivers/pci

2018-11-01 Thread Russell King - ARM Linux
On Fri, Oct 19, 2018 at 09:58:46PM +0900, Masahiro Yamada wrote: > On Fri, Oct 19, 2018 at 9:23 PM Russell King - ARM Linux > wrote: > > > > index a68b34183107..b185794549be 100644 > > > --- a/arch/arm/mach-pxa/Kconfig > > > +++ b/arch/arm/mach-pxa/Kconfig > > > @@ -125,7 +125,7 @@ config MACH_AR