[PATCH -next] mvsas: remove set but not used variables 'res_flag'

Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/mvsas/mv_init.c: In function 'mvs_ioremap': drivers/scsi/mvsas/mv_init.c:315:36: warning: variable 'res_flag' set but not used [-Wunused-but-set-variable] unsigned long res_start, res_len, res_flag, res_flag_ex = 0; It not used anymor

Re: [PATCH] bsg: convert to use blk-mq

On 10/23/18 12:07 PM, Jens Axboe wrote: > On 10/23/18 11:40 AM, Benjamin Block wrote: >> On Mon, Oct 22, 2018 at 06:38:36AM -0600, Jens Axboe wrote: >>> On 10/22/18 4:03 AM, Benjamin Block wrote: On Fri, Oct 19, 2018 at 09:50:53AM -0600, Jens Axboe wrote: Ok so, that gets past the st

Re: [PATCHSET 0/28] blk-mq driver conversions and legacy path removal

On 10/25/18 5:09 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> The first round of this went into 4.20-rc, but we've still some of >> them pending. This patch series converts the remaining drivers to >> blk-mq. The ones that support dual paths (like SCSI and DM

Re: [PATCHSET 0/28] blk-mq driver conversions and legacy path removal

On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > The first round of this went into 4.20-rc, but we've still some of > them pending. This patch series converts the remaining drivers to > blk-mq. The ones that support dual paths (like SCSI and DM) have > the non-mq path removed. At the end, leg

Re: [PATCH 08/28] scsi: kill off the legacy IO path

> On Oct 25, 2018, at 4:00 PM, Jens Axboe wrote: > > External Email > > On 10/25/18 4:44 PM, Madhani, Himanshu wrote: >> Jens, >> >>> On Oct 25, 2018, at 3:18 PM, Jens Axboe wrote: >>> >>> External Email >>> >>> On 10/25/18 3:36 PM, Bart Van Assche wrote: On Thu, 2018-10-25 at 15:10 -

Re: [PATCH 08/28] scsi: kill off the legacy IO path

On 10/25/18 4:44 PM, Madhani, Himanshu wrote: > Jens, > >> On Oct 25, 2018, at 3:18 PM, Jens Axboe wrote: >> >> External Email >> >> On 10/25/18 3:36 PM, Bart Van Assche wrote: >>> On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev

Re: [PATCH 08/28] scsi: kill off the legacy IO path

Jens, > On Oct 25, 2018, at 3:18 PM, Jens Axboe wrote: > > External Email > > On 10/25/18 3:36 PM, Bart Van Assche wrote: >> On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >>> @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const >>> struct pci_device_id *id) >>>

Re: [PATCH] libosd: Remove ignored __weak attribute

On Thu, Oct 25, 2018 at 03:02:13PM -0700, Nick Desaulniers wrote: > On Thu, Oct 25, 2018 at 2:31 PM Nathan Chancellor > wrote: > > > > On Tue, Oct 02, 2018 at 04:06:31PM -0700, Bart Van Assche wrote: > > > On Tue, 2018-10-02 at 15:33 -0700, Nick Desaulniers wrote: > > > > On Tue, Oct 2, 2018 at 10

Re: [PATCH 23/28] block: kill lld busy

On 10/25/18 3:42 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> Nobody sets the helper, so we always return 0. Kill it. > > How about changing the description of this patch into something > like "Now that the blk_lld_busy() and blk_queue_lld_busy() callers > h

Re: [PATCH 08/28] scsi: kill off the legacy IO path

On 10/25/18 3:36 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct >> pci_device_id *id) >> base_vha->mgmt_svr_loop_id, host->sg_tablesize); >> >> if (ha->mqenable) { >>

Re: [PATCH] libosd: Remove ignored __weak attribute

On Thu, Oct 25, 2018 at 2:31 PM Nathan Chancellor wrote: > > On Tue, Oct 02, 2018 at 04:06:31PM -0700, Bart Van Assche wrote: > > On Tue, 2018-10-02 at 15:33 -0700, Nick Desaulniers wrote: > > > On Tue, Oct 2, 2018 at 10:57 AM Bart Van Assche > > > wrote: > > > > Explicitly initialized global an

Re: [PATCH 23/28] block: kill lld busy

On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > Nobody sets the helper, so we always return 0. Kill it. How about changing the description of this patch into something like "Now that the blk_lld_busy() and blk_queue_lld_busy() callers have been removed, also remove the implementations of th

Re: [PATCH 08/28] scsi: kill off the legacy IO path

On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > @@ -3265,25 +3261,17 @@ qla2x00_probe_one(struct pci_dev *pdev, const struct > pci_device_id *id) > base_vha->mgmt_svr_loop_id, host->sg_tablesize); > > if (ha->mqenable) { > - bool mq = false; > boo

Re: [PATCH] libosd: Remove ignored __weak attribute

On Tue, Oct 02, 2018 at 04:06:31PM -0700, Bart Van Assche wrote: > On Tue, 2018-10-02 at 15:33 -0700, Nick Desaulniers wrote: > > On Tue, Oct 2, 2018 at 10:57 AM Bart Van Assche wrote: > > > Explicitly initialized global and static variables end up in the .data > > > section and need space in that

Re: [PATCH 05/28] IB/srp: remove old request_fn_active check

On 10/25/18 3:23 PM, Bart Van Assche wrote: > On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: >> This check is only viable for non scsi-mq. Since that is going away, >> kill this legacy check. >> >> Cc: Bart Van Assche >> Cc: Parav Pandit >> Cc: linux-scsi@vger.kernel.org >> Signed-off-by: J

Re: [PATCH 05/28] IB/srp: remove old request_fn_active check

On Thu, 2018-10-25 at 15:10 -0600, Jens Axboe wrote: > This check is only viable for non scsi-mq. Since that is going away, > kill this legacy check. > > Cc: Bart Van Assche > Cc: Parav Pandit > Cc: linux-scsi@vger.kernel.org > Signed-off-by: Jens Axboe > --- > drivers/infiniband/ulp/srp/ib_sr

[PATCH 23/28] block: kill lld busy

Nobody sets the helper, so we always return 0. Kill it. Signed-off-by: Jens Axboe --- block/blk-core.c | 28 block/blk-settings.c | 6 -- drivers/md/dm-mpath.c | 4 +--- include/linux/blkdev.h | 4 4 files changed, 1 insertion(+), 41 deletions(-)

[PATCH 24/28] block: remove request_list code

It's now dead code, nobody uses it. Signed-off-by: Jens Axboe --- block/blk-cgroup.c | 47 block/blk-core.c | 75 -- block/blk-mq.c | 4 -- block/blk.h| 3 -- include/linux/blk-cgroup.h | 108 ---

[PATCH 26/28] block: remove req_no_special_merge() from merging code

It'll always be false at this point, just remove it. Signed-off-by: Jens Axboe --- block/blk-merge.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 7fedc0391610..3561dcce2260 100644 --- a/block/blk-merge.

[PATCH 22/28] block: kill legacy parts of timeout handling

The only user of legacy timing now is BSG, which is invoked from the mq timeout handler. Kill the legacy code, and rename the q->rq_timed_out_fn to q->bsg_job_timeout_fn. Signed-off-by: Jens Axboe --- block/blk-core.c | 1 - block/blk-settings.c | 7 --- block/blk-timeout.c| 99 +++

[PATCH 25/28] block: kill request slab cache

Signed-off-by: Jens Axboe --- block/blk-core.c | 8 block/blk.h | 1 - 2 files changed, 9 deletions(-) diff --git a/block/blk-core.c b/block/blk-core.c index e8f60ed456a2..6074bf2ee2e7 100644 --- a/block/blk-core.c +++ b/block/blk-core.c @@ -57,11 +57,6 @@ EXPORT_TRACEPOINT_SYMBOL_

[PATCH 27/28] blk-merge: kill dead queue lock held check

This is dead code, any queue reaching this part has mq_ops attached. Signed-off-by: Jens Axboe --- block/blk-merge.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/block/blk-merge.c b/block/blk-merge.c index 3561dcce2260..0128284bded4 100644 --- a/block/blk-merge.c +++ b/block/blk-merge.c

[PATCH 20/28] block: remove dead elevator code

This removes a bunch of core and elevator related code. On the core front, we remove anything related to queue running, draining, initialization, plugging, and congestions. We also kill anything related to request allocation, merging, retrieval, and completion. Remove any checking for single queue

[PATCH 28/28] block: get rid of blk_queued_rq()

No point in hiding what this does, just open code it in the one spot where we are still using it. Signed-off-by: Jens Axboe --- block/blk-mq.c | 2 +- include/linux/blkdev.h | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index d43c92

[PATCH 14/28] block: remove blk_complete_request()

It's now unused. Signed-off-by: Jens Axboe --- block/blk-softirq.c| 20 include/linux/blkdev.h | 1 - 2 files changed, 21 deletions(-) diff --git a/block/blk-softirq.c b/block/blk-softirq.c index e47a2f751884..8ca0f6caf174 100644 --- a/block/blk-softirq.c +++ b/block/b

[PATCH 09/28] dm: remove legacy IO path

dm supports both, and since we're killing off the legacy path in general, get rid of it in dm as well. Signed-off-by: Jens Axboe --- drivers/md/Kconfig| 11 -- drivers/md/dm-core.h | 10 -- drivers/md/dm-mpath.c | 14 +- drivers/md/dm-rq.c| 293 ---

[PATCH 10/28] dasd: remove dead code

Since e443343e509a we haven't had a request_fn attached to this driver, hence any code inside an if (q->request_fn) is unreachable. Fixes: e443343e509a ("s390/dasd: blk-mq conversion") [sth: Keep and fix the dasd_info->chanq_len counter.] Reviewed-by: Jan Hoeppner Signed-off-by: Stefan Haberland

[PATCH 13/28] bsg: convert to use blk-mq

Requires a few changes to the FC transport class as well. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 123 +++ drivers/scsi/scsi_transport_fc.c | 59 +-- 2 fil

[PATCH 15/28] blk-wbt: kill check for legacy queue type

Everything is blk-mq at this point, so it doesn't make any sense to have this option available as it does nothing. Signed-off-by: Jens Axboe --- block/Kconfig | 6 -- block/blk-wbt.c | 3 +-- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/block/Kconfig b/block/Kconfig index

[PATCH 21/28] block: remove __blk_put_request()

Now there's no difference between blk_put_request() and __blk_put_request() anymore, get rid of the underscore version and convert the few callers. Signed-off-by: Jens Axboe --- block/blk-core.c | 9 - block/blk-merge.c | 2 +- drivers/scsi/osd/osd_init

[PATCH 16/28] blk-cgroup: remove legacy queue bypassing

We only support mq devices now. Signed-off-by: Jens Axboe --- block/blk-cgroup.c | 8 1 file changed, 8 deletions(-) diff --git a/block/blk-cgroup.c b/block/blk-cgroup.c index 992da5592c6e..5f10d755ec52 100644 --- a/block/blk-cgroup.c +++ b/block/blk-cgroup.c @@ -1446,8 +1446,6 @@ int

[PATCH 02/28] ms_block: convert to blk-mq

Straight forward conversion, room for optimization in how everything is punted to a work queue. Also looks plenty racy all over the map, with the state changes. I fixed a bunch of them up while doing the conversion, but there are surely more. Cc: Maxim Levitsky Signed-off-by: Jens Axboe --- dri

[PATCH 18/28] block: remove non mq parts from the flush code

Signed-off-by: Jens Axboe --- block/blk-flush.c | 154 +- block/blk.h | 4 +- 2 files changed, 31 insertions(+), 127 deletions(-) diff --git a/block/blk-flush.c b/block/blk-flush.c index 8b44b86779da..9baa9a119447 100644 --- a/block/blk-flush.c

[PATCH 17/28] block: remove legacy rq tagging

It's now unused, kill it. Signed-off-by: Jens Axboe --- Documentation/block/biodoc.txt | 88 block/Makefile | 2 +- block/blk-core.c | 6 - block/blk-mq-debugfs.c | 2 - block/blk-mq-tag.c | 6 +- block/blk-sysfs.c

[PATCH 12/28] bsg: provide bsg_remove_queue() helper

All drivers do unregister + cleanup, provide a helper for that. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 7 +++ drivers/scsi/scsi_transport_fc.c| 6 ++ drivers/scsi/scsi_transport_is

[PATCH 03/28] mspro_block: convert to blk-mq

Straight forward conversion, there's room for improvement. Signed-off-by: Jens Axboe --- drivers/memstick/core/mspro_block.c | 121 +++- 1 file changed, 66 insertions(+), 55 deletions(-) diff --git a/drivers/memstick/core/mspro_block.c b/drivers/memstick/core/mspro_bloc

[PATCH 04/28] ide: convert to blk-mq

ide-disk and ide-cd tested as working just fine, ide-tape and ide-floppy haven't. But the latter don't require changes, so they should work without issue. Add helper function to insert a request from a work queue, since we cannot invoke the blk-mq request insertion from IRQ context. Cc: David Mil

[PATCH 05/28] IB/srp: remove old request_fn_active check

This check is only viable for non scsi-mq. Since that is going away, kill this legacy check. Cc: Bart Van Assche Cc: Parav Pandit Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- drivers/infiniband/ulp/srp/ib_srp.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/i

[PATCH 07/28] blk-mq: remove legacy check in queue blk_freeze_queue()

Signed-off-by: Jens Axboe --- block/blk-mq.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 4c82dc44d4d8..a58d2d953876 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -177,8 +177,6 @@ void blk_freeze_queue(struct request_queue *q) * exporte

[PATCHSET 0/28] blk-mq driver conversions and legacy path removal

The first round of this went into 4.20-rc, but we've still some of them pending. This patch series converts the remaining drivers to blk-mq. The ones that support dual paths (like SCSI and DM) have the non-mq path removed. At the end, legacy IO code and schedulers are killed off. This patch series

[PATCH 08/28] scsi: kill off the legacy IO path

Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- Documentation/scsi/scsi-parameters.txt | 5 - drivers/scsi/Kconfig | 12 - drivers/scsi/cxlflash/main.c | 6 - drivers/scsi/hosts.c | 29 +- drivers/scsi/lpfc/lpfc_scsi.c |

[PATCH 06/28] blk-mq: remove the request_list usage

We don't do anything with it, that's just the legacy path. Signed-off-by: Jens Axboe --- block/blk-mq.c | 5 - 1 file changed, 5 deletions(-) diff --git a/block/blk-mq.c b/block/blk-mq.c index 3f91c6e5b17a..4c82dc44d4d8 100644 --- a/block/blk-mq.c +++ b/block/blk-mq.c @@ -510,9 +510,6 @@ vo

[PATCH 11/28] bsg: pass in desired timeout handler

This will ease in the conversion to blk-mq, where we can't set a timeout handler after queue init. Cc: Johannes Thumshirn Cc: Benjamin Block Cc: linux-scsi@vger.kernel.org Signed-off-by: Jens Axboe --- block/bsg-lib.c | 3 ++- drivers/scsi/scsi_transport_fc.c| 7 +++

[PATCH 01/28] sunvdc: convert to blk-mq

Convert from the old request_fn style driver to blk-mq. Cc: David Miller Signed-off-by: Jens Axboe --- drivers/block/sunvdc.c | 149 +++-- 1 file changed, 98 insertions(+), 51 deletions(-) diff --git a/drivers/block/sunvdc.c b/drivers/block/sunvdc.c index b5

Re: [PATCH v3 2/5] qla2xxx_nvmet: Add files for FC-NVMe Target support

On 9/28/2018 3:46 PM, Himanshu Madhani wrote: + .target_features= NVMET_FCTGTFEAT_READDATA_RSP | + NVMET_FCTGTFEAT_CMD_IN_ISR | + NVMET_FCTGTFEAT_OPDONE_IN_ISR, Himanshu, I'm looking at these but had

[PATCH v3] scsi: ufs: Fix hynix ufs bug with quirk on hi36xx SoC

From: Wei Li Hynix ufs has deviations on hi36xx platform which will result in ufs bursts transfer failures. To fix the problem, the Hynix device must set the register VS_DebugSaveConfigTime to 0x10, which will set time reference for SaveConfigTime is 250 ns. The time reference for SaveConfigTime

RE: [PATCH] scsi: aic7xxx: Fix unintended sign extension issue

From: James Bottomley > Sent: 25 October 2018 16:33 > > On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote: > > From: Colin Ian King > > > > In the expression "ahc_inb(ahc, port+3) << 24", the initial value is > > a u8, but is promoted to a signed int, then sign-extended to > > uint64_t. > > Wh

Re: [PATCH] scsi: aic7xxx: Fix unintended sign extension issue

On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote: > From: Colin Ian King > > In the expression "ahc_inb(ahc, port+3) << 24", the initial value is > a u8, but is promoted to a signed int, then sign-extended to > uint64_t. Why is this, that's highly non intuitive? The compiler is supposed to p

Re: [PATCH] scsi: aic7xxx: Fix unintended sign extension issue

On Thu, 2018-10-25 at 16:13 +0100, Colin King wrote: > From: Colin Ian King > > In the expression "ahc_inb(ahc, port+3) << 24", the initial value is a > u8, but is promoted to a signed int, then sign-extended to uint64_t. If > the value read from the port has the upper bit set then the sign > ex

[PATCH] scsi: aic7xxx: Fix unintended sign extension issue

From: Colin Ian King In the expression "ahc_inb(ahc, port+3) << 24", the initial value is a u8, but is promoted to a signed int, then sign-extended to uint64_t. If the value read from the port has the upper bit set then the sign extension will set all the upper bits of the expression which is pr

Re: [GIT PULL] first round of SCSI updates for the 4.19+ merge window

On Wed, Oct 24, 2018 at 3:59 AM James Bottomley wrote: > > This is mostly updates of the usual drivers: [...] Hmm. No diffstat? The shortlog matches, but I really prefer seeing what the diffstat is too and confirm that part. Anyway, pulled, Linus

Re: [PATCH v4 00/11] Zoned block device support improvements

On 10/24/18 10:04 AM, Bart Van Assche wrote: > On Wed, 2018-10-24 at 11:37 -0400, Martin K. Petersen wrote: >> Mike, >> You keep mentioning this, but I don't recall ever seeing anything to that effect. The rest of the kernel appears to be either arbitrary ordering or favoring author

[Resend 2/2] mpt3sas: Add support to Aero PCI IDs.

Add support for Aero/Sea controllers and add warning for configurable secure type IOC. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3s

[Resend 1/2] mpt3sas: Update MPI headers to support Aero controllers.

Updating MPI headers to the latest version 2.6.7 to add support to the driver to detect the new 3816 and 3916 chip based controllers. Separate out firmware image data from mpi2_ioc.h to new file mpi2_image.h Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpi/mpi2.h | 17 +- driv

[Resend 0/2] mpt3sas: Add support to Aero controllers.

1) Updated MPI headers to the latest version 2.6.7. 2) Added support for Aero/Sea controllers. Suganath Prabu (2): mpt3sas: Update MPI headers to support Aero controllers. mpt3sas: Add support to Aero PCI IDs. drivers/scsi/mpt3sas/mpi/mpi2.h | 17 +- drivers/scsi/mpt3sas/mpi/mpi2_cnfg

Re: [PATCH 1/2] mpt3sas: Update MPI headers to support Aero controllers.

/Suganath-Prabu/mpt3sas-Update-MPI-headers-to-support-Aero-controllers/20181025-181347 base: https://git.kernel.org/pub/scm/linux/kernel/git/jejb/scsi.git for-next config: x86_64-randconfig-x014-201842 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the

[PATCH 1/2] mpt3sas: Update MPI headers to support Aero controllers.

Updating MPI headers to the latest version 2.6.7 to add support to the driver to detect the new 3816 and 3916 chip based controllers. Separate out firmware image data from mpi2_ioc.h to new file mpi2_image.h Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpi/mpi2.h | 17 +- driv

[PATCH 2/2] mpt3sas: Add support to Aero PCI IDs.

Add support for Aero/Sea controllers and add warning for configurable secure type IOC. Signed-off-by: Suganath Prabu --- drivers/scsi/mpt3sas/mpt3sas_base.h | 1 + drivers/scsi/mpt3sas/mpt3sas_scsih.c | 26 ++ 2 files changed, 27 insertions(+) diff --git a/drivers/scsi

[PATCH 0/2]mpt3sas: Update MPI headers to support Aero controllers.

Updating MPI headers to the latest version 2.6.7 to add support to the driver to detect new 3816 and 3916 chip based controllers. Seperate out firmware image data from mpi2_ioc.h to new file mpi2_image.h Suganath Prabu (2): mpt3sas: Update MPI headers to support Aero controllers. mpt3sas: Ad

Submit Proposals to the 2019 Linux Storage and Filesystems Conference!

After a one-year hiatus, the Linux Storage and Filesystems Conference (Vault) returns in 2019, under the sponsorship and organization of the USENIX Association. Vault brings together practitioners, implementers, users, and researchers working on storage in open source and related projects. We w

[PATCH] rescan-scsi-bus.sh: use LUN wildcard in idlist

By scanning for LUN 0 only, we may encounter a device that the kernel won't add (e.g. peripheral device type 31) and which may thus never appear in sysfs for us to use for REPORT LUNS. That causes LUN additions for such devices to be missed by "rescan-iscsi-bus.sh -a". Signed-off-by: Martin Wilck