Re: move bus (PCI, PCMCIA, EISA, rapdio) config to drivers/

On Sun, Oct 14, 2018 at 12:10 AM Christoph Hellwig wrote: > > Hi all, > > currently every architecture that wants to provide on of the common > periphal busses needs to add some boilerplate code and include the > right Kconfig files. This series instead just selects the presence > (when needed)

Re: [PATCH 7/8] eisa: consolidate EISA Kconfig entry in drivers/eisa

On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > Let architectures opt into EISA support by selecting HAS_EISA and > handle everything else in drivers/eisa. > > Signed-off-by: Christoph Hellwig > --- How about HAVE_EISA ? You forgot to add source "drivers/eisa/Kconfig" to drivers

Re: [PATCH 4/8] pci: consolidate PCI config entry in drivers/pci

On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > There is no good reason to duplicate the PCI menu in every architecture. > Instead provide a selectable HAS_PCI symbol that indicates availability > of PCI support and the handle the rest in drivers/pci. I think HAVE_ is a preferred p

Re: [PATCH 2/8] powerpc: simplify CONFIG_PCI_QSPAN Kconfig magic

On Sun, Oct 14, 2018 at 12:11 AM Christoph Hellwig wrote: > > The way how CONFIG_PCI_QSPAN selects the CONFIG_PCI default is highly > unusual and gets in the way of moving CONFIG_PCI into > drivers/pci/Kconfig. Simplify it by just having it depend on > CONFIG_PCI. > > Signed-off-by: Christoph Hel

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

On Mon, 15 Oct 2018, Hannes Reinecke wrote: > On 10/14/18 8:12 AM, Finn Thain wrote: > > As a temporary measure, the code to implement PIO transfers was > > duplicated in zorro_esp and mac_esp. Now that it has stabilized > > move the common code into the core driver but don't build it unless > > n

Re: [PATCH 5/6] esp_scsi: De-duplicate PIO routines

On Mon, 15 Oct 2018, Hannes Reinecke wrote: > On 10/13/18 2:51 AM, Finn Thain wrote: > > As a temporary measure, the code to implement PIO transfers was > > duplicated in zorro_esp and mac_esp. Now that this code has stabilized, > > move it into the core driver to eliminate the duplication. > >

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

On 10/14/18 8:12 AM, Finn Thain wrote: As a temporary measure, the code to implement PIO transfers was duplicated in zorro_esp and mac_esp. Now that it has stabilized move the common code into the core driver but don't build it unless needed. This replaces the inline assembler with more portable

Re: [PATCH 5/6] esp_scsi: De-duplicate PIO routines

On 10/13/18 2:51 AM, Finn Thain wrote: As a temporary measure, the code to implement PIO transfers was duplicated in zorro_esp and mac_esp. Now that this code has stabilized, move it into the core driver to eliminate the duplication. This replaces the inline assembler with more portable writesb(

Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

On Mon, Oct 15, 2018 at 10:13:37AM +1100, Finn Thain wrote: > On Sun, 14 Oct 2018, Christoph Hellwig wrote: > > > > + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun); > > > > I think lp should always be non-NULL here. > > > > It's not clear from Documentation/scsi/scsi_mid_low_api.

Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

On Mon, 15 Oct 2018, Finn Thain wrote: > On Sun, 14 Oct 2018, Christoph Hellwig wrote: > > > > + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun); > > > > I think lp should always be non-NULL here. > > > > It's not clear from Documentation/scsi/scsi_mid_low_api.txt, but I guess >

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

On Sun, 14 Oct 2018, Geert Uytterhoeven wrote: > > > --- a/drivers/scsi/Kconfig > > +++ b/drivers/scsi/Kconfig > > @@ -42,6 +42,10 @@ config SCSI_DMA > > bool > > default n > > > > +config SCSI_ESP_PIO > > + bool > > + default n > > "default n" is the default, so plea

Re: [PATCH v4 00/11] Zoned block device support improvements

Jens, On 2018/10/14 7:43, Jens Axboe wrote: > On 10/12/18 4:08 AM, Damien Le Moal wrote: >> This series improves zoned block device support (reduce overhead) and >> introduces many simplifications to the code (overall, there are more >> deletions >> than insertions). >> >> In more details: >> * P

Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

On Sun, 14 Oct 2018, Christoph Hellwig wrote: > > + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun); > > I think lp should always be non-NULL here. > It's not clear from Documentation/scsi/scsi_mid_low_api.txt, but I guess that's true for scanning of targets. Is it true in gene

Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

On Mon, 15 Oct 2018, Michael Schmitz wrote: > > Do we really need to make that distinction? > esp_reconnect() dereferences lp, so !lp has to inhibit disconnection. At least, that's my reading. I can't see any other reason for the lp conditional. --

Re: [PATCH v2 2/6] esp_scsi: Track residual for PIO transfers

On Sun, 14 Oct 2018, Geert Uytterhoeven wrote: > > > Fixes: 6fe07aaffbf0 > > Fixes: 6fe07aaffbf0 ("[SCSI] m68k: new mac_esp scsi driver") > Fixed. > > Tested-by: Stan Johnson > > Signed-off-by: Finn Thain > > Tested-by: Michael Schmitz > > > --- a/drivers/scsi/esp_scsi.h > > +++ b/drivers

Re: [PATCH v2 1/6] zorro_esp: Limit DMA transfers to 65535 bytes

On Sun, 14 Oct 2018, Geert Uytterhoeven wrote: > > > Fixes: 3109e5ae0311 > > Fixes: 3109e5ae0311 ("scsi: zorro_esp: New driver for Amiga Zorro > NCR53C9x boards") > OK. > $ git help fixes > 'fixes' is aliased to 'show --format='Fixes: %h ("%s")' -s' > > BTW, if you use vim, add > > nore

Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

On 15/10/18 04:47, Christoph Hellwig wrote: + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun); I think lp should always be non-NULL here. That indeed appears to be the case these days. So we can't rely on !lp to detect when probing the bus any longer. What else would be a

Re: [PATCH 0/3] sd: Rely on the driver core for asynchronous probing

On 10/2/18 2:52 PM, Bart Van Assche wrote: During the 2018 edition of LSF/MM there was a session about increasing SCSI disk probing concurrency. This patch series implements what has been proposed during that session, namely: - Make sure that the driver core is aware of asynchronous SCSI LUN prob

[PATCH 21/28] qla1280: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla1280.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/scsi/qla1280.c b/drivers/scsi/qla1280.c

[PATCH 24/28] snic: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/snic/snic_disc.c | 7 --- drivers/scsi/snic/snic_io.c | 25 + drivers/scsi/snic/snic_main.c | 24 ++--

[PATCH 26/28] smartpqi: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Tested-by: Don Brace Acked-by: Don Brace Reviewed-by: Johannes Thumshirn --- drivers/scsi/smartpqi/smartpqi_init.c | 100 +

[PATCH 28/28] mesh: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/mesh.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/mesh.c b/drivers/scsi/mesh.c index 82e01dbe90af..ec6940f2f

[PATCH 27/28] ips: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/ips.c | 80 -- 1 file changed, 41 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/ips.c b/drivers/sc

[PATCH 23/28] qla4xxx: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla4xxx/ql4_os.c | 25 - 1 file changed, 8 insertions(+

[PATCH 22/28] qla2xxx: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_target.c | 8 drivers/scsi/qla2xxx/tcm_qla2xxx.c | 2 +-

[PATCH 25/28] vmw_pscsi: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/vmw_pvscsi.c | 77 +++ 1 file changed, 38 insertions(+), 39 deletions(-) diff --git a/drivers/scsi/vmw_pvscsi.c b/dri

[PATCH 08/28] be2iscsi: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/be2iscsi/be_cmds.c | 10 ++--- drivers/scsi/be2iscsi/be_iscsi.c | 13 +++--- drivers/scsi/be2iscsi/be_main.c | 72 ++-- driv

[PATCH 17/28] nsp32: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/nsp32.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/nsp32.c b/drivers/scsi/nsp32.c index 8620ac5d

[PATCH 12/28] megaraid_mbox: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/megaraid/megaraid_mbox.c | 51 +-- 1 file changed, 25 insertions(+), 26 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_

[PATCH 13/28] megaraid_sas: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/megaraid/megaraid_sas_base.c | 150 ++-- drivers/scsi/megaraid/megaraid_sas_fusion.c | 16 +-- 2 files changed, 83 insertions(+), 83 de

[PATCH 14/28] mpt3sas: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Also simplify setting the DMA mask a bit. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/mpt3sas/mpt3sas_base.c | 67 drivers/scsi/mpt3sas/mpt3sas_ctl.c | 34 ++

[PATCH 19/28] qedf: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/qedf/qedf_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH 09/28] csiostor: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/csiostor/csio_init.c | 7 ++- drivers/scsi/csiostor/csio_lnode.c | 6 +++--- drivers/scsi/csiostor/csio_scsi.c | 12 ++-- drivers/scsi/csi

[PATCH 11/28] hpsa: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Tested-by: Don Brace Acked-by: Don Brace Reviewed-by: Johannes Thumshirn --- drivers/scsi/hpsa.c | 136 ++-- 1 file changed, 69 insertions(+), 67 deletions(-) d

[PATCH 03/28] 3w-xxx: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Acked-by: Adam Radford Reviewed-by: Johannes Thumshirn --- drivers/scsi/3w-.c | 20 ++-- drivers/scsi/3w-xx

[PATCH 07/28] atp870u: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/atp870u.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/atp870u.c b/drivers/scsi/atp870u.c index 8996d2329e11..80

[PATCH 01/28] aic94xx: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/aic94xx/aic94xx_init.c | 9 ++ drivers/scsi/aic94xx/aic94xx_task.c | 46 ++

[PATCH 04/28] 3w-sas: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Acked-by: Adam Radford Reviewed-by: Johannes Thumshirn --- drivers/scsi/3w-sas.c | 38 +- 1

[PATCH 06/28] a100u2w: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/a100u2w.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/scsi/a100u2w.c b/drivers/scsi/a100u2w.c index

[PATCH 18/28] pm8001: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn Reviewed-by: Jack Wang --- drivers/scsi/pm8001/pm8001_hwi.c | 22 +++--- drivers/scsi/pm8001/pm8001_init.c | 28 +--- drivers/scs

[PATCH 05/28] BusLogic: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/BusLogic.c | 36 +++- 1 file changed, 19 insertions(+), 17 deletions(-) diff --git a/drivers/scsi/BusLogic.c b/drivers/sc

[PATCH 15/28] mvumi: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Also reuse an existing helper (after fixing the error return) to set the DMA mask instead of having three copies of the code. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/mvumi.c | 89 ++

[PATCH 02/28] 3w-9xxx: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Acked-by: Adam Radford Reviewed-by: Johannes Thumshirn --- drivers/scsi/3w-9xxx.c | 50

[PATCH 16/28] mvsas: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/mvsas/mv_init.c | 21 +++-- drivers/scsi/mvsas/mv_sas.c | 12 +

[PATCH 10/28] fnic: switch to generic DMA API

Switch from the legacy PCI DMA API to the generic DMA API. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/fnic/fnic_fcs.c | 41 +++ drivers/scsi/fnic/fnic_main.c | 19 ++-- drivers/scsi/fnic/fnic_scsi.c | 38 +++

[PATCH 20/28] qedi: fully convert to the generic DMA API

The driver is currently using an odd mix of legacy PCI DMA API and generic DMA API calls, switch it over to the generic API entirely. Signed-off-by: Christoph Hellwig Reviewed-by: Johannes Thumshirn --- drivers/scsi/qedi/qedi_main.c | 8 1 file changed, 4 insertions(+), 4 deletions(-)

switch most scsi drivers to the generic DMA API v2

A lot of SCSI drivers still use the legacy PCI DMA API. While a few of them have various oddities that should be deal with separately, most of them can be very trivially converted over. Two interesting things to look out for: - pci_(z)alloc_consistent forced GFP_ATOMIC allocations, which is a

Re: [PATCH 02/19] megaraid_sas: Add support for FW snap dump

> + > + instance->snapdump_prop = > + pci_alloc_consistent(pdev, > + sizeof(struct > MR_SNAPDUMP_PROPERTIES), > + &instance->snapdump_prop_h); No new calls to the PCI DMA API please.

Re: [PATCH v2 3/6] esp_scsi: Grant disconnect privilege for untagged commands

> + *p++ = IDENTIFY(lp && (tp->flags & ESP_TGT_DISCONNECT), lun); I think lp should always be non-NULL here.

Re: [PATCH v2 5/6] esp_scsi: De-duplicate PIO routines

Hi Finn, On Sun, Oct 14, 2018 at 8:35 AM Finn Thain wrote: > As a temporary measure, the code to implement PIO transfers was > duplicated in zorro_esp and mac_esp. Now that it has stabilized > move the common code into the core driver but don't build it unless > needed. > > This replaces the inli

Re: [PATCH v2 2/6] esp_scsi: Track residual for PIO transfers

Hi Finn, On Sun, Oct 14, 2018 at 8:36 AM Finn Thain wrote: > If a target disconnects during a PIO data transfer the command may > fail when the target reconnects: > > scsi host1: DMA length is zero! > scsi host1: cur adr[0438] len[] > > The scsi bus is then reset. This happens because

Re: [PATCH v2 1/6] zorro_esp: Limit DMA transfers to 65535 bytes

Hi Finn, On Sun, Oct 14, 2018 at 8:36 AM Finn Thain wrote: > The core driver, esp_scsi, does not use the ESP_CONFIG2_FENAB bit, so > the chip's Transfer Counter register is only 16 bits wide (not 24). > A larger transfer cannot work and will theoretically result in a failed > command and a "DMA l

Re: [PATCH v3 4/5] target: split out helper for cxn timeout error stashing

On Sun, 14 Oct 2018 11:43:34 +0800, kbuild test robot wrote: > Thank you for the patch! Yet something to improve: > > [auto build test ERROR on target/master] > [also build test ERROR on v4.19-rc7 next-20181012] > [if your patch is applied to the wrong git tree, please drop us a note to > help i

Re: [PATCH v3] target: split out helper for cxn timeout error stashing

/commits/David-Disseldorp/target-split-out-helper-for-cxn-timeout-error-stashing/20181014-111810 base: https://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git master config: i386-randconfig-s1-201841 (attached as .config) compiler: gcc-6 (Debian 6.4.0-9) 6.4.0 20171026 reproduce

Re: [PATCH 5/8] pcmcia: allow PCMCIA support independent of the architecture

On Sun, Oct 14, 2018 at 07:42:52AM +0200, Dominik Brodowski wrote: > On Sat, Oct 13, 2018 at 05:10:13PM +0200, Christoph Hellwig wrote: > > There is nothing architecture specific in the PCMCIA core, so allow > > building it everywhere. The actual host controllers will depend on ISA, > > PCI or a s

Re: [PATCH v2 1/6] zorro_esp: Limit DMA transfers to 65535 bytes

Hi Finn, thanks for spotting this! Am 14.10.2018 um 19:12 schrieb Finn Thain: The core driver, esp_scsi, does not use the ESP_CONFIG2_FENAB bit, so the chip's Transfer Counter register is only 16 bits wide (not 24). A larger transfer cannot work and will theoretically result in a failed command