Re: [PATCH v4 3/6] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-10-07 Thread Suganath Prabu Subramani
Hi Bjorn, We tried to recreate the issue with latest kernel multiple times.(Without including this patch,) but we were not able to recreate it. On 4.4 kernel we hit this issue time long back. So we are not sure that this issue is really fixed with latest kernel or not. We prefer to keep this patch

Re: [PATCH v4 1/6] mpt3sas: Introduce mpt3sas_base_pci_device_is_available

2018-10-07 Thread Suganath Prabu Subramani
On Tue, Oct 2, 2018 at 7:34 PM Bjorn Helgaas wrote: > > On Mon, Oct 01, 2018 at 03:40:51PM -0500, Bjorn Helgaas wrote: > > I think the names "pci_device_is_present()" and > > "mpt3sas_base_pci_device_is_available()" contribute to the problem > > because they make promises that can't be kept -- all

Re: [PATCH v5] scsi: Add hwmon support for SMART temperature sensors

2018-10-07 Thread Hannes Reinecke
On 10/7/18 10:49 PM, Linus Walleij wrote: S.M.A.R.T. temperature sensors have been supported for years by userspace tools such as smarttools. This adds support to read it from the kernel and adds a temperature zone for the drive. The temperature readout is however also a good fit for Linux' hwmo

[PATCH 1/1] scsi: ufs: make UFS Tx lane1 clock optional

2018-10-07 Thread Can Guo
From: Venkat Gopalakrishnan The UFS Tx lane1 clock could be muxed, hence keep it optional by ignoring it if it is not provided in device tree. Signed-off-by: Venkat Gopalakrishnan Signed-off-by: Subhash Jadavani Signed-off-by: Can Guo --- drivers/scsi/ufs/ufs-qcom.c | 46

Re: [PATCH] Revert "genirq/affinity: assign vectors to all possible CPUs"

2018-10-07 Thread Ming Lei
On Mon, Oct 01, 2018 at 02:33:07PM +0200, Paul Menzel wrote: > Date: Wed, 29 Aug 2018 17:28:45 +0200 > > This reverts commit ef86f3a72adb8a7931f67335560740a7ad696d1d. > > See the discussion in the thread *aacraid: Regression in 4.14.56 > with *genirq/affinity: assign vectors to all possible CPUs*

[PATCH v5] scsi: Add hwmon support for SMART temperature sensors

2018-10-07 Thread Linus Walleij
S.M.A.R.T. temperature sensors have been supported for years by userspace tools such as smarttools. This adds support to read it from the kernel and adds a temperature zone for the drive. The temperature readout is however also a good fit for Linux' hwmon subsystem. By adding a hwmon interface to

[PATCH v9 3/8] uapi: ufs: Make utp_upiu_req visible to user space

2018-10-07 Thread Avri Altman
in preparation to send UPIU requests via bsg. Signed-off-by: Avri Altman Reviewed-by: Bart Van Assche Reviewed-by: Christoph Hellwig --- drivers/scsi/ufs/ufs.h | 61 + drivers/scsi/ufs/ufshcd.c| 6 ++-- include/uapi/scsi/scsi_bsg_ufs.h | 74 ++

[PATCH v9 7/8] scsi: ufs-bsg: Add support for raw upiu in ufs_bsg_request()

2018-10-07 Thread Avri Altman
Do that for the currently supported UPIUs: query, nop out, and task management. We do not support UPIU of type scsi command yet, while we are using the job's request and reply pointers to hold the payload. We will look into it in later patches. We might need to elaborate the raw upiu api for that

[PATCH v9 0/8] scsi: Add ufs bsg endpoint

2018-10-07 Thread Avri Altman
Here is a proposal to use a bsg endpoint to manage ufs devices. We will do that by adding a bsg device node to the ufs driver, and use it to send UPIU transactions to the ufs device. It will serve as a ufs device management infrastructure, for device configuration, provisioning, testing and valid

[PATCH v9 2/8] scsi: ufs: add a low-level __ufshcd_issue_tm_cmd helper

2018-10-07 Thread Avri Altman
From: Christoph Hellwig Add a helper that takes a utp_task_req_desc and issues it, which will be useful for UFS bsg support. Rewrite ufshcd_issue_tm_cmd0x to use this new helper. Signed-off-by: Christoph Hellwig Signed-off-by: Avri Altman --- drivers/scsi/ufs/ufshcd.c | 141 +

[PATCH v9 4/8] scsi: ufs: Add a bsg endpoint that supports UPIUs

2018-10-07 Thread Avri Altman
For now, just provide an API to allocate and remove ufs-bsg node. We will use this framework to manage ufs devices by sending UPIU transactions. For the time being, implements an empty bsg_request() - will add some more functionality in coming patches. Nonetheless, we reveal here the protocol we

[PATCH v9 8/8] scsi: ufs-bsg: Add support for uic commands in ufs_bsg_request()

2018-10-07 Thread Avri Altman
Make ufshcd_send_uic_cmd() public for that. Signed-off-by: Avri Altman Reviewed-by: Christoph Hellwig Reviewed-by: Bart Van Assche --- drivers/scsi/ufs/ufs_bsg.c | 11 +++ drivers/scsi/ufs/ufshcd.c| 3 +-- drivers/scsi/ufs/ufshcd.h| 2 ++ include/uapi/scsi/scsi_

[PATCH v9 1/8] scsi: ufs: cleanup struct utp_task_req_desc

2018-10-07 Thread Avri Altman
From: Christoph Hellwig Remove the pointless task_req_upiu and task_rsp_upiu indirections, which are __le32 arrays always cast to given structures and just add the members directly. Also clean up variables names in use in the callers a bit to make the code more readable. Signed-off-by: Christop

[PATCH v9 5/8] scsi: ufs: Use data structure size in pointer arithmetic

2018-10-07 Thread Avri Altman
Use the structure size in pointer arithmetic's instead of an opaque 32 bytes for the over allocation of descriptors. Signed-off-by: Avri Altman Reviewed-by: Christoph Hellwig --- drivers/scsi/ufs/ufs.h| 2 +- drivers/scsi/ufs/ufshcd.c | 3 +-- 2 files changed, 2 insertions(+), 3 deletions(-

[PATCH v9 6/8] scsi: ufs: Add API to execute raw upiu commands

2018-10-07 Thread Avri Altman
The UFS host software uses a combination of a host register set, and Transfer Request Descriptors in system memory to communicate with host controller hardware. In its mmio space, a separate places are assigned to UTP Transfer Request Descriptor ("utrd") list, and to UTP Task Management Request Des

[PATCH 1/3] scsi: Allow state transitions from OFFLINE to BLOCKED

2018-10-07 Thread Hannes Reinecke
From: Hannes Reinecke When an RSCN gets delayed (or not being sent at all) the transport class will detect an error, EH kicks in, and eventually will be setting the device to offline. If we receive an RSCN after that the device will stay in 'offline'. This patch allows for an 'offline' to 'blocke

[PATCH 3/3] libfc: retry PRLI if we cannot analyse the payload

2018-10-07 Thread Hannes Reinecke
From: Hannes Reinecke When we fail to analyse the payload of a PRLI response we should reset the state machine to retry the PRLI; eventually we will be getting a proper frame. Not doing so will result in a stuck state machine and the port never to be presented to the systsm. Suggested-by: Chad D

[PATCH 0/3] libfc state machine fixes

2018-10-07 Thread Hannes Reinecke
Hi all, here are some patches for PRLI issues in libfc we've come across recently. The libfc ones are pretty straightforward, but the scsi state machine one probably warrants some discussion. What happened was that in some fabrics the RSCN might get lost or incompletely reseived. This will then ca

[PATCH 2/3] libfc: check fc_frame_payload_get() return value for null

2018-10-07 Thread Hannes Reinecke
From: Thomas Abraham We should not assume the payload of a PRLI or PLOGI respons is always present. Signed-off-by: Thomas Abraham Reviewed-by: Hannes Reinecke --- drivers/scsi/libfc/fc_rport.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/drivers/scsi/lib