Re: -Wswitch Clang warnings in drivers/scsi

2018-10-04 Thread Nathan Chancellor
On Thu, Oct 04, 2018 at 02:16:49PM -0700, Nick Desaulniers wrote: > On Thu, Oct 4, 2018 at 11:45 AM Nathan Chancellor > wrote: > > > > On Thu, Oct 04, 2018 at 11:34:29AM -0700, Bart Van Assche wrote: > > > On Thu, 2018-10-04 at 11:30 -0700, Nathan Chancellor wrote: > > > > Hi SCSI folks, > > > > >

RE: [PATCH v8 0/8] scsi: Add ufs bsg endpoint

2018-10-04 Thread Bean Huo (beanhuo)
Hi, Avri >We tested it on a Hikey-960 platform with a V4.14 kernel, "modernized" by >recent bsg and ufs patches. Which kernel version is V8 based on? I patched to 4.14-rc7, it failed.

Re: -Wswitch Clang warnings in drivers/scsi

2018-10-04 Thread Nick Desaulniers
On Thu, Oct 4, 2018 at 11:45 AM Nathan Chancellor wrote: > > On Thu, Oct 04, 2018 at 11:34:29AM -0700, Bart Van Assche wrote: > > On Thu, 2018-10-04 at 11:30 -0700, Nathan Chancellor wrote: > > > Hi SCSI folks, > > > > > > In an effort to get the kernel building warning free with Clang, we've > >

Re: -Wswitch Clang warnings in drivers/scsi

2018-10-04 Thread Nathan Chancellor
On Thu, Oct 04, 2018 at 11:34:29AM -0700, Bart Van Assche wrote: > On Thu, 2018-10-04 at 11:30 -0700, Nathan Chancellor wrote: > > Hi SCSI folks, > > > > In an effort to get the kernel building warning free with Clang, we've > > come across an interesting occurrence in a few scsi drivers: > > > >

Re: -Wswitch Clang warnings in drivers/scsi

2018-10-04 Thread Bart Van Assche
On Thu, 2018-10-04 at 11:30 -0700, Nathan Chancellor wrote: > Hi SCSI folks, > > In an effort to get the kernel building warning free with Clang, we've > come across an interesting occurrence in a few scsi drivers: > > drivers/scsi/hpsa.c:6533:7: warning: overflow converting case value to switch

-Wswitch Clang warnings in drivers/scsi

2018-10-04 Thread Nathan Chancellor
Hi SCSI folks, In an effort to get the kernel building warning free with Clang, we've come across an interesting occurrence in a few scsi drivers: drivers/scsi/hpsa.c:6533:7: warning: overflow converting case value to switch condition type (2148024833 to 18446744071562609153) [-Wswitch]

Re: [PATCH 0/7] hisi_sas: Misc bugfixes and an optimisation patch

2018-10-04 Thread John Garry
On 24/09/2018 16:06, John Garry wrote: This patchset introduces mostly more minor/obscure bugfixes for the driver. Hi Martin, Can you please consider merging this patchset? Thanks, John Also included is an optimisation to use the block layer tag for the IPTT indexing. This quite a nice opt

Re: [SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller

2018-10-04 Thread John Garry
On 04/10/2018 09:28, Colin Ian King wrote: Hi, Static analysis from CoverityScan (CID#114178 "Operands don't affect result") detected an issue in drivers/scsi/pmcraid.c, function pmcraid_init_res_table with the following check: if (pinstance->cfg_table->flags & MICROCODE_UPDATE_REQUIRED

Re: [PATCH V14 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-10-04 Thread Sayali Lokhande
On 9/24/2018 3:33 PM, Avri Altman wrote: obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o ufshcd-core-objs := ufshcd.o ufs-sysfs.o +obj-$(CONFIG_SCSI_UFS_PROVISION) += ufs-configfs.o Isn't ufs-configfs should be part of ufshcd-core? like ufs-sysfs ? Agree.

[PATCH -next] scsi: lpfc: Remove set but not used variables 'tgtp'

2018-10-04 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/lpfc/lpfc_debugfs.c: In function 'lpfc_debugfs_nodelist_data': drivers/scsi/lpfc/lpfc_debugfs.c:553:29: warning: variable 'tgtp' set but not used [-Wunused-but-set-variable] It never used since 2b65e18202fd ("scsi: lpfc: NVME Target: Ad

Re: [PATCH 7/7] mpt3sas: Remove unused macro MPT3SAS_FMT

2018-10-04 Thread Suganath Prabu Subramani
Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:33 PM Joe Perches wrote: > > All the uses have been removed, delete the macro. > > Signed-off-by: Joe Perches > --- > drivers/scsi/mpt3sas/mpt3sas_base.h | 2 -- > 1 file changed, 2 deletions(-) > > di

Re: [PATCH 6/7] mpt3sas: Convert logging uses with MPT3SAS_FMT without logging levels

2018-10-04 Thread Suganath Prabu Subramani
Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:33 PM Joe Perches wrote: > > Convert these uses to ioc_ where appropriate. > > Signed-off-by: Joe Perches > --- > drivers/scsi/mpt3sas/mpt3sas_base.c | 41 > +++- > dr

Re: [PATCH 5/7] mpt3sas: Remove KERN_WARNING from panic uses

2018-10-04 Thread Suganath Prabu Subramani
Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > Remove the logging level as panic calls stop the machine and should > always be emitted regardless of requested logging level. > > These existing panic uses are perhaps inappropr

[PATCH -next] scsi: lpfc: use correct maxch in lpfc_debugfs_nvmestat_data

2018-10-04 Thread YueHaibing
'maxch' should be used rather than 'phba->cfg_nvme_io_channel' Fixes:66a210ffb877 ("scsi: lpfc: Add per io channel NVME IO statistics") Signed-off-by: YueHaibing --- drivers/scsi/lpfc/lpfc_debugfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/lpfc/lpfc_debugf

Re: [PATCH 4/7] mpt3sas: Convert logging uses with MPT3SAS_FMT and reply_q_name to %s:

2018-10-04 Thread Suganath Prabu Subramani
Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > Convert the existing 2 uses to make the format and arguments > matching more obvious. > > Miscellanea: > > o Move the word "enabled" into the format to trivially reduce object si

Re: [PATCH 3/7] mpt3sas: Convert mlsleading uses of pr_ with MPT3SAS_FMT

2018-10-04 Thread Suganath Prabu Subramani
Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > These have misordered uses of __func__ and ioc->name that could > mismatch MPT3SAS_FMT and "%s: ". > > Convert them to ioc_. > > Signed-off-by: Joe Perches > --- > drivers/

Re: [PATCH 2/7] mpt3sas: Convert uses of pr_ with MPT3SAS_FMT to ioc_

2018-10-04 Thread Suganath Prabu Subramani
Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > Use a more common logging style. > > Done using the perl script below and some typing > > $ git grep --name-only -w MPT3SAS_FMT -- "*.c" | \ > xargs perl -i -e 'local $/; w

Re: [PATCH 1/7] mpt3sas: Add ioc_ logging macros

2018-10-04 Thread Suganath Prabu Subramani
Hi, Please consider this patch as Acked-by: Suganath Prabu Thanks. On Mon, Sep 17, 2018 at 8:31 PM Joe Perches wrote: > > These macros can help identify specific logging uses and eventually > perhaps reduce object sizes. > > Signed-off-by: Joe Perches > --- > drivers/scsi/mpt3sas/mpt3sas_base.

Re: [SCSI] pmcraid: PMC-Sierra MaxRAID driver to support 6Gb/s SAS RAID controller

2018-10-04 Thread Colin Ian King
Hi, Static analysis from CoverityScan (CID#114178 "Operands don't affect result") detected an issue in drivers/scsi/pmcraid.c, function pmcraid_init_res_table with the following check: if (pinstance->cfg_table->flags & MICROCODE_UPDATE_REQUIRED) pmcraid_err("IOA requires m

Re: [PATCH V14 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-10-04 Thread Sayali Lokhande
Hi Evan, On 10/3/2018 11:31 PM, Evan Green wrote: On Sun, Sep 23, 2018 at 11:29 PM Sayali Lokhande wrote: This patch adds configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured mult

[PATCH] scsi: aic94xx: mark expected switch fall-throughs

2018-10-04 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Addresses-Coverity-ID: 114988 ("Missing break in switch") Addresses-Coverity-ID: 114989 ("Missing break in switch") Addresses-Coverity-ID: 114990 ("Missing break in switch") Addresses-Cover

[Bug 201313] pm80xx mpi_ssp_completion 1883:SAS Address of IO Failure Drive:

2018-10-04 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=201313 --- Comment #4 from MasterCATZ (masterc...@hotmail.com) --- however it might also have something to do with serial number being read wrong? the drive is an SEAGATE ST33000650NS SM (NA01) Serial # 500605ba00b9be18 but the logs show [11125.2