> On Sep 11, 2018, at 2:22 PM, Laura Abbott wrote:
>
> While reviewing another part of the code, Kees noticed that the
> strncpy of the partition name might not always be NUL terminated. Switch
> to using strscpy which does this safely.
>
> Reported-by: Kees Cook
> Signed-off-by: Laura Abbot
Hi Ming
On 09/17/2018 07:35 PM, Ming Lei wrote:
> On Mon, Sep 17, 2018 at 10:46:34AM +0800, jianchao.wang wrote:
>> Hi Ming
>>
>> On 09/14/2018 07:33 PM, Ming Lei wrote:
>>> On Fri, Sep 14, 2018 at 11:40 AM jianchao.wang
>>> wrote:
Hi Ming
On 09/13/2018 08:15 PM, Ming Lei wrot
> On Sep 11, 2018, at 2:22 PM, Laura Abbott wrote:
>
> There's currently a warning about string overflow with strncat:
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
> bound 64 equals d
> On Sep 17, 2018, at 1:03 PM, Bart Van Assche wrote:
>
> External Email
>
> On 9/17/18 12:07 PM, Madhani, Himanshu wrote:
>>
>>> On Sep 15, 2018, at 9:53 PM, Bart Van Assche wrote:
>>>
>>> External Email
>>>
>>> On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git a/drivers/scsi/qla2
On 9/17/18 12:07 PM, Madhani, Himanshu wrote:
On Sep 15, 2018, at 9:53 PM, Bart Van Assche wrote:
External Email
On 09/14/18 14:28, Himanshu Madhani wrote:
diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
index 036cc3f217b1..f1539d8b68ef 100644
--- a/drivers/scsi/qla
> On Sep 16, 2018, at 6:42 AM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> From: Anil Gurumurthy
>>
>> This patch adds LS handling into driver
>
> Please make the patch description more clear. What does "LS" stand for?
> What is the relationshi
> On Sep 15, 2018, at 9:53 PM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/Kconfig b/drivers/scsi/qla2xxx/Kconfig
>> index 036cc3f217b1..f1539d8b68ef 100644
>> --- a/drivers/scsi/qla2xxx/Kconfig
>> +++ b/drivers/s
Hi Bart,
> On Sep 15, 2018, at 9:50 PM, Bart Van Assche wrote:
>
> External Email
>
> On 09/14/18 14:28, Himanshu Madhani wrote:
>> diff --git a/drivers/scsi/qla2xxx/qla_nvmet.c
>> b/drivers/scsi/qla2xxx/qla_nvmet.c
>> new file mode 100644
>> [ ... ]
>> +#if IS_ENABLED(CONFIG_NVME_TARGET_FC)
On Fri, Sep 14, 2018 at 11:36 PM Nathan Chancellor
wrote:
>
> Clang warns when multiple pairs of parentheses are used for a single
> conditional statement.
>
> drivers/message/fusion/mptbase.c:338:11: warning: equality comparison
> with extraneous parentheses [-Wparentheses-equality]
> if
Add support to those uic commands, that are currently supported
by ufshcd api: the variants of dme_{peer}_{set_get}.
At this point better not to add any new api, as careless
uic command may turn the device into a brick.
Signed-off-by: Avri Altman
---
drivers/scsi/ufs/ufs_bsg.c | 54
Do that for the currently supported UPIUs:
query, nop out, and task management.
We do not support UPIU of type scsi command yet, while
we are using the job's request and reply pointers to hold
the payload. We will look into it in later patches.
We might need to elaborate the raw upiu api for that
The UFS host software uses a combination of a host register set,
and Transfer Request Descriptors in system memory to communicate
with host controller hardware. In its mmio space, a separate places
are assigned to UTP Transfer Request Descriptor ("utrd") list, and
to UTP Task Management Request Des
Add a bsg endpoint that supports UPIUs.
For now, just provide an API to allocate and remove
ufs-bsg node. We will use this framework to
manage ufs devices by sending UPIU transactions.
For the time being, implements an empty bsg_request() -
will add some more functionality in coming patches.
Non
From: Christoph Hellwig
Add a helper that takes a utp_task_req_desc and issues it, which will
be useful for UFS bsg support. Rewrite ufshcd_issue_tm_cmd0x to use
this new helper.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/ufs/ufshcd.c | 141 -
From: Christoph Hellwig
Remove the pointless task_req_upiu and task_rsp_upiu indirections,
which are __le32 arrays always cast to given structures and just add
the members directly. Also clean up variables names in use in the
callers a bit to make the code more readable.
Signed-off-by: Christop
Here is a proposal to use a bsg endpoint to manage ufs devices.
We will do that by adding a bsg device node to the ufs driver,
and use it to send UPIU transactions to the ufs device.
It will serve as a ufs device management infrastructure,
for device configuration, provisioning, testing and valid
On 9/17/18 8:11 AM, Mike Snitzer wrote:
Moving kfree() into setup_scsi_dh() would require use of a common goto
for cleanup (something parse_path() already has with 'goto bad;').
But having kfree() in parse_path() is cleaner/symmetric since call to
scsi_dh_attached_handler_name() -- and associate
On Mon, Sep 17 2018 at 10:51am -0400,
Bart Van Assche wrote:
> On 9/17/18 7:20 AM, Mike Snitzer wrote:
> >>- Avoid that m->hw_handler_name becomes a dangling pointer if the
> >> RETAIN_ATTACHED_HW_HANDLER flag is set and scsi_dh_attach() returns
> >> -EBUSY.
> >
> >What is the concern about a
All the uses have been removed, delete the macro.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_base.h
index 941a4faf20be..8f1d6b071b39 100644
--- a/drive
Convert these uses to ioc_ where appropriate.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 41 +++-
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 12 +-
drivers/scsi/mpt3sas/mpt3sas_transport.c | 6 ++---
3 files changed, 28 insertio
These have misordered uses of __func__ and ioc->name that could
mismatch MPT3SAS_FMT and "%s: ".
Convert them to ioc_.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_scsih.c | 50 +++-
drivers/scsi/mpt3sas/mpt3sas_transport.c | 18
2 fil
These macros can help identify specific logging uses and eventually
perhaps reduce object sizes.
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.h | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h
b/drivers/scsi/mpt3sas/mpt3sas_bas
Several defects exist in the logging uses
o Missing KERN_
o Unnecessary KERN_ uses with panic
o Mismatched MPT3SAS_FMT and %s: with name and __func__
Correct these defects and perhaps add some clarity to the logging.
Joe Perches (7):
mpt3sas: Add ioc_ logging macros
mpt3sas: Convert uses of
Convert the existing 2 uses to make the format and arguments
matching more obvious.
Miscellanea:
o Move the word "enabled" into the format to trivially reduce object size
o Remove unnecessary parentheses
Signed-off-by: Joe Perches
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 10 +-
1 file
Remove the logging level as panic calls stop the machine and should
always be emitted regardless of requested logging level.
These existing panic uses are perhaps inappropriate.
Miscellanea:
o Coalesce formats and convert MPT3SAS_FMT to "%s: " to improve clarity
Signed-off-by: Joe Perches
---
On 9/17/18 7:20 AM, Mike Snitzer wrote:
- Avoid that m->hw_handler_name becomes a dangling pointer if the
RETAIN_ATTACHED_HW_HANDLER flag is set and scsi_dh_attach() returns
-EBUSY.
What is the concern about a dangling pointer? How does that manifest?
Stale scsi_dh name stored in hw_hand
[dropping stable@ cc and cc'ing linux-scsi instead]
On Sun, Sep 16 2018 at 11:33pm -0400,
Bart Van Assche wrote:
> This patch fixes two bugs that got introduced recently in setup_scsi_dh():
> - Avoid that a memory leak occurs if attached_handler_name is not assigned
> to m->hw_handler_name.
I
On 09/12/2018 10:29 AM, Jason Yan wrote:
> When the lldd is processing the complete sas task in interrupt and set
> the task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to
> be triggered at the same time. And smp_task_timedout() will complete the
> task wheter the SAS_TASK_STATE_DONE
On 09/12/2018 10:29 AM, Jason Yan wrote:
> When ata device IDENTIFY failed, the ata device status is
> ATA_DEV_UNKNOWN. The libata reported like:
>
> [113518.620433] ata5.00: qc timeout (cmd 0xec)
> [113518.653646] ata5.00: failed to IDENTIFY (I/O error, err_mask=0x4)
>
> But libsas verifies the
On 09/12/2018 10:29 AM, Jason Yan wrote:
> If we went into sas_rediscover_dev() the attached_sas_addr was already
> insured not to be zero. So it's unnecessary to check if the
> attached_sas_addr is zero.
>
> And although if the sas address is not changed, we always have to
> unregister the old de
On 09/12/2018 10:29 AM, Jason Yan wrote:
> We are using lldd_port_deformed so we'd better check if lldd_port_deformed
> is NULL.
>
> After this, we can remove hisi_sas_port_deformed() because it is just a
> stub to avoid a NULL dereference caused by the wrong check.
>
> Signed-off-by: Jason Yan
On 09/12/2018 10:29 AM, Jason Yan wrote:
> This code is dead and no clue implies that it will be back again.
>
> Signed-off-by: Jason Yan
> CC: John Garry
> CC: Johannes Thumshirn
> CC: Ewan Milne
> CC: Christoph Hellwig
> CC: Tomas Henzl
> CC: Dan Williams
> CC: Hannes Reinecke
> Reviewed
On Mon, Sep 17, 2018 at 10:46:34AM +0800, jianchao.wang wrote:
> Hi Ming
>
> On 09/14/2018 07:33 PM, Ming Lei wrote:
> > On Fri, Sep 14, 2018 at 11:40 AM jianchao.wang
> > wrote:
> >>
> >> Hi Ming
> >>
> >> On 09/13/2018 08:15 PM, Ming Lei wrote:
> >>> EXPORT_SYMBOL(__scsi_execute);
> >>> @@ -32
>
> > @@ -5,6 +5,9 @@ obj-$(CONFIG_SCSI_UFS_DWC_TC_PLATFORM) += tc-
> dwc-g210-pltfrm.o ufshcd-dwc.o tc-d
> > obj-$(CONFIG_SCSI_UFS_QCOM) += ufs-qcom.o
> > obj-$(CONFIG_SCSI_UFSHCD) += ufshcd-core.o
> > ufshcd-core-objs := ufshcd.o ufs-sysfs.o
> > +ifeq ($(CONFIG_SCSI_UFS_BSG),y)
> > +ufshcd
On 12/09/2018 09:29, Jason Yan wrote:
When the lldd is processing the complete sas task in interrupt and set
the task stat as SAS_TASK_STATE_DONE, the smp timeout timer is able to
be triggered at the same time. And smp_task_timedout() will complete the
task wheter the SAS_TASK_STATE_DONE is set o
On Wed, 12 Sep 2018 17:08:52 +0200
Arnd Bergmann wrote:
> The .ioctl and .compat_ioctl file operations have the same prototype so
> they can both point to the same function, which works great almost all
> the time when all the commands are compatible.
>
> One exception is the s390 architecture,
On 12/09/2018 09:29, Jason Yan wrote:
This code is dead and no clue implies that it will be back again.
Signed-off-by: Jason Yan
CC: John Garry
CC: Johannes Thumshirn
CC: Ewan Milne
CC: Christoph Hellwig
CC: Tomas Henzl
CC: Dan Williams
CC: Hannes Reinecke
Reviewed-by: Johannes Thumshirn
On 12/09/2018 09:29, Jason Yan wrote:
We are using lldd_port_deformed so we'd better check if lldd_port_deformed
is NULL.
After this, we can remove hisi_sas_port_deformed() because it is just a
stub to avoid a NULL dereference caused by the wrong check.
Signed-off-by: Jason Yan
Acked-by: Joh
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/qla2xxx/qla_iocb.c: In function 'qla24xx_els_dcmd2_iocb':
> drivers/scsi/qla2xxx/qla_iocb.c:2644:13: warning:
> variable 'ptr_dma' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue. Thanks!
--
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/lpfc/lpfc_nvme.c: In function 'lpfc_new_nvme_buf':
> drivers/scsi/lpfc/lpfc_nvme.c:2238:24: warning:
> variable 'sgl_size' set but not used [-Wunused-but-set-variable]
> int bcnt, num_posted, sgl_size;
>
40 matches
Mail list logo
