[PATCH] scsi: mptfusion: Remove unnecessary parentheses and simplify null checks

2018-09-14 Thread Nathan Chancellor
Clang warns when multiple pairs of parentheses are used for a single conditional statement. drivers/message/fusion/mptbase.c:338:11: warning: equality comparison with extraneous parentheses [-Wparentheses-equality] if ((ioc == NULL)) ^~~ drivers/message/fusion/mptbase.

[PATCH] scsi: lpfc: Fix a possible sleep-in-atomic-context bug in lpfc_mbuf_alloc()

2018-09-14 Thread Jia-Ju Bai
The driver may sleep with holding a spinlock. The function call path (from bottom to top) in Linux-4.17 is: [FUNC] dma_pool_alloc(GFP_KERNEL) drivers/scsi/lpfc/lpfc_mem.c, 400: dma_pool_alloc in lpfc_mbuf_alloc drivers/scsi/lpfc/lpfc_els.c, 228: lpfc_mbuf_alloc in lpfc_prep_els_i

[PATCH] scsi: lpfc: Fix a sleep-in-atomic-context bug in lpfc_unreg_rpi()

2018-09-14 Thread Jia-Ju Bai
The driver may sleep in an interrupt handler. The function call path (from bottom to top) in Linux-4.17 is: [FUNC] mempool_alloc(GFP_KERNEL) drivers/scsi/lpfc/lpfc_hbadisc.c, 4738: mempool_alloc in lpfc_unreg_rpi drivers/scsi/lpfc/lpfc_els.c, 2825: lpfc_unreg_rpi in lpfc_issue_el

[PATCH] scsi: lpfc: Fix three sleep-in-atomic-context bugs in lpfc_prep_els_iocb()

2018-09-14 Thread Jia-Ju Bai
The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.17 are: [FUNC] kmalloc(GFP_KERNEL) drivers/scsi/lpfc/lpfc_els.c, 205: kmalloc in lpfc_prep_els_iocb drivers/scsi/lpfc/lpfc_els.c, 2010: lpfc_prep_els_iocb in lpfc_issue_els_plogi

[PATCH] scsi: lpfc: Fix three sleep-in-atomic-context bugs in lpfc_sli4_nvmet_alloc()

2018-09-14 Thread Jia-Ju Bai
The driver may sleep with holding a spinlock. The function call paths (from bottom to top) in Linux-4.17 are: [FUNC] kzalloc(GFP_KERNEL) drivers/scsi/lpfc/lpfc_mem.c, 633: kzalloc in lpfc_sli4_nvmet_alloc drivers/scsi/lpfc/lpfc_sli.c, 6729: [FUNC_PTR]lpfc_sli4_nvmet_alloc in lpfc

.Investment Portfolio

2018-09-14 Thread Ahmad Alothman
Hi, I have contacted you earlier concerning this Info. I work for a consortium with reserve block funds mapped out for sponsorship of projects. We are open to negotiation with people with genuine projects that needs direct LONG TERM LOAN or PARTNERSHIP INVESTMENT and if agreement is reached, funds

[PATCH AUTOSEL 4.18 88/92] blk-mq: avoid to synchronize rcu inside blk_cleanup_queue()

2018-09-14 Thread Sasha Levin
From: Ming Lei [ Upstream commit 1311326cf4755c7ffefd20f576144ecf46d9906b ] SCSI probing may synchronously create and destroy a lot of request_queues for non-existent devices. Any synchronize_rcu() in queue creation or destroy path may introduce long latency during booting, see detailed descript

[PATCH AUTOSEL 4.14 53/57] blk-mq: avoid to synchronize rcu inside blk_cleanup_queue()

2018-09-14 Thread Sasha Levin
From: Ming Lei [ Upstream commit 1311326cf4755c7ffefd20f576144ecf46d9906b ] SCSI probing may synchronously create and destroy a lot of request_queues for non-existent devices. Any synchronize_rcu() in queue creation or destroy path may introduce long latency during booting, see detailed descript

Re: [PATCH V3 17/17] block: enable runtime PM for blk-mq

2018-09-14 Thread kbuild test robot
/0day-ci/linux/commits/Ming-Lei/blk-mq-allow-to-pass-default-queue-flags-for-creating-initializing-queue/20180914-162946 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-u0-09150658 (attached as .config) compiler: gcc-5 (Debian 5.5.0-3) 5.4.1

[PATCH 0/6] qla2xxx: Add FC-NVMe Target support

2018-09-14 Thread Himanshu Madhani
This series adds support for FC-NVMe Target. Patch #1 addes new qla_nvmet files for FC-NVMe Target support. Patch #2 adds Kconfig and Makefile changes to prepare code compile. Patch #3, #4 has bulk of changes to handle FC-NVMe Target LS4 processing via Purex pass through path. Patch #4 a

[PATCH 3/6] qla2xxx_nvmet: Add FC-NVMe Target LS request handling

2018-09-14 Thread Himanshu Madhani
From: Anil Gurumurthy This patch adds LS handling into driver Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_dbg.c | 1 + drivers/scsi/qla2xxx/qla_dbg.h | 2 ++ drivers/scsi/qla2xxx

[PATCH 2/6] qla2xxx_nvmet: Added Makefile and Kconfig changes

2018-09-14 Thread Himanshu Madhani
From: Anil Gurumurthy This patch updates kconfig and make file to include compilation of new NVMe Target files Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/Kconfig | 1 + drivers/scsi/qla2xxx/Makefile | 3 ++- 2 fil

[PATCH 6/6] qla2xxx: Update driver version to 11.00.00.00-k

2018-09-14 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 12bafff71a1a..0d58aa629c08 100644 --- a/drivers/scsi/qla2xxx/qla_version.h

[PATCH 1/6] qla2xxx_nvmet: Add files for FC-NVMe Target support

2018-09-14 Thread Himanshu Madhani
From: Anil Gurumurthy This patch adds initial files to enable NVMe Target Support Signed-off-by: Anil Gurumurthy Signed-off-by: Giridhar Malavali Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_nvmet.c | 780 +++ d

[PATCH 5/6] qla2xxx_nvmet: Add SysFS node for FC-NVMe Target

2018-09-14 Thread Himanshu Madhani
From: Anil Gurumurthy This patch adds SysFS node for NVMe Target configuration Signed-off-by: Anil Gurumurthy Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_attr.c | 33 + drivers/scsi/qla2xxx/qla_gs.c| 2 +- drivers/scsi/qla2xxx/qla_init.c

[PATCH 4/6] qla2xxx_nvmet: Add FC-NVMe Target handling

2018-09-14 Thread Himanshu Madhani
From: Anil Gurumurthy This patch Adds following code in the driver to support FC-NVMe Target - Updated ql2xenablenvme to allow FC-NVMe Target operation - Added LS Request handling for NVMe Target - Added passthr IOCB for LS4 request - Added CTIO for sending response to FW - Added FC4 Registratio

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-14 Thread Al Viro
On Fri, Sep 14, 2018 at 01:35:06PM -0700, Darren Hart wrote: > Acked-by: Darren Hart (VMware) > > As for a longer term solution, would it be possible to init fops in such > a way that the compat_ioctl call defaults to generic_compat_ioctl_ptrarg > so we don't have to duplicate this boilerplate

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-14 Thread Darren Hart
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH v4] libata: Add hwmon support for SMART temperature sensors

2018-09-14 Thread Douglas Gilbert
On 2018-09-14 02:20 PM, James Bottomley wrote: On Thu, 2018-09-13 at 16:22 +0200, Linus Walleij wrote: [...] + /* Send ATA command to read SMART values */ + memset(scsi_cmd, 0, sizeof(scsi_cmd)); + scsi_cmd[0] = ATA_16; + scsi_cmd[1] = (4 << 1); /* PIO Data-in */ +

Re: [PATCH v4] libata: Add hwmon support for SMART temperature sensors

2018-09-14 Thread James Bottomley
On Thu, 2018-09-13 at 16:22 +0200, Linus Walleij wrote: [...] > + /* Send ATA command to read SMART values */ > + memset(scsi_cmd, 0, sizeof(scsi_cmd)); > + scsi_cmd[0] = ATA_16; > + scsi_cmd[1] = (4 << 1); /* PIO Data-in */ > + /* > +  * No off.line or cc, read from dev, bl

Re: [PATCH v2 05/17] compat_ioctl: move more drivers to generic_compat_ioctl_ptrarg

2018-09-14 Thread David Sterba
On Wed, Sep 12, 2018 at 05:08:52PM +0200, Arnd Bergmann wrote: > The .ioctl and .compat_ioctl file operations have the same prototype so > they can both point to the same function, which works great almost all > the time when all the commands are compatible. > > One exception is the s390 architect

Re: [PATCH RFC] scsi: ufs: Disable blk-mq for now

2018-09-14 Thread Adrian Hunter
On 14/09/18 09:17, Adrian Hunter wrote: > On 14/09/18 04:52, Ming Lei wrote: >> On Thu, Sep 13, 2018 at 03:15:39PM +0300, Adrian Hunter wrote: >>> On 13/09/18 15:05, Ming Lei wrote: On Thu, Sep 13, 2018 at 02:28:48PM +0300, Adrian Hunter wrote: > blk-mq does not support runtime pm, so disa

Re: [PATCH V3 11/17] SCSI: track pending admin commands

2018-09-14 Thread Ming Lei
On Fri, Sep 14, 2018 at 11:40 AM jianchao.wang wrote: > > Hi Ming > > On 09/13/2018 08:15 PM, Ming Lei wrote: > > EXPORT_SYMBOL(__scsi_execute); > > @@ -3246,6 +3251,7 @@ static int scsi_internal_device_block(struct > > scsi_device *sdev) > > else > > scsi_wai

Re: [PATCH] scsi: mpt3sas: make sysfs error messages ratelimited

2018-09-14 Thread Joe Perches
On Fri, 2018-09-07 at 11:39 +0100, Colin King wrote: > From: Colin Ian King > > It is possible to heavily spam the kernel logs with messages by > excessive reading of the mpt3sas sysfs files. Make the error messages > ratelimited to reduce the spamming effect. [] > diff --git a/drivers/scsi/mpt3

[PATCH] scsi: core: drop excess unlikely() from BUG_ON()

2018-09-14 Thread Nicholas Mc Guire
include/asm-generic/bug.h defines BUG_ON(condition) as do { if (unlikely(condition)) BUG(); } while (0). So BUG_ON already provides unlikely() to the condition so there is no point in having a unlikely(unlikely(condition)) - drop the excess unlikely() Signed-off-by: Nicholas Mc Guire --- Found d

Re: [PATCH V3 17/17] block: enable runtime PM for blk-mq

2018-09-14 Thread kbuild test robot
/linux/commits/Ming-Lei/blk-mq-allow-to-pass-default-queue-flags-for-creating-initializing-queue/20180914-162946 base: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next config: x86_64-randconfig-x003-201836 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce

[PATCH -next] scsi: lpfc: Remove set but not used variables 'fc_hdr' and 'hw_page_size'

2018-09-14 Thread YueHaibing
Fixes gcc '-Wunused-but-set-variable' warning: drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_sp_handle_rcqe': drivers/scsi/lpfc/lpfc_sli.c:13430:26: warning: variable 'fc_hdr' set but not used [-Wunused-but-set-variable] drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_cq_create': drivers/

[PATCH V13 1/2] scsi: ufs: set the device reference clock setting

2018-09-14 Thread Sayali Lokhande
From: Subhash Jadavani UFS host supplies the reference clock to UFS device and UFS device specification allows host to provide one of the 4 frequencies (19.2 MHz, 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the device reference clock frequency setting in the device based on wha

[PATCH V13 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-09-14 Thread Sayali Lokhande
This patch adds configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during initial system development phase. Configuration Descriptors can be written multiple times unti

[PATCH V13 0/2] Add UFS provisioning support in driver

2018-09-14 Thread Sayali Lokhande
This patch adds Configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during initial system development phase. Configuration Descriptors can be written multiple times un

Re: [PATCH V12 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-09-14 Thread Sayali Lokhande
On 9/12/2018 6:44 PM, Adrian Hunter wrote: On 30/08/18 13:46, Sayali Lokhande wrote: This patch adds configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during init

Re: [PATCH v3 2/2] scsi: ufs: Add UFS platform driver for Cadence UFS

2018-09-14 Thread Janek Kotas
> On 29 Aug 2018, at 12:27, Sekhar Nori wrote: > > On Thursday 09 August 2018 06:55 PM, Janek Kotas wrote: >> This patch adds a device tree platform driver for >> Cadence UFS Host Controller. >> It can be enabled with SCSI_UFS_CDNS_PLATFORM Kconfig option. >> >> Signed-off-by: Jan Kotas > > [

Re: [PATCH -next] scsi: pm80xx: Remove set but not used variable 'page_code'

2018-09-14 Thread Jinpu Wang
On Fri, Sep 14, 2018 at 3:29 AM YueHaibing wrote: > > Fixes gcc '-Wunused-but-set-variable' warning: > > drivers/scsi/pm8001/pm80xx_hwi.c: In function 'pm8001_set_phy_profile': > drivers/scsi/pm8001/pm80xx_hwi.c:4679:6: warning: > variable 'page_code' set but not used [-Wunused-but-set-variable]