Fixes gcc '-Wunused-but-set-variable' warning:
drivers/scsi/bnx2fc/bnx2fc_fcoe.c: In function 'bnx2fc_rcv':
drivers/scsi/bnx2fc/bnx2fc_fcoe.c:435:17: warning:
variable 'oxid' set but not used [-Wunused-but-set-variable]
Signed-off-by: YueHaibing
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 3 ---
1
Colin,
> From: Colin Ian King
>
> Trival fix to spelling mistakes:
> PrimativeSeqErrCount -> PrimitiveSeqErrCount
> Primative -> Primitive
> primative -> primitive
> mptsas_broadcast_primative_work -> mptsas_broadcast_primitive_work
> Broadcase -> Broadcast
Applied to 4.20/scsi-queue.
--
Viswas,
> This patch set include some bug fixes for pm80xx driver.
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> From: Colin Ian King
>
> Trivial fix to typo in debug message text.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> We should first do the le16_to_cpu endian conversion and then apply
> the FCP_CMD_LENGTH_MASK mask.
Applied to 4.19/scsi-fixes, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Variable num_chip_names is defined but not used, hence it is
> redundant and can be removed.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
YueHaibing,
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/scsi/libfc/fc_fcp.c: In function 'fc_queuecommand':
> drivers/scsi/libfc/fc_fcp.c:1875:30: warning:
> variable 'rpriv' set but not used [-Wunused-but-set-variable]
Applied to 4.20/scsi-queue. Thank you!
--
Martin K. Pet
Geert,
> Signed-off-by: Geert Uytterhoeven
> ---
> drivers/scsi/arcmsr/arcmsr_hba.c | 20 ++--
> 1 file changed, 10 insertions(+), 10 deletions(-)
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Matthew,
> I don't think that's worth doing. Let's keep the patch simple like
> this.
Applied to 4.20/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
James,
> This patch contains lpfc bug fixes, a couple of performance mods, and
> a new diagnostic ability
Applied to 4.20/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This patch series fixes issues found during our testing for qla2xxx.
Also applied. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series updates driver for ABTS handling and rport management.
>
> Please queue this patches to 4.20/scsi-misc at your earliest convenience.
Applied to 4.20/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This series contains support for ZIO interrupt threashold and
> cleanups.
Applied!
--
Martin K. Petersen Oracle Linux Engineering
On Tue, Sep 11, 2018 at 5:36 PM Arnd Bergmann wrote:
>
> On Sun, Sep 9, 2018 at 6:38 AM Al Viro wrote:
> >
> > On Sat, Sep 08, 2018 at 04:28:17PM +0200, Arnd Bergmann wrote:
> > > MTIOCPOS and MTIOCGET are incompatible between 32-bit and 64-bit user
> > > space, and traditionally have been transl
On Tue, Sep 11, 2018 at 12:22 PM, Laura Abbott wrote:
>
> While reviewing another part of the code, Kees noticed that the
> strncpy of the partition name might not always be NUL terminated. Switch
> to using strscpy which does this safely.
>
> Reported-by: Kees Cook
> Signed-off-by: Laura Abbott
Hi,
This is (hopefully) the last version of the string fixups found in the
ibmvscsi driver.
Laura Abbott (2):
scsi: ibmvscsis: Fix a stringop-overflow warning
scsi: ibmvscsis: Ensure partition name is properly NUL terminated
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c | 5 ++---
1 file changed
While reviewing another part of the code, Kees noticed that the
strncpy of the partition name might not always be NUL terminated. Switch
to using strscpy which does this safely.
Reported-by: Kees Cook
Signed-off-by: Laura Abbott
---
v2: Switch to strscpy instead of just strlcpy
---
drivers/sc
There's currently a warning about string overflow with strncat:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
bound 64 equals destination size [-Werror=stringop-overflow=]
strncat(vscsi->eye,
On Tue, Sep 11, 2018 at 11:24 AM, Kees Cook wrote:
> On Tue, Sep 11, 2018 at 11:05 AM, Laura Abbott wrote:
>>
>> There's currently a warning about string overflow with strncat:
>>
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
>> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt
On Tue, Sep 11, 2018 at 11:15 AM, Laura Abbott wrote:
> While reviewing another part of the code, Kees noticed that the
> strncpy of the partition name might not always be NUL terminated. Switch
> to using strlcpy which does this safely.
>
> Reported-by: Kees Cook
> Signed-off-by: Laura Abbott
>
On Tue, Sep 11, 2018 at 11:05 AM, Laura Abbott wrote:
>
> There's currently a warning about string overflow with strncat:
>
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
> drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
> bound 64 equals des
While reviewing another part of the code, Kees noticed that the
strncpy of the partition name might not always be NUL terminated. Switch
to using strlcpy which does this safely.
Reported-by: Kees Cook
Signed-off-by: Laura Abbott
---
I realized looking at this that I probably should have made
thi
There's currently a warning about string overflow with strncat:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c:3479:2: error: 'strncat' specified
bound 64 equals destination size [-Werror=stringop-overflow=]
strncat(vscsi->eye,
On 09/11/2018 07:34 AM, Bryant G. Ly wrote:
On 9/10/18 6:30 PM, Kees Cook wrote:
On Mon, Sep 10, 2018 at 3:37 PM, Laura Abbott wrote:
There's currently a warning about string overflow with strncat:
drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c: In function 'ibmvscsis_probe':
drivers/scsi/ibmvscsi
Hi Martin,
This patch series fixes issues found during our testing for qla2xxx.
Please apply this series to 4.20/scsi-queue at your earliest.
Thanks,
Himanshu
Darren Trapp (1):
qla2xxx: Allow FC-NVMe underrun to be handled by transport
Himanshu Madhani (1):
qla2xxx: Update driver version
From: Quinn Tran
remove stale debug trace.
Fixes: 1eb42f965ced ("qla2xxx: Make trace flags more readable")
Cc: sta...@vger.kernel.org #4.10
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/tcm_qla2xxx.c | 4
1 file changed, 4 deletions(-)
diff --git a/d
From: Quinn Tran
Add ability to allow each physical port to control operating mode.
Current code forces all ports to behave in one mode (i.e. initiator,
target or dual). This patch allows user to select the operating
mode for each port.
- Driver must be loaded in dual mode to allow resource allo
From: Quinn Tran
Task abort can take 2 paths: 1) serial/synchronous abort
where the calling thread will put to sleep, wait for completion
and free cmd resource. 2) async abort where the cmd free will
be free by the completion thread. For path 2, driver is freeing
the SRB too early.
Fixes: f614
From: Quinn Tran
if chip unable to fully initialize, use full shutdown
sequence to clear out any stale FW state.
Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data structure
refactoring")
Cc: sta...@vger.kernel.org #4.10
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
From: Quinn Tran
Abort IOCB request can take up to 40s or 2 ABTS timeout.
We will wait for ABTS response for 20s. On a timeout, second
ABTS can go out with another 20s timeout. On 2nd ABTS timeout
FW will automatically do Logout.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
d
From: Quinn Tran
Clear port speed value on chip reset.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/scsi/qla2xxx/qla_init.c
index 096743331ec4..4d0460
From: Quinn Tran
Current code relies on switch to provide a unique combination
of WWPN + NPORTID to tract an FC port. This patch tries to detect
a case where switch data base can get corrupted where multiple WWPNs
can have the same Nport ID. The 1st Nport ID on the list will be
kept while the d
From: Quinn Tran
This patch fixes issue when switch command fails, current code
increments retry count twice. This results into less number
of retries.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 37 +
1 fil
From: Quinn Tran
When qla2xxx and Target Core gets out of sync, during
command cleanup, qla2xxx will not free command until
it is out of firmware's hand and Target Core has called
the release on the command.
This patch adds synchronization using cmd_lock and release flag.
if the release flag is
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 9559f1836170..12bafff71a1a 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++
From: Sawan Chandak
During adapter shutdown process check for register disconnect
before proceeding to call PCI functions.
Signed-off-by: Sawan Chandak
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_os.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/qla2xxx/ql
From: Quinn Tran
For Loop topology + Initiator, FW is in control of PLOGI/PRLI.
When link is reset, driver will try to cleanup the session by
doing an Implicit Logout. Instead, the code is doing an
Explicit Logout. The explicit logout interferes with FW state
machine in trying to reconnect. Th
From: Quinn Tran
When FW rejects a command due to "entry_status" error
(malform IOCB), the srb resource needs to be return back
for cleanup. The filter to catch this is in the wrong
location.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 2 +-
From: Quinn Tran
On PLOGI complete + RSCN received, driver tries
to handle RSCN but failed to reset the session back
to the beginning to restart the login process. Instead
the session was left in the Plogi complete without
moving forward. This patch will push the session state
back to the delete
From: Quinn Tran
Reject bsg request if chip is down. This prevent erroneous
timeout.
Fixes: d051a5aa1c23 ("[SCSI] qla2xxx: Add an "is reset active" helper.")
Cc: sta...@vger.kernel.org # 4.10
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_bsg.c | 2 +-
From: Darren Trapp
This patch allows FC-NVMe under-run to be handled by transport
Signed-off-by: Darren Trapp
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_isr.c | 34 +-
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/drivers/scs
Hi,
If you have photos for editing, please send email to: hansre...@outlook.com
We have 12 in house image editors and we can help you for cutting out your
photos, or path the photos.
Includes retouching if needed.
Used for products photos or portrait photos, catalog photos.
You may drop us one
On Tue, Sep 11, 2018 at 10:48 AM Viswas G wrote:
>
> From: Deepak Ukey
>
> Added proper mask for phy id in mpi_phy_stop_resp().
>
> V2:
> -Initialized the PM8001F_RUN_TIME flag in
> pm8001_pci_probe().
> -Differentiated PHY_LINK_UP state fo
From: Deepak Ukey
For the function dma_unmap_sg(), the parameter should be
number of elements in the scatter list prior to the mapping, not
after the mapping.
Signed-off-by: Deepak Ukey
Signed-off-by: Viswas G
Acked-by: Jack Wang
---
drivers/scsi/pm8001/pm8001_sas.c | 2 +-
1 file changed,
From: Deepak Ukey
When the firmware is not responding, execution of kexec boot
causes a system hang. When firmware assertion happened, driver
get notified with interrupt vector updated in MPI configuration
table. Then, the driver will read scratchpad register and
set controller_fatal_error flag t
From: Deepak Ukey
Updated the driver version from 0.1.38 to 0.1.39.
Signed-off-by: Deepak Ukey
Signed-off-by: Viswas G
Acked-by: Jack Wang
---
drivers/scsi/pm8001/pm8001_sas.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/pm8001/pm8001_sas.h b/drivers/scsi
From: Deepak Ukey
This patch set include some bug fixes for pm80xx driver.
Changes from V1:
For "Fix for phy enable/disable functionality" patch,
-Initialized the PM8001F_RUN_TIME flag in pm8001_pci_probe().
-Differentiated PHY_LINK_UP state for SPC and SP
From: Deepak Ukey
Added proper mask for phy id in mpi_phy_stop_resp().
V2:
-Initialized the PM8001F_RUN_TIME flag in
pm8001_pci_probe().
-Differentiated PHY_LINK_UP state for SPC and SPCv
controller.
-Used
49 matches
Mail list logo
