Re: [Patch v1 0/7] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-08-30 Thread Andy Shevchenko
+Cc: Lukas (I think he might be interested to look at this) On Fri, Aug 31, 2018 at 7:37 AM Suganath Prabu S wrote: > > Posting below set of patches to support PCIe Hot Plug surprise removal, > and few defect fixes. > > This is NOT the normal PCIe Hot Plug support, whereby the user informs the >

[Patch v1 5/7] mpt3sas: Fix Sync cache command failure during driver unload.

2018-08-30 Thread Suganath Prabu S
This is to fix Sync cache and start stop command failures with DID_NO_CONNECT during driver unload. 1) Release drives first from SML, then remove internally in driver. 2) And allow sync cache and Start stop commands to firmware, even when remove_host flag is set Signed-off-by: Suganath Prabu S

[Patch v1 1/7] mpt3sas: Introduce mpt3sas_base_pci_device_is_unplugged

2018-08-30 Thread Suganath Prabu S
* Driver does a PCIe read to check whether HBA is hot unplugged or not. If the returned vendor ID is 0x/0x0, then this indicates that the device might have been hot removed and the device will be removed from driver. * In the PCI device remove() callback function, flush out all the outstan

[Patch v1 2/7] mpt3sas: Add HBA hot plug watchdog thread.

2018-08-30 Thread Suganath Prabu S
During driver load create a hba hot unplug watchdog thread "_base_hba_hot_unplug_work". This will poll whether HBA device is unplugged or not by reading IOC's vendor field in IOC's PCI configuration space for every one second. If hot unplug is detected, it terminates all the outstanding IOs and h

[Patch v1 6/7] mpt3sas: Fix driver modifying NVRAM/persistent data.

2018-08-30 Thread Suganath Prabu S
* If EEDPTagMode field in manufacturing page11 is set, unset it. This is needed to fix a hardware bug in SAS3/SAS2 cards, So, skipping EEDPTagMode changes in Manufacturing page11 for SAS35 controllers. * Fix driver modifying NVRAM/persistent data in Manufacturing page11 along with current copy. Dr

[Patch v1 0/7] mpt3sas: Hot-Plug Surprise removal support on IOC.

2018-08-30 Thread Suganath Prabu S
Posting below set of patches to support PCIe Hot Plug surprise removal, and few defect fixes. This is NOT the normal PCIe Hot Plug support, whereby the user informs the OS that a hot removal is desired, the OS does an orderly shutdown of the driver on the device, special hot plug circuitry removes

[Patch v1 3/7] mpt3sas: Seperate out mpt3sas_wait_for_ioc_to_operational

2018-08-30 Thread Suganath Prabu S
Introduce mpt3sas_wait_for_ioc_to_operational. This section of code "wait for IOC to be operational" is used in many places across the driver, and hence moved this section of code in to the function "mpt3sas_wait_for_ioc_to_operational". Also added HBA hot unplug checks, and this returns with err

[Patch v1 7/7] mpt3sas: Bump driver version to 27.100.00.00.

2018-08-30 Thread Suganath Prabu S
Modify driver version to 27.100.00.00 (which is equivalent to PH8 OOB driver) Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_base.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.h b/drivers/scsi/mpt3sas/mpt3sas_base.h

[Patch v1 4/7] mpt3sas: Introdude _scsih_get_shost_and_ioc.

2018-08-30 Thread Suganath Prabu S
The code for getting shost and IOC is redundant so moved that to function "scsih_get_shost_and_ioc". Also checks for NULL are added to IOC and shost. Signed-off-by: Suganath Prabu S --- drivers/scsi/mpt3sas/mpt3sas_scsih.c | 98 ++-- 1 file changed, 82 insertions(

Re: [PATCH v3] target/iblock: split T10 PI SGL across command bios

2018-08-30 Thread Mike Christie
On 08/30/2018 12:25 PM, Greg Edwards wrote: > When T10 PI is enabled on a backing device for the iblock backstore, the > PI SGL for the entire command is attached to the first bio only. This > works fine if the command is covered by a single bio, but can result in > ref tag errors in the client fo

Re: [PATCH 1/7] mpt3sas: Introduce mpt3sas_base_pci_device_is_unplugged (fwd)

2018-08-30 Thread Julia Lawall
broadcom.com, sreekanth.re...@broadcom.com, Suganath Prabu S Hi Suganath, I love your patch! Perhaps something to improve: [auto build test WARNING on scsi/for-next] [also build test WARNING on v4.19-rc1 next-20180830] [if your patch is applied to the wrong git tree, please drop us a note to help

[PATCH v3] target/iblock: split T10 PI SGL across command bios

2018-08-30 Thread Greg Edwards
When T10 PI is enabled on a backing device for the iblock backstore, the PI SGL for the entire command is attached to the first bio only. This works fine if the command is covered by a single bio, but can result in ref tag errors in the client for the other bios in a multi-bio command, e.g. [ 4

[PATCH 09/14] qla2xxx: Force fw cleanup on ADISC error

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran Turn ON logout_on_delete flag to make sure firmware resource for fcport is cleaned up on ADISC error. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qla2xxx/qla_

[PATCH 13/14] qla2xxx: Terminate Plogi/PRLI if WWN is 0

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran When driver receive PLOGI/PRLI from FW, the WWPN value will be provided. If it is not, then driver will terminate it. The WWPN allows driver to locate the session or create a new session. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_

[PATCH 11/14] qla2xxx: Fix iIDMA error

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran when switch responds with error for Get Port Speed Command (GPSC), driver should not proceed with telling FW about the speed of the remote port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 4 ++-- 1 file changed, 2 insertions(

[PATCH 03/14] qla2xxx: Use correct qpair for ABTS/CMD

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran On Abort of initiator scsi command, the abort needs to follow the same qpair as the the scsi command to prevent out of order processing. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 15 +-- drivers/scsi/qla2xxx/ql

[PATCH 06/14] qla2xxx: Move rport registration out of internal work_list

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran Currently, the rport registration is being called from a single work element that is used to process QLA internal "work_list". This work_list is meant for quick and simple task (ie no sleep). The Rport registration process sometime can be delayed by upper layer. This causes back

[PATCH 02/14] qla2xxx: Fix incorrect port speed being set for FC adapters

2018-08-30 Thread Himanshu Madhani
Fixes: 6246b8a1d26c7c ("[SCSI] qla2xxx: Enhancements to support ISP83xx.") Fixes: 1bb395485160d2 ("qla2xxx: Correct iiDMA-update calling conventions.") Cc: Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_mbx.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/d

[PATCH 07/14] qla2xxx: Decrement login retry count for only plogi

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran Decrement login retry count only for plogi, instead of number of attempt made for login. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 18 +- 1 file changed, 5 insertions(+), 13 deletions(-) diff --git a/drive

[PATCH 04/14] qla2xxx: Update rscn_rcvd field to more meaningful scan_needed

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran Rename rscn_rcvd field to scan_needed to be more meaningful. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 2 +- drivers/scsi/qla2xxx/qla_gs.c | 12 ++-- drivers/scsi/qla2xxx/qla_init.c | 2 +- 3 files changed, 8 i

[PATCH 05/14] qla2xxx: Remove redundant check for fcport deletion

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran Remove redundant check for fcport is deleted or being delete. The same check is already in the deletion routine. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 62 +++ 1 file changed, 9 ins

[PATCH 10/14] qla2xxx: Remove all rports if fabric scan retry fails

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran When all fabric scan retries fail, remove all RPorts, DMA resources for the command otherwise we have stale Rports. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 128 +- 1 file changed, 64

[PATCH 14/14] qla2xxx: Update driver to version 10.00.00.09-k

2018-08-30 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 3850b28518e5..0dbba38c408f 100644 --- a/drivers/scsi/qla2xxx/qla_version.h +++

[PATCH 08/14] qla2xxx: Turn off IOCB timeout timer on IOCB completion

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran Turn off IOCB timeout timer on IOCB completion instead of turning it off in a deferred task. This prevent false alarm if the deferred task is stalled out. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_gs.c | 8 +--- 1 file changed

[PATCH 12/14] qla2xxx: Defer chip reset until target mode is enabled

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran For target mode, any chip reset is triggered before target mode is enabled will be hold off until user is ready to enable. This prevents the chip from starting or running before it is intended. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xx

[PATCH 01/14] qla2xxx: Fix process response queue for ISP26XX and above

2018-08-30 Thread Himanshu Madhani
From: Quinn Tran This patch improves performance for 16G and above adaper by removing additional call to process_response_queue(). Cc: Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_init.c | 2 -- drivers/scsi/qla2xxx/qla_iocb.c | 17 -

[PATCH 00/14] qla2xxx: Driver updates for scsi-misc

2018-08-30 Thread Himanshu Madhani
Hi Martin, This series updates driver for ABTS handling and rport management. Please queue this patches to 4.20/scsi-misc at your earliest convenience. Thanks, Himanshu Himanshu Madhani (2): qla2xxx: Fix incorrect port speed being set for FC adapters qla2xxx: Update driver to version 10.0

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

2018-08-30 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199435 goldyfruit (gaetan.tre...@incloudus.com) changed: What|Removed |Added CC||gaetan.tre...@i

Re: [PATCH v2] target/iblock: split T10 PI SGL across command bios

2018-08-30 Thread Greg Edwards
On Wed, Aug 29, 2018 at 06:23:52PM -0500, Mike Christie wrote: > > Can you still hit the issue where t_prot_nents > BIO_MAX_PAGES so > bio_integrity_alloc fails or is t_prot_nents always going to be smaller. > Was wondering why you dropped that from the last patch. There was a vhost bug that was a

Re: [PATCH] libfc: remove unnecessary condition check

2018-08-30 Thread Martin K. Petersen
Chengguang, > kmem_cache_destroy() can handle NULL pointer correctly, so there is > no need to check NULL pointer before calling kmem_cache_destroy() Applied to 4.20/scsi-queue, thank you. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: lpfc: remove an unnecessary NULL check

2018-08-30 Thread Martin K. Petersen
Dan, > Smatch complains about this code: > > drivers/scsi/lpfc/lpfc_scsi.c:1053 lpfc_get_scsi_buf_s4() > warn: variable dereferenced before check 'lpfc_cmd' (see line 1039) > > Fortunately the NULL check isn't required so I have removed it. Applied to 4.20/scsi-queue, thank you! -- Ma

Re: [PATCH] scsi: 53c700: Fix spelling of 'NEGOTIATION'

2018-08-30 Thread Martin K. Petersen
Faisal, > 'NEGOTIATION' was misspelled as 'NEGOTATION'. Fixed it. It is a coding > style change which should have no impact on runtime execution of code. Applied to 4.20/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] qedi: Add the CRC size within iSCSI NVM image

2018-08-30 Thread Martin K. Petersen
Nilesh, > The QED driver commit, 1ac4329 qed: Add configuration information to > register dump and debug data, removes the CRC length validation > causing nvm_get_image failure while loading qedi driver, > > [qed_mcp_get_nvm_image:2700(host_10-0)]Image [0] is too big - 6008 > bytes where onl

Re: [PATCH 0/2] iscsi target: login fixes

2018-08-30 Thread Martin K. Petersen
Mike, > The following patches are login fixes from the list. The set has been > rebased against Linus's current tree so they apply over the idr/ida > patches that have been merged. Applied to 4.19/scsi-fixes, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH V12 1/2] scsi: ufs: set the device reference clock setting

2018-08-30 Thread Sayali Lokhande
From: Subhash Jadavani UFS host supplies the reference clock to UFS device and UFS device specification allows host to provide one of the 4 frequencies (19.2 MHz, 26 MHz, 38.4 MHz, 52 MHz) for reference clock. Host should set the device reference clock frequency setting in the device based on wha

[PATCH V12 0/2] Add UFS provisioning support in driver

2018-08-30 Thread Sayali Lokhande
This patch adds Configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during initial system development phase. Configuration Descriptors can be written multiple times un

[PATCH V12 2/2] scsi: ufs: Add configfs support for UFS provisioning

2018-08-30 Thread Sayali Lokhande
This patch adds configfs support to provision UFS device at runtime. This feature can be primarily useful in factory or assembly line as some devices may be required to be configured multiple times during initial system development phase. Configuration Descriptors can be written multiple times unti