On Wed, Jul 18, 2018 at 7:38 PM, Bart Van Assche wrote:
> On Wed, 2018-07-18 at 01:22 -0400, Sreekanth Reddy wrote:
>> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
>> i.e. driver should reset smid value to zero after decrementing chain_offset
>> counter in chain_lookup
On 07/18/2018 07:15 PM, Mike Christie wrote:
> On 07/18/2018 05:19 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> diff --git a/drivers/target/target_core_transport.c
>>> b/drivers/target/target_core_transport.c
>>> index 75ddbbb..97a1ee5 100644
>>> --- a/
On 07/18/2018 06:04 PM, Mike Christie wrote:
> On 07/18/2018 05:41 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> Export the initiator port info in configfs
>>
>> Does configfs support soft links? Can this information be exported as a
>> soft link from the
On 07/18/2018 07:03 PM, Mike Christie wrote:
> On 07/18/2018 05:09 PM, Bart Van Assche wrote:
>> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>>> The isid is 48 bits, and in hex string format it's 12 bytes.
>>> We are currently copying the 12 byte hex string to a u64
>>> so we can easily
On 07/18/2018 05:46 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> + int (*test_session)(struct se_session *, u8 timeout);
>
> Does any of the patches in this series define a test_session callback
> function?
Patch 14 does.
>
> What is the unit of
On 07/18/2018 05:19 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> diff --git a/drivers/target/target_core_transport.c
>> b/drivers/target/target_core_transport.c
>> index 75ddbbb..97a1ee5 100644
>> --- a/drivers/target/target_core_transport.c
>> +++ b/driv
On 07/18/2018 05:09 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> The isid is 48 bits, and in hex string format it's 12 bytes.
>> We are currently copying the 12 byte hex string to a u64
>> so we can easily compare it, but this has the problem that
>> only
On 07/18/2018 05:41 PM, Bart Van Assche wrote:
> On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
>> Export the initiator port info in configfs
>
> Does configfs support soft links? Can this information be exported as a
> soft link from the session directory to the struct se_portal_group co
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> + int (*test_session)(struct se_session *, u8 timeout);
Does any of the patches in this series define a test_session callback
function?
What is the unit of the timeout parameter? 1/HZ, ms or s?
Thanks,
Bart.
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> Export the initiator port info in configfs
Does configfs support soft links? Can this information be exported as a
soft link from the session directory to the struct se_portal_group configfs
object?
Thanks,
Bart.
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> +static void target_fabric_session_release(struct config_item *item)
> +{
> + struct se_session *se_sess = container_of(to_config_group(item),
> + struct se_session, group);
> + target_re
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> This adds a function to remove a session which should be used by
> drivers that use target_setup_session.
>
> All the drivers but iscsi and tcm_fc were doing calling
> transport_deregister_session_configfs and then immediately calling
> tra
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> Rename target_alloc_session to target_setup_session to avoid
> confusion with the other transport session allocation
> function that only allocates the session and because
> the target_alloc_session does so more. It allocates the
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> transport_init_session_tags is only called from target_core_transport.c
> so make it static.
Reviewed-by: Bart Van Assche
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> sess_get_index is meaninless for most drivers. For iscsi, it
^^
meaningless?
> is the same as the se_session->sid now and for fcoe it was just
> the port id which would not work if multiple ini
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> diff --git a/drivers/target/target_core_transport.c
> b/drivers/target/target_core_transport.c
> index 75ddbbb..97a1ee5 100644
> --- a/drivers/target/target_core_transport.c
> +++ b/drivers/target/target_core_transport.c
> @@ -55,6 +55,8 @@
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> When __transport_register_session is called from
> transport_register_session irqs will already have been disabled,
> so we do not want the unlock irq call to enable them until
> the higher level has done the final
> spin_unlock_irqrestore/s
On Sun, 2018-07-15 at 18:16 -0500, Mike Christie wrote:
> The isid is 48 bits, and in hex string format it's 12 bytes.
> We are currently copying the 12 byte hex string to a u64
> so we can easily compare it, but this has the problem that
> only 8 bytes of the 12 bytes are copied.
>
> The next pat
From: Quinn Tran
After selecting the NPort handle/loop_id, set a bit
in the loop_id_map to prevent others from selecting the same
NPort handle.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gbl.h | 1 +
drivers/scsi/qla2xxx/qla_init.c | 27 ++
From: Anil Gurumurthy
Propagate the task management completion status properly to avoid
unnecessary waits for commands to complete.
Fixes: faef62d13463 ("[SCSI] qla2xxx: Fix Task Management command asynchronous
handling")
Cc:
Signed-off-by: Anil Gurumurthy
Signed-off-by: Himanshu Madhani
---
Hi Martin,
This patch series fixes issues with load/unload of the driver in a loop.
Please apply this series for 4.18/scsi-fixes at your earliest convenience
to be included in 4.18.0-rc6.
Thanks,
Himanshu
Anil Gurumurthy (1):
qla2xxx: Return error when TMF returns
Quinn Tran (4):
qla2xxx
From: Quinn Tran
Prevent multiple registration with transport layer for
the same remote port.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_init.c | 18 +-
1 file changed, 5 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/qla2
From: Quinn Tran
Use chip shutdown at the start of unload to stop all
DMA + traffics and bring down the laser. This prevents
any link activities from triggering the driver to be
re-engaged.
Fixes: 4b60c82736d0 ("scsi: qla2xxx: Add fw_started flags to qpair")
Cc: #4.16
Signed-off-by: Quinn Tran
From: Quinn Tran
During unload process, the chip can encounter problem
where a FW dump would be captured. For this case, the
full reset sequence will be skip to bring the chip
back to full operational state.
Fixes: e315cd28b9ef ("[SCSI] qla2xxx: Code changes for qla data structure
refactoring")
From: Quinn Tran
Add wait for session deletion to finish before freeing
an NPIV scsi host.
Fixes: 726b85487067 ("qla2xxx: Add framework for async fabric discovery")
Cc:
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 1 +
drivers/scsi/qla2xxx/q
From: Quinn Tran
In case of IOCB Queue full or system where memory is low and
driver receives large number of RSCN storm, the stale sp pointer
can stay on gpnid_list resulting in page_fault.
This patch fixes this issue by initializing the sp->elem list head
and removing sp->elem before memory is
From: Quinn Tran
Driver uses shadow pointer instead of Mirror pointer
for firmware dump collection. Skip those entries for
Mirror pointers for Request/Response queue from
firmware dump template reading.
Following messages are printed in log messages
kernel: qla2xxx [:81:00.0]-d82b:19: qla2
From: Quinn Tran
This patch sets discovery state back to GNL (Get
Name List) when session is stuck at GPDB (Get Port
DataBase). This will allow state machine to retry
login and move session state ahead in discovery.
Signed-off-by: Quinn Tran
---
drivers/scsi/qla2xxx/qla_init.c | 9 ++---
1
From: Quinn Tran
Fix race condition between switch cmd completion and timeout
timer. Timer has popped triggers command free. On IOCB completion,
stale sp point was reused. Instead, an abort will be sent to FW
to nudge the command out of FW, where the normal completion
will take place.
RIP: 0010:
From: Quinn Tran
During normal IO, FW can return IO with 'port unavailble' status.
Driver would send a LOGO to remote port for session resync. On
an off chance, a PLOGI could arrive before sending the LOGO.
This patch will skip sendiing LOGO, if a PLOGI just came in.
Signed-off-by: Quinn Tran
From: Quinn Tran
Prevent user from sending commands through SysFS while
FW is not running or reset is in progress.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_attr.c | 33 +++--
drivers/scsi/qla2xxx/qla_init.c | 2 +-
From: Quinn Tran
Flush pending mailbox commands on chip reset. Wake up
command that's waiting for an interrupt and wait for
mailbox counters to go to zero.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_def.h | 4
drivers/scsi/qla2xxx/qla_init.c
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_version.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/qla2xxx/qla_version.h
b/drivers/scsi/qla2xxx/qla_version.h
index 1ad7582220c3..3850b28518e5 100644
--- a/drivers/scsi/qla2xxx/qla_version.h
+++
From: Quinn Tran
In case of N2N connect, when sg_regset for bus/device/host
was causing driver and firmware state to go out of sync.
This patch fixes this link instablity when reconnect is
attempted after link flap.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/ql
From: Quinn Tran
The qla2x00_reset_active only cover the window of
turning the chip off, add check to cover Chip on.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_dbg.c | 3 +++
drivers/scsi/qla2xxx/qla_tmpl.c | 4 +++-
2 files changed, 6 insertions(+
From: Quinn Tran
Login retry count was not properly decrementing,
which lead to endless login retry.
Signed-off-by: Quinn Tran
Signed-off-by: Himanshu Madhani
---
drivers/scsi/qla2xxx/qla_gs.c | 16 +++
drivers/scsi/qla2xxx/qla_init.c | 23 +++---
drivers/scsi/qla2xxx/qla_mbx.c
Hi Martin,
This series contains bug-fixes for driver mainly in the area of interaction
with switch and small patch for N2N link reconnect.
Please apply this serise to 4.19/scsi-queue at your earliest convenience.
Thanks,
Himanshu
Himanshu Madhani (1):
qla2xxx: Update driver version to 10.00.0
https://bugzilla.kernel.org/show_bug.cgi?id=199703
Roberto M. (roby_program...@fastwebnet.it) changed:
What|Removed |Added
Status|NEW |RESOLVED
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #28 from Roberto M. (roby_program...@fastwebnet.it) ---
> Can you try to update your firmware on the disk controllers with HP SPP and
> see if it helps?
It solved my problem! thank you!, you are better than RHEL support, on their
faq
https://bugzilla.kernel.org/show_bug.cgi?id=199703
--- Comment #27 from Roberto M. (roby_program...@fastwebnet.it) ---
(In reply to Don from comment #25)
> I was able to take the kernel.org driver and load over a P400, which I
> believe is older than your E200.
>
> The E200 requires a working cac
Le Fri, 15 Jan 2016 12:48:09 +0100
Emmanuel Florac écrivait:
> Le Thu, 14 Jan 2016 15:12:53 -0500 (EST)
> Laurence Oberman écrivait:
>
> > All attempts to get my drive and changer firmware updated have
> > failed. So I wont be able to add another "tested by" to this thread
> > unless I can find
On Wed, 2018-07-18 at 01:22 -0400, Sreekanth Reddy wrote:
> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
> i.e. driver should reset smid value to zero after decrementing chain_offset
> counter in chain_lookup table but in current code, driver is resetting smid
> value be
On 07/18/2018 07:22 AM, Sreekanth Reddy wrote:
> In mpt3sas_base_clear_st() function smid value is reseted in wrong line,
> i.e. driver should reset smid value to zero after decrementing chain_offset
> counter in chain_lookup table but in current code, driver is resetting smid
> value before decrem
43 matches
Mail list logo
