Re: [PATCH 06/40] proc: introduce proc_create_single{,_data}

On Wed, 25 Apr 2018, Christoph Hellwig wrote: > > -/* > - * /proc/nubus stuff > - */ > - I don't think that the introduction of proc_create_single{,_data} alters the value of that comment. That comment and similar comments in the same file do have a purpose, which is to keep separate the /pro

Re: simplify procfs code for seq_file instances

On Tue, Apr 24, 2018 at 06:06:53PM +0200, Christoph Hellwig wrote: > On Tue, Apr 24, 2018 at 08:19:16AM -0700, Andrew Morton wrote: > > > > I want to ask if it is time to start using poorman function overloading > > > > with _b_c_e(). There are millions of allocation functions for example, > > > >

RE: [GIT PULL] SCSI fixes for 4.17-rc2

James, The mpt3sas should be changed to mptsas. Just responding back to have record on this problem is with old mptsas and not with mpt3sas managed controllers. Thanks Sathya -Original Message- From: linux-scsi-ow...@vger.kernel.org [mailto:linux-scsi-ow...@vger.kernel.org] On Behalf Of

[GIT PULL] SCSI fixes for 4.17-rc2

8 bug fixes, one spelling update and one tracepoint addition. The most serious is probably the mpt3sas write same fix because it means anyone using these controllers sees errors when modern filesystems try to issue discards (if the drive supports the WRITE SAME variant). The patch is available he

Re: [PATCH] aacraid: Correct hba_send to include iu_type

On 04/25/2018 10:24 AM, Dave Carroll wrote: > commit b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()") > > allows aac_hba_send() to send scsi commands, and TMF requests, but the > existing > code only updates the iu_type for scsi commands. For TMF requests we are > sending >

Re: [PATCH 27/40] rtc/proc: switch to proc_create_single_data

On 25/04/2018 17:48:14+0200, Christoph Hellwig wrote: > And stop trying to get a reference on the submodule, procfs code deals > with release after and unloaded module and thus removed proc entry. small typo here^ > > Signed-off-by: Christoph Hellwig Acked-by: Alexandre Belloni > ---

[PATCH 03/40] proc: add a proc_create_reg helper

Common code for creating a regular file. Factor out of proc_create_data, to be reused by other functions soon. Signed-off-by: Christoph Hellwig --- fs/proc/generic.c | 44 +--- fs/proc/internal.h | 2 ++ 2 files changed, 27 insertions(+), 19 deletions(-

[PATCH 01/40] net/can: single_open_net needs to be paired with single_release_net

Otherwise we will leak a reference to the network namespace. Signed-off-by: Christoph Hellwig --- net/can/bcm.c | 2 +- net/can/proc.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/net/can/bcm.c b/net/can/bcm.c index ac5e5e34fee3..8073fa14e143 100644 --- a/net/can/b

simplify procfs code for seq_file instances V2

We currently have hundreds of proc files that implement plain, read-only seq_file based interfaces. This series consolidates them using new procfs helpers that take the seq_operations or simple show callback directly. A git tree is available at: git://git.infradead.org/users/hch/misc.git pro

[PATCH 05/40] proc: introduce proc_create_seq_private

Variant of proc_create_data that directly take a struct seq_operations argument + a private state size and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- fs/locks.c | 16 ++-- fs/proc/

[PATCH] aacraid: Correct hba_send to include iu_type

commit b60710ec7d7ab ("aacraid: enable sending of TMFs from aac_hba_send()") allows aac_hba_send() to send scsi commands, and TMF requests, but the existing code only updates the iu_type for scsi commands. For TMF requests we are sending an unknown iu_type to firmware, which causes a fault. Inclu

[PATCH 04/40] proc: introduce proc_create_seq{,_data}

Variants of proc_create{,_data} that directly take a struct seq_operations argument and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- arch/ia64/hp/common/sba_iommu.c | 15 +- arch/ia64/kernel/perfmon.c

[PATCH 07/40] ipv{4,6}/udp{,lite}: simplify proc registration

Remove a couple indirections to make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- include/net/udp.h | 20 -- net/ipv4/udp.c | 99 +- net/ipv4/udplite.c | 21 +++--- net/ipv6/udp.c | 30 +

[PATCH 10/40] ipv{4,6}/raw: simplify ѕeq_file code

Pass the hashtable to the proc private data instead of copying it into the per-file private data. Signed-off-by: Christoph Hellwig --- include/net/raw.h | 4 net/ipv4/raw.c| 36 net/ipv6/raw.c| 6 -- 3 files changed, 16 insertions(+), 30 de

[PATCH 08/40] ipv{4,6}/tcp: simplify procfs registration

Avoid most of the afinfo indirections and just call the proc helpers directly. Signed-off-by: Christoph Hellwig --- include/net/tcp.h | 11 ++ net/ipv4/tcp_ipv4.c | 85 + net/ipv6/tcp_ipv6.c | 27 +- 3 files changed, 53 insertions(+),

[PATCH 14/40] net: move seq_file_single_net to

This helper deals with single_{open,release}_net internals and thus belongs here. Signed-off-by: Christoph Hellwig --- include/linux/seq_file_net.h | 13 + include/net/ip_vs.h | 12 2 files changed, 13 insertions(+), 12 deletions(-) diff --git a/include/linux/s

[PATCH 13/40] netfilter/x_tables: simplify ѕeq_file code

Just use the address family from the proc private data instead of copying it into per-file data. Signed-off-by: Christoph Hellwig --- net/netfilter/x_tables.c | 39 +++ 1 file changed, 11 insertions(+), 28 deletions(-) diff --git a/net/netfilter/x_tables.c b/

[PATCH 15/40] proc: introduce proc_create_net{,_data}

Variants of proc_create{,_data} that directly take a struct seq_operations and deal with network namespaces in ->open and ->release. All callers of proc_create + seq_open_net converted over, and seq_{open,release}_net are removed entirely. Signed-off-by: Christoph Hellwig --- drivers/net/ppp/pp

[PATCH 11/40] ipv6/flowlabel: simplify pid namespace lookup

The shole seq_file sequence already operates under a single RCU lock pair, so move the pid namespace lookup into it, and stop grabbing a reference and remove all kinds of boilerplate code. Signed-off-by: Christoph Hellwig --- net/ipv6/ip6_flowlabel.c | 28 +--- 1 file cha

[PATCH 17/40] acpi/battery: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig Reviewed-by: Rafael J. Wysocki --- drivers/acpi/battery.c | 121 +

[PATCH 16/40] proc: introduce proc_create_net_single

Variant of proc_create_data that directly take a seq_file show callback and deals with network namespaces in ->open and ->release. All callers of proc_create + single_open_net converted over, and single_{open,release}_net are removed entirely. Signed-off-by: Christoph Hellwig --- fs/proc/proc_ne

[PATCH 09/40] ipv{4,6}/ping: simplify proc file creation

Remove the pointless ping_seq_afinfo indirection and make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- include/net/ping.h | 11 -- net/ipv4/ping.c| 50 +- net/ipv6/ping.c| 35 +---

[PATCH 19/40] megaraid: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_single. Signed-off-by: Christoph Hellwig --- drivers/scsi/megaraid.c | 140 +++- drivers/scsi/megaraid.h | 12 --

[PATCH 20/40] sg: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/scsi/sg.c | 124 +- 1 file changed, 12

[PATCH 21/40] afs: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/afs/proc.c | 134 ++ 1 file changed, 15

[PATCH 22/40] ext4: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/ext4/ext4.h| 2 +- fs/ext4/mballoc.c | 29 fs/ext4/sy

[PATCH 29/40] hostap: switch to proc_create_{seq,single}_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- .../net/wireless/intersil/hostap/hostap_ap.c | 70 ++--- .../net/wireless/intersil/hostap/hostap_hw.c | 17 +-- .../wireless/intersil/hostap/hostap_proc.c| 143 +++-

[PATCH 30/40] neigh: switch to proc_create_seq_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- net/core/neighbour.c | 31 ++- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/net/core/neighbour.c b/net/core/neighbour.c index ce51

[PATCH 25/40] resource: switch to proc_create_seq_data

And use the root resource directly from the proc private data. Signed-off-by: Christoph Hellwig --- kernel/resource.c | 43 +-- 1 file changed, 5 insertions(+), 38 deletions(-) diff --git a/kernel/resource.c b/kernel/resource.c index 2af6c03858b9..b589dda

[PATCH 23/40] jfs: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- fs/jfs/jfs_debug.c| 43 ++- fs/jfs/jfs_debug.h

[PATCH 26/40] drbd: switch to proc_create_single

And stop messing with try_module_get on THIS_MODULE, which doesn't make any sense here. Signed-off-by: Christoph Hellwig --- drivers/block/drbd/drbd_int.h | 2 +- drivers/block/drbd/drbd_main.c | 3 ++- drivers/block/drbd/drbd_proc.c | 34 +- 3 files changed, 4

[PATCH 27/40] rtc/proc: switch to proc_create_single_data

And stop trying to get a reference on the submodule, procfs code deals with release after and unloaded module and thus removed proc entry. Signed-off-by: Christoph Hellwig --- drivers/rtc/rtc-proc.c | 33 ++--- 1 file changed, 2 insertions(+), 31 deletions(-) diff --

[PATCH 32/40] netfilter/x_tables: switch to proc_create_seq_private

And remove proc boilerplate code. Signed-off-by: Christoph Hellwig --- net/netfilter/x_tables.c | 42 ++-- 1 file changed, 6 insertions(+), 36 deletions(-) diff --git a/net/netfilter/x_tables.c b/net/netfilter/x_tables.c index 344dd01a5027..0e314f95a4a3 10064

[PATCH 38/40] ide: remove ide_driver_proc_write

The driver proc file hasn't been writeable for a long time, so this is just dead code. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-proc.c | 46 -- 1 file changed, 46 deletions(-) diff --git a/drivers/ide/ide-proc.c b/drivers/ide/ide-proc.c index

[PATCH 36/40] isdn: replace ->proc_fops with ->proc_show

And switch to proc_create_single_data. Signed-off-by: Christoph Hellwig --- drivers/isdn/capi/kcapi.c | 3 ++- drivers/isdn/gigaset/capi.c| 16 +--- drivers/isdn/hardware/avm/avmcard.h| 4 ++-- drivers/isdn/hardware/avm/b1.c | 17 ++-

[PATCH 40/40] tty: replace ->proc_fops with ->proc_show

Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig --- arch/ia64/hp/sim/simserial.c| 15 +-- arch/xtensa/platforms/iss/console.c | 15 +-- dr

[PATCH 34/40] atm: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- net/atm/proc.c | 65 ++ 1 file changed, 7

[PATCH 39/40] ide: replace ->proc_fops with ->proc_show

Just set up the show callback in the tty_operations, and use proc_create_single_data to create the file without additional boilerplace code. Signed-off-by: Christoph Hellwig --- drivers/ide/ide-cd.c | 15 +--- drivers/ide/ide-disk_proc.c | 62 ++-- drivers/ide/ide-floppy

[PATCH 37/40] proc: don't detour through seq->private to get the inode

Signed-off-by: Christoph Hellwig --- fs/proc/array.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/fs/proc/array.c b/fs/proc/array.c index ae2c807fd719..b34796b562ef 100644 --- a/fs/proc/array.c +++ b/fs/proc/array.c @@ -677,7 +677,7 @@ get_children_pid(s

[PATCH 33/40] bluetooth: switch to proc_create_seq_data

And use proc private data directly instead of doing a detour through seq->private and private state. Signed-off-by: Christoph Hellwig --- net/bluetooth/af_bluetooth.c | 40 +--- 1 file changed, 5 insertions(+), 35 deletions(-) diff --git a/net/bluetooth/af_blueto

[PATCH 35/40] atm: switch to proc_create_seq_private

And remove proc boilerplate code. Signed-off-by: Christoph Hellwig --- net/atm/proc.c | 72 +- 1 file changed, 13 insertions(+), 59 deletions(-) diff --git a/net/atm/proc.c b/net/atm/proc.c index f272b0f59d82..0b0495a41bbe 100644 --- a/net/atm/pro

[PATCH 31/40] netfilter/xt_hashlimit: switch to proc_create_{seq,single}_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- net/netfilter/xt_hashlimit.c | 92 +++- 1 file changed, 18 insertions(+), 74 deletions(-) diff --git a/net/netfilter/xt_hashlimit.c b/net/netfi

[PATCH 24/40] staging/rtl8192u: simplify procfs code

Unwind the registration loop into individual calls. Switch to use proc_create_single where applicable. Signed-off-by: Christoph Hellwig --- drivers/staging/rtl8192u/r8192U_core.c | 67 ++ 1 file changed, 14 insertions(+), 53 deletions(-) diff --git a/drivers/staging/rtl

[PATCH 28/40] bonding: switch to proc_create_seq_data

And use proc private data directly instead of doing a detour through seq->private. Signed-off-by: Christoph Hellwig --- drivers/net/bonding/bond_procfs.c | 36 ++- 1 file changed, 6 insertions(+), 30 deletions(-) diff --git a/drivers/net/bonding/bond_procfs.c b/driv

[PATCH 18/40] sgi-gru: simplify procfs code

Use remove_proc_subtree to remove the whole subtree on cleanup, and unwind the registration loop into individual calls. Switch to use proc_create_seq where applicable. Signed-off-by: Christoph Hellwig --- drivers/misc/sgi-gru/gruprocfs.c | 81 ++-- 1 file changed, 14

[PATCH 12/40] net/kcm: simplify proc registration

Remove a couple indirections to make the code look like most other protocols. Signed-off-by: Christoph Hellwig --- net/kcm/kcmproc.c | 71 --- 1 file changed, 17 insertions(+), 54 deletions(-) diff --git a/net/kcm/kcmproc.c b/net/kcm/kcmproc.c index 1

[PATCH 06/40] proc: introduce proc_create_single{,_data}

Variants of proc_create{,_data} that directly take a seq_file show callback and drastically reduces the boilerplate code in the callers. All trivial callers converted over. Signed-off-by: Christoph Hellwig --- arch/arm/kernel/dma.c | 14 +--- arch/arm/kernel/swp_emulate.

[PATCH 02/40] proc: simplify proc_register calling conventions

Return registered entry on success, return NULL on failure and free the passed in entry. Also expose it in internal.h as we'll start using it in proc_net.c soon. Signed-off-by: Christoph Hellwig --- fs/proc/generic.c | 44 ++-- fs/proc/internal.h | 2 ++

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #19 from lober...@redhat.com --- I was concerned about the agents but Anthony disabled them and still saw this.I have seen this timeout sometimes when the agents probe via passthrough. I did just bump into this reset on a 7.5 RHEL ker

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #18 from Anthony Hausman (anthonyhaussm...@gmail.com) --- Unfortunatly I don't know what process was consuming the CPU cycles at this. I'll try to reproduce the problem to reproduce the problem to have the information. I'm not using s

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #17 from Don (don.br...@microsemi.com) --- (In reply to Anthony Hausman from comment #16) > Don, > > So I'm actually running the kernel 4.16.3 (build 18-04-19) with the hpsa > modules patch to use local work-queue insead of system wor

[PATCH 20/21] qedf: Update copyright for 2018.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/drv_fcoe_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_fcoe_fw_funcs.h | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.c | 2 +- drivers/scsi/qedf/drv_scsi_fw_funcs.h | 2 +- drivers/scsi/qedf/qedf.h | 2 +- drivers/scsi/qedf/qedf_attr.c

[PATCH 18/21] qedf: Set the UNLOADING flag when removing a vport.

Similar to what we do when we remove a PCI function, set the QEDF_UNLOADING flag to prevent any requests from being queued while a vport is being deleted. This prevents any requests from getting stuck in limbo when the vport is unloaded or deleted. Fixes the crash: PID: 106676 TASK: 9a436aa

[PATCH 21/21] qedf: Update version number to 8.33.16.20.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_version.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_version.h b/drivers/scsi/qedf/qedf_version.h index 4a19e6f6d843..9455faacd5de 100644 --- a/drivers/scsi/qedf/qedf_version.h +++ b/drivers/

[PATCH 17/21] qedf: Add additional checks when restarting an rport due to ABTS timeout.

There are a couple of kernel cases when we restart a remote port due to ABTS timeout that we need to handle: 1. Flush any outstanding ABTS requests when flushing I/Os so that we do not hold up the eh_abort handler indefinitely causing process hangs. 2. Check if we are currently uploading a conn

[PATCH 19/21] qedf: Add more defensive checks for concurrent error conditions.

During an uplink toggle test all error handling is done via timeout and firmware error conditions which can occur concurrentl: - SCSI layer timeouts - Error detect CQEs - Firmware detected underruns - ABTS timeouts All these concurrent events require more defensive checks in the driver including:

[PATCH 14/21] qedf: Improve firmware debug dump handling.

Get all firmware debug data instead of just a grc dump. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf.h | 2 ++ drivers/scsi/qedf/qedf_dbg.c | 2 +- drivers/scsi/qedf/qedf_main.c | 13 - 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf

[PATCH 10/21] qedf: Return request as DID_NO_CONNECT if MSI-X is not enabled.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 94d6455c9ddc..78cbd126c7e5 100644 --- a/drivers/scsi/qedf/qedf_io.c +++ b/drivers/scsi/qedf/qedf_io.c @@ -931,6 +

[PATCH 16/21] qedf: If qed fails to enable MSI-X fail PCI probe.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 0150f2e4e75c..31fc64b23566 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf

[PATCH 15/21] qedf: Honor default_prio module parameter even if DCBX does not converge.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 3e9befcbd5ba..0150f2e4e75c 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qed

[PATCH 06/21] qedf: Sanity check FCoE/FIP priority value to make sure it's between 0 and 7.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 8dcacc5b5f60..1a58f4a9cdf9 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@

[PATCH 00/21] qedf: Update driver to 8.33.16.20.

Hi Martin, Please add these patches to your tree for the next kernel merge window at your convenience. Thanks, Chad Chad Dupuis (20): qedf: Synchronize rport restarts when multiple ELS commands time out. qedf: Increase the number of default FIP VLAN request retries to 60. qedf: Add missin

[PATCH 03/21] qedf: Add missing skb frees in error path.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 1 + drivers/scsi/qedf/qedf_main.c | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index 773558fc0697..aef199c12fb4 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b/driv

[PATCH 13/21] qedf: Remove setting DCBX pending during soft context reset.

From: Saurav Kashyap PROBLEM DESCRIPTION: According to the logs STAG was changing and it was triggering soft reset. In soft reset we used to virtual link down and up and also we were disabling DCBx flag. Since this was virtual link flap, DCBx never used to converge again. SOLUTION: Code change

[PATCH 02/21] qedf: Increase the number of default FIP VLAN request retries to 60.

Some configurations need more than 30 seconds to respond to a FIP VLAN request so increase the default to 60 seconds. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/

[PATCH 04/21] qedf: Fix VLAN display when printing sent FIP frames.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_fip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qedf/qedf_fip.c b/drivers/scsi/qedf/qedf_fip.c index aef199c12fb4..c6b984efa5e8 100644 --- a/drivers/scsi/qedf/qedf_fip.c +++ b/drivers/scsi/qedf/qedf_fip.c

[PATCH 05/21] qedf: Add check for offload before flushing I/Os for target.

We need to check that a fcport is offloaded before we try to flush any requests. No doing so could lead to undefined results and most likely a crash. Fixes the oops: [ 343.971886] [:42:00.3]:[qedf_execute_tmf:2070]:8: wait for tm_cmpl timeout! [ 343.971933] BUG: unable to handle kernel pa

[PATCH 01/21] qedf: Synchronize rport restarts when multiple ELS commands time out.

If multiple ELS commands time out, such as aborts, they could all try to restart the same rport and the same time. This could mean multiple multiple processes trying to clean up any outstanding commands or trying to upload the same port. Add a new flag (QEDF_RPORT_IN_RESET) and check other fcport

[PATCH 09/21] qedf: Release RRQ reference correctly when RRQ command times out.

When an RRQ request times out the reference is not getting decremented correctly as there are still ELS commands leftover when we flush any pending I/Os during offload: [ 281.788553] [:21:00.3]:[qedf_cmd_timeout:58]:4: ELS timeout, xid=0x96a. ... [ 281.788553] [:21:00.3]:[qedf_cmd_timeou

[PATCH 11/21] qedf: Check if link is alraedy up when receiving a link up event from qed.

Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index 64491ae60059..866989ccd66e 100644 --- a/drivers/scsi/qedf/qedf_main.c +++ b/drivers/scsi/qedf/qedf_main.c @@ -4

[PATCH 12/21] qedf: Add task id to kref_get_unless_zero() debug messages when flushing requests.

Helps to corroborate which requests we can't get reference on and if it's real bug or not. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_io.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/qedf/qedf_io.c b/drivers/scsi/qedf/qedf_io.c index 78cbd126

[PATCH 08/21] qedf: Honor priority from DCBX FCoE App tag.

We currently hard code the priority in the 8021q tag to 3 for FCoE traffic. The vast majority of the time this is fine but if the priority is something else besides 3, any VLAN ID comparison either in the non-offload path or offload path will fail and cause dropped frames where none are expected.

[PATCH 07/21] qedf: Add dcbx_not_wait module parameter so we won't wait for DCBX convergence to start discovery.

This module parameter is to work around cases where we do not receive the DCBX handler notification from qed but discovery is still possible if we send out a FIP VLAN request irregardless of the DCBX state. Signed-off-by: Chad Dupuis --- drivers/scsi/qedf/qedf_main.c | 11 +-- 1 file cha

Re: Regression 4.17-rc1: SSD doesn’t properly resume causing system hang (NULL pointer dereference)

Dear Bart, On 04/25/18 14:26, Bart Van Assche wrote: On Wed, 2018-04-25 at 07:37 +0200, Paul Menzel wrote: Am 24.04.2018 um 23:17 schrieb Bart Van Assche: On Tue, 2018-04-24 at 23:04 +0200, Paul Menzel wrote: I applied your change, and rebuilt the Linux kernel. Unfortunately, it looks like,

Re: Regression 4.17-rc1: SSD doesn properly resume causing system hang (NULL pointer dereference)

On Wed, 2018-04-25 at 07:37 +0200, Paul Menzel wrote: > Am 24.04.2018 um 23:17 schrieb Bart Van Assche: > > On Tue, 2018-04-24 at 23:04 +0200, Paul Menzel wrote: > > > I applied your change, and rebuilt the Linux kernel. Unfortunately, it > > > looks like, it didn’t make a difference. > > > > In t

[PATCH 4.14 071/183] scsi: devinfo: fix format of the device list

4.14-stable review patch. If anyone has any objections, please let me know. -- From: Xose Vazquez Perez [ Upstream commit 3f884a0a8bdf28cfd1e9987d54d83350096cdd46 ] Replace "" with NULL for product revision level, and merge TEXEL duplicate entries. Cc: Hannes Reinecke Cc: M

[PATCH] scsi: isci: remove redundant check on in_connection_align_insertion_frequency

From: Colin Ian King The sanity check on u->in_connection_align_insertion_frequency is being performed twice and hence the first check can be removed since it is redundant. Cleans up cppcheck warning: drivers/scsi/ibmvscsi/ibmvscsi.c:1711: (warning) Identical inner 'if' condition is always true.

[Bug 199435] HPSA + P420i resetting logical Direct-Access never complete

https://bugzilla.kernel.org/show_bug.cgi?id=199435 --- Comment #16 from Anthony Hausman (anthonyhaussm...@gmail.com) --- Don, So I'm actually running the kernel 4.16.3 (build 18-04-19) with the hpsa modules patch to use local work-queue insead of system work-queue. I have a reproduce a reset wit