When specifying same string type option several times,
current option parsing will cause memory leak. Hence,
call kfree for previous one in this case.
Signed-off-by: Chengguang Xu
---
drivers/target/target_core_configfs.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/target/ta
Nikola,
> thanks for explanation. but disabling write same for now is safe,
> right?
I was hoping we'd be able to disable it for SATA devices only.
> root@siv-70140:~ # sg_vpd /dev/sda
> Supported VPD pages VPD page:
> Supported VPD pages [sv]
> Device identification [di]
> Supported VPD
On Mon, Apr 16, 2018 at 1:44 PM, Kees Cook wrote:
> On Thu, Apr 12, 2018 at 8:02 PM, Kees Cook wrote:
>> On Thu, Apr 12, 2018 at 3:47 PM, Kees Cook wrote:
>>> After fixing up some build issues in the middle of the 4.16 cycle, I
>>> get an unhelpful bisect result of commit 0a4b6e2f80aa ("Merge br
This patch does not change any functionality but makes it clear
that it is on purpose that these fields are 32 bits wide.
Signed-off-by: Bart Van Assche
Cc: Damien Le Moal
Cc: Christoph Hellwig
Cc: Hannes Reinecke
---
drivers/scsi/sd.h | 12 ++--
1 file changed, 6 insertions(+), 6 del
Hello Martin,
This patch series, when combined with the block layer patch that prevents
that the report and reset zone ioctls are executed while a queue is frozen,
prevents that these ioctls fail sporadically with -EIO. Since this race is
relatively easy to trigger with the SMR support for fio tha
Since SCSI scanning occurs asynchronously, since sd_revalidate_disk()
is called from sd_probe_async() and since sd_revalidate_disk() calls
sd_zbc_read_zones() it can happen that sd_zbc_read_zones() is called
concurrently with blkdev_report_zones() and/or blkdev_reset_zones().
That can cause these f
scsi_io_completion() translates the sense key ILLEGAL REQUEST / ASC
0x21 into ACTION_FAIL. That means that setting cmd->allowed to zero
in sd_zbc_complete() for this sense code / ASC combination is not
necessary. Hence remove the code that resets cmd->allowed from
sd_zbc_complete().
Signed-off-by:
https://bugzilla.kernel.org/show_bug.cgi?id=199419
Bug ID: 199419
Summary: mpt3sas triggers KASAN complaint during reboot
Product: SCSI Drivers
Version: 2.5
Kernel Version: v4.17-rc1
Hardware: x86-64
OS: Linux
On Mon, 16 Apr 2018 21:30:54 +
Bart Van Assche wrote:
> Hello Steve,
>
> The tool I'm most concerned about is blktrace. I'm not sure though how this
> tool receives event data from the block layer core.
Yeah, blktrace is "special", it looks like it registers its callbacks
from the tracepoin
On Mon, 2018-04-16 at 17:24 -0400, Steven Rostedt wrote:
> On Mon, 16 Apr 2018 20:49:12 +
> Bart Van Assche wrote:
>
> > Which tools process these strings? Has it been verified whether or not
> > the tools that process these strings still work fine with this patch
> > applied?
>
> Ideally, t
On Mon, 16 Apr 2018 20:49:12 +
Bart Van Assche wrote:
> Which tools process these strings? Has it been verified whether or not
> the tools that process these strings still work fine with this patch
> applied?
Ideally, tools shouldn't process trace event strings, but I'm sure some
do. :-/
Ge
Hello
Greeetings to you please did you get my previous email regarding my
investment proposal last week friday ?
MS.Zeliha ömer faruk
zeliha.omer.fa...@gmail.com
On Mon, 2018-04-16 at 21:10 +, Bean Huo (beanhuo) wrote:
> Hi, Bart
>
> > mi...@redhad.com; linux-bl...@vger.kernel.org; raja...@google.com
> > Subject: [EXT] Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in
> > SCSI
> > trace events
> >
> > On Mon, 2018-04-16 at 14:31 +, Bean H
Hi, Bart
>mi...@redhad.com; linux-bl...@vger.kernel.org; raja...@google.com
>Subject: [EXT] Re: [RESEND PATCH v1 1/2] trace: events: scsi: Add tag in SCSI
>trace events
>
>On Mon, 2018-04-16 at 14:31 +, Bean Huo (beanhuo) wrote:
>> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u
Thanks guys!
Anything else needed for linux-scsi?
Cheers,
Michael
On Mon, Apr 16, 2018 at 10:34 PM, John Paul Adrian Glaubitz
wrote:
> On 04/16/2018 11:26 AM, Christian T. Steigies wrote:
>>
>> On Thu, Apr 12, 2018 at 01:53:26PM +1200, Michael Schmitz wrote:
>>>
>>> From: Michael Schmitz
>
On Mon, 2018-04-16 at 14:33 +, Bean Huo (beanhuo) wrote:
> [ ... ]
> - TP_printk("%d,%d %s (%s) %llu + %u [%d]",
> + TP_printk("%d,%d %s (%s) %llu + %u tag=%d [%d]",
> [ ... ]
> - TP_printk("%d,%d %s (%s) %llu + %u [%d]",
> + TP_printk("%d,%d %s (%s) %llu + %u tag=%d [%d]",
> [
On Mon, 2018-04-16 at 14:31 +, Bean Huo (beanhuo) wrote:
> TP_printk("host_no=%u channel=%u id=%u lun=%u data_sgl=%u prot_sgl=%u" \
> - " prot_op=%s cmnd=(%s %s raw=%s)",
> + " prot_op=%s tag=%d cmnd=(%s %s raw=%s)",
>
> [ ... ]
> TP_printk("host_no=%u c
On Thu, Apr 12, 2018 at 8:02 PM, Kees Cook wrote:
> On Thu, Apr 12, 2018 at 3:47 PM, Kees Cook wrote:
>> After fixing up some build issues in the middle of the 4.16 cycle, I
>> get an unhelpful bisect result of commit 0a4b6e2f80aa ("Merge branch
>> 'for-4.16/block'"). Instead of letting the test
On Mon, 2018-04-16 at 20:27 +, Bean Huo (beanhuo) wrote:
> By the way, these patches are not to add new feature, they are just to
> add print tag along with the other exist printed request parameters.
Are you aware that there are two tag fields in struct request, namely "tag"
and "internal_tag
>>> This patch is not acceptable because it adds support for tag tracing
>>> to the legacy block layer only. Any patch that adds a new feature to
>>> the legacy block layer must also add it to blk-mq.
>>>
>> To be honest, I don't understand your point, can you give me more
>explanation?
>
>The lega
C: linux-ker...@vger.kernel.org
Hi Christoph,
I love your patch! Perhaps something to improve:
[auto build test WARNING on linus/master]
[also build test WARNING on v4.17-rc1 next-20180416]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system]
url:
https://git
On Mon, 16 Apr 2018, Chris Murphy wrote:
> Adding linux-usb@ and linux-scsi@
> (This email does contain the thread initiating email, but some replies
> are on the other lists.)
>
> On Mon, Apr 16, 2018 at 5:43 AM, Austin S. Hemmelgarn
> wrote:
> > On 2018-04-15 21:04, Chris Murphy wrote:
> >>
>
On 04/16/18 10:05, Bean Huo (beanhuo) wrote:
On Mon, 2018-04-16 at 09:41 -0700, Rajat Jain wrote:
On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt
wrote:
On Mon, 16 Apr 2018 14:31:49 +
"Bean Huo (beanhuo)" wrote:
Print the request tag along with other information while tracing a
command
Adding linux-usb@ and linux-scsi@
(This email does contain the thread initiating email, but some replies
are on the other lists.)
On Mon, Apr 16, 2018 at 5:43 AM, Austin S. Hemmelgarn
wrote:
> On 2018-04-15 21:04, Chris Murphy wrote:
>>
>> I just ran into this:
>>
>> https://github.com/neilbrown/
Hi, Bart
>On Mon, 2018-04-16 at 09:41 -0700, Rajat Jain wrote:
>> On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt
>wrote:
>> > On Mon, 16 Apr 2018 14:31:49 +
>> > "Bean Huo (beanhuo)" wrote:
>> >
>> > > Print the request tag along with other information while tracing a
>> > > command.
>> > >
On Mon, 2018-04-16 at 09:41 -0700, Rajat Jain wrote:
> On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt wrote:
> > On Mon, 16 Apr 2018 14:31:49 +
> > "Bean Huo (beanhuo)" wrote:
> >
> > > Print the request tag along with other information
> > > while tracing a command.
> > >
> > > Signed-off
On Mon, Apr 16, 2018 at 8:28 AM, Steven Rostedt wrote:
> On Mon, 16 Apr 2018 14:31:49 +
> "Bean Huo (beanhuo)" wrote:
>
>> Print the request tag along with other information
>> while tracing a command.
>>
>> Signed-off-by: Bean Huo
Acked-by: Rajat Jain
>> ---
>
> I don't see any issue with
On Mon, 16 Apr 2018 14:33:29 +
"Bean Huo (beanhuo)" wrote:
> Print the request tag along with other information in block trace events
> when tracing request , and unplug type (Sync / Async).
>
> Signed-off-by: Bean Huo
I don't see any issue with the tracing part.
Acked-by: Steven Rostedt
On Mon, 16 Apr 2018 14:31:49 +
"Bean Huo (beanhuo)" wrote:
> Print the request tag along with other information
> while tracing a command.
>
> Signed-off-by: Bean Huo
> ---
I don't see any issue with the tracing part.
Acked-by: Steven Rostedt (VMware)
Others need to check the content.
Print the request tag along with other information
while tracing a command.
Signed-off-by: Bean Huo
---
include/trace/events/scsi.h | 20 +---
1 file changed, 13 insertions(+), 7 deletions(-)
diff --git a/include/trace/events/scsi.h b/include/trace/events/scsi.h
index f624969..a
These patches are to add the printout of the request tag in Block/SCSI trace
events when tracing one request or command, this is very useful for tracing
the task running status in the storage device which supports multiple command
queue.
As for the first patch " Add tag in SCSI trace events", copi
Print the request tag along with other information in block trace events
when tracing request , and unplug type (Sync / Async).
Signed-off-by: Bean Huo
---
include/trace/events/block.h | 36 +---
1 file changed, 25 insertions(+), 11 deletions(-)
diff --git a/incl
From: Xiubo Li
This patch adds 1 tcmu attr to reset and complete all the blocked
netlink waiting threads. It's used when the userspace daemon like
tcmu-runner has crashed or forced to shutdown just before the
netlink requests be replied to the kernel, then the netlink requeting
threads will get s
On 16/04/18 09:50, Christoph Hellwig wrote:
We can rely on the dma-mapping code to handle any DMA limits that is
bigger than the ISA DMA mask for us (either using an iommu or swiotlb),
so remove setting the block layer bounce limit for anything but bouncing
for highmem pages.
Signed-off-by: Chri
On 04/16/2018 11:26 AM, Christian T. Steigies wrote:
On Thu, Apr 12, 2018 at 01:53:26PM +1200, Michael Schmitz wrote:
From: Michael Schmitz
New combined SCSI driver for all ESP based Zorro SCSI boards for
m68k Amiga.
Code largely based on board specific parts of the old drivers (blz1230.c,
bl
On Thu, Apr 12, 2018 at 01:53:26PM +1200, Michael Schmitz wrote:
> From: Michael Schmitz
>
> New combined SCSI driver for all ESP based Zorro SCSI boards for
> m68k Amiga.
>
> Code largely based on board specific parts of the old drivers (blz1230.c,
> blz2060.c, cyberstorm.c, cyberstormII.c, fas
When the current page can't be added to bio, one new bio should be
created for adding this page again, instead of ignoring this page.
This patch fixes kernel crash with iscsi target and dvd, as reported
by Wakko.
Cc: Wakko Warner
Cc: Bart Van Assche
Cc: target-de...@vger.kernel.org
Cc: linux-sc
On Mon, Apr 16, 2018 at 1:46 PM, Jinpu Wang wrote:
> On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen
> wrote:
>>
>> Jinpu,
>>
>> [CC:ed the mpt3sas maintainers]
>>
>> The ratelimit patch is just an attempt to treat the symptom, not the
>> cause.
> Agree. If we can fix the root cause, it will
The default already is to never bounce, so the call is a no-op.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/iscsi_tcp.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/iscsi_tcp.c b/drivers/scsi/iscsi_tcp.c
index 2ba4b68fdb73..b025a0b74341 100644
--- a/drivers/scsi/iscsi_tc
The default already is to never bounce, so the call is a no-op.
Signed-off-by: Christoph Hellwig
---
drivers/scsi/storvsc_drv.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/scsi/storvsc_drv.c b/drivers/scsi/storvsc_drv.c
index 8c51d628b52e..5f2d177c3bd9 100644
--- a/drivers/scsi
Hi all,
this series tries to get rid of the global and PCI_DMA_BUS_IS_PHYS flag,
which causes the block layer and networking code to bounce buffer memory
above the dma mask in some cases. It is a leftover from i386 + highmem
days and is obsolete now that we have swiotlb or iommus so that the
dma
mtip32xx just sets the block bounce limit to the dma mask, which means
that the iommu or swiotlb already take care of the bounce buffering,
and the block bouncing can be removed.
Signed-off-by: Christoph Hellwig
---
drivers/block/mtip32xx/mtip32xx.c | 1 -
1 file changed, 1 deletion(-)
diff --g
DAC960 just sets the block bounce limit to the dma mask, which means
that the iommu or swiotlb already take care of the bounce buffering,
and the block bouncing can be removed.
Signed-off-by: Christoph Hellwig
---
drivers/block/DAC960.c | 9 ++---
drivers/block/DAC960.h | 1 -
2 files change
sata_nv sets the block bounce limit to the reduce dma mask for ATAPI
devices, which means that the iommu or swiotlb already take care of
the bounce buffering, and the block bouncing can be removed.
Signed-off-by: Christoph Hellwig
---
drivers/ata/sata_nv.c | 62 +-
We can rely on the dma-mapping code to handle any DMA limits that is
bigger than the ISA DMA mask for us (either using an iommu or swiotlb),
so remove setting the block layer bounce limit for anything but the
unchecked_isa_dma case, or the bouncing for highmem pages.
Signed-off-by: Christoph Hellw
All in-tree host drivers set up a proper dma mask and use the dma-mapping
helpers. This means they will be able to deal with any address that we
are throwing at them.
Signed-off-by: Christoph Hellwig
---
drivers/memstick/core/ms_block.c| 5 -
drivers/memstick/core/mspro_block.c | 5
We can rely on the dma-mapping code to handle any DMA limits that is
bigger than the ISA DMA mask for us (either using an iommu or swiotlb),
so remove setting the block layer bounce limit for anything but bouncing
for highmem pages.
Signed-off-by: Christoph Hellwig
---
drivers/mmc/core/queue.c |
We now have ways to deal with drainage in the block layer, and libata has
been using it for ages. We also want to get rid of PCI_DMA_BUS_IS_PHYS
now, so just reduce the PCI transfer size for ide - anyone who cares for
performance on PCI controllers should have switched to libata long ago.
Signed-
These days the dma mapping routines must be able to handle any address
supported by the device, be that using an iommu, or swiotlb if none is
supported. With that the PCI_DMA_BUS_IS_PHYS check in illegal_highdma
is not needed and can be removed.
Signed-off-by: Christoph Hellwig
---
net/core/dev
ide_toggle_bounce did select various strange block bounce limits, including
not bouncing at all as soon as an iommu is present in the system. Given
that the dma_map routines now handle any required bounce buffering except
for ISA DMA, and the ide code already must handle either ISA DMA or highmem
This was used by the ide, scsi and networking code in the past to
determine if they should bounce payloads. Now that the dma mapping
always have to support dma to all physical memory (thanks to swiotlb
for non-iommu systems) there is no need to this crude hack any more.
Signed-off-by: Christoph H
On Fri, Apr 13, 2018 at 6:59 PM, Martin K. Petersen
wrote:
>
> Jinpu,
>
> [CC:ed the mpt3sas maintainers]
>
> The ratelimit patch is just an attempt to treat the symptom, not the
> cause.
Agree. If we can fix the root cause, it will be great.
>
>> Thanks for asking, we updated mpt3sas driver which
52 matches
Mail list logo
