[PATCH v2] target/file: add support of direct and async I/O

2018-03-21 Thread Andrei Vagin
There are two advantages: * Direct I/O allows to avoid the write-back cache, so it reduces affects to other processes in the system. * Async I/O allows to handle a few commands concurrently. DIO + AIO shows a better perfomance for random write operations: Mode: O_DSYNC Async: 1 $ ./fio --bs=4K

Fiber Channel in LIO / TCM

2018-03-21 Thread TomK
Curious if there will be continued development and support of Fiber Channel in LIO / TCM? I haven't seen much in the way in terms of commits on github or the linux-iscsi.org/wiki/Fibre_Channel page in recent months / years so wondering about it's future. -- Cheers, Tom K.

[Bug 199155] /sys/block/dev/device/model truncates to 16 characters

2018-03-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199155 --- Comment #2 from Bryan Seitz (seit...@gmail.com) --- Is there some other place this is stored under /sys ? -- You are receiving this mail because: You are the assignee for the bug.

[Bug 199155] /sys/block/dev/device/model truncates to 16 characters

2018-03-21 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199155 Martin K. Petersen (m...@mkp.net) changed: What|Removed |Added CC||m...@mkp.net --- Comm

Re: [PATCH V3 0/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-21 Thread Martin K. Petersen
Adrian, > Here is V3, now re-based on top of patch "scsi: ufs: sysfs:reworking of the > rpm_lvl and spm_lvl entries". > > Michał Potomski has previously sent a patch for Auto-Hibernate, but this > patch is slightly different, based on the latest ufs-sysfs changes, it also > takes care to restore

Re: [PATCH] scsi: ufs: sysfs: reworking of the rpm_lvl and spm_lvl entries

2018-03-21 Thread Martin K. Petersen
Adrian, > On 01/03/18 12:48, Stanislav Nijnikov wrote: >> Read from these files will return the integed value of the chosen power >> management level now. Separate entries were added to show the target >> UFS device and UIC link states. The description of the possible power >> managements levels

Re: [PATCH] scsi: cxgb4i: potential array overflow in t4_uld_rx_handler()

2018-03-21 Thread Martin K. Petersen
Varun: Please look at this. Thanks! > What happened to this one? > > regards, > dan carpenter > > > On Wed, Nov 29, 2017 at 02:42:20PM +0300, Dan Carpenter wrote: >> The story is that Smatch marks skb->data as untrusted and so it >> complains about this code: >> >> drivers/scsi/cxgbi/cxgb4i

Re: [PATCH 0/2] smartpqi updates

2018-03-21 Thread Martin K. Petersen
Don, > . add workaround for fw bug when deleting >operational queues. > . change driver version to 1.1.4-115 Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/3] qla2xxx: fx00 copypaste typo

2018-03-21 Thread Martin K. Petersen
Meelis, > Fix an obvious copy-paste error in freeing QLAFX00 response queue - the code > checked for rsp->ring but freed rsp->ring_fx00. Hand-applied to 4.16/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/3] qla2xxx: fix error message on

2018-03-21 Thread Martin K. Petersen
Meelis, > This patch fixes IO traps caught by hardware when mailbox command fails on > qla2200. The error handler assumes newer firmware that is available on 2400 > and > newer HBA-s. > > This causes ugly crashes on sparc64. Amended according to Himanshu's requests and applied to 4.16/scsi-fixe

Re: [PATCH 0/4] scsi: arcmsr: Support Areca thunderbolt devices hot-plug

2018-03-21 Thread Martin K. Petersen
Ching, > 1. Rename ACB_F_BUS_HANG_ON to ACB_F_ADAPTER_REMOVED for adapter hot-plug > 2. Handle adapter removed due to thunderbolt cable disconnection. > 3. Sleep to avoid CPU stuck too long for waiting adapter ready > 4. Change driver version to v1.40.00.05-20180309 Applied to 4.17/scsi-queue. T

Re: [PATCH v4 00/13] qla2xxx: Fixes for FC-NVMe

2018-03-21 Thread Martin K. Petersen
Himanshu, > This patch series addresses issue with FC-NVMe abort handling in the > driver. Code has been cleaned up and devloss timeout support has been > added in qla2xxx. Applied to 4.17/scsi-queue. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 1/2] scsi: dpt_i2o: use after free in adpt_release()

2018-03-21 Thread Martin K. Petersen
Christoph, > This fix is broken! adpt_i2o_delete_hba references pHba->host as well. > > Instead we need a local variable for the host. Thanks for spotting this! Fixed it up. -- Martin K. Petersen Oracle Linux Engineering

[trivial PATCH V2] treewide: Align function definition open/close braces

2018-03-21 Thread Joe Perches
Some functions definitions have either the initial open brace and/or the closing brace outside of column 1. Move those braces to column 1. This allows various function analyzers like gnu complexity to work properly for these modified functions. Signed-off-by: Joe Perches Acked-by: Andy Shevchen

[PATCH] scsi: megaraid_sas: Do not log an error if FW successfully initializes.

2018-03-21 Thread Vinson Lee
Fixes: 2d2c2331673c ("scsi: megaraid_sas: modified few prints in OCR and IOC INIT path") Signed-off-by: Vinson Lee --- drivers/scsi/megaraid/megaraid_sas_fusion.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c b/drivers/scsi

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-21 Thread Andrei Vagin
On Wed, Mar 21, 2018 at 11:47:02AM -0700, Christoph Hellwig wrote: > On Wed, Mar 21, 2018 at 11:16:09AM -0700, Andrei Vagin wrote: > > If we look at lo_rw_aio, we can find that bvec can be allocated or got > > from bio. I think the problem with the second case. > > > > static int lo_rw_aio(struct

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-21 Thread Steven Rostedt
On Wed, 21 Mar 2018 11:50:01 -0700 Christoph Hellwig wrote: > On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(&cmd->t_state_lock); > > - WARN_ON_ONCE(!irqs_disabled()); > > + WARN_ON_ONCE_NONRT(!irqs_disabled()); > > I can't find where W

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-21 Thread Christoph Hellwig
On Wed, Mar 21, 2018 at 12:38:54PM -0300, Arnaldo Carvalho de Melo wrote: > assert_spin_locked(&cmd->t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); I can't find where WARN_ON_ONCE_NONRT is defined. That being said I think we can just kil

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-21 Thread Christoph Hellwig
On Wed, Mar 21, 2018 at 11:16:09AM -0700, Andrei Vagin wrote: > If we look at lo_rw_aio, we can find that bvec can be allocated or got > from bio. I think the problem with the second case. > > static int lo_rw_aio(struct loop_device *lo, struct loop_cmd *cmd, > loff_t pos, boo

Re: [PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-21 Thread Linus Torvalds
[ Adding PeterZ to participants due to query about lockdep_assert() ] On Wed, Mar 21, 2018 at 8:38 AM, Arnaldo Carvalho de Melo wrote: > > assert_spin_locked(&cmd->t_state_lock); > - WARN_ON_ONCE(!irqs_disabled()); > + WARN_ON_ONCE_NONRT(!irqs_disabled()); Ugh. Can't we just

[PATCH 2/2] smartpqi: update driver version

2018-03-21 Thread Don Brace
Reviewed-by: Scott Teel Reviewed-by: Gerry Morong Reviewed-by: Scott Benesh Signed-off-by: Kevin Barnett Signed-off-by: Don Brace --- drivers/scsi/smartpqi/smartpqi_init.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/scsi/smartpqi/smartpqi_init.c b/dri

[PATCH 1/2] smartpqi: workaround fw bug for oq deletion

2018-03-21 Thread Don Brace
From: Kevin Barnett - skip deleting PQI operational queues when there is an error creating a new queue group. It's not really necessary to delete the queues anyway because they get deleted during the PQI reset that is part of the error recovery path. Signed-off-by: Don Brace --- drivers/

[PATCH 0/2] smartpqi updates

2018-03-21 Thread Don Brace
These patches are based on Linus's tree The changes are: . add workaround for fw bug when deleting operational queues. . change driver version to 1.1.4-115 --- Don Brace (1): smartpqi: update driver version Kevin Barnett (1): smartpqi: workaround fw bug for oq deletion driv

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-21 Thread Andrei Vagin
On Wed, Mar 21, 2018 at 12:23:40AM -0700, Christoph Hellwig wrote: > > I'm afraid this patch doesn't work, because we are not always allocate bvec, > > sometimes we get it from bio. In this case, we have to call > > blk_mq_complete_request after read_iter/write_iter. > > The issue there is that we

Re: [PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

2018-03-21 Thread Ben Hutchings
On Wed, 2018-03-21 at 17:55 +, Madhani, Himanshu wrote: > Hi Ben,  > > > On Mar 21, 2018, at 10:45 AM, Ben Hutchings > > wrote: > > > > On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote: > > > Hi Ben,  > > > > > > > On Mar 20, 2018, at 2:36 PM, Ben Hutchings > > > > wrote: > > >

Re: [PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

2018-03-21 Thread Madhani, Himanshu
Hi Ben, > On Mar 21, 2018, at 10:45 AM, Ben Hutchings > wrote: > > On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote: >> Hi Ben, >> >>> On Mar 20, 2018, at 2:36 PM, Ben Hutchings >>> wrote: >>> >>> qla2x00_init_timer() calls add_timer() on the iocb timeout timer, >>> which means

Re: [PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

2018-03-21 Thread Ben Hutchings
On Wed, 2018-03-21 at 17:17 +, Madhani, Himanshu wrote: > Hi Ben,  > > > On Mar 20, 2018, at 2:36 PM, Ben Hutchings > > wrote: > > > > qla2x00_init_timer() calls add_timer() on the iocb timeout timer, > > which means the timeout function pointer and any data that the > > function depends on

Re: [PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

2018-03-21 Thread Madhani, Himanshu
Hi Ben, > On Mar 20, 2018, at 2:36 PM, Ben Hutchings > wrote: > > qla2x00_init_timer() calls add_timer() on the iocb timeout timer, > which means the timeout function pointer and any data that the > function depends on must be initialised beforehand. > > Move this initialisation before each c

Re: [PATCH] scsi: ufs: add trace event for ufs upiu

2018-03-21 Thread Stanislav Nijnikov
-Original Message- From: Stanislav Nijnikov Sent: Wednesday, March 21, 2018 2:24 PM To: Ohad Sharabi ; James E.J. Bottomley ; Martin K. Petersen ; gre...@linuxfoundation.org Cc: Alex Lemberg ; Ohad Sharabi Subject: Re: {PATCH} ] scsi: ufs: add trace event for ufs upiu > -Origina

[PATCH] target: Use WARNON_NON_RT(!irqs_disabled())

2018-03-21 Thread Arnaldo Carvalho de Melo
Hi, We got a report where this WARN_ON got triggered: [ 7552.77] [ cut here ] [ 7552.800016] WARNING: CPU: 7 PID: 1090 at drivers/target/target_core_transport.c:3009 __transport_check_aborted_status+0x153/0x190 [target_core_mod] [ 7552.800037] Modules linked

[PATCH 1/1] target:separate tx/rx cmd_puds

2018-03-21 Thread Zhang Zhuoyu
Separate tx/rx cmd_pdus in order to distinguish LUN read/write IOPS. Signed-off-by: Zhang Zhuoyu --- drivers/target/target_core_stat.c | 26 ++ drivers/target/target_core_transport.c | 11 ++- include/target/target_core_base.h | 3 ++- 3 files changed,

Invoice # 9437174237 Problem

2018-03-21 Thread bruno
Morning open list:XEN PVSCSI DRIVERS I called you, but could not reach you the other day, please reply back about this past due invoice asap. > http://edsqualityflooring.com/Question/ Many Thanks

[PATCH] scsi: dpt_i2o: Use after free in I2ORESETCMD ioctl

2018-03-21 Thread Dan Carpenter
Here is another use after free if we reset the card. The adpt_hba_reset() function frees "pHba" on error. Signed-off-by: Dan Carpenter diff --git a/drivers/scsi/dpt_i2o.c b/drivers/scsi/dpt_i2o.c index 3c667b23a801..359e0acfbc7c 100644 --- a/drivers/scsi/dpt_i2o.c +++ b/drivers/scsi/dpt_i2o.c @

Re: [PATCH v4 13/13] qla2xxx: Update driver version to 10.00.00.06-k

2018-03-21 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-21 Thread Christoph Hellwig
> I'm afraid this patch doesn't work, because we are not always allocate bvec, > sometimes we get it from bio. In this case, we have to call > blk_mq_complete_request after read_iter/write_iter. The issue there is that we really need to NULL ->bvec after freeing it. Which normally is an anti-patte