[PATCH v4 09/13] qla2xxx: Fix retry for PRLI RJT with reason of BUSY

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_dbg.c | 2 +- drivers/scsi/qla2xxx/qla_init.c | 13 - drivers/scsi/qla2xxx/qla_mbx.c | 7 +-- 3 files c

[PATCH v4 05/13] qla2xxx: Add FC-NVMe abort processing

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 36 ++-- drivers/scsi/qla2xxx/qla_nvme.h | 1 + 2 files changed, 19 insertions(+)

[PATCH v4 12/13] qla2xxx: Fix Async GPN_FT for FCP and FC-NVMe scan

2018-03-20 Thread Himanshu Madhani
From: Quinn Tran This patch combines FCP and FC-NVMe scan into single scan when driver detects FC-NVMe capability on same port. Signed-off-by: Quinn Tran Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_def.h | 8 ++ drivers/scsi/qla2xxx/qla_gbl.h | 2 +- drivers/scsi/qla2xx

[PATCH v4 02/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

2018-03-20 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_nvme.c index 7a292421a7d7..

[PATCH v4 10/13] qla2xxx: Fix FC-NVMe IO abort during driver reset

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 17 - drivers/scsi/qla2xxx/qla_nvme.h | 2 +- drivers/scsi/qla2xxx/qla_os.c | 2 +- 3 files ch

[PATCH v4 03/13] qla2xxx: Set IIDMA and fcport state before qla_nvme_register_remote()

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_init.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_init.c b/drivers/s

[PATCH v4 04/13] qla2xxx: Add changes for devloss timeout in driver

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Add support for error recovery within devloss timeout, now that FC-NVMe transport support devloss timeout. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.h| 1

[PATCH v4 11/13] qla2xxx: Cleanup code to improve FC-NVMe error handling

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp This patch cleans up ABTS handling for FC-NVMe by - Removing allocation of sp, instead pass the sp pointer for abort IOCB - Fix error handling from Trasport failure - set outstanding_cmds array to NULL for nvme completion Signed-off-by: Darren Trapp Signed-off-by: Himanshu M

[PATCH v4 13/13] qla2xxx: Update driver version to 10.00.00.06-k

2018-03-20 Thread Himanshu Madhani
Signed-off-by: Himanshu Madhani --- drivers/scsi/qla2xxx/qla_version.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/qla2xxx/qla_version.h b/drivers/scsi/qla2xxx/qla_version.h index 549bef9afddd..0c55d7057280 100644 --- a/drivers/scsi/qla2xxx/qla_version.h +++

[PATCH v4 08/13] qla2xxx: Remove nvme_done_list

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.h | 1 - drivers/scsi/qla2xxx/qla_gbl.h | 2 -- drivers/scsi/qla2xxx/qla_init.c | 1 - drivers/scsi/qla2xxx/qla_mid.c | 6 -- drivers/scsi

[PATCH v4 07/13] qla2xxx: Return busy if rport going away

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp This patch adds mechanism to return EBUSY if rport is going away to prevent exhausting FC-NVMe layer's retry counter. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_def.

[PATCH v4 06/13] qla2xxx: Fix n2n_ae flag to prevent dev_loss on PDB change

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp On a port db changes, this patch will set n2n_ae flag for N2N connection when requesting for Report ID Acquition MBX, instead of Loop Initialization or point to point asynchronous events. Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reineck

[PATCH v4 01/13] qla2xxx: Restore ZIO threshold setting

2018-03-20 Thread Himanshu Madhani
From: Darren Trapp Signed-off-by: Darren Trapp Signed-off-by: Himanshu Madhani Reviewed-by: Hannes Reinecke Reviewed-by: Johannes Thumshirn --- drivers/scsi/qla2xxx/qla_nvme.c | 5 - 1 file changed, 5 deletions(-) diff --git a/drivers/scsi/qla2xxx/qla_nvme.c b/drivers/scsi/qla2xxx/qla_n

[PATCH v4 00/13] qla2xxx: Fixes for FC-NVMe

2018-03-20 Thread Himanshu Madhani
Hi Martin, This patch series addresses issue with FC-NVMe abort handling in the driver. Code has been cleaned up and devloss timeout support has been added in qla2xxx. Please apply this series to 4.17/scsi-queue at your earliest convenience. Hi Christoph, Sagi, Johannes, James, Please review th

Re: [PATCH v3 01/13] qla2xxx: Remove unneeded message and minor cleanup for FC-NVMe

2018-03-20 Thread kbuild test robot
Hi Himanshu, Thank you for the patch! Yet something to improve: [auto build test ERROR on v4.16-rc4] [also build test ERROR on next-20180320] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[Bug 199155] New: /sys/block/dev/device/model truncates to 16 characters

2018-03-20 Thread bugzilla-daemon
https://bugzilla.kernel.org/show_bug.cgi?id=199155 Bug ID: 199155 Summary: /sys/block/dev/device/model truncates to 16 characters Product: IO/Storage Version: 2.5 Kernel Version: 4.4 to 4.16 Hardware: All OS: Linux

megaraid_sas error "Init cmd return status SUCCESS for SCSI host 0"

2018-03-20 Thread Vinson Lee
Hi. On Linux 4.15.7, megaraid_sas logs an error even if the firmware is successfully initialized. megaraid_sas :03:00.0: Init cmd return status SUCCESS for SCSI host 0 The error message was introduced with this 4.14 commit. commit 2d2c2331673cf7c525b44f31c766930bad18007a Author: Shivasharan

[GIT PULL] SCSI fixes for 4.16-rc6

2018-03-20 Thread James Bottomley
One driver patch (qla2xxx) which fixes a problem caused by an existing regression fix (FCP discovery is failing) and one generic fix to a longstanding bug in libsas that causes I/O eventually to hang to the device in the face of ATA error recovery. The patch is available here: git://git.kernel.or

[RFC][PATCH] qla2xxx: Fix race between iocb timeout and free

2018-03-20 Thread Ben Hutchings
qla2x00_sp_free() cancels the iocb timeout timer if it is still pending, but doesn't (and can't) wait for the timer function to complete if it is already running. Add a reference count to async iocb commands to ensure that they aren't freed too early: - One reference is held by the timer, and dro

[PATCH v2] qla2xxx: Fix race condition between iocb timeout and initialisation

2018-03-20 Thread Ben Hutchings
qla2x00_init_timer() calls add_timer() on the iocb timeout timer, which means the timeout function pointer and any data that the function depends on must be initialised beforehand. Move this initialisation before each call to qla2x00_init_timer(). In some cases qla2x00_init_timer() initialises a

[PATCH] qla2xxx: Fix race condition between iocb timeout and initialisation

2018-03-20 Thread Ben Hutchings
qla2x00_init_timer() calls add_timer() on the iocb timeout timer, which means the timeout function pointer and any data that the function depends on must be initialised beforehand. Move this initialisation before each call to qla2x00_init_timer(). In some cases qla2x00_init_timer() initialises a

Re: [PATCH] mpt3sas: Cache enclosure pages during enclosure add.

2018-03-20 Thread kbuild test robot
Hi Chaitra, I love your patch! Perhaps something to improve: [auto build test WARNING on v4.16-rc4] [also build test WARNING on next-20180320] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

[RFC PATCH] mpt3sas: mpt3sas_scsih_enclosure_find_by_handle can be static

2018-03-20 Thread kbuild test robot
Fixes: 793a6223beef ("mpt3sas: Cache enclosure pages during enclosure add.") Signed-off-by: Fengguang Wu --- mpt3sas_scsih.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/scsi/mpt3sas/mpt3sas_scsih.c b/drivers/scsi/mpt3sas/mpt3sas_scsih.c index c93c5c5..67a43957

[PATCH] qla2xxx: Avoid double completion of abort command

2018-03-20 Thread Ben Hutchings
qla2x00_tmf_sp_done() now deletes the timer that will run qla2x00_tmf_iocb_timeout(), but doesn't check whether the timer already expired. Check the return value from del_timer() to avoid calling complete() a second time. Fixes: 4440e46d5db7 ("[SCSI] qla2xxx: Add IOCB Abort command asynchronous .

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-20 Thread Andrei Vagin
On Tue, Mar 20, 2018 at 01:47:01AM -0700, Christoph Hellwig wrote: > On Tue, Mar 20, 2018 at 12:54:58AM -0700, Andrei Vagin wrote: > > commit 92d773324b7edbd36bf0c28c1e0157763aeccc92 > > Author: Shaohua Li > > Date: Fri Sep 1 11:15:17 2017 -0700 > > > > block/loop: fix use after free > >

Re: [PATCH v4 1/7] scsi: hpsa: Eliminate duplicate barriers on weakly-ordered archs

2018-03-20 Thread Laurence Oberman
On Mon, 2018-03-19 at 22:50 -0400, Sinan Kaya wrote: > Code includes wmb() followed by writel(). writel() already has a > barrier on some architectures like arm64. > > This ends up CPU observing two barriers back to back before executing > the register write. > > Since code already has an explici

Re: aacaid: Difference in `/sys` between 4.14.13 andout of tree driver 55022

2018-03-20 Thread Paul Menzel
Dear Raghava, On 01/15/18 21:22, Paul Menzel wrote: Am 18.12.2017 um 19:09 schrieb Raghava Aditya Renukunta: -Original Message- From: Paul Menzel [mailto:pmen...@molgen.mpg.de] Sent: Saturday, December 16, 2017 1:39 AM […] Am 17.02.2017 um 20:29 schrieb Raghava Aditya Renukunta:

RE: [PATCH V3 1/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-20 Thread Stanislav Nijnikov
> -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Tuesday, March 20, 2018 3:08 PM > To: Vinayak Holikatti ; Martin K. Petersen > ; James E.J. Bottomley > > Cc: Stanislav Nijnikov ; Jaegeuk Kim > ; Bart Van Assche ; linux- > s...@vger.kernel.org; linux-ke

[PATCH V3 0/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-20 Thread Adrian Hunter
Hi Here is V3, now re-based on top of patch "scsi: ufs: sysfs:reworking of the rpm_lvl and spm_lvl entries". Michał Potomski has previously sent a patch for Auto-Hibernate, but this patch is slightly different, based on the latest ufs-sysfs changes, it also takes care to restore auto-hibernate du

[PATCH V3 1/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-20 Thread Adrian Hunter
UFS host controllers may support an autonomous power management feature called the Auto-Hibernate Idle Timer. The timer is set to the number of microseconds of idle time before the UFS host controller will autonomously put the link into Hibernate state. That will save power at the expense of increa

Re: [PATCH v4 3/7] scsi: dpt_i2o: eliminate duplicate barriers on weakly-ordered archs

2018-03-20 Thread okaya
On 2018-03-20 06:23, Christoph Hellwig wrote: This is a basically unmaintained driver for historic hardware, and not the right place for micro-optimizations. Sure, I can drop this on the next version.

Re: [PATCH V2 1/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-20 Thread Adrian Hunter
On 20/03/18 13:56, Stanislav Nijnikov wrote: > > >> -Original Message- >> From: Adrian Hunter [mailto:adrian.hun...@intel.com] >> Sent: Monday, March 19, 2018 10:01 AM >> To: Vinayak Holikatti ; Martin K. Petersen >> ; James E.J. Bottomley >> >> Cc: Stanislav Nijnikov ; Jaegeuk Kim >> ;

RE: [PATCH V2 1/1] scsi: ufs: Add support for Auto-Hibernate Idle Timer

2018-03-20 Thread Stanislav Nijnikov
> -Original Message- > From: Adrian Hunter [mailto:adrian.hun...@intel.com] > Sent: Monday, March 19, 2018 10:01 AM > To: Vinayak Holikatti ; Martin K. Petersen > ; James E.J. Bottomley > > Cc: Stanislav Nijnikov ; Jaegeuk Kim > ; Bart Van Assche ; linux- > s...@vger.kernel.org; linux-ke

Re: [PATCH v4 3/7] scsi: dpt_i2o: eliminate duplicate barriers on weakly-ordered archs

2018-03-20 Thread Christoph Hellwig
This is a basically unmaintained driver for historic hardware, and not the right place for micro-optimizations.

[PATCH] mpt3sas: Cache enclosure pages during enclosure add.

2018-03-20 Thread Chaitra P B
In function _scsih_add_device, for each device connected to a enclosure, driver reads the enclosure page.(To get details like enclosure handle, enclosure logical ID, enclosure level etc.) With this patch, Instead of reading enclosure page everytime, driver maintains a list for enclosure device.(Du

Re: [PATCH 1/2] scsi: dpt_i2o: use after free in adpt_release()

2018-03-20 Thread Dan Carpenter
Yeah. You're right. Thanks for catching that. regards, dan carpenter

Re: How to Locate drive directly attached to mpt3sas HBA

2018-03-20 Thread Jack Wang
2018-03-19 18:44 GMT+01:00 James Bottomley : > On Mon, 2018-03-19 at 17:30 +0100, Jack Wang wrote: >> > >> > >> > > >> > > And I think either mpt2sas and/or mpt3sas HBAs (I don't have my >> > > hardware >> > > nearby) have a SMP target hidden away somewhere. Perhaps someone >> > > from >> > > LSI/A

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-20 Thread Christoph Hellwig
On Tue, Mar 20, 2018 at 12:54:58AM -0700, Andrei Vagin wrote: > commit 92d773324b7edbd36bf0c28c1e0157763aeccc92 > Author: Shaohua Li > Date: Fri Sep 1 11:15:17 2017 -0700 > > block/loop: fix use after free > > lo_rw_aio->call_read_iter-> > 1 aops->direct_IO > 2

Re: [PATCH 1/2] scsi: dpt_i2o: use after free in adpt_release()

2018-03-20 Thread Christoph Hellwig
On Mon, Mar 19, 2018 at 11:08:37PM -0400, Martin K. Petersen wrote: > > Dan, > > > The scsi_host_put() function frees "pHba" and then we dereference it on > > the next line when we do "scsi_host_put(pHba->host);". > > Applied to 4.17/scsi-queue, thank you. This fix is broken! adpt_i2o_delete_h

Re: [PATCH] [RFC] target/file: add support of direct and async I/O

2018-03-20 Thread Andrei Vagin
On Fri, Mar 16, 2018 at 12:50:27AM -0700, Christoph Hellwig wrote: > > DIF (PI) emulation doesn't work when a target uses async I/O, because > > DIF metadata is saved in a separate file, and it is another non-trivial > > task how to synchronize writing in two files, so that a following read > > ope