[PATCH] scsi: core: fix two wrong indentation cases

2018-02-25 Thread Jianchao Wang
No functional changes. Just fix two wrong indentation cases in scsi_finish_command and scsi_decide_disposition. Signed-off-by: Jianchao Wang --- drivers/scsi/scsi.c | 2 +- drivers/scsi/scsi_error.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi.c

[PATCH] scsi: core: use blk_mq_requeue_request in __scsi_queue_insert

2018-02-25 Thread Jianchao Wang
In scsi core, __scsi_queue_insert should just put request back on the queue and retry using the same command as before. However, for blk-mq, scsi_mq_requeue_cmd is employed here which will unprepare the request. To align with the semantics of __scsi_queue_insert, just use blk_mq_requeue_request wit

Re: [PATCH] lpfc: correct writeq failures on 32-bit architectures

2018-02-25 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N

[PATCH] scsi: return BLK_STS_OK for DID_OK in __scsi_error_from_host_byte()

2018-02-25 Thread Hannes Reinecke
When converting __scsi_error_from_host_byte() to BLK_STS error codes the case DID_OK was forgotten, resulting in it always returning an error. Fixes: 2a842acab109 ("block: introduce new block status code type") Cc: Doug Gilbert Signed-off-by: Hannes Reinecke --- drivers/scsi/scsi_lib.c | 2 ++

Re: [PATCH v2] Make SCSI Status CONDITION MET equivalent to GOOD

2018-02-25 Thread Hannes Reinecke
On 02/25/2018 07:29 PM, Douglas Gilbert wrote: > The SCSI PRE-FETCH (10 or 16) command is present both on hard disks > and some SSDs. It is useful when the address of the next block(s) to > be read is known but it is not following the LBA of the current READ > (so read-ahead won't help). It returns

[PATCH v3] Make SCSI Status CONDITION MET equivalent to GOOD

2018-02-25 Thread Douglas Gilbert
Comment on v3: Even though there has been no feedback on v2, its seems like a missed opportunity not to continue the refactoring of scsi_io_completion() started in v2. Now the main function has 34 lines of code of which the fast path visits 12; it has half as many local variables and no goto (jumpi

Re: [PATCH 9/9] scsi: ufs: Add clock ungating to a separate workqueue

2018-02-25 Thread Asutosh Das (asd)
On 2/24/2018 5:27 AM, Miguel Ojeda wrote: On Wed, Feb 21, 2018 at 5:56 AM, Asutosh Das wrote: From: Vijay Viswanath UFS driver can receive a request during memory reclaim by kswapd. So when ufs driver puts the ungate work in queue, and if there are no idle workers, kthreadd is invoked to crea

[PATCH v2] Make SCSI Status CONDITION MET equivalent to GOOD

2018-02-25 Thread Douglas Gilbert
The SCSI PRE-FETCH (10 or 16) command is present both on hard disks and some SSDs. It is useful when the address of the next block(s) to be read is known but it is not following the LBA of the current READ (so read-ahead won't help). It returns two "good" SCSI Status values. If the requested blocks

Re: [PATCH] scsi: lpfc: use memcpy_toio instead of writeq

2018-02-25 Thread Johannes Thumshirn
Arnd Bergmann writes: > 32-bit architectures generally cannot use writeq(), so we now get a build > failure for the lpfc driver: > > drivers/scsi/lpfc/lpfc_sli.c: In function 'lpfc_sli4_wq_put': > drivers/scsi/lpfc/lpfc_sli.c:145:4: error: implicit declaration of function > 'writeq'; did you mean