Re: [PATCH] scsi: scsi_debug: Fix pointer stying issues

As per the subject line, I wouldn't mind putting these changes in with the pigs :-) On 2018-02-09 09:12 PM, John Pittman wrote: Pointer styling issues exposed by checkpatch.pl in scsi_debug.c: ERROR: "foo * bar" should be "foo *bar" Fixed 37 total errors reported. Signed-off-by: John Pitt

[PATCH v2] scsi_debug: implement IMMED bit

The Start Stop Unit (SSU) command takes in the order of a second to complete on some SAS SSDs and longer on hard disks. Synchronize Cache (SC) can also take some time. Both commands have an IMMED bit in their cdbs for those apps that don't want to wait. This patch introduces a long delay for those

[PATCH] scsi: scsi_debug: Fix pointer stying issues

Pointer styling issues exposed by checkpatch.pl in scsi_debug.c: ERROR: "foo * bar" should be "foo *bar" Fixed 37 total errors reported. Signed-off-by: John Pittman --- drivers/scsi/scsi_debug.c | 72 +++ 1 file changed, 36 insertions(+), 36 delet

Re: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

Hi Kashyap, On Fri, Feb 09, 2018 at 02:12:16PM +0530, Kashyap Desai wrote: > > -Original Message- > > From: Ming Lei [mailto:ming@redhat.com] > > Sent: Friday, February 9, 2018 11:01 AM > > To: Kashyap Desai > > Cc: Hannes Reinecke; Jens Axboe; linux-bl...@vger.kernel.org; Christoph >

Re: [PATCH] scsi: pmcraid: remove redundant initializations of pointer 'ioadl'

Colin, > There are several occurrances where pointer ioadl is initialized with a > value that is never read and where it is re-assigned a new value later > on, hence the initialization is redundant and can be removed. Applied to 4.17/scsi-queue. -- Martin K. Petersen Oracle Linux Engineer

Re: [PATCH 3/6] scsi: sym53c416: avoid section mismatch with LTO

Arnd, > Building with link time optimizations produces a false-postive section > mismatch warning: Applied to 4.17/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: isci: remove redundant initialization to 'bit'

Colin, > Variable bit is initialized with a value that is never read and is > being updated immediately after the initialization, hence the > initialization is redundant and can be removed. Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/6] scsi: NCR53c406a: avoid section mismatch with LTO

Arnd, > Building with link time optimizations produces a false-postive section > mismatch warning: Applied to 4.17/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2 0/3] scsi: aacraid: Multi controller Kdump IOP reset handling

Raghava, > During Kdump aacraid controller IOP reset is invoked, IOP reset > takes approx 40 seconds to bring the controller back up and running. > with timeout of 120 seconds and anything more than 2 controllers > will cause kdump to timeout. > > This patchset implements a new reset mechanism ca

Re: [PATCH 6/6] scsi: qedf: use correct strncpy() size

Arnd, > gcc-8 warns during link-time optimization that the strncpy() call > passes the size of the source buffer rather than the destination: Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] aacraid: fix shutdown crash when init fails

Meelis, > When aacraid init fails with "AAC0: adapter self-test failed.", > shutdown leads to UBSAN warning and then oops: Applied to 4.16/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v3 0/2] Code cleanup and bug fix for truncated CHAP name and secret

Nilesh, > Please consider below patch set for next 'scsi-fixes' submission. Applied to 4.16/scsi-fixes. Thank you! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 4/6] scsi: qedf: fix LTO-enabled build

Arnd, > The prototype for qedf_dbg_fops/qedf_debugfs_ops doesn't match the > definition, which causes the final link to fail with link-time > optimizations: Applied to 4.17/scsi-queue. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v2] scsi: mpt3sas: fix oops in error handlers after shutdown/unload

> This patch adds checks for 'ioc->remove_host' in the SCSI error > handlers, so not to access pointers/resources potentially freed > in the PCI shutdown/module unload path. The error handlers may > be invoked after shutdown/unload, depending on other components. Broadcom folks: Please review!

Re: rescan-scsi-bus causes arcmsr death

On Fri, 2018-02-09 at 19:58 +, Alex Richman wrote: > Feb 9 11:55:05 Space kernel: [58801.943460] BUG: scheduling while > atomic: ksoftirqd/19/85/0x0100 > [ ... ] > Feb 9 11:55:05 Space kernel: [58801.943546] [] > msleep+0x37/0x50 > Feb 9 11:55:05 Space kernel: [58801.943552] [] > ar

RE: [PATCH] aacraid: fix shutdown crash when init fails

> -Original Message- > From: mr...@math.ut.ee [mailto:mr...@math.ut.ee] On Behalf Of Meelis > Roos > Sent: Thursday, February 08, 2018 11:58 PM > To: linux-scsi@vger.kernel.org; dl-esc-Aacraid Linux Driver > > Subject: [PATCH] aacraid: fix shutdown crash when init fails > > > When aacrai

rescan-scsi-bus causes arcmsr death

Hi, We're seeing an odd rare interaction between rescan-scsi-bus and arcmsr, which manifests as these log messages, then a hang/panic: Feb 9 18:51:19 Space kernel: [ 2624.283565] arcmsr: abort scsi_cmnd(0x8807d06cc900), cmnd[0x8a,0x 0,0x 0,0x 0,0x 0,0x 1,0x 8,0xc0,0x2b,0xe8,0x 0,0x 0], sc

[GIT PULL] target updates for v4.16-rc1

Hi Linus, Here are the target-pending updates for v4.16-rc1. Please go ahead and pull from: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git for-next The highlights include: - Numerous target-core-user improvements related to queue full and timeout handling. (MNC) - Prev

RE: [PATCH 0/5] blk-mq/scsi-mq: support global tags & introduce force_blk_mq

> -Original Message- > From: Ming Lei [mailto:ming@redhat.com] > Sent: Friday, February 9, 2018 11:01 AM > To: Kashyap Desai > Cc: Hannes Reinecke; Jens Axboe; linux-bl...@vger.kernel.org; Christoph > Hellwig; Mike Snitzer; linux-scsi@vger.kernel.org; Arun Easi; Omar Sandoval; > Martin

Re: [PATCH] scsi: storvsc: missing error code in storvsc_probe()

On Thu, Feb 08, 2018 at 04:50:40PM -0700, Long Li wrote: > From: Long Li No, Dan wrote the first patch here, don't change the authorship of a patch :( Now fixed up by hand...