Re: [RFC PATCH] scsi: sd: add wce_rcd sysfs interface

2018-01-17 Thread weiping zhang
2018-01-18 10:51 GMT+08:00 Martin K. Petersen : > > Hi Weiping, > >> add user friendly interface wce_rcd to enable/disable >> write&read cache. The code base on cache_type, but need short input. > > While I agree that the cache_type interface is somewhat arcane, I don't > think that adding a duplic

Re: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Martin K. Petersen
Arnd, > struct timespec is deprecated since it overflows in 2038 on 32-bit > architectures, so we should use timespec64 consistently. > > I'm slightly adapting the format strings here, to make sure we > print the nanoseconds with the correct number of leading zeroes. Applied to 4.16/scsi-queue.

Re: [RFC PATCH] scsi: sd: add wce_rcd sysfs interface

2018-01-17 Thread Martin K. Petersen
Hi Weiping, > add user friendly interface wce_rcd to enable/disable > write&read cache. The code base on cache_type, but need short input. While I agree that the cache_type interface is somewhat arcane, I don't think that adding a duplicate interface with slightly different semantics is a good i

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-17 Thread Martin K. Petersen
Martin, > You'd like to spend a precious BLIST bit for this single device which > uses vendor-specific ASC/Q? I really don't want string comparisons in the regular code paths. Also not a fan of vendor-specific ASCs. But if you must use them, please add a flag and trigger on that. Since this is

Re: [PATCH -next] scsi: qedf: Fix error return code in __qedf_probe()

2018-01-17 Thread Martin K. Petersen
Wei, > Fix to return error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. Applied to 4.16/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

[PATCH-next] ibmvfc: Remove unneeded semicolons

2018-01-17 Thread Christopher Díaz Riveros
Trivial fix removes unneeded semicolons after switch blocks. This issue was detected by using the Coccinelle software. Signed-off-by: Christopher Díaz Riveros --- drivers/scsi/ibmvscsi/ibmvfc.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --gi

RE: [PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Satish Kharat (satishkh)
Looks good to me. Acked-by: Satish Kharat -Original Message- From: Arnd Bergmann [mailto:a...@arndb.de] Sent: Wednesday, January 17, 2018 7:17 AM To: Satish Kharat (satishkh) ; Sesidhar Baddela (sebaddel) ; Karan Tilak Kumar (kartilak) ; James E.J. Bottomley ; Martin K. Petersen Cc:

Re: [PATCH] drivers/scsi/qla2xxx: fix double free bug after firmware timeout

2018-01-17 Thread Madhani, Himanshu
Max, > On Jan 15, 2018, at 12:37 PM, Max Kellermann wrote: > > On 2018/01/15 20:58, "Madhani, Himanshu" wrote: >> We have patch to prevent this double free in 4.16/scsi-queue >> already. > > No, let me repeat: this is a different bug! > > Your bug is about the free call after waiting for comp

[LSF/MM TOPIC] Improving Asynchronous SCSI Disk Probing

2018-01-17 Thread Bart Van Assche
When the SCSI scanning code discovers a SCSI device it calls the driver core function device_add() to associate a SCSI ULD with the device. The driver core invokes the probing function for the matching SCSI ULP, e.g. sd_probe(). In order to minimize the time needed to scan SCSI targets that have a

[ANNOUNCE] Participate at the Linux FAST Summit '18

2018-01-17 Thread Christoph Hellwig
We are pleased to announce that the Call for Participation [1] for the 2018 USENIX Research in Linux File and Storage Technologies Summit (Linux FAST Summit '18) [2] is now available. Linux FAST Summit '18 will take place at the Oakland Marriott City Center on February 15 and will be co-located wi

Re: A qla2xxx commit cause Linux no response, has not fixed in lastest version 4.15-rc6

2018-01-17 Thread Madhani, Himanshu
Hi Chang, > On Jan 15, 2018, at 10:49 PM, Changlimin wrote: > > Hi Himanshu, > This is my progress. > First, I compiled 4.15-rc6, I found linux hang when booting, the stack > showed something wrong in qla2xxx driver. Can you provide me detail steps of how you compiled 4.15-rc6. Also provi

Re: [PATCH] scsi: handle ABORTED_COMMAND on Fujitsu ETERNUS

2018-01-17 Thread Xose Vazquez Perez
Martin Wilck wrote: > On Wed, 2018-01-17 at 01:15 -0500, Martin K. Petersen wrote: >> >> > + if (!strncmp(scmd->device->vendor, "FUJITSU", 7) >> > && >> > + !strncmp(scmd->device->model, >> > "ETERNUS_DXM", 11) && Is DXM the S3 family? >> Blacklist, please. > > To

[PATCH 2/3] scsi: hisi_sas: directly attached disk LED feature for v2 hw

2018-01-17 Thread John Garry
From: Xiaofei Tan This patch implements LED feature of directly attached disk for v2 hw. As libsas has provided an interface lldd_write_gpio() for this feature, we just need realise the interface following SPGIO API. We use an CPLD to finish the hardware part of this feature, and the base addres

[PATCH 3/3] scsi: hisi_sas: fix a bug in hisi_sas_dev_gone()

2018-01-17 Thread John Garry
From: Xiang Chen When device gone, NULL pointer can be accessed in free_device callback if during SAS controller reset as we clear structure sas_dev prior. Actually we can only set dev_type as SAS_PHY_UNUSED and not clear structure sas_dev as all the members of structure sas_dev will be re-initi

[PATCH 1/3] devicetree: bindings: scsi: hisi_sas: add LED feature for v2 hw

2018-01-17 Thread John Garry
From: Xiaofei Tan Add directly attached disk LED feature for v2 hw. Signed-off-by: Xiaofei Tan Signed-off-by: John Garry --- Documentation/devicetree/bindings/scsi/hisilicon-sas.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/scsi/

[PATCH 0/3] hisi_sas: v2 hw LED support

2018-01-17 Thread John Garry
This patchset includes SGPIO support for driving LEDs for boards including a SoC (like hip07) with v2 hw. The SGPIO interface is realised with a CPLD on the D05 board which inludes hip07. Also included in the patchset is a small bug fix for device removal. Xiang Chen (1): scsi: hisi_sas: fix a

[PATCH] [RESEND] scsi: fnic: use 64-bit timestamps

2018-01-17 Thread Arnd Bergmann
struct timespec is deprecated since it overflows in 2038 on 32-bit architectures, so we should use timespec64 consistently. I'm slightly adapting the format strings here, to make sure we print the nanoseconds with the correct number of leading zeroes. Signed-off-by: Arnd Bergmann --- Originally

[PATCH] [RESEND] scsi: esas2r: use ktime_get_real_seconds()

2018-01-17 Thread Arnd Bergmann
do_gettimeofday() is deprecated because of the y2038 overflow. Here, we use the result to pass into a 32-bit field in the firmware, which still risks an overflow, but if the firmware is written to expect unsigned values, it can at least last until y2106, and there is not much we can do about it. T

[PATCH] [RESEND] scsi: ips: fix firmware timestamps for 32-bit

2018-01-17 Thread Arnd Bergmann
do_gettimeofday() is deprecated since it will stop working in 2038 on 32-bit platforms. The firmware interface here actually supports times until year 25500, so we should use longer timestamps. Using ktime_get_real_seconds() to get a 64-bit seconds value and time64_to_tm() to convert it into the r

[PATCH] [RESEND] megaraid: use ktime_get_real for firmware time

2018-01-17 Thread Arnd Bergmann
do_gettimeofday() overflows in 2038 on 32-bit architectures and is deprecated, so convert this driver to call ktime_get_real() directly. This also simplifies the calculation. Signed-off-by: Arnd Bergmann --- Sent originally in Nov 2017, no comments. Please apply --- drivers/scsi/megaraid/megarai

Re: [PATCH -next] scsi: qedf: Fix error return code in __qedf_probe()

2018-01-17 Thread Chad Dupuis
On Wed, 17 Jan 2018, 7:42am, Wei Yongjun wrote: > Fix to return error code -ENOMEM from the error handling > case instead of 0, as done elsewhere in this function. > > Signed-off-by: Wei Yongjun > --- > drivers/scsi/qedf/qedf_main.c | 3 +++ > 1 file changed, 3 insertions(+) > Yeah, we shoul

[RFC PATCH] scsi: sd: add wce_rcd sysfs interface

2018-01-17 Thread weiping zhang
add user friendly interface wce_rcd to enable/disable write&read cache. The code base on cache_type, but need short input. enable both write and read cache: echo "10" > wce_rcd wce rcd write_cache read_cache 0 0 off on 0 1 off off 1 0 on on 1 1 on

[PATCH -next] scsi: qedf: Fix error return code in __qedf_probe()

2018-01-17 Thread Wei Yongjun
Fix to return error code -ENOMEM from the error handling case instead of 0, as done elsewhere in this function. Signed-off-by: Wei Yongjun --- drivers/scsi/qedf/qedf_main.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/scsi/qedf/qedf_main.c b/drivers/scsi/qedf/qedf_main.c index

[PATCH] scsi: ufs: add trace event for ufs upiu

2018-01-17 Thread Ohad Sharabi
Add UFS Protocol Information Units(upiu) trace events for ufs driver, used to trace various ufs transaction types- command, task-management and device management. The trace-point format is generic and can be easily adapted to trace other upius if needed. Currently tracing ufs transaction of type 'd