Fixes: 99cfdc04c12e ("scsi: libsas: direct call probe and destruct")
Signed-off-by: Fengguang Wu
---
sas_discover.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/libsas/sas_discover.c
b/drivers/scsi/libsas/sas_discover.c
index 190108e..e4fd078 100644
--- a/
tree: https://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git for-next
head: f7c3d0667404295422c9a5d71fd87ca20c770f49
commit: 99cfdc04c12ea1bc5719bff15f24dae8b5b90da9 [237/263] scsi: libsas: direct
call probe and destruct
reproduce:
# apt-get install sparse
git checkout 99
On 01/09/2018 05:09 AM, Jason Yan wrote:
> Hannes,
>
> On 2018/1/8 20:04, Hannes Reinecke wrote:
>> The abort handler might be racing with command completion, so the
>> task might already be NULL by the time the abort handler is called.
>>
>> Signed-off-by: Hannes Reinecke
>> ---
>> drivers/scs
On 01/08/2018 07:50 PM, Bart Van Assche wrote:
> The previous two patches guarantee that srp_queuecommand() does not get
> invoked while reconnecting occurs. Hence remove the code from
> srp_queuecommand() that prevents command queueing while reconnecting.
> This patch avoids that the following can
On 01/08/2018 07:50 PM, Bart Van Assche wrote:
> Several SCSI transport and LLD drivers surround code that does not
> tolerate concurrent calls of .queuecommand() with scsi_target_block() /
> scsi_target_unblock(). These last two functions use
> blk_mq_quiesce_queue() / blk_mq_unquiesce_queue() for
On 01/08/2018 07:50 PM, Bart Van Assche wrote:
> Introduce functions that allow block drivers to wait while a request
> queue is in the quiesced state (blk-mq) or in the stopped state (legacy
> block layer). The next patch will add calls to these functions in the
> SCSI core.
>
> Signed-off-by: Ba
On 01/08/2018 07:50 PM, Bart Van Assche wrote:
> Rename a waitqueue in struct request_queue since the next patch will
> add code that uses this waitqueue outside the request queue freezing
> implementation.
>
> Signed-off-by: Bart Van Assche
> Cc: Christoph Hellwig
> Cc: Hannes Reinecke
> Cc: J
Hannes,
On 2018/1/8 20:04, Hannes Reinecke wrote:
The abort handler might be racing with command completion, so the
task might already be NULL by the time the abort handler is called.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libsas/sas_scsi_host.c | 22 +++---
1 file
chenxiang,
> According to ATA protocol, there are two other values for SET MAX commands'
> feature field. So definite them. Also those SET MAX commands belong to
> different frame types,and judge feature field of SET MAX commands to decide
> which frame type they belongs to.
Applied to 4.16/sc
On Mon, Jan 08, 2018 at 10:16:55PM -0500, Martin K. Petersen wrote:
>
> Tejun,
>
> Are you OK with me pulling this change through the SCSI tree?
Sure, yeah, please go ahead.
Thanks.
--
tejun
Himanshu,
> scsi: qedi: Use zeroing allocator instead of allocator/memset --Resend
> scsi: mvsas: Use zeroing allocator rather than allocator/memset
> scsi: fnic: Use zeroing allocator rather than allocator/memset
> scsi: dpt_i2o: Use zeroing allocator rather than allocator/memset
> scsi: bnx2fc:
Steffen,
> If CONFIG_SCSI_SMARTPQI=y then don't build this driver as a module.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Douglas,
> While testing the WRITE SCATTERED command support in a new sg3_utils
> utility (sg_write_x) it was helpful to have a target that supported
> this command. This command might be attractive to other kernel
> subsystems. Even if end devices don't support this command yet, it
> would most
Tejun,
Are you OK with me pulling this change through the SCSI tree?
> There are two other values for SET MAX feature field according to ata
> protocol. So definite them.
>
> Signed-off-by: Xiang Chen
> Signed-off-by: John Garry
> ---
> include/linux/ata.h | 2 ++
> 1 file changed, 2 insertio
Jens,
> Completely up to you - I already have 1-5, I can add 6/7 as well, or
> just can do it in your tree. Let me know what you prefer.
Started my 4.16/scsi-fixes branch early based on your tree.
I queued these two up.
--
Martin K. Petersen Oracle Linux Engineering
Bart,
> Show the request result, request timeout and SCSI command flags.
> This information is very helpful when trying to figure out why a
> queue got stuck. An example of the information that is exported
> through debugfs:
Applied to 4.16/scsi-fixes, thanks.
--
Martin K. Petersen Oracle
Suganath,
> This patch set is initially posted by Hannes Reinecke to enable scsi
> multiqueue for the mpt3sas driver. While the HBA only has a single
> mailbox register for submitting commands, it does have individual
> receive queues per MSI-X interrupt and as such does benefit from
> convertin
Uma,
> This patch series contains miscellaneous fixes. The first patch fixes
> a bug while the rest improve the code structure and prepare the code
> for future enhancements.
Added stable tag to first patch and applied series to
4.16/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Lin
Xiongfeng,
> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-truncation]
>
> We need to use strlcpy() to make sure the dest string is
Colin,
> A previous commit no longer stores the contents of c, so we now have a
> situation where c is being updated but the value is never read. Clean
> up the code by removing the now redundant setting of variable c.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux
Varun,
> For mgmt cmds ->alloc_pdu() can be called from atomic
> context so use GFP_ATOMIC instead of GFP_KERNEL.
Applied to 4.16/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
Jason,
> We've got a memory leak with the following producer:
Applied patches 1-3 to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Monday, January 8, 2018 5:02:53 PM CET Martin K. Petersen wrote:
>
> Bart,
>
> > Avoid that the following warning is reported when suspending a system
> > that is using the mptspi driver:
>
> Acked-by: Martin K. Petersen
Thanks!
Let me take both patches to the linux-pm tree then.
Thanks,
This saves a little .text and gets rid of the unmotivated line break and
the sizeof(...) style inconsistency.
Signed-off-by: Rasmus Villemoes
---
drivers/scsi/fnic/fnic_fcs.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/scsi/fnic/fnic_fcs.c b/drivers/scsi/fnic/f
Introduce functions that allow block drivers to wait while a request
queue is in the quiesced state (blk-mq) or in the stopped state (legacy
block layer). The next patch will add calls to these functions in the
SCSI core.
Signed-off-by: Bart Van Assche
Cc: Martin K. Petersen
Cc: Christoph Hellwi
The previous two patches guarantee that srp_queuecommand() does not get
invoked while reconnecting occurs. Hence remove the code from
srp_queuecommand() that prevents command queueing while reconnecting.
This patch avoids that the following can appear in the kernel log:
BUG: sleeping function call
Several SCSI transport and LLD drivers surround code that does not
tolerate concurrent calls of .queuecommand() with scsi_target_block() /
scsi_target_unblock(). These last two functions use
blk_mq_quiesce_queue() / blk_mq_unquiesce_queue() for scsi-mq request
queues to prevent concurrent .queuecom
Hello Jens,
A longstanding issue with the SCSI core is that several SCSI transport drivers
use scsi_target_block() and scsi_target_unblock() to avoid concurrent
.queuecommand() calls during e.g. transport recovery but that this is not
sufficient to protect from such calls. Hence this patch series.
Rename a waitqueue in struct request_queue since the next patch will
add code that uses this waitqueue outside the request queue freezing
implementation.
Signed-off-by: Bart Van Assche
Cc: Christoph Hellwig
Cc: Hannes Reinecke
Cc: Johannes Thumshirn
Cc: Ming Lei
---
block/blk-core.c |
* Alan Cox wrote:
> On Mon, 8 Jan 2018 11:08:36 +0100
> Peter Zijlstra wrote:
>
> > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote:
> > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman
> > > wrote:
> > > > In at least one place (mpls) you are patching a fast path. Compile
https://bugzilla.kernel.org/show_bug.cgi?id=151661
--- Comment #22 from Matthias (hm10...@gmail.com) ---
with my Adaptec 3405 and Kernel of Ubuntu 16.04.3 (Kernel 4.4.0-104-generic)
and also with self-compiled 4.13.0, the message does not appear anymore.
--
You are receiving this mail because:
Y
On Mon, 2018-01-08 at 13:04 +0100, Hannes Reinecke wrote:
> The abort handler might be racing with command completion, so the
> task might already be NULL by the time the abort handler is called.
Hi,
I tried the patch on top of 4.15-rc7 (and without the revert of 90965761). I
don't have the NULL
> On Jan 7, 2018, at 1:36 PM, Matthew R. Ochs wrote:
>
> On Thu, Jan 04, 2018 at 05:33:48PM +1100, Andrew Donnellan wrote:
>> On 04/01/18 09:54, Uma Krishnan wrote:
>>> In the event of a command failure, cxlflash returns the failure to the
>>> upper layers to process. After processing the error,
On Mon, Jan 8, 2018 at 1:49 PM, Xiongfeng Wang
wrote:
> From: Xiongfeng Wang
>
> gcc-8 reports
>
> drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
> ./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
> bound 100 equals destination size [-Wstringop-trunc
On 01/05/18 22:30, Dan Williams wrote:
On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman wrote:
Please expand this.
It is not clear what the static analysis is looking for. Have a clear
description of what is being fixed is crucial for allowing any of these
changes.
For the details given in
On 1/8/18 8:52 AM, Martin K. Petersen wrote:
>
> Jens,
>
>> This looks OK for me for 4.16. I can grab all of them, or I can leave
>> the last two for Martin to apply if he prefers that, though that will
>> add a block tree dependency for SCSI.
>
> I already have a block dependency for 4.16. But
Bart,
> Avoid that the following warning is reported when suspending a system
> that is using the mptspi driver:
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Andy,
> Using this extension reduces the object size.
Applied to 4.16/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Jens,
> This looks OK for me for 4.16. I can grab all of them, or I can leave
> the last two for Martin to apply if he prefers that, though that will
> add a block tree dependency for SCSI.
I already have a block dependency for 4.16. But it doesn't matter much.
--
Martin K. Petersen Oracl
From: Xiongfeng Wang
gcc-8 reports
drivers/message/fusion/mptbase.c: In function 'mpt_display_event_info':
./include/linux/string.h:245:9: warning: '__builtin_strncpy' specified
bound 100 equals destination size [-Wstringop-truncation]
We need to use strlcpy() to make sure the dest string is
nu
The abort handler might be racing with command completion, so the
task might already be NULL by the time the abort handler is called.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libsas/sas_scsi_host.c | 22 +++---
1 file changed, 19 insertions(+), 3 deletions(-)
diff --git a
On Mon, Jan 08, 2018 at 11:43:42AM +, Alan Cox wrote:
> On Mon, 8 Jan 2018 11:08:36 +0100
> Peter Zijlstra wrote:
>
> > On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote:
> > > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman
> > > wrote:
> > > > In at least one place (mpls) y
On Mon, 8 Jan 2018 11:08:36 +0100
Peter Zijlstra wrote:
> On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote:
> > On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman
> > wrote:
> > > In at least one place (mpls) you are patching a fast path. Compile out
> > > or don't load mpls by al
On 01/08/2018 12:23 PM, Christoph Hellwig wrote:
> On Mon, Jan 08, 2018 at 11:51:56AM +0100, Hannes Reinecke wrote:
>> The abort handler might be racing with command completion, so the
>> task might already be NULL by the time the abort handler is called.
>
> But without taking dev_done_lock (or u
Btw, did you manage to get any further with these new drivers?
On Wed, Jun 28, 2017 at 10:32:26AM +0200, Hannes Reinecke wrote:
> Hi all,
> finally here's the patchset to revamp the SCSI EH callback arguments
> which I promised to do (some years ago ...).
What happened to this series?
On Mon, Jan 08, 2018 at 11:51:56AM +0100, Hannes Reinecke wrote:
> The abort handler might be racing with command completion, so the
> task might already be NULL by the time the abort handler is called.
But without taking dev_done_lock (or using cmpxchg) what prevents
use from still hitting this,
On 01/08/2018 11:11 AM, Christoph Hellwig wrote:
> Hannes said he was going to look into this, which makes sense
> given that he designed the async abort code.
>
> On Fri, Jan 05, 2018 at 01:13:48PM +0100, Yves-Alexis Perez wrote:
>> Hi,
>>
>> since kernel 4.11 (sorry it took so long to report) I
The abort handler might be racing with command completion, so the
task might already be NULL by the time the abort handler is called.
Signed-off-by: Hannes Reinecke
---
drivers/scsi/libsas/sas_scsi_host.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/libsa
Hannes said he was going to look into this, which makes sense
given that he designed the async abort code.
On Fri, Jan 05, 2018 at 01:13:48PM +0100, Yves-Alexis Perez wrote:
> Hi,
>
> since kernel 4.11 (sorry it took so long to report) I have a box failing to
> boot with a NULL pointer dereferenc
On Fri, Jan 05, 2018 at 10:30:16PM -0800, Dan Williams wrote:
> On Fri, Jan 5, 2018 at 6:22 PM, Eric W. Biederman
> wrote:
> > In at least one place (mpls) you are patching a fast path. Compile out
> > or don't load mpls by all means. But it is not acceptable to change the
> > fast path without
NAK. Please implement the same ioctl interfaces as the nvme driver
instead of inventing your own incomaptible one.
On 01/04/2018 02:04 PM, Jason Yan wrote:
> From: chenxiang
>
> The status of SAS PHY is in sas_phy->enabled. There is an issue that the
> status of a remote SAS PHY may be initialized incorrectly: if disable remote
> SAS PHY through sysfs interface (such as echo 0 >
> /sys/class/sas_phy/phy-1:0:
On 01/04/2018 02:04 PM, Jason Yan wrote:
> The intend purpose here was to goto out if smp_execute_task() returned
> error. Obviously something got screwed up. We will never get these link
> error statistics below:
>
> ~:/sys/class/sas_phy/phy-1:0:12 # cat invalid_dword_count
> 0
> ~:/sys/class/sas
On 01/04/2018 02:04 PM, Jason Yan wrote:
> We've got a memory leak with the following producer:
>
> while true;
> do cat /sys/class/sas_phy/phy-1:0:12/invalid_dword_count >/dev/null;
> done
>
> The buffer req is allocated and not freed after we return. Fix it.
>
> Fixes: 2908d778ab3e ("[SCSI] ai
+cc Jack Wang
在 2018/1/4 10:36, chenxiang 写道:
For function dma_unmap_sg(), the parameter should be number of
elements in the scatterlist prior to the mapping, not after the mapping.
Fix this usage.
Cc: Jack Wang
Cc: lindar_...@usish.com
Fixes: dbf9bfe6("[SCSI]pm8001: add SAS/SATA/HBA driver"
"Martin K. Petersen" writes:
> I am thoroughly annoyed by all the legacy whitespace problems. I've been
> working on two different sd patch series over the holidays and both
> caused me no end of grief due to legacy formatting issues.
>
> I have had an unbreak-sd patch sitting in my queue for seve
57 matches
Mail list logo
