On Mon, 18 Dec 2017 01:28:44 +0100,
Joe Perches wrote:
>
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these
chenxiang,
> The type of function pci_choose_state's return value is pci_power_t
> while we define it as a u32. A warning will be reported by sparse. So
> change u32 into pci_power_t.
Applied to 4.16/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Himanshu,
> This patch fixes following warnings reported by smatch
>
> drivers/scsi/qla2xxx/qla_mid.c:586 qla25xx_delete_req_que()
> error: we previously assumed 'req' could be null (see line 580)
>
> drivers/scsi/qla2xxx/qla_mid.c:602 qla25xx_delete_rsp_que()
> error: we previously assumed 'rsp'
Hannes,
> As it turned out device_get() doesn't use kref_get_unless_zero(),
> so we will be always getting a device pointer.
> So we need to check for the device state in __scsi_remove_target()
> to avoid tripping over deleted objects.
Applied to 4.15/scsi-fixes. Thanks!
--
Martin K. Petersen
Jia-Ju,
> To fix it, GFP_KERNEL is replaced with GFP_ATOMIC.
>
> This bug is found by my static analysis tool(DSAC) and checked by my
> code review.
Applied to 4.16/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Joe,
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
SCSI bits look OK.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
The type of function pci_choose_state's return value is pci_power_t while we
define it as a u32. A warning will be reported by sparse. So change u32
into pci_power_t.
Signed-off-by: Xiang Chen
---
drivers/scsi/hisi_sas/hisi_sas_v3_hw.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
On 17/12/2017 at 16:28:44 -0800, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifi
On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for the
On Sun, Dec 17, 2017 at 04:28:44PM -0800, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for the
On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifie
On Sun, Dec 17, 2017 at 7:28 PM, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifie
Good Day,
Forgive my indignation if this message comes to you as a surprise and may
offend your personality for contacting you without your prior consent and
writing through this channel.
I came across your name and contact on the course of my personal searching when
i was searching for a fore
From: Romain Perier
Date: Fri, 15 Dec 2017 20:31:21 +0100
> From: Romain Perier
>
> The PCI pool API is deprecated. This commit replaces the PCI pool old
> API by the appropriate function with the DMA pool API.
>
> Signed-off-by: Romain Perier
> Acked-by: Peter Senna Tschudin
> Acked-by: Jef
From: Romain Perier
Date: Fri, 15 Dec 2017 20:31:22 +0100
> From: Romain Perier
>
> The PCI pool API is deprecated. This commit replaces the PCI pool old
> API by the appropriate function with the DMA pool API.
>
> Signed-off-by: Romain Perier
Acked-by: David S. Miller
On Monday, December 18, 2017 1:28:44 AM CET Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for t
Hi Paul,
> -Original Message-
> From: Paul Menzel [mailto:pmen...@molgen.mpg.de]
> Sent: Saturday, December 16, 2017 1:39 AM
> To: Raghava Aditya Renukunta
> ; dl-esc-Aacraid Linux Driver
>
> Cc: linux-scsi@vger.kernel.org; it+linux-s...@vger.kernel.org
> Subject: Re: Driver version for
On Thu, 2017-12-14 at 17:10 -0500, Ewan D. Milne wrote:
> On Thu, 2017-12-14 at 10:02 +0100, Hannes Reinecke wrote:
> > On 12/14/2017 09:05 AM, Jason Yan wrote:
> > >
> > > On 2017/12/14 6:23, Bart Van Assche wrote:
> > >> On Wed, 2017-12-13 at 14:21 +0100, Hannes Reinecke wrote:
> > >>> As it tur
On Mon, Dec 18, 2017 at 2:28 AM, Joe Perches wrote:
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
>
> This allows various function analyzers like gnu complexity to work
> properly for these modifie
On 12/16/2017 02:31 PM, Xose Vazquez Perez wrote:
> Hi,
>
> After last pattern matching changes, maybe some entries should be revised:
>
>
> Empty strings(current meaning?):
> {"", "Scanner", "1.80", BLIST_NOLUN}, /* responds to all lun */
> {"Promise", "", NULL, BLIST_SPARSELUN},
On 12/15/2017 07:08 PM, Steffen Maier wrote:
>
> On 12/14/2017 11:11 AM, Hannes Reinecke wrote:
>> When a device announces an 'FC' protocol we should be pulling
>> in the FC transport class to have the rports etc setup correctly.
>
> It took some time for me to understand what this does.
> It see
21 matches
Mail list logo
