In case (a) scsi_eh_inc_host_failed() will wake up the error handler. And
in
case (b) scsi_dec_host_busy() will wake up the error handler. So it's not
clear to me why you think that there is a scenario in which the EH won't be
woken up?
>>>
>>> So in case (b), in my unders
Hi Martin,
> On Dec 6, 2017, at 6:43 PM, Martin K. Petersen
> wrote:
>
>
> Himanshu,
>
>>> This looks pretty big for a series of bug fixes. Are all these
>>> patches really candidates for 4.15 and stable backports all the way
>>> back to 4.10?
>
>> Yes Please. I would want them back ported
Himanshu,
>> This looks pretty big for a series of bug fixes. Are all these
>> patches really candidates for 4.15 and stable backports all the way
>> back to 4.10?
> Yes Please. I would want them back ported to 4.10 since these issues
> were discovered in combination of 4.10/4.11 kernel.
James
Doug,
> While testing "sd: Micro-optimize READ / WRITE CDB encoding" patches
> it was helpful to check various code paths associated with READ/WRITE
> 6, 10 and 16 byte cdb variants. There seems to be no user space
> "knobs" to twiddle use_10_for_rw and friends in the scsi_device
> structure. So
Bart,
> These three patches is what I came up with after having reviewed
> recent changes in the code for handling blacklist flags
> handling. Please consider these patches for kernel v4.16.
I applied 1 and 3 to 4.16/scsi-queue. I am still not a fan of forcing
u32. That's a recipe for disaster w
Bart,
> As reported by Pavel Tikhomirov it can happen that the SCSI error
> handler does not get woken up. This is very annoying because it
> results in a queue stall. The two patches in this series address this
> issue without acquiring the SCSI host lock in the hot path. Please
> consider these
Can anybody review this patch? Our test of SG_IO all failed because of
this bug.
On 2017/12/5 17:39, Jason Yan wrote:
The bsg_job_done() requires the length of payload received, but we give
it the untransferred residual.
Fixes: 651a01364994 ("scsi: scsi_transport_sas: switch to bsg-lib for SMP"
On Thu, Dec 07, 2017 at 12:10:51AM +0100, Holger Hoffstätte wrote:
> On 12/05/17 08:52, Ming Lei wrote:
> > Before commit 0df21c86bdbf ("scsi: implement .get_budget and .put_budget
> > for blk-mq"), we run queue after 3ms if queue is idle and SCSI device
> > queue isn't ready, which is done in hand
On Wed, Dec 06, 2017 at 04:07:17PM +, Bart Van Assche wrote:
> On Wed, 2017-12-06 at 09:52 +0800, Ming Lei wrote:
> > On Wed, Dec 06, 2017 at 12:28:25AM +0800, Ming Lei wrote:
> > > On Tue, Dec 05, 2017 at 04:08:20PM +, Bart Van Assche wrote:
> > > > The patch below is not a full solution b
Ching,
> Due to 4.16/scsi-queue conflict with 4.15-rc1, so I resubmit these
> patches again. The following patches apply to Linus' 4.15-rc1 tree.
Thanks for reworking this series! I have applied it to 4.16/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
On 12/05/17 08:52, Ming Lei wrote:
> Before commit 0df21c86bdbf ("scsi: implement .get_budget and .put_budget
> for blk-mq"), we run queue after 3ms if queue is idle and SCSI device
> queue isn't ready, which is done in handling BLK_STS_RESOURCE. After
> commit 0df21c86bdbf is introduced, queue won
These duplicate includes have been found with scripts/checkincludes.pl but
they have been removed manually to avoid removing false positives.
Signed-off-by: Pravin Shedge
---
drivers/scsi/qla2xxx/qla_nx2.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/qla2xxx/qla_nx2.c b/driv
On Wed, 2017-12-06 at 09:52 +0800, Ming Lei wrote:
> On Wed, Dec 06, 2017 at 12:28:25AM +0800, Ming Lei wrote:
> > On Tue, Dec 05, 2017 at 04:08:20PM +, Bart Van Assche wrote:
> > > The patch below is not a full solution but resulted in a significant
> > > improvement in my tests:
> > >
> > >
On Wed, 2017-12-06 at 09:07 +0100, Johannes Thumshirn wrote:
> James Bottomley writes:
> >
> > On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote:
> > >
> > > Commit 'cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost()
> > > helper")'
> > > changed access to bfa's 'struct bfad_im_port_s'
From: Colin Ian King
There are several places where the source is not indented correctly
with either too many or too few levels of intentation. Fix these.
Signed-off-by: Colin Ian King
---
drivers/message/fusion/mptbase.c | 57
1 file changed, 29 insert
A regression fix introduced a harmless type mismatch warning:
drivers/scsi/bfa/bfad_bsg.c: In function 'bfad_im_bsg_vendor_request':
drivers/scsi/bfa/bfad_bsg.c:3137:35: error: initialization of 'struct
bfad_im_port_s *' from 'long unsigned int' makes pointer from integer without a
cast [-Werror
James Bottomley writes:
> On Tue, 2017-11-28 at 16:26 +0100, Johannes Thumshirn wrote:
>> Commit 'cd21c605b2cf ("scsi: fc: provide fc_bsg_to_shost() helper")'
>> changed access to bfa's 'struct bfad_im_port_s' by using shost_priv()
>> instead of shost->hostdata[0].
>>
>> This lead to crashes like
17 matches
Mail list logo
