Re: [PATCH v2] target/iscsi: Convert timers to use timer_setup()

2017-10-30 Thread Kees Cook
On Fri, Oct 27, 2017 at 5:57 AM, Bart Van Assche wrote: > On Fri, 2017-10-27 at 02:19 -0700, Kees Cook wrote: >> In preparation for unconditionally passing the struct timer_list pointer to >> all timer callbacks, switch to using the new timer_setup() and from_timer() >> to pass the timer pointer e

[PATCH v11 3/7] block: Introduce BLK_MQ_REQ_PREEMPT

2017-10-30 Thread Bart Van Assche
Set RQF_PREEMPT if BLK_MQ_REQ_PREEMPT is passed to blk_get_request_flags(). Signed-off-by: Bart Van Assche Reviewed-by: Hannes Reinecke Tested-by: Martin Steigerwald Cc: Christoph Hellwig Cc: Ming Lei Cc: Johannes Thumshirn --- block/blk-core.c | 4 +++- block/blk-mq.c | 2 ++

[PATCH v11 7/7] block, nvme: Introduce blk_mq_req_flags_t

2017-10-30 Thread Bart Van Assche
Several block layer and NVMe core functions accept a combination of BLK_MQ_REQ_* flags through the 'flags' argument but there is no verification at compile time whether the right type of block layer flags is passed. Make it possible for sparse to verify this. This patch does not change any function

[PATCH v11 2/7] block: Introduce blk_get_request_flags()

2017-10-30 Thread Bart Van Assche
A side effect of this patch is that the GFP mask that is passed to several allocation functions in the legacy block layer is changed from GFP_KERNEL into __GFP_DIRECT_RECLAIM. Signed-off-by: Bart Van Assche Reviewed-by: Hannes Reinecke Tested-by: Martin Steigerwald Cc: Christoph Hellwig Cc: Mi

[PATCH v11 4/7] ide, scsi: Tell the block layer at request allocation time about preempt requests

2017-10-30 Thread Bart Van Assche
Convert blk_get_request(q, op, __GFP_RECLAIM) into blk_get_request_flags(q, op, BLK_MQ_PREEMPT). This patch does not change any functionality. Signed-off-by: Bart Van Assche Tested-by: Martin Steigerwald Acked-by: David S. Miller [ for IDE ] Acked-by: Martin K. Petersen Reviewed-by: Hannes Rei

[PATCH v11 1/7] block: Make q_usage_counter also track legacy requests

2017-10-30 Thread Bart Van Assche
From: Ming Lei This patch makes it possible to pause request allocation for the legacy block layer by calling blk_mq_freeze_queue() and blk_mq_unfreeze_queue(). Signed-off-by: Ming Lei [ bvanassche: Combined two patches into one, edited a comment and made sure REQ_NOWAIT is handled properly i

[PATCH v11 6/7] block, scsi: Make SCSI quiesce and resume work reliably

2017-10-30 Thread Bart Van Assche
The contexts from which a SCSI device can be quiesced or resumed are: * Writing into /sys/class/scsi_device/*/device/state. * SCSI parallel (SPI) domain validation. * The SCSI device power management methods. See also scsi_bus_pm_ops. It is essential during suspend and resume that neither the file

[PATCH v11 5/7] block: Add the QUEUE_FLAG_PREEMPT_ONLY request queue flag

2017-10-30 Thread Bart Van Assche
This flag will be used in the next patch to let the block layer core know whether or not a SCSI request queue has been quiesced. A quiesced SCSI queue namely only processes RQF_PREEMPT requests. Signed-off-by: Bart Van Assche Reviewed-by: Hannes Reinecke Tested-by: Martin Steigerwald Cc: Ming L

[PATCH v11 0/7] block, scsi, md: Improve suspend and resume

2017-10-30 Thread Bart Van Assche
Hello Jens, It is known that during the resume following a hibernate, especially when using an md RAID1 array created on top of SCSI devices, sometimes the system hangs instead of coming up properly. This patch series fixes that problem. These patches have been tested on top of the block layer for

[PATCH] scsi_error.c: DID_SOFT_ERROR comment clean up

2017-10-30 Thread Petros Koutoupis
Updated comment. We are keeping track of maximum number of retries per command via retries/allowed in struct scsi_cmnd. Corrected comment positioning. Signed-off-by: Petros Koutoupis diff -uNpr linux-4.14-rc7.orig/drivers/scsi/scsi_error.c linux-4.14-rc7/drivers/scsi/scsi_error.c --- linux-4.1

Re: [PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

2017-10-30 Thread Brian King
On 10/30/2017 03:37 PM, Bart Van Assche wrote: > On Wed, 2017-10-18 at 15:57 -0500, Brian King wrote: >> On 10/17/2017 01:19 AM, Hannes Reinecke wrote: >>> On 10/17/2017 12:49 AM, Bart Van Assche wrote: [ ... ] >>> >>> Not sure if this is a valid conversion. >>> Originally the driver would all

Re: [PATCH v2 6/8] scsi/ipr: Use sgl_alloc_order() and sgl_free_order()

2017-10-30 Thread Bart Van Assche
On Wed, 2017-10-18 at 15:57 -0500, Brian King wrote: > On 10/17/2017 01:19 AM, Hannes Reinecke wrote: > > On 10/17/2017 12:49 AM, Bart Van Assche wrote: > > > [ ... ] > > > > Not sure if this is a valid conversion. > > Originally the driver would allocate a single buffer; with this buffer > > we h

Re: 答复: [PATCH v5 2/5] dt-bindings: scsi: ufs: add document for hisi-ufs

2017-10-30 Thread Arnd Bergmann
On Tue, Oct 24, 2017 at 11:06 AM, liwei (CM) wrote: > what's your opinion about my explanation and revision method? > I am looking forward to your reply, thanks! Sorry for the delay, I was travelling last week. > 发件人: arndbergm...@gmail.com [mailto:arndbergm...@gmail.com] 代表 Arnd Bergmann > On Fr

RE: system hung up when offlining CPUs

2017-10-30 Thread Shivasharan Srikanteshwara
> -Original Message- > From: Thomas Gleixner [mailto:t...@linutronix.de] > Sent: Tuesday, October 17, 2017 1:57 AM > To: YASUAKI ISHIMATSU > Cc: Kashyap Desai; Hannes Reinecke; Marc Zyngier; Christoph Hellwig; > ax...@kernel.dk; m...@ellerman.id.au; keith.bu...@intel.com; > pet...@infradead