Maybe my first version is suitable for stable.
Huacai
-- Original --
From: "Marek Szyprowski";
Date: Wed, Oct 25, 2017 03:21 PM
To: "陈华才"; "Christoph Hellwig";
Cc: "Robin Murphy"; "Andrew
Morton"; "Fuxin Zhang";
"linux-kernel"; "Ralf
Baechle"; "JamesHoga
Doug,
> The sd_setup_read_write_cmnd() function is on the "fast path" for
> block system access to SCSI devices (logical units). Rewrite this
> function to improve speed and readability.
Please do any optimizations on top of my scsi-work branch which has the
sd_setup_read_write_cmnd() rewrite. I
The 5380 drivers only support asynchronous transfers and the 5380
controllers only have narrow busses. Hence, the core driver will reject
any SDTR and WDTR messages from target devices. Don't log this, it's
expected behaviour. Also, fix the off-by-one array indices in the
arguments to scmd_print
The sd_setup_read_write_cmnd() function is on the "fast path" for
block system access to SCSI devices (logical units). Rewrite this
function to improve speed and readability.
version 2.2:
- remove empty branch from condition (review comment)
- remove redundant log message
- introduce lb_size va
Hi Martin,
> On Oct 16, 2017, at 8:08 PM, Martin K. Petersen
> wrote:
>
>
> Madhani,
>
>> This series adds support for INTx mode for qla2xxx driver. Also, adds
>> support for N2N login for FC-NVMe.
>>
>> Please apply to 4.15/scsi-queue at your earliest convenience.
>
> Several of the patch
Hi Martin,
> On Oct 16, 2017, at 8:09 PM, Martin K. Petersen
> wrote:
>
>
> Himanshu,
>
>> This series has couple bug fixes for FC-NVMe code path. Please apply
>> them to 4.15/scsi-queue at your earliest convenience.
>
> Applied to 4.15/scsi-queue.
>
> PS. You send email as "Madhani, Madha
Hello Bart,
> On Oct 17, 2017, at 9:12 PM, Bart Van Assche wrote:
>
> On Mon, 2017-10-16 at 11:26 -0700, Madhani, Himanshu wrote:
>> diff --git a/drivers/scsi/qla2xxx/qla_os.c b/drivers/scsi/qla2xxx/qla_os.c
>> index 937209805baf..3bd956d3bc5d 100644
>> --- a/drivers/scsi/qla2xxx/qla_os.c
>> ++
Hi Bart,
> On Oct 19, 2017, at 6:13 PM, Bart Van Assche wrote:
>
> Hello Himanshu,
>
> If I load the qla2xxx driver
> (git://git.kernel.org/pub/scm/linux/kernel/git/mkp/scsi.git,
> 4.15/scsi-queue) then a new kernel warning appears. This did not happen with
> kernel v4.13.
> Can you have a l
From: "Matthew R. Ochs"
The cxlflash driver tracks process IDs alongside contexts to validate
context ownership. Currently, the process IDs are derived by directly
accessing values from the 'current' task pointer. While this method
of access is fine for the current process, it is incorrect when t
From: "Matthew R. Ochs"
The existing write same routine within the cxlflash driver uses a
statically defined value for the maximum write same transfer length.
While this is close to the value reflected by the original device that
was supported by cxlflash, newer devices are capable of much larger
From: "Matthew R. Ochs"
Currently, all adapters that cxlflash supports must have WWPN VPD
keywords to complete configuration. This was required as cards with
external FC ports needed to be programmed with WWPNs.
Newer supported cards do not have an external FC interface and
therefore do not requ
This patch series contains miscellaneous fixes. All three patches resolve
minor issues.
This series is intended for 4.15 and is bisectable.
Matthew R. Ochs (3):
cxlflash: Use derived maximum write same length
cxlflash: Allow cards without WWPN VPD to configure
cxlflash: Derive pid through a
On 2017-10-25 03:28 AM, Hannes Reinecke wrote:
On 10/25/2017 05:52 AM, Douglas Gilbert wrote:
The sd_setup_read_write_cmnd() function is on the "fast path" for
block system access to SCSI devices (logical units). Rewrite this
function to improve speed and readability:
- use put_unaligned_be fa
> On Oct 20, 2017, at 6:17 AM, Douglas Miller
> wrote:
>
> On error, kthread_create() returns an errno-encoded pointer, not NULL.
> The routine qla2x00_probe_one() detects the error case and jumps
> to probe_failed, but has already assigned the return value from
> kthread_create() to ha->dpc_th
On Wed, 2017-10-25 at 16:10 +0200, Kees Cook wrote:
> However, maintainers: sorry to send this one -- it can't be merged
> yet, this uses timer_setup_on_stack() which is only in -next right
> now. If it looks okay, though, I can carry this in the timer tree.
Hello Kees,
Can you have a look at the
Hello,
On Wed, Oct 25, 2017 at 03:52:56PM +0530, Rameshwar Prasad Sahu wrote:
> @@ -288,8 +289,8 @@
> ),
>
> TP_fast_assign(
> - __entry->ata_port = dev->link->ap->print_id;
> - __entry->ata_dev= dev->link->pmp + dev->devno;
> + __entr
On Wed, Oct 25, 2017 at 2:41 PM, Jason A. Donenfeld wrote:
> On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote:
>> sess->time2retain_timer.expires =
>> (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ);
>> add_timer(&sess->time2retain_timer);
>>
On Wed, Oct 25, 2017 at 12:01 PM, Kees Cook wrote:
> sess->time2retain_timer.expires =
> (get_jiffies_64() + sess->sess_ops->DefaultTime2Retain * HZ);
> add_timer(&sess->time2retain_timer);
> cmd->dataout_timer.expires = (get_jiffies_64() + na->dataout_timeo
Yisheng,
> I have get many kmemleak reports just similar to commit 70c54e210ee9
> (scsi: megaraid_sas: fix memleak in megasas_alloc_cmdlist_fusion)
> on v4.14-rc6, however it seems have a different stroy:
Do you still see leaks reported with the megaraid driver update recently
merged into 4.15/s
John,
> This patchset contains many misc fixes, improvements, and a few new
> features.
>
> Here is a list of the significant changes:
> - more fixes for hisi_hba.locking
> - v3 hw DFX feature
> - random error handling bugfixes
> - reporting v2 hw errors to userspace
Applied to 4.15/scsi-queue.
When tracing ata link error event, the kernel crashes when the disk is
removed due to NULL pointer access by trace_ata_eh_link_autopsy API.
This occurs as the dev is NULL when the disk disappeared. Given that
the trace routine requires only the link info, pass the link info instead
of passing dev p
megasas_alloc_cmds is to alloc cmd_list of instance instead of fusion,
and fusion is useless in this function. Just remove it.
Signed-off-by: Yisheng Xie
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Karen Xie
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-o
I have get many kmemleak reports just similar to commit 70c54e210ee9
(scsi: megaraid_sas: fix memleak in megasas_alloc_cmdlist_fusion)
on v4.14-rc6, however it seems have a different stroy:
unreferenced object 0x8b5139d9d2c0 (size 192):
comm "kworker/0:0", pid 3, jiffies 4294689182 (age 1134
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: "Martin K. Petersen"
Cc: "James E.J. Bottomley"
Cc: Varun Prakash
Cc: Johannes Thumshirn
Cc: linux-s
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: James Smart
Cc: Dick Kennedy
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: qla2xxx-upstr...@qlogic.com
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.ke
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: qlogic-storage-upstr...@qlogic.com
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-off-by: Kees Coo
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. This requires adding a pointer to
hold the timer's target task, as there isn't a link back from slow_task.
C
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. Also consolidates the timer setup
functions arguments, which are all identical, and corrects on-stack timer
u
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: "Martin K. Petersen"
Cc: Tyrel Datwyler
Cc: Benjamin Herrenschmidt
Cc: Paul Mackerras
Cc: Michael El
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: Brian King
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: linux-scsi@vger.kernel.org
Signed-
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly.
Cc: qlogic-storage-upstr...@qlogic.com
Cc: "James E.J. Bottomley"
Cc: "Martin K. Petersen"
Cc: Johannes Th
stat_timer only ever assigns the same function and data, so consolidate
to using timer_setup(), adjust callback, drop everything else used
to pass things around, and remove needless typedefs.
reset_timer is unused; remove it.
Cc: Hannes Reinecke
Cc: "James E.J. Bottomley"
Cc: "Martin K. Peterse
You are right. I've tested on 4.14-rc6, and it cannot be reproducible.
On Wed, Oct 25, 2017 at 4:01 PM, Johannes Thumshirn wrote:
> idaifish writes:
>
>> Hi,
>>
>> I've got the following report while fuzzing the kernel with syzkaller.
>> (on 4.9.58)
>
> Can you test if this is already fixed on
In preparation for unconditionally passing the struct timer_list pointer to
all timer callbacks, switch to using the new timer_setup() and from_timer()
to pass the timer pointer explicitly. Includes a fix for correcting an
on-stack timer usage.
Cc: "Nicholas A. Bellinger"
Cc: Jiang Yi
Cc: Varun
Jeffy,
> Add generated scsi_devinfo_tbl.c into .gitignore.
Applied to 4.15/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
On 10/25/2017 09:39 AM, Jeffy Chen wrote:
> Add generated scsi_devinfo_tbl.c into .gitignore.
>
> Signed-off-by: Jeffy Chen
> ---
>
> drivers/scsi/.gitignore | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/scsi/.gitignore b/drivers/scsi/.gitignore
> index c89ae9a04399..e295674
idaifish writes:
> Hi,
>
> I've got the following report while fuzzing the kernel with syzkaller.
> (on 4.9.58)
Can you test if this is already fixed on 4.14-rcX? There have been a
number of syzkaller related fixes between 4.9 and now. Probably we just
missed to back-port it to stable.
Thanks,
Hi Hannes,
On 10/25/2017 03:22 PM, Hannes Reinecke wrote:
On 10/25/2017 03:48 AM, jeffy wrote:
Hi guys,
maybe we need to add the generated scsi_devinfo_tbl.c into
drivers/scsi/.gitignore :)
Indeed, maybe.
So here's your chance to get a patch upstream :-)
Ok, will do that :)
Cheers,
Hann
Add generated scsi_devinfo_tbl.c into .gitignore.
Signed-off-by: Jeffy Chen
---
drivers/scsi/.gitignore | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/scsi/.gitignore b/drivers/scsi/.gitignore
index c89ae9a04399..e2956741fbd1 100644
--- a/drivers/scsi/.gitignore
+++ b/drivers/scsi/
On 10/25/2017 05:52 AM, Douglas Gilbert wrote:
> The sd_setup_read_write_cmnd() function is on the "fast path" for
> block system access to SCSI devices (logical units). Rewrite this
> function to improve speed and readability:
> - use put_unaligned_be family of functions to save lots of shifts
>
On 10/25/2017 03:48 AM, jeffy wrote:
> Hi guys,
>
> maybe we need to add the generated scsi_devinfo_tbl.c into
> drivers/scsi/.gitignore :)
>
Indeed, maybe.
So here's your chance to get a patch upstream :-)
Cheers,
Hannes
--
Dr. Hannes ReineckeTeamlead Storage & Networking
h...
Hi Huacai,
On 2017-10-25 03:22, 陈华才 wrote:
Hi, Marek
Patch3 is needed for stable, but Patch3 depend on Patch1 and Patch2.
Then patch #3 has to be reworked. First change scsi to align the block
queue to dma_get_cache_alignment(). This will be safe in all cases and
it will not hurt memory usa
45 matches
Mail list logo
