[PATCH V2] megaraid: kmemleak: Track page allocation for fusion

2017-09-14 Thread shuwang
From: Shu Wang Kmemleak reports about a thousand false positives for fusion-> cmd_list[]. Root casue is the cmd_list objects are allocated from slab allocator, and stored its pointer in object allocated by page allocator. The fix will tell kmemleak to track and scan fusion object. V2: Add commen

Re: [PATCH 1/2] bsg-lib: don't free job in bsg_prepare_job

2017-09-14 Thread Jens Axboe
On 09/07/2017 05:54 AM, Christoph Hellwig wrote: > The job structure is allocated as part of the request, so we should not > free it in the error path of bsg_prepare_job. Added for this series, thanks. -- Jens Axboe

[PATCH V4 3/3] scsi: Align queue to ARCH_DMA_MINALIGN in non-coherent DMA mode

2017-09-14 Thread Huacai Chen
In non-coherent DMA mode, kernel uses cache flushing operations to maintain I/O coherency, so scsi's block queue should be aligned to ARCH_DMA_MINALIGN. Otherwise, it will cause data corruption, at least on MIPS: Step 1, dma_map_single Step 2, cache_invalidate (no writeback)

Re: [PATCH RESEND] lpfc: Don't return internal MBXERR_ERROR code from probe function

2017-09-14 Thread Martin K. Petersen
James/Dick, Please review! > Internal error codes happen to be positive, thus the PCI driver > core won't treat them as failure, but we do. This would cause a > crash later on as lpfc_pci_remove_one() is called (e.g. as > shutdown function). > > Fixes: 6d368e532168 ("[SCSI] lpfc 8.3.24: Add reso

Re: [PATCH 0/3] fcoe: Fixup device_del() inversion

2017-09-14 Thread Martin K. Petersen
Hannes, > when shutting down an FCoE target system one is greeted with a flood > of kernel warnings about > > sysfs group 81eff0e0 not found for kobject 'XXX' > > Reason here is that the fcoe driver tries to remove devices from > a workqueue, but the NETDEV_UNREGISTER notification expects

Re: [PATCH] scsi: Remove unnecessary condition in sd_read_block_limits()

2017-09-14 Thread Martin K. Petersen
Lukas, > After series of changes around WRITE_SAME and UNMAP setup we ended up > with leftover unnecessary condition. Remove it. Yeah, lbprz went away and made it redundant. Applied to 4.14/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH v4 00/14] mpt3sas driver NVMe support:

2017-09-14 Thread Martin K. Petersen
Suganath, > Is there any update on the submitted mpt3sas patches. We are waiting for you to report back your findings on PRP vs. SGL. -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: acornscsi: fix build error

2017-09-14 Thread Martin K. Petersen
Arnd, > A cleanup patch introduced a fatal typo from inbalanced curly braces: Applied to 4.14/scsi-fixes. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] aacraid: Fix 2T+ drives on SmartIOC-2000

2017-09-14 Thread Martin K. Petersen
Dave, Not sure what happened. I do not have the original patch submission that Raghava replied to. Nor does patchwork or marc.info. Please resubmit. Thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH 2/2] scsi_transport_fc: fix NULL pointer dereference in fc_bsg_job_timeout

2017-09-14 Thread Martin K. Petersen
Christoph, > bsg-lib now embeddeds the job structure into the request, and > req->special can't be used anymore. Applied to 4.14/scsi-fixes. -- Martin K. Petersen Oracle Linux Engineering

Re: two small bsg fixes, take 3

2017-09-14 Thread Christoph Hellwig
On Thu, Sep 07, 2017 at 01:54:34PM +0200, Christoph Hellwig wrote: > Now fully away, with my fair share of coffee and lunch: > > > Two fixups for the recent bsg-lib fixes, should go into 4.13 stable as > well. Jens, can you look at this for Linux 4.14?

Re: [PATCH v2 17/17] iscsi_tcp: Remove a set-but-not-used variable

2017-09-14 Thread Lee Duncan
On 08/25/2017 01:46 PM, Bart Van Assche wrote: > This patch avoids that gcc reports the following warning when > building with W=1: > > drivers/scsi/iscsi_tcp.c:166:24: warning: variable ?session? set but not used > [-Wunused-but-set-variable] > > Signed-off-by: Bart Van Assche > Reviewed-by:

Re: system hung up when offlining CPUs

2017-09-14 Thread YASUAKI ISHIMATSU
On 09/13/2017 09:33 AM, Thomas Gleixner wrote: > On Wed, 13 Sep 2017, Kashyap Desai wrote: >>> On 09/12/2017 08:15 PM, YASUAKI ISHIMATSU wrote: + linux-scsi and maintainers of megasas > > In my server, IRQ#66-89 are sent to CPU#24-29. And if I offline > CPU#24-29, I/O does not work,

Re: [PATCH V4 08/10] block: allow to allocate req with RQF_PREEMPT when queue is preempt frozen

2017-09-14 Thread Ming Lei
On Thu, Sep 14, 2017 at 01:37:14PM +, Bart Van Assche wrote: > On Thu, 2017-09-14 at 09:15 +0800, Ming Lei wrote: > > On Wed, Sep 13, 2017 at 07:07:53PM +, Bart Van Assche wrote: > > > On Thu, 2017-09-14 at 01:48 +0800, Ming Lei wrote: > > > > No, that patch only changes blk_insert_cloned_r

Re: [PATCH] scsi: lpfc: remove redundant null check on eqe

2017-09-14 Thread James Smart
On 9/8/2017 1:02 AM, Colin King wrote: From: Colin Ian King The pointer eqe is always non-null inside the while loop, so the check to see if eqe is NULL is redudant and hence can be removed. Detected by CoverityScan CID#1248693 ("Logically Dead Code") Signed-off-by: Colin Ian King Yep. th

Re: [PATCH V4 08/10] block: allow to allocate req with RQF_PREEMPT when queue is preempt frozen

2017-09-14 Thread Bart Van Assche
On Thu, 2017-09-14 at 09:15 +0800, Ming Lei wrote: > On Wed, Sep 13, 2017 at 07:07:53PM +, Bart Van Assche wrote: > > On Thu, 2017-09-14 at 01:48 +0800, Ming Lei wrote: > > > No, that patch only changes blk_insert_cloned_request() which is used > > > by dm-rq(mpath) only, nothing to do with the

Re: [PATCH] megaraid: kmemleak: Track page allocation for fusion

2017-09-14 Thread Catalin Marinas
On Thu, Sep 14, 2017 at 02:16:46PM +0800, shuw...@redhat.com wrote: > From: Shu Wang > > Kmemleak reports about a thousand false positives for fusion-> > cmd_list[]. Root casue is the cmd_list objects are allocated from > slab allocator, and stored its pointer in object allocated by page > alloca

RE: [PATCH] megaraid: kmemleak: Track page allocation for fusion

2017-09-14 Thread Sumit Saxena
-Original Message- From: shuw...@redhat.com [mailto:shuw...@redhat.com] Sent: Thursday, September 14, 2017 11:47 AM To: kashyap.de...@broadcom.com; sumit.sax...@broadcom.com; shivasharan.srikanteshw...@broadcom.com; j...@linux.vnet.ibm.com; martin.peter...@oracle.com Cc: megaraidlinux@b

Re: [PATCH] megaraid: kmemleak: Track page allocation for fusion

2017-09-14 Thread Bart Van Assche
On Thu, 2017-09-14 at 14:16 +0800, shuw...@redhat.com wrote: > diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c > b/drivers/scsi/megaraid/megaraid_sas_fusion.c > index 11bd2e698b84..621299edd8de 100644 > --- a/drivers/scsi/megaraid/megaraid_sas_fusion.c > +++ b/drivers/scsi/megaraid/megara

Re: [Patch v2 2/2] libiscsi: Remove iscsi_destroy_session

2017-09-14 Thread Johannes Thumshirn
On Wed, Sep 13, 2017 at 05:09:03PM -0700, Lee Duncan wrote: > On 07/13/2017 09:11 AM, Khazhismel Kumykov wrote: > > iscsi_session_teardown was the only user of this function. Function > > currently is just short for iscsi_remove_session + iscsi_free_session. > > > > Signed-off-by: Khazhismel Kumyk