Re: [PATCH] scsi: shost->async_scan should be protected by mutex_lock

2017-09-12 Thread Ouyangzhaowei (Charles)
shost->async_scan should be protected by mutex_lock, otherwise the check of "called twice" won't work. Signed-off-by: Ouyang Zhaowei --- drivers/scsi/scsi_scan.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c index fd

Re: [PATCH V2 3/3] scsi: Align queue to ARCH_DMA_MINALIGN in non-coherent DMA mode

2017-09-12 Thread kbuild test robot
Hi Huacai, [auto build test ERROR on linus/master] [also build test ERROR on v4.13 next-20170912] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Huacai-Chen/dma-mapping-Provide-a-default

Re: [PATCH V2 10/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

2017-09-12 Thread Damien Le Moal
Ming, On 9/12/17 18:26, Ming Lei wrote: >>> OK, I suggest to document this guarantee of no write reorder for ZBC >>> somewhere, so that people will keep it in mind when trying to change >>> the current code. >> >> Have you looked at the comments in sd_zbc.c ? That is explained there. >> Granted, t

Re: [PATCH V3 2/2] scsi: sd: Use sectors_to_logical()

2017-09-12 Thread Bart Van Assche
On Tue, 2017-09-05 at 20:55 +0900, Damien Le Moal wrote: > Replace open coded conversions. Reviewed-by: Bart Van Assche

Re: [PATCH V3 1/2] scsi: sd: Fix sd_config_write_same()

2017-09-12 Thread Bart Van Assche
On Tue, 2017-09-05 at 20:55 +0900, Damien Le Moal wrote: > Reporting a maximum number of blocks that is not aligned on the device > physical size would cause a large write same request to be split into > physically unaligned chunks by __blkdev_issue_write_zeroes() and > __blkdev_issue_write_same(),

Re: [PATCH V4 0/10] block/scsi: safe SCSI quiescing

2017-09-12 Thread Cathy Avery
On 09/11/2017 07:10 AM, Ming Lei wrote: Hi, The current SCSI quiesce isn't safe and easy to trigger I/O deadlock. Once SCSI device is put into QUIESCE, no new request except for RQF_PREEMPT can be dispatched to SCSI successfully, and scsi_device_quiesce() just simply waits for completion of I/O

Re: system hung up when offlining CPUs

2017-09-12 Thread YASUAKI ISHIMATSU
+ linux-scsi and maintainers of megasas When offlining CPU, I/O stops. Do you have any ideas? On 09/07/2017 04:23 PM, YASUAKI ISHIMATSU wrote: > Hi Mark and Christoph, > > Sorry for the late reply. I appreciated that you fixed the issue on kvm > environment. > But the issue still occurs on phys

Re: [PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size

2017-09-12 Thread Bart Van Assche
On Tue, 2017-09-12 at 12:32 +0100, Colin King wrote: > From: Colin Ian King > > Don't populate const arrays on the stack, instead make them > static. Makes the object code smaller by over 740 bytes. > > Before: >text data bss dec hex filename >3840 208

[PATCH] scsi: ufs: tc-dwc-g210: make arrays static, reduces object code size

2017-09-12 Thread Colin King
From: Colin Ian King Don't populate const arrays on the stack, instead make them static. Makes the object code smaller by over 740 bytes. Before: textdata bss dec hex filename 3840 208 04048 fd0 drivers/scsi/ufs/tc-dwc-g210.o After: textdata b

Re: [PATCH V2 10/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

2017-09-12 Thread Ming Lei
On Tue, Sep 12, 2017 at 05:24:02PM +0900, Damien Le Moal wrote: > Ming, > > On 9/10/17 14:10, Ming Lei wrote: > > On Fri, Sep 08, 2017 at 09:53:53AM -0700, Damien Le Moal wrote: > >> Ming, > >> > >> On 9/8/17 05:43, Ming Lei wrote: > >>> Hi Damien, > >>> > >>> On Fri, Sep 08, 2017 at 01:16:38AM +0

Re: [PATCH V2 00/12] scsi-mq support for ZBC disks

2017-09-12 Thread Damien Le Moal
Christoph, On 9/11/17 21:24, Christoph Hellwig wrote: > On Fri, Sep 08, 2017 at 09:12:12AM -0700, Damien Le Moal wrote: >> 1) The zone size and the number of zones of the device (for the bitmaps >> allocation and offset->zone number conversion). >> 2) Zone type for the optimization that avoids loc

Re: [PATCH V2 10/12] scsi: sd_zbc: Disable zone write locking with scsi-mq

2017-09-12 Thread Damien Le Moal
Ming, On 9/10/17 14:10, Ming Lei wrote: > On Fri, Sep 08, 2017 at 09:53:53AM -0700, Damien Le Moal wrote: >> Ming, >> >> On 9/8/17 05:43, Ming Lei wrote: >>> Hi Damien, >>> >>> On Fri, Sep 08, 2017 at 01:16:38AM +0900, Damien Le Moal wrote: In the case of a ZBC disk used with scsi-mq, zone wr

Re: [PATCH V2 11/12] scsi: sd: Introduce scsi_disk_from_queue()

2017-09-12 Thread Damien Le Moal
Ming, On 9/10/17 14:16, Ming Lei wrote: > On Fri, Sep 08, 2017 at 01:16:39AM +0900, Damien Le Moal wrote: >> Using scsi_device_from_queue(), return the scsi_disk structure >> associated with a request queue if the device is a disk. >> Export this function to make it available to modules. >> > > T

[PATCH V2 3/3] scsi: Align queue to ARCH_DMA_MINALIGN in non-coherent DMA mode

2017-09-12 Thread Huacai Chen
In non-coherent DMA mode, kernel uses cache flushing operations to maintain I/O coherency, so scsi's block queue should be aligned to ARCH_DMA_MINALIGN. Cc: sta...@vger.kernel.org Signed-off-by: Huacai Chen --- drivers/scsi/scsi_lib.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-

Re: [PATCH] scsi: acornscsi: fix build error

2017-09-12 Thread Johannes Thumshirn
Looks good, Reviewed-by: Johannes Thumshirn -- Johannes Thumshirn Storage jthumsh...@suse.de+49 911 74053 689 SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG N