Hi, Ming Lei
On 07/06, Ming Lei wrote:
>Hi Xiaolong,
>
>On Mon, Jul 3, 2017 at 10:57 AM, kernel test robot
> wrote:
>>
>> Greeting,
>>
>> FYI, we noticed a -10.0% regression of blogbench.read_score due to commit:
>
>Looks like related with mq scheduler, could you test the following patch to see
>i
Hi Xiaolong,
On Mon, Jul 3, 2017 at 10:57 AM, kernel test robot
wrote:
>
> Greeting,
>
> FYI, we noticed a -10.0% regression of blogbench.read_score due to commit:
Looks like related with mq scheduler, could you test the following patch to see
if your issue can be fixed?
https://git.kernel.org/
On 07/03/2017 12:21 PM, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in QEDF_INFO message and
> remove duplicated "since" (thanks to Tyrel Datwyler for spotting
> the latter issue).
>
> Signed-off-by: Colin Ian King
Reviewed-by: Tyrel Datwyler
On 07/04/2017 03:44 AM, Colin King wrote:
> From: Colin Ian King
>
> Variables device_mutex and device_list static are local to the source,
> so make them static.
>
> Cleans up sparse warnings:
> "symbol 'device_list' was not declared. Should it be static?"
> "symbol 'device_mutex' was not decla
> -Original Message-
> From: Hannes Reinecke [mailto:h...@suse.de]
> Sent: Friday, June 30, 2017 10:18 AM
> To: Martin K. Petersen
> Cc: Christoph Hellwig ; James Bottomley
> ; linux-scsi@vger.kernel.org;
> Raghava Aditya Renukunta ;
> Hannes Reinecke ; Hannes Reinecke
> Subject: [PATCH
> On Jun 30, 2017, at 3:01 AM, Dan Carpenter wrote:
>
> The copy_from/to_user() functions return the number of bytes remaining
> to be copied but we had intended to return -EFAULT here.
>
> Fixes: bc88ac47d5cb ("scsi: cxlflash: Support AFU debug")
> Signed-off-by: Dan Carpenter
Good catch Dan
On Mon, 3 Jul 2017, 3:21pm, Colin King wrote:
> From: Colin Ian King
>
> Trivial fix to spelling mistake in QEDF_INFO message and
> remove duplicated "since" (thanks to Tyrel Datwyler for spotting
> the latter issue).
>
> Signed-off-by: Colin Ian King
> ---
> drivers/scsi/qedf/qedf_main.c |
On Wed, Jul 05, 2017 at 02:45:06PM +0100, Chris Clayton wrote:
> With your patch applied to 4.12.0, all three of the nero applications can now
> detect my drives again.
>
> Excellent work! Thank you.
>
> Tested-by: Chris Clayton
Thanks for confirmation.
--
Johannes Thumshirn
SG_DXFER_FROM_DEV transfers do not have a dxferp as we set it to NULL,
but must have a length bigger than 0. This fixes a regression introduced
by commit 28676d869bbb ("scsi: sg: check for valid direction before
starting the request")
Signed-off-by: Johannes Thumshirn
Fixes: 28676d869bbb ("scsi:
On 05/07/17 13:42, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 01:19:09PM +0100, Chris Clayton wrote:
>> I'm happy to test any patches you may propose.
>
> Can you verify this fix? Preferedably with using Nero. It passes my small
> reproducer:
>
Thanks Johannes.
With your patch applied
On Wed, Jul 05, 2017 at 01:19:09PM +0100, Chris Clayton wrote:
> I'm happy to test any patches you may propose.
Can you verify this fix? Preferedably with using Nero. It passes my small
reproducer:
>From f52502180cc3843f8acc956253af2575245546a8 Mon Sep 17 00:00:00 2001
From: Johannes Thumshirn
D
On 05/07/17 13:09, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 01:05:46PM +0100, Chris Clayton wrote:
>> Yes, I get:
>>
>> [chris:~/rpm/build]$ su -c "./nerotest /dev/sg0"
>> Password:
>> write: Invalid argument
>> FAIL
>
> Awesome, thanks for confirming.
>
You're welcome. I've attached
On Wed, Jul 05, 2017 at 01:05:46PM +0100, Chris Clayton wrote:
> Yes, I get:
>
> [chris:~/rpm/build]$ su -c "./nerotest /dev/sg0"
> Password:
> write: Invalid argument
> FAIL
Awesome, thanks for confirming.
I'll work on it locally now and hopefully send you something to test soon.
Thanks,
On 05/07/17 12:52, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 10:06:49AM +0100, Chris Clayton wrote:
>> I'll do this and send dmesg(?) output as soon as I've got
>> scsi_logging_level installed.
>
> Hi Chris,
>
> does this reproducer work (i.e. output FAIL) for you?
>
Hi Johannes.
Currently driver sets default queue_depth for VDs at 256 and JBODs based on
interface type,
ie., for SAS JBOD QD will be 64, for SATA JBOD QD will be 32.
During performance runs with scsi-mq enabled, we are seeing better results by
setting QD same as HBA queue_depth.
Signed-off-by: Kashyap Desai
Fix - After a kill adapter, since the cmd_status is not set the
IOCTLs will be hung in driver resulting in application hang.
Set cmd_status MFI_STAT_WRONG_STATE when completing pended IOCTLs.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Cc: sta...@vger.kernel.org
Reviewed-by: Hannes
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megarai
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_fp.c | 40 +
1 file changed, 15 insertions(+), 25 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fp.c
b/drivers/scsi/mega
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_base.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
index c
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas.h
b/drivers/scsi/megaraid/megaraid_sas.h
index 6d9f111..a6722c9 100644
--- a/drivers/scsi
Similar to task abort case, use synchronize_irq API in target reset case.
Also, remove redundant call to megasas_complete_cmd_dpc_fusion
after calling megasas_sync_irqs in task abort case.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/m
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_base.c | 8
1 file changed, 8 insertions(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.c
index 3c50a7b..
Fix - In TM code, smid_task is valid only in case of task aborts.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/megara
Setting resetwaittime to 0 during a FW fault will result in driver
not calling the OCR.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/dri
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_base.c | 9 +
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
b/drivers/scsi/megaraid/megaraid_sas_base.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas_fusion.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.c
b/drivers/scsi/megaraid/megaraid_sas_fusion.c
index 0f
Fix - megasas_wait_for_outstanding_fusion checks for pending commands every
1second. But megasas_complete_cmd_dpc_fusion is only called every 5seconds.
If the commands are already completed by firmware, there is an additional
delay of 5seconds before driver will process completion for these command
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hannes Reinecke
---
drivers/scsi/megaraid/megaraid_sas.h| 1 -
drivers/scsi/megaraid/megaraid_sas_base.c | 12 ++-
drivers/scsi/megaraid/megaraid_sas_fusion.c | 121 ++--
3 files changed,
Fix - Driver allocated 256 byte MFI frames bytes but while sending MFI
frame (embedded inside chain frame of MPT frame) to firmware, driver
sets the length as 4k. This results in DMA read error messages during
boot.
Signed-off-by: Kashyap Desai
Signed-off-by: Shivasharan S
Reviewed-by: Hanne
Changes from v1:
- Patch 4: Updated patch description
- Patch 9: Cleanup ld_drv_map in case ld_map allocation fails
Shivasharan S (15):
megaraid_sas: mismatch of allocated MFI frame size and length exposed
in MFI MPT pass through command
megaraid_sas: set minimum value of resetwaittime to
On Wed, Jul 05, 2017 at 10:06:49AM +0100, Chris Clayton wrote:
> I'll do this and send dmesg(?) output as soon as I've got scsi_logging_level
> installed.
Hi Chris,
does this reproducer work (i.e. output FAIL) for you?
#include
#include
#include
#include
#include
#include
#include
#inc
On 07/05/2017 12:33 PM, Shivasharan Srikanteshwara wrote:
>> -Original Message-
>> From: Shivasharan Srikanteshwara
>> [mailto:shivasharan.srikanteshw...@broadcom.com]
>> Sent: Tuesday, July 04, 2017 12:39 PM
>> To: 'Hannes Reinecke'; 'linux-scsi@vger.kernel.org'
>> Cc: 'martin.peter...@ora
> -Original Message-
> From: Shivasharan Srikanteshwara
> [mailto:shivasharan.srikanteshw...@broadcom.com]
> Sent: Tuesday, July 04, 2017 12:39 PM
> To: 'Hannes Reinecke'; 'linux-scsi@vger.kernel.org'
> Cc: 'martin.peter...@oracle.com'; 'the...@redhat.com';
> 'j...@linux.vnet.ibm.com'; Kash
On 05/07/17 09:48, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 10:44:47AM +0200, Johannes Thumshirn wrote:
>> On Wed, Jul 05, 2017 at 08:57:54AM +0100, Chris Clayton wrote:
>>> Thanks for the reply, Johannes.
>>> The strace log for 4.12.0 is attached.
>>
>> Thanks Chris.
>>
>> Can I have
On Wed, Jul 05, 2017 at 10:44:47AM +0200, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 08:57:54AM +0100, Chris Clayton wrote:
> > Thanks for the reply, Johannes.
> > The strace log for 4.12.0 is attached.
>
> Thanks Chris.
>
> Can I have a known good version as well? The counterpart to thi
On Wed, Jul 05, 2017 at 08:57:54AM +0100, Chris Clayton wrote:
> Thanks for the reply, Johannes.
> The strace log for 4.12.0 is attached.
Thanks Chris.
Can I have a known good version as well? The counterpart to this snippet would
be great:
open("/dev/sg0", O_RDWR)= 6
ioctl(6, SG
On Wed, 07/05 10:30, Paolo Bonzini wrote:
> Multi-queue virtio-scsi uses a different scsi_host_template struct.
> Add the .device_alloc field there, too.
>
> Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
> Cc: sta...@vger.kernel.org
> Cc: David Gibson
> Signed-off-by: Paolo Bonzini
> ---
> dr
Multi-queue virtio-scsi uses a different scsi_host_template struct.
Add the .device_alloc field there, too.
Fixes: 25d1d50e23275e141e3a3fe06c25a99f4c4bf4e0
Cc: sta...@vger.kernel.org
Cc: David Gibson
Signed-off-by: Paolo Bonzini
---
drivers/scsi/virtio_scsi.c | 1 +
1 file changed, 1 insertion(
On 05/07/17 08:39, Johannes Thumshirn wrote:
> On Wed, Jul 05, 2017 at 08:06:17AM +0100, Chris Clayton wrote:
>> I can provide the full traces or any other diagnostics, if they would help.
>
> Yes this would definitively help. An strace log would be great so I
> can make a local reproducer.
>
On Wed, Jul 05, 2017 at 08:06:17AM +0100, Chris Clayton wrote:
> I can provide the full traces or any other diagnostics, if they would help.
Yes this would definitively help. An strace log would be great so I
can make a local reproducer.
Thanks,
Johannes
--
Johannes Thumshirn
Hi.
I use the applications from Nero 4 Linux to write to blu-ray media,
principally, but not exclusively, as part of my
back-up regime. Those applications have stopped working with Linux 4.12 because
they fail to detect my drives (one built
in to my laptop and the other attached via USB). The ap
41 matches
Mail list logo
