On Monday 26 June 2017, Ondrej Zary wrote:
> On Monday 26 June 2017 09:30:33 Finn Thain wrote:
> > Ondrej, would you please test this new series?
> >
> > Changed since v1:
> > - PDMA transfer residual is calculated earlier.
> > - End of DMA flag check is now polled (if there is any residual).
> >
>
On Mon, 2017-06-26 at 20:55 +0200, Martin Wilck wrote:
> I personally find it odd that the compile-time choice goes away while
> the run-time choice remains available. I understand what Christoph is
> trying to achieve, but if it was up to me, I'd prefer to change the
> default and mark the "n" set
Hello,
My name is Ms Julian Smith and i am from Sinara Group Co.
We are glad to know about your company from the web and we are interested in
your products.Please send us your Latest catalog and price list for our
trial order.
Julian Smith,
Purchasing Manager
Sinara Group Co.
7 Krasnogo Znamen
On Mon, 26 Jun 2017, Ondrej Zary wrote:
>
> No apparent change in behavior, the first write test resulted in:
> [ 842.830802] sd 2:0:1:0: [sdb] tag#0 53c80 registers not accessible, device
> will be reset
> [ 842.830802] sd 2:0:1:0: [sdb] tag#0 switching to slow handshake
>
> Checking for IRQ
Setting speed based on the vinc device parameter read during
linkup. Also adding support to display 25,40 and 100G
Signed-off-by: Satish Kharat
Signed-off-by: Sesidhar Baddela
---
drivers/scsi/fnic/fnic_fcs.c | 24
drivers/scsi/fnic/fnic_io.h | 9 +
drivers/
io_cmpl_skip keep track of number of completions to skip when
stats are reset. If a fw_reset happens immediately after stats
reset it could put it out of sync so need to reset io_cmpl_skip
when fw reset is completed.
Signed-off-by: Satish Kharat
Signed-off-by: Sesidhar Baddela
---
drivers/scsi/
Added the timestamps for
1. current timestamp
2. last fnic stats read timestamp
3. last fnic stats reset timestamp
and the deltas since last stats read and last reset in fnic stats.
fnic stats uses debugfs
Signed-off-by: Sesidhar Baddela
Signed-off-by: Satish Kharat
---
drivers/scsi/fnic/fnic_d
Currently the queue command returns DID_NO_CONNECT anytime the rport
is not in RPORT_ST_READY state. Changing it to return DID_NO_CONNECT
only when the rport is in RPORT_ST_DELETE state. When the rport is
in one of the init states retruning DID_IMM_RETRY.
Signed-off-by: Sesidhar Baddela
Signed-of
On Mon, Jun 26, 2017 at 12:07:30AM -0700, Christoph Hellwig wrote:
> Tejun, does this look ok to you?
Acked-by: Tejun Heo
Thanks.
--
tejun
On Mon, Jun 26, 2017 at 12:07:15AM -0700, Christoph Hellwig wrote:
> Tejun, does this look ok to you?
Sure,
Acked-by: Tejun Heo
Thanks.
--
tejun
On Mon, Jun 26, 2017 at 12:43:27PM -0400, Martin K. Petersen wrote:
>
> Christoph,
>
> > ping?
>
> Looks good to me. I'll queue it up for 4.13 as soon as Linus has pulled
> in the ata bits.
I can route it through libata tree w/ your ack if that's more convenient.
Thanks.
--
tejun
On Monday 26 June 2017 09:30:33 Finn Thain wrote:
> Ondrej, would you please test this new series?
>
> Changed since v1:
> - PDMA transfer residual is calculated earlier.
> - End of DMA flag check is now polled (if there is any residual).
>
> Changed since v2:
> - Bail out of transfer loops when Ga
Hi Bart,
On Mon, 2017-06-26 at 15:31 +, Bart Van Assche wrote:
> On Mon, 2017-06-26 at 12:13 +, Bart Van Assche wrote:
> > On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote:
> > > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote:
> > > > Remove the SCSI_MQ_DEFAULT config opti
Uma,
> This patch series contains miscellaneous fixes and several
> enhancements such as LUN provisioning support, WS16 unmap and AFU
> debug capabilities.
Applied to 4.13/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent
> wrapper.
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> Use dma_alloc_attrs directly instead of the dma_alloc_noncoherent
> wrapper.
Fixed driver name typo and applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Christos,
> Variable idx is defined as u16 thus statement (idx < 0) is always
> false and should be removed.
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> Trivial fix to spelling mistake in dev_info message
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
John,
> Element phy_type is a bitmask and it only ever has 2 bits possibly
> set, and it is overkill to define as a u64, so redefine as a u32.
>
> This change resolves static code check complaint that "phy->phy_type
> &= ~PORT_TYPE_SAS;" would unintentionally clear the high 32 bits as
> well.
>
>
Bart,
> The symbolic name VLC_SA_RECEIVE_CREDENTIAL is not used anywhere in
> the kernel. Additionally, since SPC 5 the RECEIVE CREDENTIAL command
> is obsolete. The VLC_SA_RECEIVE_CREDENTIAL definition is misleading
> since it occurs outside the list of other variable length CDB service
> action
Seth,
> Both aac_send_raw_srb() and aac_get_hba_info() may copy stack
> allocated structs to userspace without initializing all members of
> these structs. Clear out this memory to prevent information leaks.
Applied to 4.13/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Enginee
Don,
> The hpsa firmware will bypass the cache for any request larger than
> 1MB, so we should cap the request size to avoid any performance
> degradation in kernels later than v4.3
I assume you guys are OK with this change?
--
Martin K. Petersen Oracle Linux Engineering
Dan,
> If bnx2i_map_ep_dbell_regs() then we accidentally return NULL instead
> of an error pointer. It results in a NULL dereference in
> iscsi_if_ep_connect().
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> The function hptiop_iop_request_callback_itl does not need to be in
> global scope, so make it static.
>
> Cleans up sparse warning:
> "symbol 'hptiop_iop_request_callback_itl' was not declared. Should it
> be static?"
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Lin
Varun,
> Assign rxq to TCP connections in round robin mode to use all available
> rxqs.
Applied to 4.13/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
James,
> A change in remote port removal introduced a spurious put which can
> cause a premature structure teardown. The affects were most notable
> when the driver attempted to unload as a null pointer would be hit.
>
> Fix by removing the unnecessary put.
Applied to 4.13/scsi-queue.
--
Marti
James,
> On link down, transport is calling driver to abort outstanding ios.
> Driver erroneously rejects the abort if the port indicates it isn't
> logged in - which will be the case after the link down. Thus, the io
> can't clean up. This prevents reconnection at the transport level.
>
> Fix by
Paolo,
> virtio_scsi tries to do exception handling after the default 30
> seconds timeout expires. However, it's better to let the host control
> the timeout, otherwise with a heavy I/O load it is likely that an
> abort will also timeout. This leads to fatal errors like filesystems
> going off
Johannes,
> There's no need to use the static UTS_RELEASE string, since
> utsname()->release contains the same.
>
> This avoids rebuilding this file for every change of the
> release string.
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Kefeng,
> After commit 556e26a70b64 ("scsi: remove tsk_mgmt_response and
> it_nexus_response transport methods"), the target driver support was
> removed totally. Drop the residua.
Applied to 4.13/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Varun,
> Add -ko to the module version similar to module version of other
> Chelsio drivers.
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Nilesh,
> This patch adds support for offload iSCSI boot (Boot from SAN
> over iSCSI offload).
>
> The dependent qed patches for this support are,
> - qed: Support NVM-image reading API
> - qed: Share additional information with qedf
You had tagged this for 4.12/scsi-fixes but the above patches
Christoph,
> Since 9c58b395 ("scsi: scsi_devinfo: remove synchronous ALUA for
> NETAPP devices") this code is unused.
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> ping?
Looks good to me. I'll queue it up for 4.13 as soon as Linus has pulled
in the ata bits.
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
Applied to 4.13/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
Do not call the stock libfc terminate rport i/o handler so we won't reset
the libfc exchange manager and kill any outstanding discovery requests.
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/scs
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc.h b/drivers/scsi/bnx2fc/bnx2fc.h
index c192840..7e007e1 100644
--- a/drivers/scsi/bnx2fc/bnx2fc.h
+++ b/drivers/scsi/bnx2fc/bnx2fc.h
@@ -66,7
In eh_abort, driver is calling scsi->done() for a IO for which cleanup is
pending. As the IO is outstanding with the firmware, it may do DMA
associated with the IO. This may lead to heap corruption.
Do not complete the IO for which cleanup is still pending. Return failure
from eh_abort and let the
Some vports addresses stored in NVRAM may have zero for the WWNN. Adjust
the WWNN that we'll use to be the same as the WWPN.
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_fcoe.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/bnx2fc
Add the following filters to bnx2fc_recv_frame():
1. Filter out invalid packets
- eth->dest_mac[3] matches FC frame's D_ID
2. Filter out packets that are not from our connected target
- In FIP_ST_ENABLED mode
- eth->src_mac matches fcoe_ctlr->dest_addr
3. Filter out packets where if d_
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/57xx_hsi_bnx2fc.h | 3 ++-
drivers/scsi/bnx2fc/bnx2fc.h | 3 ++-
drivers/scsi/bnx2fc/bnx2fc_constants.h | 3 ++-
drivers/scsi/bnx2fc/bnx2fc_debug.c | 3 ++-
drivers/scsi/bnx2fc/bnx2fc_debug.h | 3 ++-
drivers/scsi/bnx2fc/bnx2fc
If the connection is not offloaded then the backpointers from the tgt
pointer are undefined.
Signed-off-by: Chad Dupuis
---
drivers/scsi/bnx2fc/bnx2fc_els.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/bnx2fc/bnx2fc_els.c b/drivers/scsi/bnx2fc/b
Hi Martin,
Please apply the following patches at your earliest convenience.
Thanks,
Chad
Dupuis, Chad (7):
bnx2fc: Add filters to the non-offload FCoE receive path.
bnx2fc: Check for connection offload before sending RRQ.
bnx2fc: Update copyright for 2017.
bnx2fc: Adjust bnx2fc_npiv_crea
On Mon, 2017-06-26 at 12:13 +, Bart Van Assche wrote:
> On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote:
> > On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote:
> > > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq
> > > I/O
> > > path now that we had plenty of
On 06/20/2017 06:38 AM, Maurizio Lombardi wrote:
Dne 16.6.2017 v 18:08 Douglas Miller napsal(a):
Just to respond to James' question on the cause. What I observed was a race
condition between udevd (ses_init()) and a worker thread (do_scan_async()),
where the worker thread is creating the direc
From: Colin Ian King
Trivial fix to spelling mistake in dev_info message
Signed-off-by: Colin Ian King
---
drivers/scsi/hpsa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/hpsa.c b/drivers/scsi/hpsa.c
index 9934947073e6..8914eab84337 100644
--- a/drivers/scs
On Thu, 2017-06-22 at 17:05 +0200, Martin Wilck wrote:
> On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote:
> > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq
> > I/O
> > path now that we had plenty of testing, and have I/O schedulers for
> > blk-mq. The module option
https://bugzilla.kernel.org/show_bug.cgi?id=188061
--- Comment #10 from Anthony (anthony.blood...@gmail.com) ---
Problem does not change with kernel updates. Any news about firmware?
--
You are receiving this mail because:
You are watching the assignee of the bug.
ping?
On Mon, Jun 19, 2017 at 02:26:46PM +0200, Christoph Hellwig wrote:
> Just wire up the generic TCG OPAL infrastructure to the SCSI disk driver
> and the Security In/Out commands.
>
> Note that I don't know of any actual SCSI disks that do support TCG OPAL,
> but this is required to support A
Element phy_type is a bitmask and it only ever has 2
bits possibly set, and it is overkill to define as a u64,
so redefine as a u32.
This change resolves static code check complaint that
"phy->phy_type &= ~PORT_TYPE_SAS;" would
unintentionally clear the high 32 bits as well.
Structure hisi_sas_ph
On Thu, Jun 22, 2017 at 05:05:33PM +0200, Martin Wilck wrote:
> Hello Christoph,
>
> On Fri, 2017-06-16 at 10:27 +0200, Christoph Hellwig wrote:
> > Remove the SCSI_MQ_DEFAULT config option and default to the blk-mq
> > I/O
> > path now that we had plenty of testing, and have I/O schedulers for
>
On Monday 26 June 2017, Finn Thain wrote:
> On Sun, 25 Jun 2017, Ondrej Zary wrote:
> > It mostly works, but there are some problems:
> >
> > It's not reliable - we continue the data transfer after poll_politely2
> > returns zero but we don't know if it returned because of host buffer
> > being rea
On Sun, 25 Jun 2017, Ondrej Zary wrote:
>
> It mostly works, but there are some problems:
>
> It's not reliable - we continue the data transfer after poll_politely2
> returns zero but we don't know if it returned because of host buffer
> being ready of because of an IRQ. So if a device disconnect
From: Ondrej Zary
The polling loops in pread() and pwrite() can easily become infinite
loops and hang the machine.
On DTC chips, IRQ can arrive late and we miss it because we only check
once. Merge the IRQ check into host buffer wait and add polling limit.
Also place a limit on polling for 53C8
Signed-off-by: Finn Thain
---
drivers/scsi/g_NCR5380.c | 61 ++--
1 file changed, 28 insertions(+), 33 deletions(-)
diff --git a/drivers/scsi/g_NCR5380.c b/drivers/scsi/g_NCR5380.c
index 911a4300ea51..9f18082415c4 100644
--- a/drivers/scsi/g_NCR5380.c
Ondrej, would you please test this new series?
Changed since v1:
- PDMA transfer residual is calculated earlier.
- End of DMA flag check is now polled (if there is any residual).
Changed since v2:
- Bail out of transfer loops when Gated IRQ gets asserted.
- Make udelay conditional on board type.
From: Ondrej Zary
When an IRQ arrives during PDMA transfer, pread() and pwrite() return
without waiting for the 53C80 registers to be ready and this ends up
messing up the chip state. This was observed with SONY CDU-55S which is
slow enough to disconnect during 4096-byte reads.
IRQ during PDMA i
From: Ondrej Zary
generic_NCR5380_dma_xfer_len() incorrectly uses cmd->transfersize
which causes rescan-scsi-bus and CD-ROM access to hang the system.
Use cmd->SCp.this_residual instead, like other NCR5380 drivers.
Signed-off-by: Ondrej Zary
Signed-off-by: Finn Thain
---
drivers/scsi/g_NCR538
On 24/06/17 9:54 PM, "Christos Gkekas" wrote:
>Variable idx is defined as u16 thus statement (idx < 0) is
>always false and should be removed.
>
>Signed-off-by: Christos Gkekas
>---
> drivers/scsi/qedi/qedi_fw.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/drivers
On Fri, Jun 23, 2017 at 10:32:39AM -0700, Bart Van Assche wrote:
> The symbolic name VLC_SA_RECEIVE_CREDENTIAL is not used anywhere
> in the kernel. Additionally, since SPC 5 the RECEIVE CREDENTIAL
> command is obsolete. The VLC_SA_RECEIVE_CREDENTIAL definition is
> misleading since it occurs outsi
Tejun, does this look ok to you?
On Fri, Jun 16, 2017 at 09:17:07AM +0200, Christoph Hellwig wrote:
> dmam_alloc_noncoherent is a trivial wrapper around dmam_alloc_attrs,
> that hardcodes one particular flag. Make the devres code more
> flexible by allowing the callers to pass arbitrary flags.
>
Tejun, does this look ok to you?
On Fri, Jun 16, 2017 at 09:17:06AM +0200, Christoph Hellwig wrote:
> This function was never used since it was added.
>
> Signed-off-by: Christoph Hellwig
> ---
> Documentation/driver-model/devres.txt | 1 -
> drivers/base/dma-mapping.c| 20
63 matches
Mail list logo
